Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, jbaron@akamai.com,
	gregkh@linuxfoundation.org, ukaszb@chromium.org,
	louis.chauvet@bootlin.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch,
	tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com,
	ville.syrjala@linux.intel.com, seanpaul@chromium.org,
	robdclark@gmail.com, groeck@google.com, yanivt@google.com,
	bleung@google.com, quic_saipraka@quicinc.com, will@kernel.org,
	catalin.marinas@arm.com, quic_psodagud@quicinc.com,
	maz@kernel.org, arnd@arndb.de,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, mingo@redhat.com,
	jim.cromie@gmail.com
Subject: [PATCH v7 07/31] dyndbg: make ddebug_class_param union members same size
Date: Mon, 22 Dec 2025 21:20:24 +1300	[thread overview]
Message-ID: <20251222082049.1782440-8-jim.cromie@gmail.com> (raw)
In-Reply-To: <20251222082049.1782440-3-jim.cromie@gmail.com>

struct ddebug_class_param keeps a ref to the state-storage of the
param; make both class-types use the same unsigned long storage type.

ISTM this is simpler and safer; it avoids an irrelevant difference,
and if 2 users somehow get class-type mixed up (or refer to the wrong
union member), at least they will both see the same value.

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 include/linux/dynamic_debug.h | 2 +-
 lib/dynamic_debug.c           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 98a36e2f94b6..4b7c3b997657 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -103,7 +103,7 @@ struct _ddebug_info {
 struct ddebug_class_param {
 	union {
 		unsigned long *bits;
-		unsigned int *lvl;
+		unsigned long *lvl;
 	};
 	char flags[8];
 	const struct ddebug_class_map *map;
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index cb171088850c..d2ff203d0873 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -810,7 +810,7 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp)
 
 	case DD_CLASS_TYPE_LEVEL_NAMES:
 	case DD_CLASS_TYPE_LEVEL_NUM:
-		return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl);
+		return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl);
 	default:
 		return -1;
 	}
-- 
2.52.0


  parent reply	other threads:[~2025-12-22 14:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-22  8:20 [PATCH v7 02/31] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP Jim Cromie
2025-12-22  8:20 ` [PATCH v7 03/31] docs/dyndbg: update examples \012 to \n Jim Cromie
2025-12-22  8:20 ` [PATCH v7 04/31] docs/dyndbg: explain flags parse 1st Jim Cromie
2025-12-22  8:20 ` [PATCH v7 05/31] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2025-12-22  8:20 ` [PATCH v7 06/31] dyndbg: reword "class unknown, " to "class:_UNKNOWN_" Jim Cromie
2025-12-22  8:20 ` Jim Cromie [this message]
2025-12-22  8:20 ` [PATCH v7 08/31] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2025-12-22  8:20 ` [PATCH v7 09/31] dyndbg: tweak pr_fmt to avoid expansion conflicts Jim Cromie
2025-12-22  8:20 ` [PATCH v7 10/31] dyndbg: reduce verbose/debug clutter Jim Cromie
2025-12-22  8:20 ` [PATCH v7 11/31] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie
2025-12-22  8:20 ` [PATCH v7 12/31] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2025-12-22  8:20 ` [PATCH v7 13/31] dyndbg: replace classmap list with a vector Jim Cromie
2025-12-22  8:20 ` [PATCH v7 14/31] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie
2025-12-22  8:20 ` [PATCH v7 15/31] dyndbg, module: make proper substructs in _ddebug_info Jim Cromie
2025-12-22  8:20 ` [PATCH v7 16/31] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Jim Cromie
2025-12-22  8:20 ` [PATCH v7 17/31] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info Jim Cromie
2025-12-22  8:20 ` [PATCH v7 18/31] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2025-12-22  8:20 ` [PATCH v7 19/31] selftests-dyndbg: add a dynamic_debug run_tests target Jim Cromie
2025-12-22  8:20 ` [PATCH v7 20/31] dyndbg: change __dynamic_func_call_cls* macros into expressions Jim Cromie
2025-12-22  8:20 ` [PATCH v7 21/31] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP Jim Cromie
2025-12-22  8:20 ` [PATCH v7 22/31] dyndbg: detect class_id reservation conflicts Jim Cromie
2025-12-22  8:20 ` [PATCH v7 23/31] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_DEFINE args at compile-time Jim Cromie
2025-12-22  8:20 ` [PATCH v7 24/31] dyndbg-test: change do_prints testpoint to accept a loopct Jim Cromie
2025-12-22  8:20 ` [PATCH v7 25/31] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API Jim Cromie
2025-12-22  8:20 ` [PATCH v7 26/31] dyndbg: treat comma as a token separator Jim Cromie
2025-12-22  8:20 ` [PATCH v7 27/31] dyndbg: split multi-query strings with % Jim Cromie
2025-12-22  8:20 ` [PATCH v7 28/31] selftests-dyndbg: add test_mod_submod Jim Cromie
2025-12-22  8:20 ` [PATCH v7 29/31] dyndbg: resolve "protection" of class'd pr_debug Jim Cromie
2025-12-22  8:20 ` [PATCH v7 30/31] dyndbg: add DYNAMIC_DEBUG_CLASSMAP_USE_(dd_class_name, offset) Jim Cromie
2025-12-22  8:20 ` [PATCH v7 31/31] docs/dyndbg: add classmap info to howto Jim Cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251222082049.1782440-8-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=arnd@arndb.de \
    --cc=bleung@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@google.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jbaron@akamai.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=maz@kernel.org \
    --cc=mingo@redhat.com \
    --cc=quic_psodagud@quicinc.com \
    --cc=quic_saipraka@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    --cc=ukaszb@chromium.org \
    --cc=ville.syrjala@linux.intel.com \
    --cc=will@kernel.org \
    --cc=yanivt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox