Re: [PATCH 3/3] drm/i915/de: Nuke intel_de_{read,write}_notrace()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/i915: unused intel_uncore_write_notrace generator leftover
--

commit 63a0967a4211723ada8b8d7082bed7b2f369c08a
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>

drm/i915/de: Nuke intel_de_{read,write}_notrace()

The commit removes the unused intel_de_read_notrace() and 
intel_de_write_notrace() accessors, along with their xe compat wrappers. This 
reduces the number of register access functions to clean up the code between 
i915 and xe.

> diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
> index 8144588d3cf77..4ae041a96b31a 100644
> --- a/drivers/gpu/drm/i915/display/intel_de.h
> +++ b/drivers/gpu/drm/i915/display/intel_de.h
> @@ -164,18 +164,6 @@ intel_de_posting_read_fw(struct intel_display *display, intel_reg_t reg)
>  	intel_de_read_fw(display, reg);
>  }
>  
> -static inline u32
> -intel_de_read_notrace(struct intel_display *display, intel_reg_t reg)
> -{
> -	return intel_uncore_read_notrace(__to_uncore(display), reg);
> -}
> -
> -static inline void
> -intel_de_write_notrace(struct intel_display *display, intel_reg_t reg, u32 val)
> -{
> -	intel_uncore_write_notrace(__to_uncore(display), reg, val);
> -}

[Severity: Low]
With the removal of intel_de_write_notrace(), it looks like
intel_uncore_write_notrace() is now unused. Should the macro expansion that
generates it in i915 be removed as well to complete the cleanup?

drivers/gpu/drm/i915/intel_uncore.h:
__uncore_write(write_notrace, 32, l, false)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930115303.24285-1-ville.syrjala@linux.intel.com?part=3