Re: [PATCH 2/3] drm/i915/dp: Drop using intel_de_read_notrace()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Tracing redundancy: duplicate trace of DP_AUX_CH_CTL read
--

commit afa17c7838a57999000c6a138fccf379e59ccba4
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>

drm/i915/dp: Drop using intel_de_read_notrace()

This patch eliminates intel_de_read_notrace() to shrink the API, switching
its last users in intel_dp_aux_wait_done() and intel_dp_aux_xfer() over to
the normal intel_de_read().

> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c

[ ... ]

> @@ -324,7 +324,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
>  
>  	/* Try to wait for any previous AUX channel activity */
>  	for (try = 0; try < 3; try++) {
> -		status = intel_de_read_notrace(display, ch_ctl);
> +		status = intel_de_read(display, ch_ctl);
>  		if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
>  			break;
>  		msleep(1);
>  	}
>  	/* just trace the final value */
>  	trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);

[Severity: Low]
Does this leave us with duplicate trace events?

Since intel_de_read() internally traces the register read, this explicit
trace_i915_reg_rw() call in intel_dp_aux_xfer() appears redundant and might
cause duplicate trace log entries for this final read.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930115303.24285-1-ville.syrjala@linux.intel.com?part=2