From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v2 2/3] drm/i915/dp: Drop using intel_de_read_notrace()
Date: Fri, 2 Oct 2026 16:57:54 +0300 [thread overview]
Message-ID: <20261002135754.25422-1-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260930115303.24285-2-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
I want to eliminate intel_de_read_notrace() to shrink the
intel_de.h API a bit. That should help with the cleaning out
the remaining uncore mess for xe vs. i915.
Furthermore on xe intel_de_read_notrace() doesn't even do
what it says on the tin, and instead all register accesses
are traced anyway.
Switch the last users of intel_de_read_notrace()
(intel_dp_aux_wait_done() and intel_dp_aux_xfer())
over to the normal intel_de_read().
v2: Drop the trace_i915_reg_rw() as well
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 3cb07b0a901c..394326d17e0d 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -16,7 +16,6 @@
#include "intel_pps.h"
#include "intel_quirks.h"
#include "intel_tc.h"
-#include "intel_uncore_trace.h"
#define AUX_CH_NAME_BUFSIZE 6
@@ -66,7 +65,7 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
int ret;
if (intel_parent_irq_enabled(display)) {
-#define C (((status = intel_de_read_notrace(display, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
+#define C (((status = intel_de_read(display, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
done = wait_event_timeout(display->gmbus.wait_queue, C,
msecs_to_jiffies_timeout(timeout_ms));
@@ -324,13 +323,11 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
/* Try to wait for any previous AUX channel activity */
for (try = 0; try < 3; try++) {
- status = intel_de_read_notrace(display, ch_ctl);
+ status = intel_de_read(display, ch_ctl);
if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
break;
msleep(1);
}
- /* just trace the final value */
- trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
if (try == 3) {
const u32 status = intel_de_read(display, ch_ctl);
--
2.54.0
next prev parent reply other threads:[~2026-10-02 13:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 11:53 [PATCH 1/3] drm/i915/gmbus: Switch GMBUS fully to _fw() register accesses Ville Syrjala
2026-09-30 11:53 ` [PATCH 2/3] drm/i915/dp: Drop using intel_de_read_notrace() Ville Syrjala
2026-09-30 12:02 ` sashiko-bot
2026-09-30 14:53 ` Jani Nikula
2026-10-01 15:16 ` Jani Nikula
2026-10-02 13:57 ` Ville Syrjala [this message]
2026-09-30 11:53 ` [PATCH 3/3] drm/i915/de: Nuke intel_de_{read,write}_notrace() Ville Syrjala
2026-09-30 12:01 ` sashiko-bot
2026-09-30 14:54 ` Jani Nikula
2026-09-30 12:04 ` [PATCH 1/3] drm/i915/gmbus: Switch GMBUS fully to _fw() register accesses sashiko-bot
2026-09-30 13:16 ` [PATCH v2 " Ville Syrjala
2026-09-30 14:14 ` Jani Nikula
2026-09-30 13:52 ` ✓ i915.CI.BAT: success for series starting with [1/3] " Patchwork
2026-09-30 16:19 ` ✓ i915.CI.BAT: success for series starting with [v2,1/3] drm/i915/gmbus: Switch GMBUS fully to _fw() register accesses (rev2) Patchwork
2026-10-01 6:08 ` ✓ i915.CI.Full: " Patchwork
2026-10-02 16:18 ` ✗ i915.CI.BAT: failure for series starting with [v2,1/3] drm/i915/gmbus: Switch GMBUS fully to _fw() register accesses (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002135754.25422-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox