From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 3/5] drm/i915/gmbus: Reorder the PNV clock gating GPIO w/a
Date: Thu, 8 Oct 2026 01:23:12 +0300 [thread overview]
Message-ID: <20261007222314.5714-4-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20261007222314.5714-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Move the PNV bit banging clock gating toggle to be the
outermost operation in the pre/post xfer hooks. We don't
want the clock gating to kick in once we've touched something
in the GPIO registers. Right now this doesn't really matter,
but upcoming changes to the GPIO register mask handling will
need this.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_gmbus.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c
index e808f5c4106b..854f439ac5ba 100644
--- a/drivers/gpu/drm/i915/display/intel_gmbus.c
+++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
@@ -339,11 +339,11 @@ intel_gpio_pre_xfer(struct i2c_adapter *adapter)
struct intel_gmbus *bus = to_intel_gmbus(adapter);
struct intel_display *display = bus->display;
- intel_gmbus_reset(display);
-
if (display->platform.pineview)
pnv_gmbus_clock_gating(display, false);
+ intel_gmbus_reset(display);
+
if (intel_display_wa(display, INTEL_DISPLAY_WA_16025573575))
ptl_handle_mask_bits(bus, true);
@@ -362,11 +362,11 @@ intel_gpio_post_xfer(struct i2c_adapter *adapter)
set_data(bus, 1);
set_clock(bus, 1);
- if (display->platform.pineview)
- pnv_gmbus_clock_gating(display, true);
-
if (intel_display_wa(display, INTEL_DISPLAY_WA_16025573575))
ptl_handle_mask_bits(bus, false);
+
+ if (display->platform.pineview)
+ pnv_gmbus_clock_gating(display, true);
}
static void
--
2.55.0
next prev parent reply other threads:[~2026-10-07 22:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 22:23 [PATCH 0/5] drm/i915/gmbus: Fix PTL+ i2c bit banging Ville Syrjala
2026-10-07 22:23 ` [PATCH 1/5] drm/i915/gmbus: Stop frobbing with pin direction in .getsda()/.getscl() Ville Syrjala
2026-10-08 9:34 ` Sebastian Brzezinka
2026-10-07 22:23 ` [PATCH 2/5] drm/i915/gmbus: Handle the internal pullup disable bits more sensibly Ville Syrjala
2026-10-07 22:23 ` Ville Syrjala [this message]
2026-10-08 9:49 ` [PATCH 3/5] drm/i915/gmbus: Reorder the PNV clock gating GPIO w/a Sebastian Brzezinka
2026-10-07 22:23 ` [PATCH 4/5] drm/i915/gmbus: Fix i2c bit banging for PTL+ Ville Syrjala
2026-10-08 9:48 ` Sebastian Brzezinka
2026-10-07 22:23 ` [PATCH 5/5] drm/i915/gmbus: Remove the INTEL_DISPLAY_WA_16025573575 leftovers Ville Syrjala
2026-10-08 9:48 ` Sebastian Brzezinka
2026-10-07 23:36 ` ✓ i915.CI.BAT: success for drm/i915/gmbus: Fix PTL+ i2c bit banging Patchwork
2026-10-08 8:50 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007222314.5714-4-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox