Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 5/5] drm/i915/gmbus: Remove the INTEL_DISPLAY_WA_16025573575 leftovers
Date: Thu,  8 Oct 2026 01:23:14 +0300	[thread overview]
Message-ID: <20261007222314.5714-6-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20261007222314.5714-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We no longer need the INTEL_DISPLAY_WA_16025573575 since the
bit banging code now always follows the w/a sequence.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_wa.c | 13 -------------
 drivers/gpu/drm/i915/display/intel_display_wa.h |  1 -
 2 files changed, 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_wa.c b/drivers/gpu/drm/i915/display/intel_display_wa.c
index 888676693f5e..2e3ff4861ef4 100644
--- a/drivers/gpu/drm/i915/display/intel_display_wa.c
+++ b/drivers/gpu/drm/i915/display/intel_display_wa.c
@@ -51,17 +51,6 @@ void intel_display_wa_apply(struct intel_display *display)
 		gen11_display_wa_apply(display);
 }
 
-/*
- * Wa_16025573575:
- * Fixes: Issue with bitbashing on Xe3 based platforms.
- * Workaround: Set masks bits in GPIO CTL and preserve it during bitbashing sequence.
- */
-static bool intel_display_needs_wa_16025573575(struct intel_display *display)
-{
-	return DISPLAY_VERx100(display) == 3000 || DISPLAY_VERx100(display) == 3002 ||
-		DISPLAY_VERx100(display) == 3500;
-}
-
 /*
  * Wa_14011503117:
  * Fixes: Before enabling the scaler DE fatal error is masked
@@ -134,8 +123,6 @@ bool __intel_display_wa(struct intel_display *display, enum intel_display_wa wa,
 	case INTEL_DISPLAY_WA_16023588340:
 		/* This is a GT workaround. */
 		return display->parent->wa && display->parent->wa->wa_16023588340(display->drm);
-	case INTEL_DISPLAY_WA_16025573575:
-		return intel_display_needs_wa_16025573575(display);
 	case INTEL_DISPLAY_WA_16025596647:
 		return DISPLAY_VER(display) == 20 &&
 			IS_DISPLAY_VERx100_STEP(display, 3000,
diff --git a/drivers/gpu/drm/i915/display/intel_display_wa.h b/drivers/gpu/drm/i915/display/intel_display_wa.h
index 425a300840aa..b707147a7587 100644
--- a/drivers/gpu/drm/i915/display/intel_display_wa.h
+++ b/drivers/gpu/drm/i915/display/intel_display_wa.h
@@ -42,7 +42,6 @@ enum intel_display_wa {
 	INTEL_DISPLAY_WA_16011342517,
 	INTEL_DISPLAY_WA_16011863758,
 	INTEL_DISPLAY_WA_16023588340,
-	INTEL_DISPLAY_WA_16025573575,
 	INTEL_DISPLAY_WA_16025596647,
 	INTEL_DISPLAY_WA_16029024088,
 	INTEL_DISPLAY_WA_16030862157,
-- 
2.55.0


  parent reply	other threads:[~2026-10-07 22:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 22:23 [PATCH 0/5] drm/i915/gmbus: Fix PTL+ i2c bit banging Ville Syrjala
2026-10-07 22:23 ` [PATCH 1/5] drm/i915/gmbus: Stop frobbing with pin direction in .getsda()/.getscl() Ville Syrjala
2026-10-08  9:34   ` Sebastian Brzezinka
2026-10-07 22:23 ` [PATCH 2/5] drm/i915/gmbus: Handle the internal pullup disable bits more sensibly Ville Syrjala
2026-10-07 22:23 ` [PATCH 3/5] drm/i915/gmbus: Reorder the PNV clock gating GPIO w/a Ville Syrjala
2026-10-08  9:49   ` Sebastian Brzezinka
2026-10-07 22:23 ` [PATCH 4/5] drm/i915/gmbus: Fix i2c bit banging for PTL+ Ville Syrjala
2026-10-08  9:48   ` Sebastian Brzezinka
2026-10-07 22:23 ` Ville Syrjala [this message]
2026-10-08  9:48   ` [PATCH 5/5] drm/i915/gmbus: Remove the INTEL_DISPLAY_WA_16025573575 leftovers Sebastian Brzezinka
2026-10-07 23:36 ` ✓ i915.CI.BAT: success for drm/i915/gmbus: Fix PTL+ i2c bit banging Patchwork
2026-10-08  8:50 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261007222314.5714-6-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox