* [Intel-gfx] [PATCH] drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11
@ 2022-11-01 7:59 Swati Sharma
2022-11-01 8:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Swati Sharma @ 2022-11-01 7:59 UTC (permalink / raw)
To: intel-gfx
i915 driver supports DSC from DISPLAY_VER >= 11. Fix it.
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 7400d6b4c587..02e64f0284d8 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1012,7 +1012,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
* Output bpp is stored in 6.4 format so right shift by 4 to get the
* integer value since we support only integer values of bpp.
*/
- if (DISPLAY_VER(dev_priv) >= 10 &&
+ if (DISPLAY_VER(dev_priv) >= 11 &&
drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)) {
/*
* TBD pass the connector BPC,
@@ -2906,7 +2906,7 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
intel_dp_set_max_sink_lane_count(intel_dp);
/* Read the eDP DSC DPCD registers */
- if (DISPLAY_VER(dev_priv) >= 10)
+ if (DISPLAY_VER(dev_priv) >= 11)
intel_dp_get_dsc_sink_cap(intel_dp);
/*
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11
2022-11-01 7:59 [Intel-gfx] [PATCH] drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11 Swati Sharma
@ 2022-11-01 8:49 ` Patchwork
2022-11-01 10:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-01 21:20 ` [Intel-gfx] [PATCH] " Matt Roper
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-11-01 8:49 UTC (permalink / raw)
To: Swati Sharma; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 2681 bytes --]
== Series Details ==
Series: drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11
URL : https://patchwork.freedesktop.org/series/110353/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12325 -> Patchwork_110353v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/index.html
Participating hosts (40 -> 27)
------------------------------
Missing (13): fi-cml-u2 bat-dg2-8 bat-adlm-1 fi-icl-u2 bat-dg2-9 bat-adlp-6 bat-adlp-4 bat-adln-1 bat-rplp-1 bat-rpls-1 bat-rpls-2 bat-dg2-11 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_110353v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][1] -> [FAIL][2] ([i915#7229])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
#### Possible fixes ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][3] ([i915#6298]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
Build changes
-------------
* Linux: CI_DRM_12325 -> Patchwork_110353v1
CI-20190529: 20190529
CI_DRM_12325: 1a90222aa5e5bb86ffcbde5ba9611659a23f0df6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7032: 372c56225e12578a7a4a6bcc5b79eb40b643fcde @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110353v1: 1a90222aa5e5bb86ffcbde5ba9611659a23f0df6 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
f8de86345655 drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/index.html
[-- Attachment #2: Type: text/html, Size: 3182 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11
2022-11-01 7:59 [Intel-gfx] [PATCH] drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11 Swati Sharma
2022-11-01 8:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-11-01 10:22 ` Patchwork
2022-11-01 21:20 ` [Intel-gfx] [PATCH] " Matt Roper
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-11-01 10:22 UTC (permalink / raw)
To: Swati Sharma; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 28459 bytes --]
== Series Details ==
Series: drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11
URL : https://patchwork.freedesktop.org/series/110353/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12325_full -> Patchwork_110353v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_110353v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_110353v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 9)
------------------------------
Missing (2): shard-rkl shard-dg1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_110353v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@drm_import_export@flink:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-tglb1/igt@drm_import_export@flink.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-tglb2/igt@drm_import_export@flink.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu:
- shard-skl: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-skl10/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl6/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu.html
Known issues
------------
Here are the changes found in Patchwork_110353v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-snb: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29]) -> ([PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [FAIL][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54]) ([i915#4338])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb5/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb7/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb7/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb5/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb5/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb5/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb4/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb4/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb4/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb4/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb2/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb2/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb2/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb7/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb6/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb6/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb6/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb5/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb5/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb5/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb5/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb4/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb4/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb4/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb4/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb2/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb2/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb2/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb7/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb7/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb7/boot.html
### IGT changes ###
#### Issues hit ####
* igt@dmabuf@all@dma_fence_chain:
- shard-skl: NOTRUN -> [INCOMPLETE][55] ([i915#6949])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl9/igt@dmabuf@all@dma_fence_chain.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][56] -> [SKIP][57] ([i915#4525]) +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb2/igt@gem_exec_balancer@parallel-bb-first.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb7/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][58] ([i915#2842])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_lmem_swapping@massive:
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#4613])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl9/igt@gem_lmem_swapping@massive.html
* igt@gem_softpin@evict-single-offset:
- shard-tglb: [PASS][60] -> [FAIL][61] ([i915#4171])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-tglb2/igt@gem_softpin@evict-single-offset.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-tglb7/igt@gem_softpin@evict-single-offset.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][62] -> [DMESG-WARN][63] ([i915#180])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl7/igt@gem_workarounds@suspend-resume.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-apl3/igt@gem_workarounds@suspend-resume.html
* igt@i915_module_load@load:
- shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#6227])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl3/igt@i915_module_load@load.html
* igt@i915_pm_backlight@fade:
- shard-iclb: [PASS][65] -> [DMESG-WARN][66] ([i915#402])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb7/igt@i915_pm_backlight@fade.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb2/igt@i915_pm_backlight@fade.html
* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][67] ([i915#1886])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl9/igt@i915_selftest@live@gt_pm.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-iclb: NOTRUN -> [SKIP][68] ([i915#5286])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb5/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#110725] / [fdo#111614])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb5/igt@kms_big_fb@x-tiled-64bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#110723])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb5/igt@kms_big_fb@yf-tiled-8bpp-rotate-180.html
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#3886]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl10/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109278]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb5/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs.html
* igt@kms_chamelium@hdmi-crc-multiple:
- shard-skl: NOTRUN -> [SKIP][73] ([fdo#109271] / [fdo#111827]) +6 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl9/igt@kms_chamelium@hdmi-crc-multiple.html
* igt@kms_chamelium@hdmi-crc-nonplanar-formats:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109284] / [fdo#111827])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb5/igt@kms_chamelium@hdmi-crc-nonplanar-formats.html
* igt@kms_cursor_legacy@flip-vs-cursor@varying-size:
- shard-skl: [PASS][75] -> [FAIL][76] ([i915#2346])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor@varying-size.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor@varying-size.html
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [PASS][77] -> [FAIL][78] ([i915#79])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-edp1:
- shard-iclb: [PASS][79] -> [DMESG-WARN][80] ([i915#2867]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb2/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb8/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][81] ([i915#3555])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#2587] / [i915#2672]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][83] ([i915#2672]) +5 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271]) +93 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl9/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#109280]) +5 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-pgflip-blt:
- shard-iclb: [PASS][86] -> [FAIL][87] ([i915#2546])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-pgflip-blt.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-apl: NOTRUN -> [SKIP][88] ([fdo#109271]) +22 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-apl3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
* igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-c-edp-1:
- shard-skl: NOTRUN -> [FAIL][89] ([i915#4573]) +5 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl4/igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-c-edp-1.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109642] / [fdo#111068] / [i915#658])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb8/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr2_su@page_flip-p010@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [FAIL][91] ([i915#5939]) +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb2/igt@kms_psr2_su@page_flip-p010@pipe-b-edp-1.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: [PASS][92] -> [SKIP][93] ([fdo#109441]) +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb7/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [PASS][94] -> [SKIP][95] ([i915#5519])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb6/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb1/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-snb: [PASS][96] -> [DMESG-WARN][97] ([i915#5090])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-snb4/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-snb5/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
* igt@kms_writeback@writeback-fb-id:
- shard-skl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2437]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl9/igt@kms_writeback@writeback-fb-id.html
* igt@syncobj_timeline@wait-for-submit-delayed-submit:
- shard-skl: [PASS][99] -> [DMESG-WARN][100] ([i915#1982]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-skl4/igt@syncobj_timeline@wait-for-submit-delayed-submit.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl7/igt@syncobj_timeline@wait-for-submit-delayed-submit.html
#### Possible fixes ####
* igt@gem_ctx_persistence@many-contexts:
- shard-iclb: [INCOMPLETE][101] -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb5/igt@gem_ctx_persistence@many-contexts.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb5/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][103] ([i915#4525]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb6/igt@gem_exec_balancer@parallel-balancer.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb2/igt@gem_exec_balancer@parallel-balancer.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][105] ([i915#5566] / [i915#716]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl7/igt@gen9_exec_parse@allowed-single.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-apl7/igt@gen9_exec_parse@allowed-single.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][107] ([i915#2346]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank@c-dp1:
- shard-apl: [FAIL][109] ([i915#79]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl3/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-apl7/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][111] ([i915#79]) -> [PASS][112] +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@wf_vblank-ts-check@a-edp1:
- shard-skl: [FAIL][113] ([i915#2122]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-skl3/igt@kms_flip@wf_vblank-ts-check@a-edp1.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl6/igt@kms_flip@wf_vblank-ts-check@a-edp1.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][115] ([fdo#109441]) -> [PASS][116] +2 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb7/igt@kms_psr@psr2_no_drrs.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][117] ([i915#180]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-apl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@perf_pmu@all-busy-idle-check-all:
- shard-skl: [DMESG-WARN][119] ([i915#1982]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-skl6/igt@perf_pmu@all-busy-idle-check-all.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl3/igt@perf_pmu@all-busy-idle-check-all.html
#### Warnings ####
* igt@gem_pread@exhaustion:
- shard-apl: [WARN][121] ([i915#2658]) -> [INCOMPLETE][122] ([i915#7248])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl7/igt@gem_pread@exhaustion.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-apl1/igt@gem_pread@exhaustion.html
- shard-tglb: [WARN][123] ([i915#2658]) -> [INCOMPLETE][124] ([i915#7248])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-tglb7/igt@gem_pread@exhaustion.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-tglb6/igt@gem_pread@exhaustion.html
- shard-glk: [INCOMPLETE][125] ([i915#7248]) -> [WARN][126] ([i915#2658])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-glk3/igt@gem_pread@exhaustion.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-glk6/igt@gem_pread@exhaustion.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][127] ([i915#658]) -> [SKIP][128] ([i915#2920])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][129] ([i915#2920]) -> [SKIP][130] ([i915#658])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@runner@aborted:
- shard-apl: ([FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134]) ([fdo#109271] / [i915#3002] / [i915#4312]) -> ([FAIL][135], [FAIL][136], [FAIL][137]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl7/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl6/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl6/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-apl2/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-apl2/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-apl3/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-apl7/igt@runner@aborted.html
- shard-skl: ([FAIL][138], [FAIL][139]) ([i915#3002] / [i915#4312]) -> ([FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144]) ([i915#3002] / [i915#4312] / [i915#6949])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-skl10/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12325/shard-skl4/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl9/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl3/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl3/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl7/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/shard-skl7/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4338]: https://gitlab.freedesktop.org/drm/intel/issues/4338
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5090]: https://gitlab.freedesktop.org/drm/intel/issues/5090
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6949]: https://gitlab.freedesktop.org/drm/intel/issues/6949
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12325 -> Patchwork_110353v1
CI-20190529: 20190529
CI_DRM_12325: 1a90222aa5e5bb86ffcbde5ba9611659a23f0df6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7032: 372c56225e12578a7a4a6bcc5b79eb40b643fcde @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110353v1: 1a90222aa5e5bb86ffcbde5ba9611659a23f0df6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110353v1/index.html
[-- Attachment #2: Type: text/html, Size: 32736 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11
2022-11-01 7:59 [Intel-gfx] [PATCH] drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11 Swati Sharma
2022-11-01 8:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-01 10:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-11-01 21:20 ` Matt Roper
2022-11-02 9:02 ` Swati Sharma
2 siblings, 1 reply; 7+ messages in thread
From: Matt Roper @ 2022-11-01 21:20 UTC (permalink / raw)
To: Swati Sharma; +Cc: intel-gfx
On Tue, Nov 01, 2022 at 01:29:27PM +0530, Swati Sharma wrote:
> i915 driver supports DSC from DISPLAY_VER >= 11. Fix it.
Bspec 19713 indicates that GLK (i.e., our only display version 10
platform) does support DSC. Are you saying that there's other GLK
enablement missing in the driver right now that prevents DSC from
working?
Matt
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 7400d6b4c587..02e64f0284d8 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1012,7 +1012,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
> * Output bpp is stored in 6.4 format so right shift by 4 to get the
> * integer value since we support only integer values of bpp.
> */
> - if (DISPLAY_VER(dev_priv) >= 10 &&
> + if (DISPLAY_VER(dev_priv) >= 11 &&
> drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)) {
> /*
> * TBD pass the connector BPC,
> @@ -2906,7 +2906,7 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
> intel_dp_set_max_sink_lane_count(intel_dp);
>
> /* Read the eDP DSC DPCD registers */
> - if (DISPLAY_VER(dev_priv) >= 10)
> + if (DISPLAY_VER(dev_priv) >= 11)
> intel_dp_get_dsc_sink_cap(intel_dp);
>
> /*
> --
> 2.25.1
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11
2022-11-01 21:20 ` [Intel-gfx] [PATCH] " Matt Roper
@ 2022-11-02 9:02 ` Swati Sharma
2022-11-02 9:32 ` Jani Nikula
0 siblings, 1 reply; 7+ messages in thread
From: Swati Sharma @ 2022-11-02 9:02 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
Hi Matt,
Yes. Though h/w supports DSC from gen10, DSC is enabled from gen11+ from
driver.
We can see "has_dsc" flag enabled in gen11+.
#define GEN11_FEATURES \
>-------.__runtime.has_dsc = 1, \
Also, in the driver intel_dsc_source_support(), it is
if (DISPLAY_VER(i915) >= 11 && cpu_transcoder != TRANSCODER_A)
return true;
So, we should align DISPLAY_VER check according to DSC enablement
from driver.
On 02-Nov-22 2:50 AM, Matt Roper wrote:
> On Tue, Nov 01, 2022 at 01:29:27PM +0530, Swati Sharma wrote:
>> i915 driver supports DSC from DISPLAY_VER >= 11. Fix it.
>
> Bspec 19713 indicates that GLK (i.e., our only display version 10
> platform) does support DSC. Are you saying that there's other GLK
> enablement missing in the driver right now that prevents DSC from
> working?
>
>
> Matt
>
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> index 7400d6b4c587..02e64f0284d8 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -1012,7 +1012,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
>> * Output bpp is stored in 6.4 format so right shift by 4 to get the
>> * integer value since we support only integer values of bpp.
>> */
>> - if (DISPLAY_VER(dev_priv) >= 10 &&
>> + if (DISPLAY_VER(dev_priv) >= 11 &&
>> drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)) {
>> /*
>> * TBD pass the connector BPC,
>> @@ -2906,7 +2906,7 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
>> intel_dp_set_max_sink_lane_count(intel_dp);
>>
>> /* Read the eDP DSC DPCD registers */
>> - if (DISPLAY_VER(dev_priv) >= 10)
>> + if (DISPLAY_VER(dev_priv) >= 11)
>> intel_dp_get_dsc_sink_cap(intel_dp);
>>
>> /*
>> --
>> 2.25.1
>>
>
--
~Swati Sharma
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11
2022-11-02 9:02 ` Swati Sharma
@ 2022-11-02 9:32 ` Jani Nikula
2022-11-03 6:05 ` Swati Sharma
0 siblings, 1 reply; 7+ messages in thread
From: Jani Nikula @ 2022-11-02 9:32 UTC (permalink / raw)
To: Swati Sharma, Matt Roper; +Cc: intel-gfx
On Wed, 02 Nov 2022, Swati Sharma <swati2.sharma@intel.com> wrote:
> Hi Matt,
>
> Yes. Though h/w supports DSC from gen10, DSC is enabled from gen11+ from
> driver.
> We can see "has_dsc" flag enabled in gen11+.
> #define GEN11_FEATURES \
> >-------.__runtime.has_dsc = 1, \
>
> Also, in the driver intel_dsc_source_support(), it is
> if (DISPLAY_VER(i915) >= 11 && cpu_transcoder != TRANSCODER_A)
> return true;
> So, we should align DISPLAY_VER check according to DSC enablement
> from driver.
The real fix would be to use intel_dsc_source_support() as the single
point of truth instead of sprinkled all over the place. Especially since
that also takes fusing into account.
BR,
Jani.
>
> On 02-Nov-22 2:50 AM, Matt Roper wrote:
>> On Tue, Nov 01, 2022 at 01:29:27PM +0530, Swati Sharma wrote:
>>> i915 driver supports DSC from DISPLAY_VER >= 11. Fix it.
>>
>> Bspec 19713 indicates that GLK (i.e., our only display version 10
>> platform) does support DSC. Are you saying that there's other GLK
>> enablement missing in the driver right now that prevents DSC from
>> working?
>>
>>
>> Matt
>>
>>>
>>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>>> index 7400d6b4c587..02e64f0284d8 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>> @@ -1012,7 +1012,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
>>> * Output bpp is stored in 6.4 format so right shift by 4 to get the
>>> * integer value since we support only integer values of bpp.
>>> */
>>> - if (DISPLAY_VER(dev_priv) >= 10 &&
>>> + if (DISPLAY_VER(dev_priv) >= 11 &&
>>> drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)) {
>>> /*
>>> * TBD pass the connector BPC,
>>> @@ -2906,7 +2906,7 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
>>> intel_dp_set_max_sink_lane_count(intel_dp);
>>>
>>> /* Read the eDP DSC DPCD registers */
>>> - if (DISPLAY_VER(dev_priv) >= 10)
>>> + if (DISPLAY_VER(dev_priv) >= 11)
>>> intel_dp_get_dsc_sink_cap(intel_dp);
>>>
>>> /*
>>> --
>>> 2.25.1
>>>
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11
2022-11-02 9:32 ` Jani Nikula
@ 2022-11-03 6:05 ` Swati Sharma
0 siblings, 0 replies; 7+ messages in thread
From: Swati Sharma @ 2022-11-03 6:05 UTC (permalink / raw)
To: Jani Nikula, Matt Roper; +Cc: intel-gfx
On 02-Nov-22 3:02 PM, Jani Nikula wrote:
> On Wed, 02 Nov 2022, Swati Sharma <swati2.sharma@intel.com> wrote:
>> Hi Matt,
>>
>> Yes. Though h/w supports DSC from gen10, DSC is enabled from gen11+ from
>> driver.
>> We can see "has_dsc" flag enabled in gen11+.
>> #define GEN11_FEATURES \
>> >-------.__runtime.has_dsc = 1, \
>>
>> Also, in the driver intel_dsc_source_support(), it is
>> if (DISPLAY_VER(i915) >= 11 && cpu_transcoder != TRANSCODER_A)
>> return true;
>> So, we should align DISPLAY_VER check according to DSC enablement
>> from driver.
>
> The real fix would be to use intel_dsc_source_support() as the single
> point of truth instead of sprinkled all over the place. Especially since
> that also takes fusing into account.
>
> BR,
> Jani.
intel_dsc_source_support() can't be used directly since it requires
crtc_state which is not available in intel_dp_mode_valid().
Introduced is_dsc_supported() to get this info from RUNTIME_INFO()
https://patchwork.freedesktop.org/patch/509761/
Please review if this approach is okay.
>
>
>
>>
>> On 02-Nov-22 2:50 AM, Matt Roper wrote:
>>> On Tue, Nov 01, 2022 at 01:29:27PM +0530, Swati Sharma wrote:
>>>> i915 driver supports DSC from DISPLAY_VER >= 11. Fix it.
>>>
>>> Bspec 19713 indicates that GLK (i.e., our only display version 10
>>> platform) does support DSC. Are you saying that there's other GLK
>>> enablement missing in the driver right now that prevents DSC from
>>> working?
>>>
>>>
>>> Matt
>>>
>>>>
>>>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>>>> index 7400d6b4c587..02e64f0284d8 100644
>>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>>> @@ -1012,7 +1012,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
>>>> * Output bpp is stored in 6.4 format so right shift by 4 to get the
>>>> * integer value since we support only integer values of bpp.
>>>> */
>>>> - if (DISPLAY_VER(dev_priv) >= 10 &&
>>>> + if (DISPLAY_VER(dev_priv) >= 11 &&
>>>> drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)) {
>>>> /*
>>>> * TBD pass the connector BPC,
>>>> @@ -2906,7 +2906,7 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
>>>> intel_dp_set_max_sink_lane_count(intel_dp);
>>>>
>>>> /* Read the eDP DSC DPCD registers */
>>>> - if (DISPLAY_VER(dev_priv) >= 10)
>>>> + if (DISPLAY_VER(dev_priv) >= 11)
>>>> intel_dp_get_dsc_sink_cap(intel_dp);
>>>>
>>>> /*
>>>> --
>>>> 2.25.1
>>>>
>>>
>
--
~Swati Sharma
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-11-03 6:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-01 7:59 [Intel-gfx] [PATCH] drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11 Swati Sharma
2022-11-01 8:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-01 10:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-01 21:20 ` [Intel-gfx] [PATCH] " Matt Roper
2022-11-02 9:02 ` Swati Sharma
2022-11-02 9:32 ` Jani Nikula
2022-11-03 6:05 ` Swati Sharma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox