From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [Intel-gfx] [PATCH 15/15] drm/i915: re-enable -Wunused-but-set-variable
Date: Fri, 26 May 2023 19:38:08 +0300 [thread overview]
Message-ID: <28ca3f95fe77ceb8aa35b87fca73f7afbc89859a.1685119007.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1685119006.git.jani.nikula@intel.com>
W=1 enables -Wunused-but-set-variable. We disabled it locally in i915
Makefile as we were hitting a bunch of warnings. See commit 6a05d2900464
("drm/i915: Disable unused-but-set compiler warning").
With the issues fixed or annotated with __maybe_unused, re-enable the
warning not only in W=1 but also locally as part of i915 build.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 06374fc072d3..c704824e2a8c 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -19,7 +19,7 @@ subdir-ccflags-y += -Wno-type-limits
subdir-ccflags-y += -Wno-missing-field-initializers
subdir-ccflags-y += -Wno-sign-compare
subdir-ccflags-y += -Wno-shift-negative-value
-subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
+subdir-ccflags-y += $(call cc-option, -Wunused-but-set-variable)
subdir-ccflags-y += $(call cc-disable-warning, frame-address)
subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
--
2.39.2
next prev parent reply other threads:[~2023-05-26 16:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 16:37 [Intel-gfx] [PATCH 00/15] drm/i915: re-enable -Wunused-but-set-variable Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 01/15] drm/i915/plane: warn on non-zero plane offset Jani Nikula
2023-05-26 16:49 ` Ville Syrjälä
2023-05-26 17:22 ` Jani Nikula
2023-05-26 17:22 ` [Intel-gfx] [PATCH v2] " Jani Nikula
2023-05-27 0:27 ` [Intel-gfx] [PATCH 01/15] " kernel test robot
2023-05-27 1:50 ` kernel test robot
2023-05-29 9:24 ` Dan Carpenter
2023-05-29 10:04 ` Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 02/15] drm/i915/ddi: drop unused but set variable intel_dp Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 03/15] drm/i915/dsi: drop unused but set variable data Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 04/15] drm/i915/dsi: drop unused but set variable vbp Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 05/15] drm/i915/dpll: drop unused but set variables bestn and bestm1 Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 06/15] drm/i915/fb: drop unused but set variable cpp Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 07/15] drm/i915/irq: drop unused but set variable tmp Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 08/15] drm/i915/gt/uc: drop unused but set variable sseu Jani Nikula
2023-05-26 17:51 ` Andi Shyti
2023-05-26 16:38 ` [Intel-gfx] [PATCH 09/15] drm/i915/gem: drop unused but set variable unpinned Jani Nikula
2023-05-26 17:35 ` Andi Shyti
2023-05-26 16:38 ` [Intel-gfx] [PATCH 10/15] drm/i915/gem: annotate maybe unused but set variable c Jani Nikula
2023-05-26 17:50 ` Andi Shyti
2023-05-26 16:38 ` [Intel-gfx] [PATCH 11/15] drm/i915/selftest: annotate maybe unused but set variable unused Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 12/15] drm/i915: annotate maybe unused but set intel_plane_state variables Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 13/15] drm/i915: annotate maybe unused but set intel_crtc_state variables Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 14/15] drm/i915/gvt: annotate maybe unused gma_bottom variables Jani Nikula
2023-05-29 14:36 ` Wang, Zhi A
2023-05-26 16:38 ` Jani Nikula [this message]
2023-05-26 19:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev2) Patchwork
2023-05-26 19:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-26 23:21 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev3) Patchwork
2023-05-26 23:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-29 9:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev4) Patchwork
2023-05-29 9:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-29 14:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-06-07 9:35 ` [Intel-gfx] [PATCH 00/15] drm/i915: re-enable -Wunused-but-set-variable Hogander, Jouni
2023-06-07 10:37 ` Jani Nikula
2023-06-08 9:05 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28ca3f95fe77ceb8aa35b87fca73f7afbc89859a.1685119007.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox