From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 08/15] drm/i915/gt/uc: drop unused but set variable sseu
Date: Fri, 26 May 2023 19:51:48 +0200 [thread overview]
Message-ID: <ZHDxtK5eC2dwOuK7@ashyti-mobl2.lan> (raw)
In-Reply-To: <d542f25bffd5a50ff621bee93415a972c7768a2a.1685119007.git.jani.nikula@intel.com>
Hi Jani,
On Fri, May 26, 2023 at 07:38:01PM +0300, Jani Nikula wrote:
> Prepare for re-enabling -Wunused-but-set-variable.
>
> Apparently sseu is leftover from commit 9a92732f040a ("drm/i915/gt: Add
> general DSS steering iterator to intel_gt_mcr").
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> index 0ff864da92df..331cec07c125 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> @@ -301,7 +301,6 @@ guc_capture_alloc_steered_lists(struct intel_guc *guc,
> const struct __guc_mmio_reg_descr_group *list;
> struct __guc_mmio_reg_descr_group *extlists;
> struct __guc_mmio_reg_descr *extarray;
> - struct sseu_dev_info *sseu;
> bool has_xehpg_extregs;
>
> /* steered registers currently only exist for the render-class */
> @@ -318,7 +317,6 @@ guc_capture_alloc_steered_lists(struct intel_guc *guc,
> if (has_xehpg_extregs)
> num_steer_regs += ARRAY_SIZE(xehpg_extregs);
>
> - sseu = >->info.sseu;
leftovers...
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
> for_each_ss_steering(iter, gt, slice, subslice)
> num_tot_regs += num_steer_regs;
>
> --
> 2.39.2
next prev parent reply other threads:[~2023-05-26 17:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 16:37 [Intel-gfx] [PATCH 00/15] drm/i915: re-enable -Wunused-but-set-variable Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 01/15] drm/i915/plane: warn on non-zero plane offset Jani Nikula
2023-05-26 16:49 ` Ville Syrjälä
2023-05-26 17:22 ` Jani Nikula
2023-05-26 17:22 ` [Intel-gfx] [PATCH v2] " Jani Nikula
2023-05-27 0:27 ` [Intel-gfx] [PATCH 01/15] " kernel test robot
2023-05-27 1:50 ` kernel test robot
2023-05-29 9:24 ` Dan Carpenter
2023-05-29 10:04 ` Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 02/15] drm/i915/ddi: drop unused but set variable intel_dp Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 03/15] drm/i915/dsi: drop unused but set variable data Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 04/15] drm/i915/dsi: drop unused but set variable vbp Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 05/15] drm/i915/dpll: drop unused but set variables bestn and bestm1 Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 06/15] drm/i915/fb: drop unused but set variable cpp Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 07/15] drm/i915/irq: drop unused but set variable tmp Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 08/15] drm/i915/gt/uc: drop unused but set variable sseu Jani Nikula
2023-05-26 17:51 ` Andi Shyti [this message]
2023-05-26 16:38 ` [Intel-gfx] [PATCH 09/15] drm/i915/gem: drop unused but set variable unpinned Jani Nikula
2023-05-26 17:35 ` Andi Shyti
2023-05-26 16:38 ` [Intel-gfx] [PATCH 10/15] drm/i915/gem: annotate maybe unused but set variable c Jani Nikula
2023-05-26 17:50 ` Andi Shyti
2023-05-26 16:38 ` [Intel-gfx] [PATCH 11/15] drm/i915/selftest: annotate maybe unused but set variable unused Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 12/15] drm/i915: annotate maybe unused but set intel_plane_state variables Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 13/15] drm/i915: annotate maybe unused but set intel_crtc_state variables Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 14/15] drm/i915/gvt: annotate maybe unused gma_bottom variables Jani Nikula
2023-05-29 14:36 ` Wang, Zhi A
2023-05-26 16:38 ` [Intel-gfx] [PATCH 15/15] drm/i915: re-enable -Wunused-but-set-variable Jani Nikula
2023-05-26 19:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev2) Patchwork
2023-05-26 19:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-26 23:21 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev3) Patchwork
2023-05-26 23:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-29 9:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev4) Patchwork
2023-05-29 9:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-29 14:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-06-07 9:35 ` [Intel-gfx] [PATCH 00/15] drm/i915: re-enable -Wunused-but-set-variable Hogander, Jouni
2023-06-07 10:37 ` Jani Nikula
2023-06-08 9:05 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHDxtK5eC2dwOuK7@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox