From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "Nikula, Jani" <jani.nikula@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 00/15] drm/i915: re-enable -Wunused-but-set-variable
Date: Wed, 7 Jun 2023 09:35:49 +0000 [thread overview]
Message-ID: <47e1e5df376354c07fb428a49acbb14cd3dd6f11.camel@intel.com> (raw)
In-Reply-To: <cover.1685119006.git.jani.nikula@intel.com>
On Fri, 2023-05-26 at 19:37 +0300, Jani Nikula wrote:
> Bring back -Wunused-but-set-variable both in W=1 build as well as
> locally for CI and development. This already found dubious code.
for the whole set (including v2 of patch 01) :
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
>
> Jani Nikula (15):
> drm/i915/plane: warn on non-zero plane offset
> drm/i915/ddi: drop unused but set variable intel_dp
> drm/i915/dsi: drop unused but set variable data
> drm/i915/dsi: drop unused but set variable vbp
> drm/i915/dpll: drop unused but set variables bestn and bestm1
> drm/i915/fb: drop unused but set variable cpp
> drm/i915/irq: drop unused but set variable tmp
> drm/i915/gt/uc: drop unused but set variable sseu
> drm/i915/gem: drop unused but set variable unpinned
> drm/i915/gem: annotate maybe unused but set variable c
> drm/i915/selftest: annotate maybe unused but set variable unused
> drm/i915: annotate maybe unused but set intel_plane_state variables
> drm/i915: annotate maybe unused but set intel_crtc_state variables
> drm/i915/gvt: annotate maybe unused gma_bottom variables
> drm/i915: re-enable -Wunused-but-set-variable
>
> drivers/gpu/drm/i915/Makefile | 2 +-
> drivers/gpu/drm/i915/display/i9xx_plane.c | 2 ++
> drivers/gpu/drm/i915/display/intel_atomic_plane.c | 2 +-
> drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> drivers/gpu/drm/i915/display/intel_ddi.c | 4 ----
> drivers/gpu/drm/i915/display/intel_display.c | 10 +++++-----
> drivers/gpu/drm/i915/display/intel_display_irq.c | 4 ++--
> drivers/gpu/drm/i915/display/intel_dpll.c | 4 +---
> drivers/gpu/drm/i915/display/intel_fb.c | 3 +--
> drivers/gpu/drm/i915/display/intel_fbc.c | 6 +++---
> drivers/gpu/drm/i915/display/skl_universal_plane.c | 1 +
> drivers/gpu/drm/i915/display/skl_watermark.c | 2 +-
> drivers/gpu/drm/i915/display/vlv_dsi.c | 6 ++----
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 3 +--
> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
> drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 2 --
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 ++--
> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +-
> 18 files changed, 26 insertions(+), 35 deletions(-)
>
next prev parent reply other threads:[~2023-06-07 9:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 16:37 [Intel-gfx] [PATCH 00/15] drm/i915: re-enable -Wunused-but-set-variable Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 01/15] drm/i915/plane: warn on non-zero plane offset Jani Nikula
2023-05-26 16:49 ` Ville Syrjälä
2023-05-26 17:22 ` Jani Nikula
2023-05-26 17:22 ` [Intel-gfx] [PATCH v2] " Jani Nikula
2023-05-27 0:27 ` [Intel-gfx] [PATCH 01/15] " kernel test robot
2023-05-27 1:50 ` kernel test robot
2023-05-29 9:24 ` Dan Carpenter
2023-05-29 10:04 ` Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 02/15] drm/i915/ddi: drop unused but set variable intel_dp Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 03/15] drm/i915/dsi: drop unused but set variable data Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 04/15] drm/i915/dsi: drop unused but set variable vbp Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 05/15] drm/i915/dpll: drop unused but set variables bestn and bestm1 Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 06/15] drm/i915/fb: drop unused but set variable cpp Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 07/15] drm/i915/irq: drop unused but set variable tmp Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 08/15] drm/i915/gt/uc: drop unused but set variable sseu Jani Nikula
2023-05-26 17:51 ` Andi Shyti
2023-05-26 16:38 ` [Intel-gfx] [PATCH 09/15] drm/i915/gem: drop unused but set variable unpinned Jani Nikula
2023-05-26 17:35 ` Andi Shyti
2023-05-26 16:38 ` [Intel-gfx] [PATCH 10/15] drm/i915/gem: annotate maybe unused but set variable c Jani Nikula
2023-05-26 17:50 ` Andi Shyti
2023-05-26 16:38 ` [Intel-gfx] [PATCH 11/15] drm/i915/selftest: annotate maybe unused but set variable unused Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 12/15] drm/i915: annotate maybe unused but set intel_plane_state variables Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 13/15] drm/i915: annotate maybe unused but set intel_crtc_state variables Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 14/15] drm/i915/gvt: annotate maybe unused gma_bottom variables Jani Nikula
2023-05-29 14:36 ` Wang, Zhi A
2023-05-26 16:38 ` [Intel-gfx] [PATCH 15/15] drm/i915: re-enable -Wunused-but-set-variable Jani Nikula
2023-05-26 19:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev2) Patchwork
2023-05-26 19:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-26 23:21 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev3) Patchwork
2023-05-26 23:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-29 9:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev4) Patchwork
2023-05-29 9:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-29 14:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-06-07 9:35 ` Hogander, Jouni [this message]
2023-06-07 10:37 ` [Intel-gfx] [PATCH 00/15] drm/i915: re-enable -Wunused-but-set-variable Jani Nikula
2023-06-08 9:05 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47e1e5df376354c07fb428a49acbb14cd3dd6f11.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox