public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/2] drm/i915/gtt: flush the scratch page
@ 2021-10-22 16:48 Matthew Auld
  2021-10-22 16:48 ` [Intel-gfx] [PATCH 2/2] drm/i915/gtt: stop caching " Matthew Auld
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Matthew Auld @ 2021-10-22 16:48 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel, Thomas Hellström, Chris Wilson, Ramalingam C

The scratch page is directly visible in the users address space, and
while this is forced as CACHE_LLC, by the kernel, we still have to
contend with things like "Bypass-LLC" MOCS. So just flush no matter
what.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ramalingam C <ramalingam.c@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_gtt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c
index 67d14afa6623..b6c088423319 100644
--- a/drivers/gpu/drm/i915/gt/intel_gtt.c
+++ b/drivers/gpu/drm/i915/gt/intel_gtt.c
@@ -273,6 +273,7 @@ static void poison_scratch_page(struct drm_i915_gem_object *scratch)
 		val = POISON_FREE;
 
 	memset(vaddr, val, scratch->base.size);
+	clflush_cache_range(vaddr, scratch->base.size);
 }
 
 int setup_scratch_page(struct i915_address_space *vm)
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-10-26 10:17 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-22 16:48 [Intel-gfx] [PATCH 1/2] drm/i915/gtt: flush the scratch page Matthew Auld
2021-10-22 16:48 ` [Intel-gfx] [PATCH 2/2] drm/i915/gtt: stop caching " Matthew Auld
2021-10-26 10:17   ` Thomas Hellström
2021-10-22 21:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gtt: flush " Patchwork
2021-10-23  5:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-10-26  9:24 ` [Intel-gfx] [PATCH 1/2] " Thomas Hellström
2021-10-26  9:36 ` Thomas Hellström

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox