public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH v2 1/5] drm/i915/crt: remove BUG_ON()
@ 2022-08-30  9:34 Jani Nikula
  2022-08-30  9:34 ` [Intel-gfx] [PATCH v2 2/5] drm/i915/dpll: replace BUG_ON() with drm_WARN_ON() Jani Nikula
                   ` (8 more replies)
  0 siblings, 9 replies; 14+ messages in thread
From: Jani Nikula @ 2022-08-30  9:34 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Avoid BUG_ON(). We don't have such checks on output type anywhere else
either, so just remove.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_crt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c
index 6a3893c8ff22..d766c506b235 100644
--- a/drivers/gpu/drm/i915/display/intel_crt.c
+++ b/drivers/gpu/drm/i915/display/intel_crt.c
@@ -643,8 +643,6 @@ static bool intel_crt_detect_ddc(struct drm_connector *connector)
 	struct i2c_adapter *i2c;
 	bool ret = false;
 
-	BUG_ON(crt->base.type != INTEL_OUTPUT_ANALOG);
-
 	i2c = intel_gmbus_get_adapter(dev_priv, dev_priv->vbt.crt_ddc_pin);
 	edid = intel_crt_get_edid(connector, i2c);
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2022-08-31 15:56 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-30  9:34 [Intel-gfx] [PATCH v2 1/5] drm/i915/crt: remove BUG_ON() Jani Nikula
2022-08-30  9:34 ` [Intel-gfx] [PATCH v2 2/5] drm/i915/dpll: replace BUG_ON() with drm_WARN_ON() Jani Nikula
2022-08-31 15:44   ` Andrzej Hajda
2022-08-31 15:55     ` Jani Nikula
2022-08-30  9:34 ` [Intel-gfx] [PATCH v2 3/5] drm/i915/pch: " Jani Nikula
2022-08-31 15:45   ` Andrzej Hajda
2022-08-30  9:34 ` [Intel-gfx] [PATCH v2 4/5] drm/i915/perf: replace BUG_ON() with WARN_ON() Jani Nikula
2022-08-30  9:34 ` [Intel-gfx] [PATCH v2 5/5] drm/i915/fence: replace BUG_ON() with BUILD_BUG_ON() Jani Nikula
2022-08-30  9:50 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/5] drm/i915/crt: remove BUG_ON() Patchwork
2022-08-30 10:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-31 13:30 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-08-31 14:46 ` [Intel-gfx] [PATCH v2 1/5] " Ville Syrjälä
2022-08-31 15:30 ` Andrzej Hajda
2022-08-31 15:41   ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox