[PATCH v2 0/2] fixes to DRM doc & parameter's print

[PATCH v2 0/2] fixes to DRM doc & parameter's print

[Michał Grzelak]

Next version of [1]. Changed commit message to mention kernel-doc of
actually changed macro.

[1] https://lore.kernel.org/intel-gfx/20260521155231.1821935-1-michal.grzelak@intel.com/

BR,
Michał

Michał Grzelak (2):
  drm/print: describe 6th & 9th bit of drm.debug
  drm/managed: fix drmm_add_action() kernel-doc

 drivers/gpu/drm/drm_print.c | 4 +++-
 include/drm/drm_managed.h   | 2 +-
 include/drm/drm_print.h     | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

-- 
2.45.2

[PATCH v2 1/2] drm/print: describe 6th & 9th bit of drm.debug

[Michał Grzelak]

Setting 6th or 9th bit of drm.debug change debug logging. Meanwhile
`modinfo drm` does not inform about it at all.

Add info to MODULE_PARAM_DESC(debug, ...) about setting 6th and 9th bit
basing on DECLARE_DYNDBG_CLASSMAP(drm_debug_classes, ...). Match
description of corresponding bits with enum drm_debug_category. Include
9th bit in the example with enabling all possible logging provided at
comment at include/drm/drm_print.h.

Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 drivers/gpu/drm/drm_print.c | 4 +++-
 include/drm/drm_print.h     | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
index ded9461df5f2..86cef1a37678 100644
--- a/drivers/gpu/drm/drm_print.c
+++ b/drivers/gpu/drm/drm_print.c
@@ -50,8 +50,10 @@ MODULE_PARM_DESC(debug, "Enable debug output, where each bit enables a debug cat
 "\t\tBit 3 (0x08)  will enable PRIME messages (prime code)\n"
 "\t\tBit 4 (0x10)  will enable ATOMIC messages (atomic code)\n"
 "\t\tBit 5 (0x20)  will enable VBL messages (vblank code)\n"
+"\t\tBit 6 (0x40)  will enable STATE messages (atomic state code)\n"
 "\t\tBit 7 (0x80)  will enable LEASE messages (leasing code)\n"
-"\t\tBit 8 (0x100) will enable DP messages (displayport code)");
+"\t\tBit 8 (0x100) will enable DP messages (displayport code)\n"
+"\t\tBit 9 (0x200) will enable DRMRES messages (managed resources code)");
 
 #if !defined(CONFIG_DRM_USE_DYNAMIC_DEBUG)
 module_param_named(debug, __drm_debug, ulong, 0600);
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index ab017b05e175..2adc5ac688e1 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -87,7 +87,7 @@ extern unsigned long __drm_debug;
  *  - drm.debug=0x2 will enable DRIVER messages
  *  - drm.debug=0x3 will enable CORE and DRIVER messages
  *  - ...
- *  - drm.debug=0x1ff will enable all messages
+ *  - drm.debug=0x3ff will enable all messages
  *
  * An interesting feature is that it's possible to enable verbose logging at
  * run-time by echoing the debug value in its sysfs node::
-- 
2.45.2

Re: [PATCH v2 1/2] drm/print: describe 6th & 9th bit of drm.debug

[Michał Grzelak]

[-- Attachment #1: Type: text/plain, Size: 2386 bytes --]

On Fri, 22 May 2026, Michał Grzelak wrote:
> Setting 6th or 9th bit of drm.debug change debug logging. Meanwhile
> `modinfo drm` does not inform about it at all.
>
> Add info to MODULE_PARAM_DESC(debug, ...) about setting 6th and 9th bit
> basing on DECLARE_DYNDBG_CLASSMAP(drm_debug_classes, ...). Match
> description of corresponding bits with enum drm_debug_category. Include
> 9th bit in the example with enabling all possible logging provided at
> comment at include/drm/drm_print.h.
>
> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>

What should have been added here is R-B: tag provided by Chaitanya,
which currently is very much absent. The omission was not intentional.

BR,
Michał

> ---
> drivers/gpu/drm/drm_print.c | 4 +++-
> include/drm/drm_print.h     | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
> index ded9461df5f2..86cef1a37678 100644
> --- a/drivers/gpu/drm/drm_print.c
> +++ b/drivers/gpu/drm/drm_print.c
> @@ -50,8 +50,10 @@ MODULE_PARM_DESC(debug, "Enable debug output, where each bit enables a debug cat
> "\t\tBit 3 (0x08)  will enable PRIME messages (prime code)\n"
> "\t\tBit 4 (0x10)  will enable ATOMIC messages (atomic code)\n"
> "\t\tBit 5 (0x20)  will enable VBL messages (vblank code)\n"
> +"\t\tBit 6 (0x40)  will enable STATE messages (atomic state code)\n"
> "\t\tBit 7 (0x80)  will enable LEASE messages (leasing code)\n"
> -"\t\tBit 8 (0x100) will enable DP messages (displayport code)");
> +"\t\tBit 8 (0x100) will enable DP messages (displayport code)\n"
> +"\t\tBit 9 (0x200) will enable DRMRES messages (managed resources code)");
>
> #if !defined(CONFIG_DRM_USE_DYNAMIC_DEBUG)
> module_param_named(debug, __drm_debug, ulong, 0600);
> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> index ab017b05e175..2adc5ac688e1 100644
> --- a/include/drm/drm_print.h
> +++ b/include/drm/drm_print.h
> @@ -87,7 +87,7 @@ extern unsigned long __drm_debug;
>  *  - drm.debug=0x2 will enable DRIVER messages
>  *  - drm.debug=0x3 will enable CORE and DRIVER messages
>  *  - ...
> - *  - drm.debug=0x1ff will enable all messages
> + *  - drm.debug=0x3ff will enable all messages
>  *
>  * An interesting feature is that it's possible to enable verbose logging at
>  * run-time by echoing the debug value in its sysfs node::
> -- 
> 2.45.2
>
>

Re: [PATCH v2 1/2] drm/print: describe 6th & 9th bit of drm.debug

[Borah, Chaitanya Kumar]

On 5/23/2026 1:25 AM, Michał Grzelak wrote:
> On Fri, 22 May 2026, Michał Grzelak wrote:
>> Setting 6th or 9th bit of drm.debug change debug logging. Meanwhile
>> `modinfo drm` does not inform about it at all.
>>
>> Add info to MODULE_PARAM_DESC(debug, ...) about setting 6th and 9th bit
>> basing on DECLARE_DYNDBG_CLASSMAP(drm_debug_classes, ...). Match
>> description of corresponding bits with enum drm_debug_category. Include
>> 9th bit in the example with enabling all possible logging provided at
>> comment at include/drm/drm_print.h.
>>
>> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
> 
> What should have been added here is R-B: tag provided by Chaitanya,
> which currently is very much absent. The omission was not intentional.
> 

No worries :) still LGTM

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>


> BR,
> Michał
> 
>> ---
>> drivers/gpu/drm/drm_print.c | 4 +++-
>> include/drm/drm_print.h     | 2 +-
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
>> index ded9461df5f2..86cef1a37678 100644
>> --- a/drivers/gpu/drm/drm_print.c
>> +++ b/drivers/gpu/drm/drm_print.c
>> @@ -50,8 +50,10 @@ MODULE_PARM_DESC(debug, "Enable debug output, where 
>> each bit enables a debug cat
>> "\t\tBit 3 (0x08)  will enable PRIME messages (prime code)\n"
>> "\t\tBit 4 (0x10)  will enable ATOMIC messages (atomic code)\n"
>> "\t\tBit 5 (0x20)  will enable VBL messages (vblank code)\n"
>> +"\t\tBit 6 (0x40)  will enable STATE messages (atomic state code)\n"
>> "\t\tBit 7 (0x80)  will enable LEASE messages (leasing code)\n"
>> -"\t\tBit 8 (0x100) will enable DP messages (displayport code)");
>> +"\t\tBit 8 (0x100) will enable DP messages (displayport code)\n"
>> +"\t\tBit 9 (0x200) will enable DRMRES messages (managed resources 
>> code)");
>>
>> #if !defined(CONFIG_DRM_USE_DYNAMIC_DEBUG)
>> module_param_named(debug, __drm_debug, ulong, 0600);
>> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
>> index ab017b05e175..2adc5ac688e1 100644
>> --- a/include/drm/drm_print.h
>> +++ b/include/drm/drm_print.h
>> @@ -87,7 +87,7 @@ extern unsigned long __drm_debug;
>>  *  - drm.debug=0x2 will enable DRIVER messages
>>  *  - drm.debug=0x3 will enable CORE and DRIVER messages
>>  *  - ...
>> - *  - drm.debug=0x1ff will enable all messages
>> + *  - drm.debug=0x3ff will enable all messages
>>  *
>>  * An interesting feature is that it's possible to enable verbose 
>> logging at
>>  * run-time by echoing the debug value in its sysfs node::
>> -- 
>> 2.45.2
>>
>>

[PATCH v2 2/2] drm/managed: fix drmm_add_action() kernel-doc

[Michał Grzelak]

Kernel-doc of drmm_add_action() references @releases which is not
on argument list. Swap '@' between 'releases' and 'action' words to fix
the documentation.

Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 include/drm/drm_managed.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h
index 72bfac002c06..72d0d68be226 100644
--- a/include/drm/drm_managed.h
+++ b/include/drm/drm_managed.h
@@ -18,7 +18,7 @@ typedef void (*drmres_release_t)(struct drm_device *dev, void *res);
  * @action: function which should be called when @dev is released
  * @data: opaque pointer, passed to @action
  *
- * This function adds the @release action with optional parameter @data to the
+ * This function adds the release @action with optional parameter @data to the
  * list of cleanup actions for @dev. The cleanup actions will be run in reverse
  * order in the final drm_dev_put() call for @dev.
  */
-- 
2.45.2

Re: [PATCH v2 2/2] drm/managed: fix drmm_add_action() kernel-doc

[Borah, Chaitanya Kumar]

On 5/22/2026 7:25 PM, Michał Grzelak wrote:
> Kernel-doc of drmm_add_action() references @releases which is not
> on argument list. Swap '@' between 'releases' and 'action' words to fix
> the documentation.
> 

LGTM
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
> ---
>   include/drm/drm_managed.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h
> index 72bfac002c06..72d0d68be226 100644
> --- a/include/drm/drm_managed.h
> +++ b/include/drm/drm_managed.h
> @@ -18,7 +18,7 @@ typedef void (*drmres_release_t)(struct drm_device *dev, void *res);
>    * @action: function which should be called when @dev is released
>    * @data: opaque pointer, passed to @action
>    *
> - * This function adds the @release action with optional parameter @data to the
> + * This function adds the release @action with optional parameter @data to the
>    * list of cleanup actions for @dev. The cleanup actions will be run in reverse
>    * order in the final drm_dev_put() call for @dev.
>    */

Re: [PATCH v2 2/2] drm/managed: fix drmm_add_action() kernel-doc

[Michał Grzelak]

[-- Attachment #1: Type: text/plain, Size: 1537 bytes --]

On Tue, 26 May 2026, Borah, Chaitanya Kumar wrote:
> On 5/22/2026 7:25 PM, Michał Grzelak wrote:
>> Kernel-doc of drmm_add_action() references @releases which is not
>> on argument list. Swap '@' between 'releases' and 'action' words to fix
>> the documentation.
>> 
>
> LGTM
> Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
>

Thank you Chaitanya for the review. Do you think this series can be
merged via drm-misc-next branch from drm-misc [1]? Asking because I
don't have commiter right to any of drm-* repositories.

BR,
Michał

[1] https://drm.pages.freedesktop.org/maintainer-tools/repositories/drm-misc.html

>> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
>> ---
>>   include/drm/drm_managed.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h
>> index 72bfac002c06..72d0d68be226 100644
>> --- a/include/drm/drm_managed.h
>> +++ b/include/drm/drm_managed.h
>> @@ -18,7 +18,7 @@ typedef void (*drmres_release_t)(struct drm_device *dev, 
>> void *res);
>>    * @action: function which should be called when @dev is released
>>    * @data: opaque pointer, passed to @action
>>    *
>> - * This function adds the @release action with optional parameter @data to 
>> the
>> + * This function adds the release @action with optional parameter @data to 
>> the
>>    * list of cleanup actions for @dev. The cleanup actions will be run in 
>> reverse
>>    * order in the final drm_dev_put() call for @dev.
>>    */
>
>

Re: [PATCH v2 2/2] drm/managed: fix drmm_add_action() kernel-doc

[Borah, Chaitanya Kumar]

On 6/3/2026 3:28 AM, Michał Grzelak wrote:
> On Tue, 26 May 2026, Borah, Chaitanya Kumar wrote:
>> On 5/22/2026 7:25 PM, Michał Grzelak wrote:
>>> Kernel-doc of drmm_add_action() references @releases which is not
>>> on argument list. Swap '@' between 'releases' and 'action' words to fix
>>> the documentation.
>>>
>>
>> LGTM
>> Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
>>
> 
> Thank you Chaitanya for the review. Do you think this series can be
> merged via drm-misc-next branch from drm-misc [1]?

I suppose so.

Asking because I
> don't have commiter right to any of drm-* repositories.
> 

Same here. You can check in #dri-devel IRC if someone can help.

==
Chaitanya

> BR,
> Michał
> 
> [1] https://drm.pages.freedesktop.org/maintainer-tools/repositories/drm- 
> misc.html
> 
>>> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
>>> ---
>>>   include/drm/drm_managed.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h
>>> index 72bfac002c06..72d0d68be226 100644
>>> --- a/include/drm/drm_managed.h
>>> +++ b/include/drm/drm_managed.h
>>> @@ -18,7 +18,7 @@ typedef void (*drmres_release_t)(struct drm_device 
>>> *dev, void *res);
>>>    * @action: function which should be called when @dev is released
>>>    * @data: opaque pointer, passed to @action
>>>    *
>>> - * This function adds the @release action with optional parameter 
>>> @data to the
>>> + * This function adds the release @action with optional parameter 
>>> @data to the
>>>    * list of cleanup actions for @dev. The cleanup actions will be 
>>> run in reverse
>>>    * order in the final drm_dev_put() call for @dev.
>>>    */
>>
>>

✗ i915.CI.BAT: failure for fixes to DRM doc & parameter's print (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]

== Series Details ==

Series: fixes to DRM doc & parameter's print (rev2)
URL   : https://patchwork.freedesktop.org/series/167035/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_18542 -> Patchwork_167035v2
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_167035v2 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_167035v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_167035v2/index.html

Participating hosts (42 -> 39)
------------------------------

  Missing    (3): bat-dg2-13 fi-snb-2520m bat-adls-6 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_167035v2:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@guc_multi_lrc:
    - bat-arls-5:         [PASS][1] -> [INCOMPLETE][2] +1 other test incomplete
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18542/bat-arls-5/igt@i915_selftest@live@guc_multi_lrc.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_167035v2/bat-arls-5/igt@i915_selftest@live@guc_multi_lrc.html

  


Build changes
-------------

  * Linux: CI_DRM_18542 -> Patchwork_167035v2

  CI-20190529: 20190529
  CI_DRM_18542: 60d51bdeabf700864c26264c51b146a86b0a9124 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8936: 98b65acc4f6edf68cd52b30f27b83049c4c5c83b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_167035v2: 60d51bdeabf700864c26264c51b146a86b0a9124 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_167035v2/index.html

[-- Attachment #2: Type: text/html, Size: 2564 bytes --]