Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Eero Tamminen <eero.t.tamminen@intel.com>
Subject: Re: [PATCH] drm/i915: Default to more lenient force preempt timeout
Date: Tue, 26 Nov 2019 09:32:42 +0000	[thread overview]
Message-ID: <4740e8fe-7747-1eb5-803b-bcefb5d72959@linux.intel.com> (raw)
In-Reply-To: <20191125162737.2161069-1-chris@chris-wilson.co.uk>


On 25/11/2019 16:27, Chris Wilson wrote:
> Based on a sampling of a number of benchmarks across platforms, by
> default opt for a more much lenient timeout so that we should not
> adversely affect existing clients.
> 
> 640ms ought to be enough for anyone.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112169
> Fixes: 3a7a92aba8fb ("drm/i915/execlists: Force preemption")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> ---
>   drivers/gpu/drm/i915/Kconfig.profile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile
> index 1799537a3228..c280b6ae38eb 100644
> --- a/drivers/gpu/drm/i915/Kconfig.profile
> +++ b/drivers/gpu/drm/i915/Kconfig.profile
> @@ -25,7 +25,7 @@ config DRM_I915_HEARTBEAT_INTERVAL
>   
>   config DRM_I915_PREEMPT_TIMEOUT
>   	int "Preempt timeout (ms, jiffy granularity)"
> -	default 100 # milliseconds
> +	default 640 # milliseconds
>   	help
>   	  How long to wait (in milliseconds) for a preemption event to occur
>   	  when submitting a new context via execlists. If the current context
> 

If it's needed it's needed.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Eero Tamminen <eero.t.tamminen@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Default to more lenient force preempt timeout
Date: Tue, 26 Nov 2019 09:32:42 +0000	[thread overview]
Message-ID: <4740e8fe-7747-1eb5-803b-bcefb5d72959@linux.intel.com> (raw)
Message-ID: <20191126093242.CHXozOaBJfCXeF2_RNWdKjSX7paWc9rbZ3LFb_xXP1c@z> (raw)
In-Reply-To: <20191125162737.2161069-1-chris@chris-wilson.co.uk>


On 25/11/2019 16:27, Chris Wilson wrote:
> Based on a sampling of a number of benchmarks across platforms, by
> default opt for a more much lenient timeout so that we should not
> adversely affect existing clients.
> 
> 640ms ought to be enough for anyone.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112169
> Fixes: 3a7a92aba8fb ("drm/i915/execlists: Force preemption")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> ---
>   drivers/gpu/drm/i915/Kconfig.profile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile
> index 1799537a3228..c280b6ae38eb 100644
> --- a/drivers/gpu/drm/i915/Kconfig.profile
> +++ b/drivers/gpu/drm/i915/Kconfig.profile
> @@ -25,7 +25,7 @@ config DRM_I915_HEARTBEAT_INTERVAL
>   
>   config DRM_I915_PREEMPT_TIMEOUT
>   	int "Preempt timeout (ms, jiffy granularity)"
> -	default 100 # milliseconds
> +	default 640 # milliseconds
>   	help
>   	  How long to wait (in milliseconds) for a preemption event to occur
>   	  when submitting a new context via execlists. If the current context
> 

If it's needed it's needed.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-26  9:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 16:27 [PATCH] drm/i915: Default to more lenient force preempt timeout Chris Wilson
2019-11-25 16:27 ` [Intel-gfx] " Chris Wilson
2019-11-25 17:52 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-11-25 17:52   ` [Intel-gfx] " Patchwork
2019-11-26  9:32 ` Tvrtko Ursulin [this message]
2019-11-26  9:32   ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2019-11-26 14:14   ` Joonas Lahtinen
2019-11-26 14:14     ` [Intel-gfx] " Joonas Lahtinen
2019-11-26 14:22     ` Chris Wilson
2019-11-26 14:22       ` [Intel-gfx] " Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4740e8fe-7747-1eb5-803b-bcefb5d72959@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=eero.t.tamminen@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox