* [PATCH] drm/i915: Default to more lenient force preempt timeout
@ 2019-11-25 16:27 Chris Wilson
2019-11-25 16:27 ` [Intel-gfx] " Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Chris Wilson @ 2019-11-25 16:27 UTC (permalink / raw)
To: intel-gfx; +Cc: Eero Tamminen
Based on a sampling of a number of benchmarks across platforms, by
default opt for a more much lenient timeout so that we should not
adversely affect existing clients.
640ms ought to be enough for anyone.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112169
Fixes: 3a7a92aba8fb ("drm/i915/execlists: Force preemption")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Eero Tamminen <eero.t.tamminen@intel.com>
Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
---
drivers/gpu/drm/i915/Kconfig.profile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile
index 1799537a3228..c280b6ae38eb 100644
--- a/drivers/gpu/drm/i915/Kconfig.profile
+++ b/drivers/gpu/drm/i915/Kconfig.profile
@@ -25,7 +25,7 @@ config DRM_I915_HEARTBEAT_INTERVAL
config DRM_I915_PREEMPT_TIMEOUT
int "Preempt timeout (ms, jiffy granularity)"
- default 100 # milliseconds
+ default 640 # milliseconds
help
How long to wait (in milliseconds) for a preemption event to occur
when submitting a new context via execlists. If the current context
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Intel-gfx] [PATCH] drm/i915: Default to more lenient force preempt timeout
2019-11-25 16:27 [PATCH] drm/i915: Default to more lenient force preempt timeout Chris Wilson
@ 2019-11-25 16:27 ` Chris Wilson
2019-11-25 17:52 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-11-26 9:32 ` [PATCH] " Tvrtko Ursulin
2 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2019-11-25 16:27 UTC (permalink / raw)
To: intel-gfx; +Cc: Eero Tamminen
Based on a sampling of a number of benchmarks across platforms, by
default opt for a more much lenient timeout so that we should not
adversely affect existing clients.
640ms ought to be enough for anyone.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112169
Fixes: 3a7a92aba8fb ("drm/i915/execlists: Force preemption")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Eero Tamminen <eero.t.tamminen@intel.com>
Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
---
drivers/gpu/drm/i915/Kconfig.profile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile
index 1799537a3228..c280b6ae38eb 100644
--- a/drivers/gpu/drm/i915/Kconfig.profile
+++ b/drivers/gpu/drm/i915/Kconfig.profile
@@ -25,7 +25,7 @@ config DRM_I915_HEARTBEAT_INTERVAL
config DRM_I915_PREEMPT_TIMEOUT
int "Preempt timeout (ms, jiffy granularity)"
- default 100 # milliseconds
+ default 640 # milliseconds
help
How long to wait (in milliseconds) for a preemption event to occur
when submitting a new context via execlists. If the current context
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread* ✗ Fi.CI.BAT: failure for drm/i915: Default to more lenient force preempt timeout
2019-11-25 16:27 [PATCH] drm/i915: Default to more lenient force preempt timeout Chris Wilson
2019-11-25 16:27 ` [Intel-gfx] " Chris Wilson
@ 2019-11-25 17:52 ` Patchwork
2019-11-25 17:52 ` [Intel-gfx] " Patchwork
2019-11-26 9:32 ` [PATCH] " Tvrtko Ursulin
2 siblings, 1 reply; 10+ messages in thread
From: Patchwork @ 2019-11-25 17:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Default to more lenient force preempt timeout
URL : https://patchwork.freedesktop.org/series/69992/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7418 -> Patchwork_15427
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15427 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15427, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15427/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15427:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_gt_heartbeat:
- fi-bdw-5557u: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7418/fi-bdw-5557u/igt@i915_selftest@live_gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15427/fi-bdw-5557u/igt@i915_selftest@live_gt_heartbeat.html
Known issues
------------
Here are the changes found in Patchwork_15427 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#106107])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7418/fi-icl-u3/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15427/fi-icl-u3/igt@i915_pm_rpm@module-reload.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic:
- fi-icl-dsi: [DMESG-WARN][5] ([fdo#106107]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7418/fi-icl-dsi/igt@gem_ctx_exec@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15427/fi-icl-dsi/igt@gem_ctx_exec@basic.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][7] ([fdo#111045] / [fdo#111096]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7418/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15427/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-x1275: [DMESG-WARN][9] ([fdo#103558] / [fdo#105602] / [fdo#105763] / [fdo#107139]) -> [DMESG-WARN][10] ([fdo#103558] / [fdo#105602] / [fdo#107139])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7418/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15427/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
* igt@kms_flip@basic-flip-vs-modeset:
- fi-kbl-x1275: [DMESG-WARN][11] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +6 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7418/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15427/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][13] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7418/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15427/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (51 -> 45)
------------------------------
Missing (6): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7418 -> Patchwork_15427
CI-20190529: 20190529
CI_DRM_7418: 6e08331c458d051f6e12d478c96ae6c3c89061ca @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5305: eafaa79dfb71f7251126f1c000e0cbe94425c95a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15427: 585ef26cc5119f0dc68855fd36d0697e6530e5f1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
585ef26cc511 drm/i915: Default to more lenient force preempt timeout
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15427/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm/i915: Default to more lenient force preempt timeout
2019-11-25 16:27 [PATCH] drm/i915: Default to more lenient force preempt timeout Chris Wilson
2019-11-25 16:27 ` [Intel-gfx] " Chris Wilson
2019-11-25 17:52 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2019-11-26 9:32 ` Tvrtko Ursulin
2019-11-26 9:32 ` [Intel-gfx] " Tvrtko Ursulin
2019-11-26 14:14 ` Joonas Lahtinen
2 siblings, 2 replies; 10+ messages in thread
From: Tvrtko Ursulin @ 2019-11-26 9:32 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Eero Tamminen
On 25/11/2019 16:27, Chris Wilson wrote:
> Based on a sampling of a number of benchmarks across platforms, by
> default opt for a more much lenient timeout so that we should not
> adversely affect existing clients.
>
> 640ms ought to be enough for anyone.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112169
> Fixes: 3a7a92aba8fb ("drm/i915/execlists: Force preemption")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> ---
> drivers/gpu/drm/i915/Kconfig.profile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile
> index 1799537a3228..c280b6ae38eb 100644
> --- a/drivers/gpu/drm/i915/Kconfig.profile
> +++ b/drivers/gpu/drm/i915/Kconfig.profile
> @@ -25,7 +25,7 @@ config DRM_I915_HEARTBEAT_INTERVAL
>
> config DRM_I915_PREEMPT_TIMEOUT
> int "Preempt timeout (ms, jiffy granularity)"
> - default 100 # milliseconds
> + default 640 # milliseconds
> help
> How long to wait (in milliseconds) for a preemption event to occur
> when submitting a new context via execlists. If the current context
>
If it's needed it's needed.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Default to more lenient force preempt timeout
2019-11-26 9:32 ` [PATCH] " Tvrtko Ursulin
@ 2019-11-26 9:32 ` Tvrtko Ursulin
2019-11-26 14:14 ` Joonas Lahtinen
1 sibling, 0 replies; 10+ messages in thread
From: Tvrtko Ursulin @ 2019-11-26 9:32 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Eero Tamminen
On 25/11/2019 16:27, Chris Wilson wrote:
> Based on a sampling of a number of benchmarks across platforms, by
> default opt for a more much lenient timeout so that we should not
> adversely affect existing clients.
>
> 640ms ought to be enough for anyone.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112169
> Fixes: 3a7a92aba8fb ("drm/i915/execlists: Force preemption")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> ---
> drivers/gpu/drm/i915/Kconfig.profile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile
> index 1799537a3228..c280b6ae38eb 100644
> --- a/drivers/gpu/drm/i915/Kconfig.profile
> +++ b/drivers/gpu/drm/i915/Kconfig.profile
> @@ -25,7 +25,7 @@ config DRM_I915_HEARTBEAT_INTERVAL
>
> config DRM_I915_PREEMPT_TIMEOUT
> int "Preempt timeout (ms, jiffy granularity)"
> - default 100 # milliseconds
> + default 640 # milliseconds
> help
> How long to wait (in milliseconds) for a preemption event to occur
> when submitting a new context via execlists. If the current context
>
If it's needed it's needed.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm/i915: Default to more lenient force preempt timeout
2019-11-26 9:32 ` [PATCH] " Tvrtko Ursulin
2019-11-26 9:32 ` [Intel-gfx] " Tvrtko Ursulin
@ 2019-11-26 14:14 ` Joonas Lahtinen
2019-11-26 14:14 ` [Intel-gfx] " Joonas Lahtinen
2019-11-26 14:22 ` Chris Wilson
1 sibling, 2 replies; 10+ messages in thread
From: Joonas Lahtinen @ 2019-11-26 14:14 UTC (permalink / raw)
To: Chris Wilson, Tvrtko Ursulin, intel-gfx; +Cc: Eero Tamminen, Kenneth Graunke
+ Jason/Ken for Mesa feedback (please look at Bugzilla discussion)
Quoting Tvrtko Ursulin (2019-11-26 11:32:42)
>
> On 25/11/2019 16:27, Chris Wilson wrote:
> > Based on a sampling of a number of benchmarks across platforms, by
> > default opt for a more much lenient timeout so that we should not
> > adversely affect existing clients.
> >
> > 640ms ought to be enough for anyone.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112169
> > Fixes: 3a7a92aba8fb ("drm/i915/execlists: Force preemption")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> > Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> > ---
> > drivers/gpu/drm/i915/Kconfig.profile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile
> > index 1799537a3228..c280b6ae38eb 100644
> > --- a/drivers/gpu/drm/i915/Kconfig.profile
> > +++ b/drivers/gpu/drm/i915/Kconfig.profile
> > @@ -25,7 +25,7 @@ config DRM_I915_HEARTBEAT_INTERVAL
> >
> > config DRM_I915_PREEMPT_TIMEOUT
> > int "Preempt timeout (ms, jiffy granularity)"
> > - default 100 # milliseconds
> > + default 640 # milliseconds
Maybe just bump to 1000 ms for a good measure.
640 ms is already a radical stall.
Regards, Joonas
> > help
> > How long to wait (in milliseconds) for a preemption event to occur
> > when submitting a new context via execlists. If the current context
> >
>
> If it's needed it's needed.
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Regards,
>
> Tvrtko
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Default to more lenient force preempt timeout
2019-11-26 14:14 ` Joonas Lahtinen
@ 2019-11-26 14:14 ` Joonas Lahtinen
2019-11-26 14:22 ` Chris Wilson
1 sibling, 0 replies; 10+ messages in thread
From: Joonas Lahtinen @ 2019-11-26 14:14 UTC (permalink / raw)
To: Chris Wilson, Tvrtko Ursulin, intel-gfx; +Cc: Eero Tamminen, Kenneth Graunke
+ Jason/Ken for Mesa feedback (please look at Bugzilla discussion)
Quoting Tvrtko Ursulin (2019-11-26 11:32:42)
>
> On 25/11/2019 16:27, Chris Wilson wrote:
> > Based on a sampling of a number of benchmarks across platforms, by
> > default opt for a more much lenient timeout so that we should not
> > adversely affect existing clients.
> >
> > 640ms ought to be enough for anyone.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112169
> > Fixes: 3a7a92aba8fb ("drm/i915/execlists: Force preemption")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> > Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> > ---
> > drivers/gpu/drm/i915/Kconfig.profile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile
> > index 1799537a3228..c280b6ae38eb 100644
> > --- a/drivers/gpu/drm/i915/Kconfig.profile
> > +++ b/drivers/gpu/drm/i915/Kconfig.profile
> > @@ -25,7 +25,7 @@ config DRM_I915_HEARTBEAT_INTERVAL
> >
> > config DRM_I915_PREEMPT_TIMEOUT
> > int "Preempt timeout (ms, jiffy granularity)"
> > - default 100 # milliseconds
> > + default 640 # milliseconds
Maybe just bump to 1000 ms for a good measure.
640 ms is already a radical stall.
Regards, Joonas
> > help
> > How long to wait (in milliseconds) for a preemption event to occur
> > when submitting a new context via execlists. If the current context
> >
>
> If it's needed it's needed.
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Regards,
>
> Tvrtko
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm/i915: Default to more lenient force preempt timeout
2019-11-26 14:14 ` Joonas Lahtinen
2019-11-26 14:14 ` [Intel-gfx] " Joonas Lahtinen
@ 2019-11-26 14:22 ` Chris Wilson
2019-11-26 14:22 ` [Intel-gfx] " Chris Wilson
1 sibling, 1 reply; 10+ messages in thread
From: Chris Wilson @ 2019-11-26 14:22 UTC (permalink / raw)
To: Joonas Lahtinen, Tvrtko Ursulin, intel-gfx; +Cc: Eero Tamminen, Kenneth Graunke
Quoting Joonas Lahtinen (2019-11-26 14:14:10)
> + Jason/Ken for Mesa feedback (please look at Bugzilla discussion)
>
> Quoting Tvrtko Ursulin (2019-11-26 11:32:42)
> >
> > On 25/11/2019 16:27, Chris Wilson wrote:
> > > Based on a sampling of a number of benchmarks across platforms, by
> > > default opt for a more much lenient timeout so that we should not
> > > adversely affect existing clients.
> > >
> > > 640ms ought to be enough for anyone.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112169
> > > Fixes: 3a7a92aba8fb ("drm/i915/execlists: Force preemption")
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> > > Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/Kconfig.profile | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile
> > > index 1799537a3228..c280b6ae38eb 100644
> > > --- a/drivers/gpu/drm/i915/Kconfig.profile
> > > +++ b/drivers/gpu/drm/i915/Kconfig.profile
> > > @@ -25,7 +25,7 @@ config DRM_I915_HEARTBEAT_INTERVAL
> > >
> > > config DRM_I915_PREEMPT_TIMEOUT
> > > int "Preempt timeout (ms, jiffy granularity)"
> > > - default 100 # milliseconds
> > > + default 640 # milliseconds
>
> Maybe just bump to 1000 ms for a good measure.
>
> 640 ms is already a radical stall.
But 640ms! :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Default to more lenient force preempt timeout
2019-11-26 14:22 ` Chris Wilson
@ 2019-11-26 14:22 ` Chris Wilson
0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2019-11-26 14:22 UTC (permalink / raw)
To: Joonas Lahtinen, Tvrtko Ursulin, intel-gfx; +Cc: Eero Tamminen, Kenneth Graunke
Quoting Joonas Lahtinen (2019-11-26 14:14:10)
> + Jason/Ken for Mesa feedback (please look at Bugzilla discussion)
>
> Quoting Tvrtko Ursulin (2019-11-26 11:32:42)
> >
> > On 25/11/2019 16:27, Chris Wilson wrote:
> > > Based on a sampling of a number of benchmarks across platforms, by
> > > default opt for a more much lenient timeout so that we should not
> > > adversely affect existing clients.
> > >
> > > 640ms ought to be enough for anyone.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112169
> > > Fixes: 3a7a92aba8fb ("drm/i915/execlists: Force preemption")
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> > > Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/Kconfig.profile | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kconfig.profile
> > > index 1799537a3228..c280b6ae38eb 100644
> > > --- a/drivers/gpu/drm/i915/Kconfig.profile
> > > +++ b/drivers/gpu/drm/i915/Kconfig.profile
> > > @@ -25,7 +25,7 @@ config DRM_I915_HEARTBEAT_INTERVAL
> > >
> > > config DRM_I915_PREEMPT_TIMEOUT
> > > int "Preempt timeout (ms, jiffy granularity)"
> > > - default 100 # milliseconds
> > > + default 640 # milliseconds
>
> Maybe just bump to 1000 ms for a good measure.
>
> 640 ms is already a radical stall.
But 640ms! :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-11-26 14:22 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-25 16:27 [PATCH] drm/i915: Default to more lenient force preempt timeout Chris Wilson
2019-11-25 16:27 ` [Intel-gfx] " Chris Wilson
2019-11-25 17:52 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-11-25 17:52 ` [Intel-gfx] " Patchwork
2019-11-26 9:32 ` [PATCH] " Tvrtko Ursulin
2019-11-26 9:32 ` [Intel-gfx] " Tvrtko Ursulin
2019-11-26 14:14 ` Joonas Lahtinen
2019-11-26 14:14 ` [Intel-gfx] " Joonas Lahtinen
2019-11-26 14:22 ` Chris Wilson
2019-11-26 14:22 ` [Intel-gfx] " Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox