* [PATCH] drm/i915: only match on PCI_BASE_CLASS_DISPLAY
@ 2011-10-11 8:59 Daniel Vetter
2011-10-11 13:40 ` Adam Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2011-10-11 8:59 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
... not DISPLAY_VGA, because we ignore the VGA subclass with our
class_mask.
It confused me until Chris Wilson clued me up.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index ad85c13..d4f0a58 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -106,7 +106,7 @@ static struct drm_driver driver;
extern int intel_agp_enabled;
#define INTEL_VGA_DEVICE(id, info) { \
- .class = PCI_CLASS_DISPLAY_VGA << 8, \
+ .class = PCI_BASE_CLASS_DISPLAY << 16, \
.class_mask = 0xff0000, \
.vendor = 0x8086, \
.device = id, \
--
1.7.6.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: only match on PCI_BASE_CLASS_DISPLAY
2011-10-11 8:59 [PATCH] drm/i915: only match on PCI_BASE_CLASS_DISPLAY Daniel Vetter
@ 2011-10-11 13:40 ` Adam Jackson
2011-10-23 10:05 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Adam Jackson @ 2011-10-11 13:40 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
On 10/11/11 4:59 AM, Daniel Vetter wrote:
> ... not DISPLAY_VGA, because we ignore the VGA subclass with our
> class_mask.
>
> It confused me until Chris Wilson clued me up.
>
> Signed-off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
Reviewed-by: Adam Jackson <ajax@redhat.com>
- ajax
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: only match on PCI_BASE_CLASS_DISPLAY
2011-10-11 13:40 ` Adam Jackson
@ 2011-10-23 10:05 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2011-10-23 10:05 UTC (permalink / raw)
To: Keith Packard; +Cc: Daniel Vetter, intel-gfx
Hi Keith
This patch isn't in your -next pull request. Please consider merging for
3.2.
Yours, Daniel
On Tue, Oct 11, 2011 at 09:40:51AM -0400, Adam Jackson wrote:
> On 10/11/11 4:59 AM, Daniel Vetter wrote:
> >... not DISPLAY_VGA, because we ignore the VGA subclass with our
> >class_mask.
> >
> >It confused me until Chris Wilson clued me up.
> >
> >Signed-off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
>
> Reviewed-by: Adam Jackson <ajax@redhat.com>
>
> - ajax
>
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-23 10:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-11 8:59 [PATCH] drm/i915: only match on PCI_BASE_CLASS_DISPLAY Daniel Vetter
2011-10-11 13:40 ` Adam Jackson
2011-10-23 10:05 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox