Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Souza, Jose" <jose.souza@intel.com>
To: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"De Marchi, Lucas" <lucas.demarchi@intel.com>
Cc: "Nikula, Jani" <jani.nikula@intel.com>
Subject: Re: [PATCH 0/5] tgl: MST support
Date: Fri, 1 Nov 2019 00:43:28 +0000	[thread overview]
Message-ID: <4ec4df6aa34ead6619d5173038c216f7e7301909.camel@intel.com> (raw)
In-Reply-To: <20191030012448.14937-1-lucas.demarchi@intel.com>

I plan to debug MST with this patches next week but I guess at least
the 4 first patches can be merged. The 5th too if someone else reviews
it, the selection of the master transcoder was tested by me and Lucas
and the problem in not in any of this patches.


On Tue, 2019-10-29 at 18:24 -0700, Lucas De Marchi wrote:
> Additional code to support more than one display when using MST with
> TGL. It's still WIP! From what I could check on my tests we are
> correctly
> tracking the master transcoder and setting it accordingly on
> TRANS_DDI_FUNC_CTL and DP_TP_CTL.
> 
> I tried also setting MST mode on the slave's DP_TP_CTL. I could get
> the
> second display to show up some times and we don't get stuck on
> "timeout
> waiting for ACT" error message.  This is not according to the spec
> though, and it still doesn't work most of the time. So... I didn't
> add
> it here.
> 
> I guess now I need another pair of eyes to check what I'm doing wrong
> since continuing to stare at the spec and code isn't helping. José,
> Imre?
> 
> José Roberto de Souza (2):
>   drm/i915: Add for_each_new_intel_connector_in_state()
>   drm/i915/tgl: Select master transcoder in DP MST
> 
> Lucas De Marchi (3):
>   drm/i915: add wrappers to get intel connector state
>   drm/i915/tgl: do not enable transcoder clock twice on MST
>   drm/i915: avoid reading DP_TP_CTL twice
> 
>  drivers/gpu/drm/i915/display/intel_ddi.c      |  54 +++---
>  drivers/gpu/drm/i915/display/intel_display.c  |  16 ++
>  drivers/gpu/drm/i915/display/intel_display.h  |   8 +
>  .../drm/i915/display/intel_display_types.h    |  21 +++
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   | 159
> +++++++++++++++++-
>  drivers/gpu/drm/i915/display/intel_dp_mst.h   |   2 +
>  6 files changed, 236 insertions(+), 24 deletions(-)
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Souza, Jose" <jose.souza@intel.com>
To: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"De Marchi, Lucas" <lucas.demarchi@intel.com>
Cc: "Nikula, Jani" <jani.nikula@intel.com>
Subject: Re: [Intel-gfx] [PATCH 0/5] tgl: MST support
Date: Fri, 1 Nov 2019 00:43:28 +0000	[thread overview]
Message-ID: <4ec4df6aa34ead6619d5173038c216f7e7301909.camel@intel.com> (raw)
Message-ID: <20191101004328.6QMy0I19FmkwonFLfZ5Lkc5cZHU2opevB6W-Y08Uw5o@z> (raw)
In-Reply-To: <20191030012448.14937-1-lucas.demarchi@intel.com>

I plan to debug MST with this patches next week but I guess at least
the 4 first patches can be merged. The 5th too if someone else reviews
it, the selection of the master transcoder was tested by me and Lucas
and the problem in not in any of this patches.


On Tue, 2019-10-29 at 18:24 -0700, Lucas De Marchi wrote:
> Additional code to support more than one display when using MST with
> TGL. It's still WIP! From what I could check on my tests we are
> correctly
> tracking the master transcoder and setting it accordingly on
> TRANS_DDI_FUNC_CTL and DP_TP_CTL.
> 
> I tried also setting MST mode on the slave's DP_TP_CTL. I could get
> the
> second display to show up some times and we don't get stuck on
> "timeout
> waiting for ACT" error message.  This is not according to the spec
> though, and it still doesn't work most of the time. So... I didn't
> add
> it here.
> 
> I guess now I need another pair of eyes to check what I'm doing wrong
> since continuing to stare at the spec and code isn't helping. José,
> Imre?
> 
> José Roberto de Souza (2):
>   drm/i915: Add for_each_new_intel_connector_in_state()
>   drm/i915/tgl: Select master transcoder in DP MST
> 
> Lucas De Marchi (3):
>   drm/i915: add wrappers to get intel connector state
>   drm/i915/tgl: do not enable transcoder clock twice on MST
>   drm/i915: avoid reading DP_TP_CTL twice
> 
>  drivers/gpu/drm/i915/display/intel_ddi.c      |  54 +++---
>  drivers/gpu/drm/i915/display/intel_display.c  |  16 ++
>  drivers/gpu/drm/i915/display/intel_display.h  |   8 +
>  .../drm/i915/display/intel_display_types.h    |  21 +++
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   | 159
> +++++++++++++++++-
>  drivers/gpu/drm/i915/display/intel_dp_mst.h   |   2 +
>  6 files changed, 236 insertions(+), 24 deletions(-)
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-01  0:43 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30  1:24 [PATCH 0/5] tgl: MST support Lucas De Marchi
2019-10-30  1:24 ` [Intel-gfx] " Lucas De Marchi
2019-10-30  1:24 ` [PATCH 1/5] drm/i915: Add for_each_new_intel_connector_in_state() Lucas De Marchi
2019-10-30  1:24   ` [Intel-gfx] " Lucas De Marchi
2019-10-30  1:24 ` [PATCH 2/5] drm/i915: add wrappers to get intel connector state Lucas De Marchi
2019-10-30  1:24   ` [Intel-gfx] " Lucas De Marchi
2019-11-01  0:26   ` Souza, Jose
2019-11-01  0:26     ` [Intel-gfx] " Souza, Jose
2019-10-30  1:24 ` [PATCH 3/5] drm/i915/tgl: do not enable transcoder clock twice on MST Lucas De Marchi
2019-10-30  1:24   ` [Intel-gfx] " Lucas De Marchi
2019-11-01  0:37   ` Souza, Jose
2019-11-01  0:37     ` [Intel-gfx] " Souza, Jose
2019-10-30  1:24 ` [PATCH 4/5] drm/i915: avoid reading DP_TP_CTL twice Lucas De Marchi
2019-10-30  1:24   ` [Intel-gfx] " Lucas De Marchi
2019-11-01  0:39   ` Souza, Jose
2019-11-01  0:39     ` [Intel-gfx] " Souza, Jose
2019-10-30  1:24 ` [PATCH 5/5] drm/i915/tgl: Select master transcoder in DP MST Lucas De Marchi
2019-10-30  1:24   ` [Intel-gfx] " Lucas De Marchi
2019-10-30  3:24 ` ✗ Fi.CI.CHECKPATCH: warning for tgl: MST support Patchwork
2019-10-30  3:24   ` [Intel-gfx] " Patchwork
2019-10-30  3:27 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-10-30  3:27   ` [Intel-gfx] " Patchwork
2019-10-30  3:51 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-30  3:51   ` [Intel-gfx] " Patchwork
2019-10-31  8:00 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-31  8:00   ` [Intel-gfx] " Patchwork
2019-11-01  0:43 ` Souza, Jose [this message]
2019-11-01  0:43   ` [Intel-gfx] [PATCH 0/5] " Souza, Jose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ec4df6aa34ead6619d5173038c216f7e7301909.camel@intel.com \
    --to=jose.souza@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox