From: Kenneth Graunke <kenneth@whitecape.org>
To: "Xiang, Haihao" <haihao.xiang@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel gfx][i-g-t PATCH 1/4] lib: Clean the batch buffer store after reset
Date: Fri, 06 Dec 2013 02:14:52 -0800 [thread overview]
Message-ID: <52A1A39C.6000905@whitecape.org> (raw)
In-Reply-To: <1386320087-3017-1-git-send-email-haihao.xiang@intel.com>
On 12/06/2013 12:54 AM, Xiang, Haihao wrote:
> From: "Xiang, Haihao" <haihao.xiang@intel.com>
>
> Otherwise the stale data in the buffer
>
> Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
> ---
> lib/intel_batchbuffer.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index 06a5437..9ce7424 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -50,6 +50,8 @@ intel_batchbuffer_reset(struct intel_batchbuffer *batch)
> batch->bo = drm_intel_bo_alloc(batch->bufmgr, "batchbuffer",
> BATCH_SZ, 4096);
>
> + memset(batch->buffer, 0, sizeof(batch->buffer));
> +
> batch->ptr = batch->buffer;
> }
>
>
I don't think that should be harmful, but this would definitely make
debugging nicer. For intel-gpu-tools, I think it makes sense.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
next prev parent reply other threads:[~2013-12-06 10:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 8:54 [Intel gfx][i-g-t PATCH 1/4] lib: Clean the batch buffer store after reset Xiang, Haihao
2013-12-06 8:54 ` [Intel gfx][i-g-t PATCH 2/4] rendercopy/bdw: Set Instruction Buffer size Modify Enable to 1 Xiang, Haihao
2013-12-06 10:15 ` Kenneth Graunke
2013-12-06 13:08 ` Damien Lespiau
2013-12-06 8:54 ` [Intel gfx][i-g-t PATCH 3/4] rendercopy/bdw: A workaround for 3D pipeline Xiang, Haihao
2013-12-06 13:30 ` Damien Lespiau
2013-12-09 4:47 ` Xiang, Haihao
2013-12-09 6:53 ` Daniel Vetter
2013-12-06 8:54 ` [Intel gfx][i-g-t PATCH 4/4] Revert "gen8 rendercpy: temporarily disable" Xiang, Haihao
2013-12-06 10:14 ` Kenneth Graunke [this message]
2013-12-06 13:03 ` [Intel gfx][i-g-t PATCH 1/4] lib: Clean the batch buffer store after reset Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A1A39C.6000905@whitecape.org \
--to=kenneth@whitecape.org \
--cc=haihao.xiang@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox