From: Damien Lespiau <damien.lespiau@intel.com>
To: Kenneth Graunke <kenneth@whitecape.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel gfx][i-g-t PATCH 2/4] rendercopy/bdw: Set Instruction Buffer size Modify Enable to 1
Date: Fri, 6 Dec 2013 13:08:27 +0000 [thread overview]
Message-ID: <20131206130827.GE16277@strange.amr.corp.intel.com> (raw)
In-Reply-To: <52A1A3B6.1040501@whitecape.org>
On Fri, Dec 06, 2013 at 02:15:18AM -0800, Kenneth Graunke wrote:
> On 12/06/2013 12:54 AM, Xiang, Haihao wrote:
> > From: "Xiang, Haihao" <haihao.xiang@intel.com>
> >
> > Otherwise it may result in GPU hang
> >
> > Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
> > ---
> > lib/rendercopy_gen8.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
> > index 43e962c..1a137dd 100644
> > --- a/lib/rendercopy_gen8.c
> > +++ b/lib/rendercopy_gen8.c
> > @@ -526,7 +526,7 @@ gen8_emit_state_base_address(struct intel_batchbuffer *batch) {
> > /* indirect object buffer size */
> > OUT_BATCH(0xfffff000 | 1);
> > /* intruction buffer size */
> > - OUT_BATCH(1 << 12);
> > + OUT_BATCH(1 << 12 | 1);
> > }
> >
> > static void
> >
>
> Thanks a ton for finding this!
>
> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Nice catch! Thanks for the patch and review, pushed.
--
Damien
next prev parent reply other threads:[~2013-12-06 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 8:54 [Intel gfx][i-g-t PATCH 1/4] lib: Clean the batch buffer store after reset Xiang, Haihao
2013-12-06 8:54 ` [Intel gfx][i-g-t PATCH 2/4] rendercopy/bdw: Set Instruction Buffer size Modify Enable to 1 Xiang, Haihao
2013-12-06 10:15 ` Kenneth Graunke
2013-12-06 13:08 ` Damien Lespiau [this message]
2013-12-06 8:54 ` [Intel gfx][i-g-t PATCH 3/4] rendercopy/bdw: A workaround for 3D pipeline Xiang, Haihao
2013-12-06 13:30 ` Damien Lespiau
2013-12-09 4:47 ` Xiang, Haihao
2013-12-09 6:53 ` Daniel Vetter
2013-12-06 8:54 ` [Intel gfx][i-g-t PATCH 4/4] Revert "gen8 rendercpy: temporarily disable" Xiang, Haihao
2013-12-06 10:14 ` [Intel gfx][i-g-t PATCH 1/4] lib: Clean the batch buffer store after reset Kenneth Graunke
2013-12-06 13:03 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206130827.GE16277@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox