Re: [Intel-gfx] [PATCH v2 38/50] drm/i915/dg2: Don't program BW_BUDDY registers

["Souza, Jose" <jose.souza@intel.com>]

On Tue, 2021-07-13 at 20:15 -0700, Matt Roper wrote:
> Although the BW_BUDDY registers still exist, they are not used for
> anything on DG2.  This change is expected to hold true for future dgpu's
> too.

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> 
> Bspec: 49218
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_power.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 04af987f3324..9593c517a321 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -5814,6 +5814,10 @@ static void tgl_bw_buddy_init(struct drm_i915_private *dev_priv)
>  	unsigned long abox_mask = INTEL_INFO(dev_priv)->abox_mask;
>  	int config, i;
>  
> +	/* BW_BUDDY registers are not used on dgpu's beyond DG1 */
> +	if (IS_DGFX(dev_priv) && !IS_DG1(dev_priv))
> +		return;
> +
>  	if (IS_ALDERLAKE_S(dev_priv) ||
>  	    IS_DG1_REVID(dev_priv, DG1_REVID_A0, DG1_REVID_A0) ||
>  	    IS_TGL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0))

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx