* [Intel-gfx] [PATCH 1/6] drm/i915: Remove leftover cnl SAGV block time
2022-03-08 17:32 [Intel-gfx] [PATCH 0/6] drm/i915: SAGV block time fixes Ville Syrjala
@ 2022-03-08 17:32 ` Ville Syrjala
2022-03-09 10:24 ` Govindapillai, Vinod
2022-03-08 17:32 ` [Intel-gfx] [PATCH 2/6] drm/i915: Rework SAGV block time probing Ville Syrjala
` (6 subsequent siblings)
7 siblings, 1 reply; 14+ messages in thread
From: Ville Syrjala @ 2022-03-08 17:32 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
GLK doesn't support SAGV, so with CNL gone there is no
use for having a DISPLAY_VER==10 SAGV block time in the code.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index f70eb10ab24d..8ee31c9590a7 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3689,9 +3689,6 @@ skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)
} else if (DISPLAY_VER(dev_priv) == 11) {
dev_priv->sagv_block_time_us = 10;
return;
- } else if (DISPLAY_VER(dev_priv) == 10) {
- dev_priv->sagv_block_time_us = 20;
- return;
} else if (DISPLAY_VER(dev_priv) == 9) {
dev_priv->sagv_block_time_us = 30;
return;
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [Intel-gfx] [PATCH 1/6] drm/i915: Remove leftover cnl SAGV block time
2022-03-08 17:32 ` [Intel-gfx] [PATCH 1/6] drm/i915: Remove leftover cnl SAGV block time Ville Syrjala
@ 2022-03-09 10:24 ` Govindapillai, Vinod
0 siblings, 0 replies; 14+ messages in thread
From: Govindapillai, Vinod @ 2022-03-09 10:24 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
On Tue, 2022-03-08 at 19:32 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> GLK doesn't support SAGV, so with CNL gone there is no
> use for having a DISPLAY_VER==10 SAGV block time in the code.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index f70eb10ab24d..8ee31c9590a7 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3689,9 +3689,6 @@ skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)
> } else if (DISPLAY_VER(dev_priv) == 11) {
> dev_priv->sagv_block_time_us = 10;
> return;
> - } else if (DISPLAY_VER(dev_priv) == 10) {
> - dev_priv->sagv_block_time_us = 20;
> - return;
> } else if (DISPLAY_VER(dev_priv) == 9) {
> dev_priv->sagv_block_time_us = 30;
> return;
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 2/6] drm/i915: Rework SAGV block time probing
2022-03-08 17:32 [Intel-gfx] [PATCH 0/6] drm/i915: SAGV block time fixes Ville Syrjala
2022-03-08 17:32 ` [Intel-gfx] [PATCH 1/6] drm/i915: Remove leftover cnl SAGV block time Ville Syrjala
@ 2022-03-08 17:32 ` Ville Syrjala
2022-03-09 10:41 ` Govindapillai, Vinod
2022-03-08 17:32 ` [Intel-gfx] [PATCH 3/6] drm/i915: Treat SAGV block time 0 as SAGV disabled Ville Syrjala
` (5 subsequent siblings)
7 siblings, 1 reply; 14+ messages in thread
From: Ville Syrjala @ 2022-03-08 17:32 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
I'd like to see the SAGV block time we got from the mailbox
in the logs regardless of whether other factors prevent the
use of SAGV.
So let's adjust the code to always query the SAGV block time,
log it, and then reset it if SAGV is not actually supported.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 38 +++++++++++++++++++--------------
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 8ee31c9590a7..21c37115c36e 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3670,8 +3670,8 @@ intel_has_sagv(struct drm_i915_private *dev_priv)
dev_priv->sagv_status != I915_SAGV_NOT_CONTROLLED;
}
-static void
-skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)
+static u32
+intel_sagv_block_time(struct drm_i915_private *dev_priv)
{
if (DISPLAY_VER(dev_priv) >= 12) {
u32 val = 0;
@@ -3680,24 +3680,31 @@ skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)
ret = snb_pcode_read(dev_priv,
GEN12_PCODE_READ_SAGV_BLOCK_TIME_US,
&val, NULL);
- if (!ret) {
- dev_priv->sagv_block_time_us = val;
- return;
+ if (ret) {
+ drm_dbg_kms(&dev_priv->drm, "Couldn't read SAGV block time!\n");
+ return -1;
}
- drm_dbg(&dev_priv->drm, "Couldn't read SAGV block time!\n");
+ return val;
} else if (DISPLAY_VER(dev_priv) == 11) {
- dev_priv->sagv_block_time_us = 10;
- return;
- } else if (DISPLAY_VER(dev_priv) == 9) {
- dev_priv->sagv_block_time_us = 30;
- return;
+ return 10;
+ } else if (DISPLAY_VER(dev_priv) == 9 && !IS_LP(dev_priv)) {
+ return 30;
} else {
- MISSING_CASE(DISPLAY_VER(dev_priv));
+ /* Default to an unusable block time */
+ return -1;
}
+}
- /* Default to an unusable block time */
- dev_priv->sagv_block_time_us = -1;
+static void intel_sagv_init(struct drm_i915_private *i915)
+{
+ i915->sagv_block_time_us = intel_sagv_block_time(i915);
+
+ drm_dbg_kms(&i915->drm, "SAGV supported: %s, original SAGV block time: %u us\n",
+ str_yes_no(intel_has_sagv(i915)), i915->sagv_block_time_us);
+
+ if (!intel_has_sagv(i915))
+ i915->sagv_block_time_us = -1;
}
/*
@@ -8173,8 +8180,7 @@ void intel_init_pm(struct drm_i915_private *dev_priv)
else if (GRAPHICS_VER(dev_priv) == 5)
ilk_get_mem_freq(dev_priv);
- if (intel_has_sagv(dev_priv))
- skl_setup_sagv_block_time(dev_priv);
+ intel_sagv_init(dev_priv);
/* For FIFO watermark updates */
if (DISPLAY_VER(dev_priv) >= 9) {
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [Intel-gfx] [PATCH 2/6] drm/i915: Rework SAGV block time probing
2022-03-08 17:32 ` [Intel-gfx] [PATCH 2/6] drm/i915: Rework SAGV block time probing Ville Syrjala
@ 2022-03-09 10:41 ` Govindapillai, Vinod
2022-03-09 12:59 ` Ville Syrjälä
0 siblings, 1 reply; 14+ messages in thread
From: Govindapillai, Vinod @ 2022-03-09 10:41 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
On Tue, 2022-03-08 at 19:32 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> I'd like to see the SAGV block time we got from the mailbox
> in the logs regardless of whether other factors prevent the
> use of SAGV.
>
> So let's adjust the code to always query the SAGV block time,
> log it, and then reset it if SAGV is not actually supported.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Hi Ville,
I wonder if it is better to comprehend if we clean assigning -1 to a u32 variable first before
this? I see that you are doing that anyway in the next patch in this series. Was there any
particular reason?
BR
Vinod
> ---
> drivers/gpu/drm/i915/intel_pm.c | 38 +++++++++++++++++++--------------
> 1 file changed, 22 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 8ee31c9590a7..21c37115c36e 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3670,8 +3670,8 @@ intel_has_sagv(struct drm_i915_private *dev_priv)
> dev_priv->sagv_status != I915_SAGV_NOT_CONTROLLED;
> }
>
> -static void
> -skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)
> +static u32
> +intel_sagv_block_time(struct drm_i915_private *dev_priv)
> {
> if (DISPLAY_VER(dev_priv) >= 12) {
> u32 val = 0;
> @@ -3680,24 +3680,31 @@ skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)
> ret = snb_pcode_read(dev_priv,
> GEN12_PCODE_READ_SAGV_BLOCK_TIME_US,
> &val, NULL);
> - if (!ret) {
> - dev_priv->sagv_block_time_us = val;
> - return;
> + if (ret) {
> + drm_dbg_kms(&dev_priv->drm, "Couldn't read SAGV block time!\n");
> + return -1;
> }
>
> - drm_dbg(&dev_priv->drm, "Couldn't read SAGV block time!\n");
> + return val;
> } else if (DISPLAY_VER(dev_priv) == 11) {
> - dev_priv->sagv_block_time_us = 10;
> - return;
> - } else if (DISPLAY_VER(dev_priv) == 9) {
> - dev_priv->sagv_block_time_us = 30;
> - return;
> + return 10;
> + } else if (DISPLAY_VER(dev_priv) == 9 && !IS_LP(dev_priv)) {
> + return 30;
> } else {
> - MISSING_CASE(DISPLAY_VER(dev_priv));
> + /* Default to an unusable block time */
> + return -1;
> }
> +}
>
> - /* Default to an unusable block time */
> - dev_priv->sagv_block_time_us = -1;
> +static void intel_sagv_init(struct drm_i915_private *i915)
> +{
> + i915->sagv_block_time_us = intel_sagv_block_time(i915);
> +
> + drm_dbg_kms(&i915->drm, "SAGV supported: %s, original SAGV block time: %u us\n",
> + str_yes_no(intel_has_sagv(i915)), i915->sagv_block_time_us);
> +
> + if (!intel_has_sagv(i915))
> + i915->sagv_block_time_us = -1;
> }
>
> /*
> @@ -8173,8 +8180,7 @@ void intel_init_pm(struct drm_i915_private *dev_priv)
> else if (GRAPHICS_VER(dev_priv) == 5)
> ilk_get_mem_freq(dev_priv);
>
> - if (intel_has_sagv(dev_priv))
> - skl_setup_sagv_block_time(dev_priv);
> + intel_sagv_init(dev_priv);
>
> /* For FIFO watermark updates */
> if (DISPLAY_VER(dev_priv) >= 9) {
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Intel-gfx] [PATCH 2/6] drm/i915: Rework SAGV block time probing
2022-03-09 10:41 ` Govindapillai, Vinod
@ 2022-03-09 12:59 ` Ville Syrjälä
0 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjälä @ 2022-03-09 12:59 UTC (permalink / raw)
To: Govindapillai, Vinod; +Cc: intel-gfx@lists.freedesktop.org
On Wed, Mar 09, 2022 at 10:41:28AM +0000, Govindapillai, Vinod wrote:
> On Tue, 2022-03-08 at 19:32 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > I'd like to see the SAGV block time we got from the mailbox
> > in the logs regardless of whether other factors prevent the
> > use of SAGV.
> >
> > So let's adjust the code to always query the SAGV block time,
> > log it, and then reset it if SAGV is not actually supported.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Hi Ville,
>
> I wonder if it is better to comprehend if we clean assigning -1 to a u32 variable first before
> this? I see that you are doing that anyway in the next patch in this series. Was there any
> particular reason?
No real reason. Probably best to reorder as you suggest so we can
backport the s/-1/0/ change, assuming it actually fixes something.
>
> BR
> Vinod
>
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 38 +++++++++++++++++++--------------
> > 1 file changed, 22 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 8ee31c9590a7..21c37115c36e 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -3670,8 +3670,8 @@ intel_has_sagv(struct drm_i915_private *dev_priv)
> > dev_priv->sagv_status != I915_SAGV_NOT_CONTROLLED;
> > }
> >
> > -static void
> > -skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)
> > +static u32
> > +intel_sagv_block_time(struct drm_i915_private *dev_priv)
> > {
> > if (DISPLAY_VER(dev_priv) >= 12) {
> > u32 val = 0;
> > @@ -3680,24 +3680,31 @@ skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)
> > ret = snb_pcode_read(dev_priv,
> > GEN12_PCODE_READ_SAGV_BLOCK_TIME_US,
> > &val, NULL);
> > - if (!ret) {
> > - dev_priv->sagv_block_time_us = val;
> > - return;
> > + if (ret) {
> > + drm_dbg_kms(&dev_priv->drm, "Couldn't read SAGV block time!\n");
> > + return -1;
> > }
> >
> > - drm_dbg(&dev_priv->drm, "Couldn't read SAGV block time!\n");
> > + return val;
> > } else if (DISPLAY_VER(dev_priv) == 11) {
> > - dev_priv->sagv_block_time_us = 10;
> > - return;
> > - } else if (DISPLAY_VER(dev_priv) == 9) {
> > - dev_priv->sagv_block_time_us = 30;
> > - return;
> > + return 10;
> > + } else if (DISPLAY_VER(dev_priv) == 9 && !IS_LP(dev_priv)) {
> > + return 30;
> > } else {
> > - MISSING_CASE(DISPLAY_VER(dev_priv));
> > + /* Default to an unusable block time */
> > + return -1;
> > }
> > +}
> >
> > - /* Default to an unusable block time */
> > - dev_priv->sagv_block_time_us = -1;
> > +static void intel_sagv_init(struct drm_i915_private *i915)
> > +{
> > + i915->sagv_block_time_us = intel_sagv_block_time(i915);
> > +
> > + drm_dbg_kms(&i915->drm, "SAGV supported: %s, original SAGV block time: %u us\n",
> > + str_yes_no(intel_has_sagv(i915)), i915->sagv_block_time_us);
> > +
> > + if (!intel_has_sagv(i915))
> > + i915->sagv_block_time_us = -1;
> > }
> >
> > /*
> > @@ -8173,8 +8180,7 @@ void intel_init_pm(struct drm_i915_private *dev_priv)
> > else if (GRAPHICS_VER(dev_priv) == 5)
> > ilk_get_mem_freq(dev_priv);
> >
> > - if (intel_has_sagv(dev_priv))
> > - skl_setup_sagv_block_time(dev_priv);
> > + intel_sagv_init(dev_priv);
> >
> > /* For FIFO watermark updates */
> > if (DISPLAY_VER(dev_priv) >= 9) {
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 3/6] drm/i915: Treat SAGV block time 0 as SAGV disabled
2022-03-08 17:32 [Intel-gfx] [PATCH 0/6] drm/i915: SAGV block time fixes Ville Syrjala
2022-03-08 17:32 ` [Intel-gfx] [PATCH 1/6] drm/i915: Remove leftover cnl SAGV block time Ville Syrjala
2022-03-08 17:32 ` [Intel-gfx] [PATCH 2/6] drm/i915: Rework SAGV block time probing Ville Syrjala
@ 2022-03-08 17:32 ` Ville Syrjala
2022-03-09 11:29 ` Govindapillai, Vinod
2022-03-08 17:32 ` [Intel-gfx] [PATCH 4/6] drm/i915: Probe whether SAGV works on pre-icl Ville Syrjala
` (4 subsequent siblings)
7 siblings, 1 reply; 14+ messages in thread
From: Ville Syrjala @ 2022-03-08 17:32 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
For modern platforms the spec explicitly states that a
SAGV block time of zero means that SAGV is not supported.
Let's extend that to all platforms. Supposedly there should
be no systems where this isn't true, and it'll allow us to:
- use the same code regardless of older vs. newer platform
- wm latencies already treat 0 as disabled, so this fits well
with other related code
- make it a bit more clear when SAGV is used vs. not
- avoid overflows from adding U32_MAX with a u16 wm0 latency value
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 21c37115c36e..906501d6b298 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3682,7 +3682,7 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)
&val, NULL);
if (ret) {
drm_dbg_kms(&dev_priv->drm, "Couldn't read SAGV block time!\n");
- return -1;
+ return 0;
}
return val;
@@ -3691,8 +3691,7 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)
} else if (DISPLAY_VER(dev_priv) == 9 && !IS_LP(dev_priv)) {
return 30;
} else {
- /* Default to an unusable block time */
- return -1;
+ return 0;
}
}
@@ -3704,7 +3703,7 @@ static void intel_sagv_init(struct drm_i915_private *i915)
str_yes_no(intel_has_sagv(i915)), i915->sagv_block_time_us);
if (!intel_has_sagv(i915))
- i915->sagv_block_time_us = -1;
+ i915->sagv_block_time_us = 0;
}
/*
@@ -5651,7 +5650,7 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state,
result->min_ddb_alloc = max(min_ddb_alloc, blocks) + 1;
result->enable = true;
- if (DISPLAY_VER(dev_priv) < 12)
+ if (DISPLAY_VER(dev_priv) < 12 && dev_priv->sagv_block_time_us)
result->can_sagv = latency >= dev_priv->sagv_block_time_us;
}
@@ -5684,7 +5683,10 @@ static void tgl_compute_sagv_wm(const struct intel_crtc_state *crtc_state,
struct drm_i915_private *dev_priv = to_i915(crtc_state->uapi.crtc->dev);
struct skl_wm_level *sagv_wm = &plane_wm->sagv.wm0;
struct skl_wm_level *levels = plane_wm->wm;
- unsigned int latency = dev_priv->wm.skl_latency[0] + dev_priv->sagv_block_time_us;
+ unsigned int latency = 0;
+
+ if (dev_priv->sagv_block_time_us)
+ latency = dev_priv->sagv_block_time_us + dev_priv->wm.skl_latency[0];
skl_compute_plane_wm(crtc_state, plane, 0, latency,
wm_params, &levels[0],
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [Intel-gfx] [PATCH 3/6] drm/i915: Treat SAGV block time 0 as SAGV disabled
2022-03-08 17:32 ` [Intel-gfx] [PATCH 3/6] drm/i915: Treat SAGV block time 0 as SAGV disabled Ville Syrjala
@ 2022-03-09 11:29 ` Govindapillai, Vinod
2022-03-09 13:00 ` Ville Syrjälä
0 siblings, 1 reply; 14+ messages in thread
From: Govindapillai, Vinod @ 2022-03-09 11:29 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
On Tue, 2022-03-08 at 19:32 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> For modern platforms the spec explicitly states that a
> SAGV block time of zero means that SAGV is not supported.
> Let's extend that to all platforms. Supposedly there should
> be no systems where this isn't true, and it'll allow us to:
> - use the same code regardless of older vs. newer platform
> - wm latencies already treat 0 as disabled, so this fits well
> with other related code
> - make it a bit more clear when SAGV is used vs. not
> - avoid overflows from adding U32_MAX with a u16 wm0 latency value
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 21c37115c36e..906501d6b298 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3682,7 +3682,7 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)
> &val, NULL);
> if (ret) {
> drm_dbg_kms(&dev_priv->drm, "Couldn't read SAGV block time!\n");
> - return -1;
> + return 0;
> }
>
> return val;
> @@ -3691,8 +3691,7 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)
> } else if (DISPLAY_VER(dev_priv) == 9 && !IS_LP(dev_priv)) {
> return 30;
> } else {
> - /* Default to an unusable block time */
> - return -1;
> + return 0;
> }
> }
>
> @@ -3704,7 +3703,7 @@ static void intel_sagv_init(struct drm_i915_private *i915)
> str_yes_no(intel_has_sagv(i915)), i915->sagv_block_time_us);
>
> if (!intel_has_sagv(i915))
> - i915->sagv_block_time_us = -1;
> + i915->sagv_block_time_us = 0;
Hi Ville
Currently we set the "sagv_status" as "I915_SAGV_NOT_CONTROLLED" based on the number of qgv points.
So here i915->sagv_block_time_us will be set to 0 even if intel_sagv_block_time(i915) would have
returned some valid values. Is that the desired behavior for sgav watermarks calcultations?
BR
vinod
> }
>
> /*
> @@ -5651,7 +5650,7 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state,
> result->min_ddb_alloc = max(min_ddb_alloc, blocks) + 1;
> result->enable = true;
>
> - if (DISPLAY_VER(dev_priv) < 12)
> + if (DISPLAY_VER(dev_priv) < 12 && dev_priv->sagv_block_time_us)
> result->can_sagv = latency >= dev_priv->sagv_block_time_us;
> }
>
> @@ -5684,7 +5683,10 @@ static void tgl_compute_sagv_wm(const struct intel_crtc_state *crtc_state,
> struct drm_i915_private *dev_priv = to_i915(crtc_state->uapi.crtc->dev);
> struct skl_wm_level *sagv_wm = &plane_wm->sagv.wm0;
> struct skl_wm_level *levels = plane_wm->wm;
> - unsigned int latency = dev_priv->wm.skl_latency[0] + dev_priv->sagv_block_time_us;
> + unsigned int latency = 0;
> +
> + if (dev_priv->sagv_block_time_us)
> + latency = dev_priv->sagv_block_time_us + dev_priv->wm.skl_latency[0];
>
> skl_compute_plane_wm(crtc_state, plane, 0, latency,
> wm_params, &levels[0],
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [Intel-gfx] [PATCH 3/6] drm/i915: Treat SAGV block time 0 as SAGV disabled
2022-03-09 11:29 ` Govindapillai, Vinod
@ 2022-03-09 13:00 ` Ville Syrjälä
0 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjälä @ 2022-03-09 13:00 UTC (permalink / raw)
To: Govindapillai, Vinod; +Cc: intel-gfx@lists.freedesktop.org
On Wed, Mar 09, 2022 at 11:29:37AM +0000, Govindapillai, Vinod wrote:
> On Tue, 2022-03-08 at 19:32 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > For modern platforms the spec explicitly states that a
> > SAGV block time of zero means that SAGV is not supported.
> > Let's extend that to all platforms. Supposedly there should
> > be no systems where this isn't true, and it'll allow us to:
> > - use the same code regardless of older vs. newer platform
> > - wm latencies already treat 0 as disabled, so this fits well
> > with other related code
> > - make it a bit more clear when SAGV is used vs. not
> > - avoid overflows from adding U32_MAX with a u16 wm0 latency value
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 14 ++++++++------
> > 1 file changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 21c37115c36e..906501d6b298 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -3682,7 +3682,7 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)
> > &val, NULL);
> > if (ret) {
> > drm_dbg_kms(&dev_priv->drm, "Couldn't read SAGV block time!\n");
> > - return -1;
> > + return 0;
> > }
> >
> > return val;
> > @@ -3691,8 +3691,7 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)
> > } else if (DISPLAY_VER(dev_priv) == 9 && !IS_LP(dev_priv)) {
> > return 30;
> > } else {
> > - /* Default to an unusable block time */
> > - return -1;
> > + return 0;
> > }
> > }
> >
> > @@ -3704,7 +3703,7 @@ static void intel_sagv_init(struct drm_i915_private *i915)
> > str_yes_no(intel_has_sagv(i915)), i915->sagv_block_time_us);
> >
> > if (!intel_has_sagv(i915))
> > - i915->sagv_block_time_us = -1;
> > + i915->sagv_block_time_us = 0;
>
> Hi Ville
>
> Currently we set the "sagv_status" as "I915_SAGV_NOT_CONTROLLED" based on the number of qgv points.
> So here i915->sagv_block_time_us will be set to 0 even if intel_sagv_block_time(i915) would have
> returned some valid values. Is that the desired behavior for sgav watermarks calcultations?
I don't think there's much point in calculating the sagv wm if we can't
use sagv anyway.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 4/6] drm/i915: Probe whether SAGV works on pre-icl
2022-03-08 17:32 [Intel-gfx] [PATCH 0/6] drm/i915: SAGV block time fixes Ville Syrjala
` (2 preceding siblings ...)
2022-03-08 17:32 ` [Intel-gfx] [PATCH 3/6] drm/i915: Treat SAGV block time 0 as SAGV disabled Ville Syrjala
@ 2022-03-08 17:32 ` Ville Syrjala
2022-03-08 17:32 ` [Intel-gfx] [PATCH 5/6] drm/i915: Reject excessive SAGV block time Ville Syrjala
` (3 subsequent siblings)
7 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjala @ 2022-03-08 17:32 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Instead of leaving the SAGV enable/disable to the first commit
let's try to disable it first thing to see if we can do it or
not (disabling SAGV is a safe thing to at any time). This avoids
running the code in this funny intermediate state where we don't
know if SAGV is available or not.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 906501d6b298..36f5bccabf64 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -57,6 +57,8 @@
#include "vlv_sideband.h"
#include "../../../platform/x86/intel_ips.h"
+static int intel_disable_sagv(struct drm_i915_private *dev_priv);
+
struct drm_i915_clock_gating_funcs {
void (*init_clock_gating)(struct drm_i915_private *i915);
};
@@ -3697,6 +3699,18 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)
static void intel_sagv_init(struct drm_i915_private *i915)
{
+ if (!intel_has_sagv(i915))
+ i915->sagv_status = I915_SAGV_NOT_CONTROLLED;
+
+ /*
+ * Probe to see if we have working SAGV control.
+ * For icl+ this was already determined by intel_bw_init_hw().
+ */
+ if (DISPLAY_VER(i915) < 11)
+ intel_disable_sagv(i915);
+
+ drm_WARN_ON(&i915->drm, i915->sagv_status == I915_SAGV_UNKNOWN);
+
i915->sagv_block_time_us = intel_sagv_block_time(i915);
drm_dbg_kms(&i915->drm, "SAGV supported: %s, original SAGV block time: %u us\n",
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [Intel-gfx] [PATCH 5/6] drm/i915: Reject excessive SAGV block time
2022-03-08 17:32 [Intel-gfx] [PATCH 0/6] drm/i915: SAGV block time fixes Ville Syrjala
` (3 preceding siblings ...)
2022-03-08 17:32 ` [Intel-gfx] [PATCH 4/6] drm/i915: Probe whether SAGV works on pre-icl Ville Syrjala
@ 2022-03-08 17:32 ` Ville Syrjala
2022-03-08 17:32 ` [Intel-gfx] [PATCH 6/6] drm/i915: Rename pre-icl SAGV enable/disable functions Ville Syrjala
` (2 subsequent siblings)
7 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjala @ 2022-03-08 17:32 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
If the mailbox returns an exceesively large SAGV block time let's just
reject it. This avoids having to worry about overflows when we add the
SAGV block time to the wm0 latency.
We shall put the limit arbitrarily at U16_MAX. >65msec latency
doesn't really make sense to me in any case.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 36f5bccabf64..166246fa27e4 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3716,6 +3716,12 @@ static void intel_sagv_init(struct drm_i915_private *i915)
drm_dbg_kms(&i915->drm, "SAGV supported: %s, original SAGV block time: %u us\n",
str_yes_no(intel_has_sagv(i915)), i915->sagv_block_time_us);
+ /* avoid overflow when adding with wm0 latency/etc. */
+ if (drm_WARN(&i915->drm, i915->sagv_block_time_us > U16_MAX,
+ "Excessive SAGV block time %u, ignoring\n",
+ i915->sagv_block_time_us))
+ i915->sagv_block_time_us = 0;
+
if (!intel_has_sagv(i915))
i915->sagv_block_time_us = 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [Intel-gfx] [PATCH 6/6] drm/i915: Rename pre-icl SAGV enable/disable functions
2022-03-08 17:32 [Intel-gfx] [PATCH 0/6] drm/i915: SAGV block time fixes Ville Syrjala
` (4 preceding siblings ...)
2022-03-08 17:32 ` [Intel-gfx] [PATCH 5/6] drm/i915: Reject excessive SAGV block time Ville Syrjala
@ 2022-03-08 17:32 ` Ville Syrjala
2022-03-09 2:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: SAGV block time fixes Patchwork
2022-03-09 10:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
7 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjala @ 2022-03-08 17:32 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Give the pre-icl SAGV control functions a skl_ prefix instead
of the intel_ prefix to make it a bit more clear that they
are not some kind of universal things that can be called on
any platform. Also make the functions void since we never
use the return value anyway.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 32 ++++++++++++++------------------
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 166246fa27e4..bd936d4c5b0f 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -57,7 +57,7 @@
#include "vlv_sideband.h"
#include "../../../platform/x86/intel_ips.h"
-static int intel_disable_sagv(struct drm_i915_private *dev_priv);
+static void skl_sagv_disable(struct drm_i915_private *dev_priv);
struct drm_i915_clock_gating_funcs {
void (*init_clock_gating)(struct drm_i915_private *i915);
@@ -3707,7 +3707,7 @@ static void intel_sagv_init(struct drm_i915_private *i915)
* For icl+ this was already determined by intel_bw_init_hw().
*/
if (DISPLAY_VER(i915) < 11)
- intel_disable_sagv(i915);
+ skl_sagv_disable(i915);
drm_WARN_ON(&i915->drm, i915->sagv_status == I915_SAGV_UNKNOWN);
@@ -3737,16 +3737,15 @@ static void intel_sagv_init(struct drm_i915_private *i915)
* - All planes can enable watermarks for latencies >= SAGV engine block time
* - We're not using an interlaced display configuration
*/
-static int
-intel_enable_sagv(struct drm_i915_private *dev_priv)
+static void skl_sagv_enable(struct drm_i915_private *dev_priv)
{
int ret;
if (!intel_has_sagv(dev_priv))
- return 0;
+ return;
if (dev_priv->sagv_status == I915_SAGV_ENABLED)
- return 0;
+ return;
drm_dbg_kms(&dev_priv->drm, "Enabling SAGV\n");
ret = snb_pcode_write(dev_priv, GEN9_PCODE_SAGV_CONTROL,
@@ -3761,26 +3760,24 @@ intel_enable_sagv(struct drm_i915_private *dev_priv)
if (IS_SKYLAKE(dev_priv) && ret == -ENXIO) {
drm_dbg(&dev_priv->drm, "No SAGV found on system, ignoring\n");
dev_priv->sagv_status = I915_SAGV_NOT_CONTROLLED;
- return 0;
+ return;
} else if (ret < 0) {
drm_err(&dev_priv->drm, "Failed to enable SAGV\n");
- return ret;
+ return;
}
dev_priv->sagv_status = I915_SAGV_ENABLED;
- return 0;
}
-static int
-intel_disable_sagv(struct drm_i915_private *dev_priv)
+static void skl_sagv_disable(struct drm_i915_private *dev_priv)
{
int ret;
if (!intel_has_sagv(dev_priv))
- return 0;
+ return;
if (dev_priv->sagv_status == I915_SAGV_DISABLED)
- return 0;
+ return;
drm_dbg_kms(&dev_priv->drm, "Disabling SAGV\n");
/* bspec says to keep retrying for at least 1 ms */
@@ -3795,14 +3792,13 @@ intel_disable_sagv(struct drm_i915_private *dev_priv)
if (IS_SKYLAKE(dev_priv) && ret == -ENXIO) {
drm_dbg(&dev_priv->drm, "No SAGV found on system, ignoring\n");
dev_priv->sagv_status = I915_SAGV_NOT_CONTROLLED;
- return 0;
+ return;
} else if (ret < 0) {
drm_err(&dev_priv->drm, "Failed to disable SAGV (%d)\n", ret);
- return ret;
+ return;
}
dev_priv->sagv_status = I915_SAGV_DISABLED;
- return 0;
}
static void skl_sagv_pre_plane_update(struct intel_atomic_state *state)
@@ -3815,7 +3811,7 @@ static void skl_sagv_pre_plane_update(struct intel_atomic_state *state)
return;
if (!intel_can_enable_sagv(i915, new_bw_state))
- intel_disable_sagv(i915);
+ skl_sagv_disable(i915);
}
static void skl_sagv_post_plane_update(struct intel_atomic_state *state)
@@ -3828,7 +3824,7 @@ static void skl_sagv_post_plane_update(struct intel_atomic_state *state)
return;
if (intel_can_enable_sagv(i915, new_bw_state))
- intel_enable_sagv(i915);
+ skl_sagv_enable(i915);
}
static void icl_sagv_pre_plane_update(struct intel_atomic_state *state)
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: SAGV block time fixes
2022-03-08 17:32 [Intel-gfx] [PATCH 0/6] drm/i915: SAGV block time fixes Ville Syrjala
` (5 preceding siblings ...)
2022-03-08 17:32 ` [Intel-gfx] [PATCH 6/6] drm/i915: Rename pre-icl SAGV enable/disable functions Ville Syrjala
@ 2022-03-09 2:45 ` Patchwork
2022-03-09 10:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
7 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2022-03-09 2:45 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11277 bytes --]
== Series Details ==
Series: drm/i915: SAGV block time fixes
URL : https://patchwork.freedesktop.org/series/101171/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11338 -> Patchwork_22517
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/index.html
Participating hosts (45 -> 44)
------------------------------
Additional (1): bat-dg1-6
Missing (2): fi-ctg-p8600 fi-bsw-cyan
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22517:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@hugepages:
- {bat-rpls-2}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/bat-rpls-2/igt@i915_selftest@live@hugepages.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-rpls-2/igt@i915_selftest@live@hugepages.html
* igt@i915_selftest@live@workarounds:
- {bat-adlp-6}: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/bat-adlp-6/igt@i915_selftest@live@workarounds.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-adlp-6/igt@i915_selftest@live@workarounds.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- {bat-dg2-9}: [SKIP][5] ([i915#4213]) -> [SKIP][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/bat-dg2-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg2-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
Known issues
------------
Here are the changes found in Patchwork_22517 that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- fi-bxt-dsi: [PASS][7] -> [FAIL][8] ([i915#4912])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/fi-bxt-dsi/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/fi-bxt-dsi/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- bat-dg1-6: NOTRUN -> [SKIP][9] ([i915#4086])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_suspend@basic-s3@smem:
- fi-skl-6600u: NOTRUN -> [INCOMPLETE][10] ([i915#4547])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/fi-skl-6600u/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_mmap@basic:
- bat-dg1-6: NOTRUN -> [SKIP][11] ([i915#4083])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@gem_mmap@basic.html
* igt@gem_tiled_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][12] ([i915#4077]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@gem_tiled_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg1-6: NOTRUN -> [SKIP][13] ([i915#4079]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-6: NOTRUN -> [SKIP][14] ([i915#1155])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-dg1-6: NOTRUN -> [FAIL][15] ([i915#4032])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: [PASS][16] -> [INCOMPLETE][17] ([i915#4418])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@hangcheck:
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][18] ([i915#3921])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/fi-bdw-5557u/igt@i915_selftest@live@hangcheck.html
* igt@kms_addfb_basic@addfb25-x-tiled-legacy:
- bat-dg1-6: NOTRUN -> [SKIP][19] ([i915#4212]) +7 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-6: NOTRUN -> [SKIP][20] ([i915#4215])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_chamelium@hdmi-edid-read:
- bat-dg1-6: NOTRUN -> [SKIP][21] ([fdo#111827]) +8 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- bat-dg1-6: NOTRUN -> [SKIP][22] ([i915#4103] / [i915#4213]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-6: NOTRUN -> [SKIP][23] ([fdo#109285])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@sprite_plane_onoff:
- bat-dg1-6: NOTRUN -> [SKIP][24] ([i915#1072] / [i915#4078]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-6: NOTRUN -> [SKIP][25] ([i915#3708] / [i915#4077]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-userptr:
- bat-dg1-6: NOTRUN -> [SKIP][26] ([i915#3708] / [i915#4873])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- bat-dg1-6: NOTRUN -> [SKIP][27] ([i915#3708]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-6/igt@prime_vgem@basic-write.html
* igt@runner@aborted:
- bat-dg1-5: NOTRUN -> [FAIL][28] ([i915#4312] / [i915#5257])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-dg1-5/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-tgl-1115g4: [DMESG-WARN][29] ([i915#4002]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/fi-tgl-1115g4/igt@i915_module_load@reload.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/fi-tgl-1115g4/igt@i915_module_load@reload.html
* igt@i915_selftest@live@vma:
- {bat-rpls-2}: [DMESG-WARN][31] ([i915#4391]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/bat-rpls-2/igt@i915_selftest@live@vma.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-rpls-2/igt@i915_selftest@live@vma.html
* igt@i915_selftest@live@workarounds:
- fi-bdw-5557u: [INCOMPLETE][33] ([i915#5170]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/fi-bdw-5557u/igt@i915_selftest@live@workarounds.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/fi-bdw-5557u/igt@i915_selftest@live@workarounds.html
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- {bat-adlp-6}: [DMESG-WARN][35] ([i915#3576]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4002]: https://gitlab.freedesktop.org/drm/intel/issues/4002
[i915#4032]: https://gitlab.freedesktop.org/drm/intel/issues/4032
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4086]: https://gitlab.freedesktop.org/drm/intel/issues/4086
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4912]: https://gitlab.freedesktop.org/drm/intel/issues/4912
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
[i915#5170]: https://gitlab.freedesktop.org/drm/intel/issues/5170
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_11338 -> Patchwork_22517
CI-20190529: 20190529
CI_DRM_11338: 10d23ef3d24468332f37689a99d707e57c4d9a3f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6368: 60e5ffca027b38398c279fba0f5a1b7517aa6061 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22517: a2be95ea1ed97d4697c8ab95baa1e4820e0b0897 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a2be95ea1ed9 drm/i915: Rename pre-icl SAGV enable/disable functions
8cc8e8b9af33 drm/i915: Reject excessive SAGV block time
646b316b5264 drm/i915: Probe whether SAGV works on pre-icl
7ca9861d41a7 drm/i915: Treat SAGV block time 0 as SAGV disabled
df333d300a8a drm/i915: Rework SAGV block time probing
9fe89caa21a9 drm/i915: Remove leftover cnl SAGV block time
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/index.html
[-- Attachment #2: Type: text/html, Size: 12541 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: SAGV block time fixes
2022-03-08 17:32 [Intel-gfx] [PATCH 0/6] drm/i915: SAGV block time fixes Ville Syrjala
` (6 preceding siblings ...)
2022-03-09 2:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: SAGV block time fixes Patchwork
@ 2022-03-09 10:52 ` Patchwork
7 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2022-03-09 10:52 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30255 bytes --]
== Series Details ==
Series: drm/i915: SAGV block time fixes
URL : https://patchwork.freedesktop.org/series/101171/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11338_full -> Patchwork_22517_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22517_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@api_intel_allocator@fork-simple-stress-signal:
- {shard-dg1}: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-dg1-13/igt@api_intel_allocator@fork-simple-stress-signal.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-dg1-13/igt@api_intel_allocator@fork-simple-stress-signal.html
* igt@kms_cursor_legacy@all-pipes-forked-bo:
- {shard-rkl}: ([PASS][3], [PASS][4]) -> ([INCOMPLETE][5], [PASS][6])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-4/igt@kms_cursor_legacy@all-pipes-forked-bo.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-5/igt@kms_cursor_legacy@all-pipes-forked-bo.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-5/igt@kms_cursor_legacy@all-pipes-forked-bo.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-4/igt@kms_cursor_legacy@all-pipes-forked-bo.html
* {igt@kms_hdr@bpc-switch-dpms@bpc-switch-dpms-edp-1-pipe-a}:
- shard-skl: [PASS][7] -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-skl8/igt@kms_hdr@bpc-switch-dpms@bpc-switch-dpms-edp-1-pipe-a.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl7/igt@kms_hdr@bpc-switch-dpms@bpc-switch-dpms-edp-1-pipe-a.html
* igt@kms_hdr@static-toggle:
- {shard-dg1}: NOTRUN -> [SKIP][9] +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-dg1-17/igt@kms_hdr@static-toggle.html
* {igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale}:
- {shard-rkl}: NOTRUN -> [SKIP][10]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale.html
New tests
---------
New tests have been introduced between CI_DRM_11338_full and Patchwork_22517_full:
### New IGT tests (20) ###
* igt@gem_ctx_persistence@saturated-hostile:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@gem_render_copy@mixed-tiled-to-yf-tiled-ccs:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@perf:
- Statuses :
- Exec time: [None] s
* igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-a-edp-1-downscale-with-pixel-format:
- Statuses : 1 pass(s) 2 skip(s)
- Exec time: [0.01, 30.11] s
* igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-b-edp-1-downscale-with-pixel-format:
- Statuses : 1 pass(s) 2 skip(s)
- Exec time: [0.02, 29.96] s
* igt@kms_plane_scaling@downscale-with-rotation-factor-0-25:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@downscale-with-rotation-factor-0-75@pipe-a-edp-1-downscale-with-rotation:
- Statuses : 3 skip(s)
- Exec time: [0.94, 5.04] s
* igt@kms_plane_scaling@downscale-with-rotation-factor-0-75@pipe-b-edp-1-downscale-with-rotation:
- Statuses : 3 skip(s)
- Exec time: [1.97, 5.24] s
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1-planes-downscale:
- Statuses : 2 pass(s)
- Exec time: [1.43, 1.45] s
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-b-edp-1-planes-downscale:
- Statuses : 2 pass(s)
- Exec time: [1.27, 1.33] s
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale:
- Statuses : 2 pass(s) 1 skip(s)
- Exec time: [1.34, 1.54] s
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale:
- Statuses : 2 pass(s) 1 skip(s)
- Exec time: [0.30, 1.28] s
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-75@pipe-a-edp-1-planes-upscale-downscale:
- Statuses : 3 pass(s)
- Exec time: [0.13, 1.71] s
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-75@pipe-b-edp-1-planes-upscale-downscale:
- Statuses : 3 pass(s)
- Exec time: [1.23, 1.58] s
* igt@kms_plane_scaling@scaler-with-rotation-unity-scaling@pipe-a-edp-1-scaler-with-rotation:
- Statuses : 1 skip(s)
- Exec time: [1.14] s
* igt@kms_plane_scaling@scaler-with-rotation-unity-scaling@pipe-b-edp-1-scaler-with-rotation:
- Statuses : 1 skip(s)
- Exec time: [2.10] s
* igt@kms_plane_scaling@upscale-with-rotation-factor-0-25:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@prime_mmap@test_dup@test_dup-lmem0:
- Statuses : 1 pass(s)
- Exec time: [0.12] s
* igt@prime_mmap@test_refcounting@test_refcounting-lmem0:
- Statuses : 1 pass(s)
- Exec time: [0.12] s
Known issues
------------
Here are the changes found in Patchwork_22517_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-kbl: NOTRUN -> [DMESG-WARN][11] ([i915#5076])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl1/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@gem_exec_capture@pi@bcs0:
- shard-iclb: [PASS][12] -> [INCOMPLETE][13] ([i915#3371])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-iclb7/igt@gem_exec_capture@pi@bcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb1/igt@gem_exec_capture@pi@bcs0.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][14] ([fdo#109271]) +68 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl1/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-iclb1/igt@gem_exec_fair@basic-none-share@rcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb1/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][17] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [PASS][18] -> [FAIL][19] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-apl2/igt@gem_exec_fair@basic-none@vecs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-apl1/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][20] -> [FAIL][21] ([i915#2842]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][22] -> [FAIL][23] ([i915#2842]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_params@no-bsd:
- shard-iclb: NOTRUN -> [SKIP][24] ([fdo#109283])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@gem_exec_params@no-bsd.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][25] -> [SKIP][26] ([i915#2190])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-tglb2/igt@gem_huc_copy@huc-copy.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#4613]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-apl4/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@heavy-random:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#4613])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl1/igt@gem_lmem_swapping@heavy-random.html
* igt@gem_lmem_swapping@verify:
- shard-kbl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#4613])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl4/igt@gem_lmem_swapping@verify.html
* igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#768])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb5/igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-yf-tiled.html
* igt@gem_softpin@allocator-evict-all-engines:
- shard-glk: [PASS][31] -> [FAIL][32] ([i915#4171])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-glk6/igt@gem_softpin@allocator-evict-all-engines.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-glk7/igt@gem_softpin@allocator-evict-all-engines.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3323])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl3/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][34] ([i915#4991])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl8/igt@gem_userptr_blits@input-checking.html
* igt@gen3_render_tiledy_blits:
- shard-tglb: NOTRUN -> [SKIP][35] ([fdo#109289])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-tglb5/igt@gen3_render_tiledy_blits.html
* igt@gen9_exec_parse@bb-start-param:
- shard-iclb: NOTRUN -> [SKIP][36] ([i915#2856])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@gen9_exec_parse@bb-start-param.html
* igt@gen9_exec_parse@secure-batches:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#2527] / [i915#2856])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-tglb5/igt@gen9_exec_parse@secure-batches.html
* igt@i915_pm_rpm@pc8-residency:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109293] / [fdo#109506])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb5/igt@i915_pm_rpm@pc8-residency.html
* igt@kms_big_fb@linear-16bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#110725] / [fdo#111614])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@kms_big_fb@linear-16bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][40] ([i915#3743])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3777])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-apl2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#3777])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3777]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#110723])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl1/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3886]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl1/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3886]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-apl4/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109278] / [i915#3886])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-edid-read:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109284] / [fdo#111827]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@kms_chamelium@dp-edid-read.html
* igt@kms_chamelium@hdmi-audio:
- shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl9/igt@kms_chamelium@hdmi-audio.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-kbl: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +4 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl4/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +5 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-apl8/igt@kms_color_chamelium@pipe-b-ctm-0-5.html
* igt@kms_content_protection@dp-mst-type-0:
- shard-iclb: NOTRUN -> [SKIP][53] ([i915#3116])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb3/igt@kms_content_protection@dp-mst-type-0.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109278] / [fdo#109279])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][55] -> [DMESG-WARN][56] ([i915#180])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-128x128-onscreen:
- shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271]) +65 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-apl4/igt@kms_cursor_crc@pipe-d-cursor-128x128-onscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-32x10-offscreen:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109278]) +8 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@kms_cursor_crc@pipe-d-cursor-32x10-offscreen.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109274] / [fdo#109278])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][60] -> [FAIL][61] ([i915#2346] / [i915#533])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][62] -> [DMESG-WARN][63] ([i915#180]) +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109280] / [fdo#111825])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt:
- shard-kbl: NOTRUN -> [SKIP][65] ([fdo#109271]) +81 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109280]) +3 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#533])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-apl8/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][68] ([i915#265])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl3/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][69] ([fdo#108145] / [i915#265])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_lowres@pipe-b-tiling-none:
- shard-iclb: NOTRUN -> [SKIP][70] ([i915#3536])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@kms_plane_lowres@pipe-b-tiling-none.html
* {igt@kms_plane_scaling@upscale-with-rotation-factor-0-25} (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][71] ([i915#4098])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-5/igt@kms_plane_scaling@upscale-with-rotation-factor-0-25.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#111068] / [i915#658])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][73] -> [SKIP][74] ([fdo#109441]) +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
* igt@kms_psr@suspend:
- shard-skl: [PASS][75] -> [INCOMPLETE][76] ([i915#4939])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-skl8/igt@kms_psr@suspend.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl5/igt@kms_psr@suspend.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][77] -> [DMESG-WARN][78] ([i915#180] / [i915#295])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-apl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@nouveau_crc@pipe-a-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#2530])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-tglb5/igt@nouveau_crc@pipe-a-source-outp-inactive.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][80] -> [FAIL][81] ([i915#1542])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-skl6/igt@perf@polling-parameterized.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl9/igt@perf@polling-parameterized.html
* igt@prime_udl:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109291]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb5/igt@prime_udl.html
* igt@sysfs_clients@fair-7:
- shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2994]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl10/igt@sysfs_clients@fair-7.html
* igt@sysfs_clients@sema-25:
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#2994])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb7/igt@sysfs_clients@sema-25.html
#### Possible fixes ####
* igt@fbdev@info:
- {shard-rkl}: [SKIP][85] ([i915#2582]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-2/igt@fbdev@info.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-6/igt@fbdev@info.html
* igt@feature_discovery@psr1:
- {shard-rkl}: [SKIP][87] ([i915#658]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-1/igt@feature_discovery@psr1.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-6/igt@feature_discovery@psr1.html
* igt@gem_eio@in-flight-immediate:
- shard-tglb: [TIMEOUT][89] ([i915#3063]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-tglb8/igt@gem_eio@in-flight-immediate.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-tglb5/igt@gem_eio@in-flight-immediate.html
* igt@gem_eio@unwedge-stress:
- {shard-rkl}: [TIMEOUT][91] ([i915#3063]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-2/igt@gem_eio@unwedge-stress.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-5/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][93] ([i915#2842]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs1.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][95] ([i915#2849]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-glk: [DMESG-WARN][97] ([i915#118]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-glk1/igt@gem_exec_whisper@basic-fds-priority-all.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-glk3/igt@gem_exec_whisper@basic-fds-priority-all.html
* igt@i915_pm_backlight@basic-brightness:
- {shard-rkl}: [SKIP][99] ([i915#3012]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-2/igt@i915_pm_backlight@basic-brightness.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-6/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@basic-rte:
- {shard-rkl}: [SKIP][101] ([fdo#109308]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-2/igt@i915_pm_rpm@basic-rte.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-6/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@gem_contexts:
- shard-skl: [DMESG-WARN][103] ([i915#4391]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-skl9/igt@i915_selftest@live@gem_contexts.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-skl10/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@mock@vma:
- {shard-rkl}: [INCOMPLETE][105] -> [PASS][106] +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-5/igt@i915_selftest@mock@vma.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-5/igt@i915_selftest@mock@vma.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][107] ([i915#180]) -> [PASS][108] +3 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-apl2/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- {shard-rkl}: [SKIP][109] ([i915#1845]) -> [PASS][110] +24 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-6/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][111] ([i915#1845] / [i915#4098]) -> [PASS][112] +4 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-2/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-6/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color@pipe-b-ctm-0-75:
- {shard-rkl}: [SKIP][113] ([i915#1149] / [i915#1849] / [i915#4070]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-2/igt@kms_color@pipe-b-ctm-0-75.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-6/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding:
- {shard-rkl}: [SKIP][115] ([fdo#112022] / [i915#4070]) -> [PASS][116] +5 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html
* igt@kms_cursor_legacy@cursora-vs-flipa-atomic:
- {shard-rkl}: [SKIP][117] ([fdo#111825] / [i915#4070]) -> [PASS][118] +3 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-2/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-6/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-iclb: [FAIL][119] ([i915#2346]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-iclb6/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_cursor_legacy@pipe-c-single-bo:
- {shard-rkl}: [SKIP][121] ([i915#4070]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-6/igt@kms_cursor_legacy@pipe-c-single-bo.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-5/igt@kms_cursor_legacy@pipe-c-single-bo.html
* igt@kms_draw_crc@draw-method-rgb565-blt-untiled:
- {shard-rkl}: [SKIP][123] ([fdo#111314]) -> [PASS][124] +4 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-rkl-2/igt@kms_draw_crc@draw-method-rgb565-blt-untiled.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/shard-rkl-6/igt@kms_draw_crc@draw-method-rgb565-blt-untiled.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][125] ([i915#79]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11338/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[126]: https://intel-gf
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22517/index.html
[-- Attachment #2: Type: text/html, Size: 33822 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread