From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/3] drm/i915: fixup the plane->pipe fixup code
Date: Thu, 11 Oct 2012 09:03:21 +0100 [thread overview]
Message-ID: <84c8a8$62orsq@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1349903641-18378-2-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 10 Oct 2012 23:14:00 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> We need to check whether the _other plane is on our pipe, not whether
> our plane is on the other pipe. Otherwise if not both pipes/planes are
> active, we won't properly clean up the mess and set up our desired
> plane->pipe mapping.
>
> v2: Fixup the logic, I've totally fumbled it. Noticed by Chris Wilson.
>
> v3: I've checked Bspec, and the flexible plane->pipe mapping is a
> gen2/3 feature, so test for that instead of PCH_SPLIT
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51265
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49838
> Tested-by: Dave Airlie <airlied@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
With these patches applied my 855gm is still in good working order (the
best it has been). Though I'm still spammed by modeset_check failing in
every possible way!
Tested-by: Chris Wilson <chris@chris-wilson.co.uk> #855gm
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-10-11 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 21:13 [PATCH 1/3] drm/i915: rip out the pipe A quirk for i855gm Daniel Vetter
2012-10-10 21:14 ` [PATCH 2/3] drm/i915: fixup the plane->pipe fixup code Daniel Vetter
2012-10-11 8:03 ` Chris Wilson [this message]
2012-10-10 21:14 ` [PATCH 3/3] drm/i915: disable wc gtt pte mappings on gen2 Daniel Vetter
2012-10-10 22:37 ` Chris Wilson
2012-10-11 8:37 ` Daniel Vetter
2012-10-11 8:45 ` Chris Wilson
2012-10-11 9:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='84c8a8$62orsq@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox