From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/i915: disable wc gtt pte mappings on gen2
Date: Thu, 11 Oct 2012 10:37:54 +0200 [thread overview]
Message-ID: <20121011083754.GA5799@phenom.ffwll.local> (raw)
In-Reply-To: <453bf0$61is0t@azsmga001.ch.intel.com>
On Wed, Oct 10, 2012 at 11:37:36PM +0100, Chris Wilson wrote:
> On Wed, 10 Oct 2012 23:14:01 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > It doesn't work since the gtt pte range sits in the middle of the mmio
> > bar. We didn't notice that since both my and Chris' gen2 machines
> > don't support PAT and hence all wc io mapping request will
> > automatically be demoted to uc.
> >
> > This regression has been introduce in
> >
> > commit edef7e685da05c13cce50c0126189c80fe2c8f71
> > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > Date: Fri Sep 14 11:57:47 2012 +0100
> >
> > agp/intel: Use a write-combining map for updating PTEs
> >
> > Reported-by: Egbert Eich <eich@pdx.freedesktop.org>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55834
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Thanks for the explanation,
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Patch merged to -fixes.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-10-11 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 21:13 [PATCH 1/3] drm/i915: rip out the pipe A quirk for i855gm Daniel Vetter
2012-10-10 21:14 ` [PATCH 2/3] drm/i915: fixup the plane->pipe fixup code Daniel Vetter
2012-10-11 8:03 ` Chris Wilson
2012-10-10 21:14 ` [PATCH 3/3] drm/i915: disable wc gtt pte mappings on gen2 Daniel Vetter
2012-10-10 22:37 ` Chris Wilson
2012-10-11 8:37 ` Daniel Vetter [this message]
2012-10-11 8:45 ` Chris Wilson
2012-10-11 9:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011083754.GA5799@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox