public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>, Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Handle sync_seqno correctly when seqno has wrapped.
Date: Tue, 13 Nov 2012 16:54:50 +0000	[thread overview]
Message-ID: <84c8a8$6gsevb@orsmga001.jf.intel.com> (raw)
In-Reply-To: <CAKMK7uGY17_1WVOgqDz7ZDO8mLwQYZK076Bh32g3u_=mp_sWZg@mail.gmail.com>

On Tue, 13 Nov 2012 17:45:14 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> trying to engineer a perfect test for the
> single failure mode we now have in front of us might actually reduce
> coverage.

This is a critical point worth remembering when writing tests: Having a
test case that detects a past bug is great, but a test case that
detects a future bug is better.
-Chris.

-- 
Chris Wilson, Intel Open Source Technology Centre

  parent reply	other threads:[~2012-11-13 16:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-13 13:51 [PATCH] drm/i915: Handle sync_seqno correctly when seqno has wrapped Mika Kuoppala
2012-11-13 14:15 ` Chris Wilson
2012-11-13 16:39 ` Ben Widawsky
2012-11-13 16:45   ` Daniel Vetter
2012-11-13 16:52     ` Ben Widawsky
2012-11-13 16:54     ` Chris Wilson [this message]
2012-11-19 10:55   ` Mika Kuoppala
2012-11-19 17:21     ` Ben Widawsky
2012-11-29  8:43       ` Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='84c8a8$6gsevb@orsmga001.jf.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=ben@bwidawsk.net \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox