From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Handle sync_seqno correctly when seqno has wrapped.
Date: Tue, 13 Nov 2012 14:15:05 +0000 [thread overview]
Message-ID: <6c3329$767ssr@orsmga002.jf.intel.com> (raw)
In-Reply-To: <1352814696-2154-1-git-send-email-mika.kuoppala@intel.com>
On Tue, 13 Nov 2012 15:51:36 +0200, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
> If seqno has wrapped, normal compare operation will give wrong results.
> i915_seqno_passed can handle the wrap so use it instead.
I'm still a little wary of this patch, as it means that we are emitting
requests that are not associated with an execbuffer and so the
wraparound detection is lost. Perhaps if you were to make the seqno
wraparound handling explicit we could all sleep more soundly...
And then I'd accept this patch for making seqno handling consistent at
least.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-13 14:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 13:51 [PATCH] drm/i915: Handle sync_seqno correctly when seqno has wrapped Mika Kuoppala
2012-11-13 14:15 ` Chris Wilson [this message]
2012-11-13 16:39 ` Ben Widawsky
2012-11-13 16:45 ` Daniel Vetter
2012-11-13 16:52 ` Ben Widawsky
2012-11-13 16:54 ` Chris Wilson
2012-11-19 10:55 ` Mika Kuoppala
2012-11-19 17:21 ` Ben Widawsky
2012-11-29 8:43 ` Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6c3329$767ssr@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox