From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Handle sync_seqno correctly when seqno has wrapped.
Date: Thu, 29 Nov 2012 10:43:46 +0200 [thread overview]
Message-ID: <87a9u04x4t.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20121119092148.710df2a0@bwidawsk.net>
On Mon, 19 Nov 2012 09:21:48 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Mon, 19 Nov 2012 12:55:22 +0200
> Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
>
> >
> > On Tue, 13 Nov 2012 08:39:26 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> > > Can you add another patch on top of this to have the starting seqno be a
> > > near pre-wrap value so we can catch bugs even without igt.
> >
> > I tried that but failed. I suspect that there is something in hw/sw
> > that doesn't like if first seqno is >0x80000000. Something in hw needs
> > to initialized explicitly if seqno is not starting from 1?
> >
>
> Nothing that I am aware of. If you have the first be 0, and then add a
> huge jump right after that, does it work?
We can't jump more than 0x80000000-1 as i915_seqno_passed() breaks.
But with the patches for preallocate seqnos now in, I was able to
get things working when first seqno was 0xFFFF0000.
-Mika
prev parent reply other threads:[~2012-11-29 8:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 13:51 [PATCH] drm/i915: Handle sync_seqno correctly when seqno has wrapped Mika Kuoppala
2012-11-13 14:15 ` Chris Wilson
2012-11-13 16:39 ` Ben Widawsky
2012-11-13 16:45 ` Daniel Vetter
2012-11-13 16:52 ` Ben Widawsky
2012-11-13 16:54 ` Chris Wilson
2012-11-19 10:55 ` Mika Kuoppala
2012-11-19 17:21 ` Ben Widawsky
2012-11-29 8:43 ` Mika Kuoppala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9u04x4t.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox