Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/8] drm/client: Stop using legacy crtc->mode and a bunch of cleanups
@ 2025-02-28 21:14 Ville Syrjala
  2025-02-28 21:14 ` [PATCH v2 1/8] drm/client: Constify modes Ville Syrjala
                   ` (12 more replies)
  0 siblings, 13 replies; 23+ messages in thread
From: Ville Syrjala @ 2025-02-28 21:14 UTC (permalink / raw)
  To: dri-devel; +Cc: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The most interesting part is the change to modes[] to solve
the lifetime issue so that we can stop using the legacy
crtc->mode for atomic drivers.

Additionally I included a bunch of cleanups, some of which were
inherited from https://patchwork.freedesktop.org/series/132051/

v2: Changed modes[] back to storing pointers rather
    than the actual mode structures, wasn't as ugly
    as I recalled last time

Ville Syrjälä (8):
  drm/client: Constify modes
  drm/client: Use array notation for function arguments
  drm/client: Streamline mode selection debugs
  drm/client: Make copies of modes
  drm/client: Stop using the legacy crtc->mode
  drm/client: s/new_crtc/crtc/
  drm/client: Move variables to tighter scope
  drm/client: s/unsigned int i/int i/

 drivers/gpu/drm/drm_client_modeset.c | 257 +++++++++++++++------------
 1 file changed, 140 insertions(+), 117 deletions(-)

-- 
2.45.3


^ permalink raw reply	[flat|nested] 23+ messages in thread
* [PATCH 5/8] drm/client: Stop using the legacy crtc->mode
@ 2024-10-03 11:33 Ville Syrjala
  2024-10-03 18:16 ` [PATCH v2 " Ville Syrjala
  0 siblings, 1 reply; 23+ messages in thread
From: Ville Syrjala @ 2024-10-03 11:33 UTC (permalink / raw)
  To: dri-devel; +Cc: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

crtc->mode is legacy junk and shouldn't really be used with
atomic drivers.

Most (all?) atomic drivers do end up still calling
drm_atomic_helper_update_legacy_modeset_state() at some
point, so crtc->mode does still get populated, and this
does work for now. But now that the modes[] lifetime issues
have been sorted out we can just switch over to the
proper crtc->state->mode.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/drm_client_modeset.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c
index d413e119db3f..3e49448370c4 100644
--- a/drivers/gpu/drm/drm_client_modeset.c
+++ b/drivers/gpu/drm/drm_client_modeset.c
@@ -710,19 +710,8 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
 
 		/* last resort: use current mode */
 		if (!mode_valid(&modes[i])) {
-			/*
-			 * IMPORTANT: We want to use the adjusted mode (i.e.
-			 * after the panel fitter upscaling) as the initial
-			 * config, not the input mode, which is what crtc->mode
-			 * usually contains. But since our current
-			 * code puts a mode derived from the post-pfit timings
-			 * into crtc->mode this works out correctly.
-			 *
-			 * This is crtc->mode and not crtc->state->mode for the
-			 * fastboot check to work correctly.
-			 */
 			mode_type = "current";
-			drm_mode_copy(&modes[i], &connector->state->crtc->mode);
+			drm_mode_copy(&modes[i], &new_crtc->state->mode);
 		}
 
 		/*
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2025-03-12 14:45 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-28 21:14 [PATCH v2 0/8] drm/client: Stop using legacy crtc->mode and a bunch of cleanups Ville Syrjala
2025-02-28 21:14 ` [PATCH v2 1/8] drm/client: Constify modes Ville Syrjala
2025-03-01  3:28   ` kernel test robot
2025-03-01  4:41   ` kernel test robot
2025-03-03  9:38   ` [PATCH v3 " Ville Syrjala
2025-02-28 21:14 ` [PATCH v2 2/8] drm/client: Use array notation for function arguments Ville Syrjala
2025-02-28 21:14 ` [PATCH v2 3/8] drm/client: Streamline mode selection debugs Ville Syrjala
2025-02-28 21:14 ` [PATCH v2 4/8] drm/client: Make copies of modes Ville Syrjala
2025-03-12 14:38   ` Jani Nikula
2025-02-28 21:14 ` [PATCH v2 5/8] drm/client: Stop using the legacy crtc->mode Ville Syrjala
2025-03-12 14:44   ` Jani Nikula
2025-02-28 21:14 ` [PATCH v2 6/8] drm/client: s/new_crtc/crtc/ Ville Syrjala
2025-03-12 14:45   ` Jani Nikula
2025-02-28 21:14 ` [PATCH v2 7/8] drm/client: Move variables to tighter scope Ville Syrjala
2025-03-12 14:45   ` Jani Nikula
2025-02-28 21:14 ` [PATCH v2 8/8] drm/client: s/unsigned int i/int i/ Ville Syrjala
2025-03-12 14:45   ` Jani Nikula
2025-02-28 21:35 ` ✗ Fi.CI.CHECKPATCH: warning for drm/client: Stop using legacy crtc->mode and a bunch of cleanups (rev5) Patchwork
2025-02-28 21:56 ` ✓ i915.CI.BAT: success " Patchwork
2025-03-01 10:34 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-03 10:27 ` ✗ Fi.CI.CHECKPATCH: warning for drm/client: Stop using legacy crtc->mode and a bunch of cleanups (rev6) Patchwork
2025-03-03 10:45 ` ✗ i915.CI.BAT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-10-03 11:33 [PATCH 5/8] drm/client: Stop using the legacy crtc->mode Ville Syrjala
2024-10-03 18:16 ` [PATCH v2 " Ville Syrjala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox