Re: [Intel-gfx] [PATCH 1/4] drm/i915/gvt: remove unused to_gvt() and reduce includes

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 04 Oct 2023, "Wang, Zhi A" <zhi.a.wang@intel.com> wrote:
> Singed-off-by: Zhi Wang <zhi.a.wang@intel.com>

Mmh, sorry, what does that mean here? Are you picking them up via gvt?

BR,
Jani.

>
> Thanks,
> Zhi.
>
> -----Original Message-----
> From: Nikula, Jani <jani.nikula@intel.com>
> Sent: Wednesday, October 4, 2023 3:54 PM
> To: intel-gvt-dev@lists.freedesktop.org; Zhenyu Wang <zhenyuw@linux.intel.com>; Wang, Zhi A <zhi.a.wang@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH 1/4] drm/i915/gvt: remove unused to_gvt() and reduce includes
>
> On Tue, 26 Sep 2023, Jani Nikula <jani.nikula@intel.com> wrote:
>> gvt.h has no need to include i915_drv.h once the unused to_gvt() has
>> been removed.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Zhenyu, Zhi, ping?
>
> BR,
> Jani.
>
>
>
>> ---
>>  drivers/gpu/drm/i915/gvt/gvt.h | 7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gvt/gvt.h
>> b/drivers/gpu/drm/i915/gvt/gvt.h index 53a0a42a50db..3a0624fe63bf
>> 100644
>> --- a/drivers/gpu/drm/i915/gvt/gvt.h
>> +++ b/drivers/gpu/drm/i915/gvt/gvt.h
>> @@ -39,7 +39,7 @@
>>
>>  #include <asm/kvm_page_track.h>
>>
>> -#include "i915_drv.h"
>> +#include "gt/intel_gt.h"
>>  #include "intel_gvt.h"
>>
>>  #include "debug.h"
>> @@ -368,11 +368,6 @@ struct intel_gvt {
>>       struct dentry *debugfs_root;
>>  };
>>
>> -static inline struct intel_gvt *to_gvt(struct drm_i915_private *i915)
>> -{
>> -     return i915->gvt;
>> -}
>> -
>>  enum {
>>       /* Scheduling trigger by timer */
>>       INTEL_GVT_REQUEST_SCHED = 0,
>
> --
> Jani Nikula, Intel

-- 
Jani Nikula, Intel