From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915/gvt: remove unused to_gvt() and reduce includes
Date: Wed, 11 Oct 2023 13:07:30 +0800 [thread overview]
Message-ID: <ZSYtkk0EldETrP8l@debian-scheme> (raw)
In-Reply-To: <871qeafszw.fsf@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]
On 2023.10.04 15:54:11 +0300, Jani Nikula wrote:
> On Tue, 26 Sep 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> > gvt.h has no need to include i915_drv.h once the unused to_gvt() has
> > been removed.
> >
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Zhenyu, Zhi, ping?
>
Sorry for late reply, as last week was full holiday here.
Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
I don't think I need to do extra pick and pull request for this or
let me know if you has question.
Thanks!
>
>
>
> > ---
> > drivers/gpu/drm/i915/gvt/gvt.h | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h
> > index 53a0a42a50db..3a0624fe63bf 100644
> > --- a/drivers/gpu/drm/i915/gvt/gvt.h
> > +++ b/drivers/gpu/drm/i915/gvt/gvt.h
> > @@ -39,7 +39,7 @@
> >
> > #include <asm/kvm_page_track.h>
> >
> > -#include "i915_drv.h"
> > +#include "gt/intel_gt.h"
> > #include "intel_gvt.h"
> >
> > #include "debug.h"
> > @@ -368,11 +368,6 @@ struct intel_gvt {
> > struct dentry *debugfs_root;
> > };
> >
> > -static inline struct intel_gvt *to_gvt(struct drm_i915_private *i915)
> > -{
> > - return i915->gvt;
> > -}
> > -
> > enum {
> > /* Scheduling trigger by timer */
> > INTEL_GVT_REQUEST_SCHED = 0,
>
> --
> Jani Nikula, Intel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-10-11 5:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 12:19 [Intel-gfx] [PATCH 1/4] drm/i915/gvt: remove unused to_gvt() and reduce includes Jani Nikula
2023-09-26 12:19 ` [Intel-gfx] [PATCH 2/4] drm/i915/gvt: don't include gvt.h from intel_gvt_mmio_table.h Jani Nikula
2023-09-26 12:19 ` [Intel-gfx] [PATCH 3/4] drm/i915/gvt: move struct engine_mmio to mmio_context.c Jani Nikula
2023-09-26 12:19 ` [Intel-gfx] [PATCH 4/4] drm/i915/gvt: move structs intel_gvt_irq_info and intel_gvt_irq_map to interrupt.c Jani Nikula
2023-09-26 20:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/gvt: remove unused to_gvt() and reduce includes Patchwork
2023-09-27 8:34 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-04 12:54 ` [Intel-gfx] [PATCH 1/4] " Jani Nikula
2023-10-04 16:03 ` Wang, Zhi A
2023-10-04 16:33 ` Jani Nikula
2023-10-04 17:02 ` Wang, Zhi A
2023-10-11 5:07 ` Zhenyu Wang [this message]
2023-10-11 7:04 ` Jani Nikula
2023-10-11 8:44 ` Zhenyu Wang
2023-10-11 11:36 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSYtkk0EldETrP8l@debian-scheme \
--to=zhenyuw@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox