Re: [PATCH 12/35] drm/i915/bios: Define VBT blocks 6, 7, 8 (register tables) contents

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 03 May 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Define the contents for VBT blocks:
> - Block 6 (Extended MMIO Register Table)
> - Block 7 (IO Software Flag Table)
> - Block 8 (MMIO SWF Register Table)
>
> All of these use the same basic layout, with two known variants:
> - data_access_size==0xce -> offset,value tuples are u8,u8
> - data_access_size==0x02 -> offset,value tuples are u32,u32
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_vbt_defs.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index f3478a20ff16..4f0b8be3034c 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -634,6 +634,22 @@ struct bdb_generic_mode_table_mgm {
>  	struct generic_mode_timings timings[3];
>  } __packed;
>  
> +/*
> + * Block 6 - Extended MMIO Register Table, VBIOS only
> + * Block 7 - IO Software Flag Table, VBIOS only
> + * Block 8 - MMIO SWF Register Table, VBIOS only
> + */
> +struct bdb_reg_table {
> +	u16 table_id;
> +	u8 data_access_size;
> +	/*
> +	 * offset,value tuples:
> +	 * data_access_size==0xce -> u8,u8
> +	 * data_access_size==0x02 -> u32,u32
> +	 */
> +	/* u16 table_end_marker; */
> +} __packed;
> +
>  /*
>   * Block 9 - SRD Feature Block
>   */

-- 
Jani Nikula, Intel