Re: [PATCH 08/35] drm/i915/bios: Add version notes for some blocks

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 03 May 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Document which VBT blocks were defined in which BDB version,
> for the cases where the spec actually states this accurately.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_vbt_defs.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index 0533025d133b..18f54311a6e8 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -147,7 +147,7 @@ enum bdb_block_id {
>  	BDB_EXT_MMIO_REGS		= 6, /* VBIOS only */
>  	BDB_SWF_IO			= 7, /* VBIOS only */
>  	BDB_SWF_MMIO			= 8, /* VBIOS only */
> -	BDB_PSR				= 9,
> +	BDB_PSR				= 9, /* 165+ */
>  	BDB_MODE_REMOVAL_TABLE		= 10,
>  	BDB_CHILD_DEVICE_TABLE		= 11,
>  	BDB_DRIVER_FEATURES		= 12,
> @@ -170,10 +170,10 @@ enum bdb_block_id {
>  	BDB_LFP_DATA			= 42,
>  	BDB_LFP_BACKLIGHT		= 43,
>  	BDB_LFP_POWER			= 44,
> -	BDB_MIPI_CONFIG			= 52,
> -	BDB_MIPI_SEQUENCE		= 53,
> -	BDB_COMPRESSION_PARAMETERS	= 56,
> -	BDB_GENERIC_DTD			= 58,
> +	BDB_MIPI_CONFIG			= 52, /* 175+ */
> +	BDB_MIPI_SEQUENCE		= 53, /* 177+ */
> +	BDB_COMPRESSION_PARAMETERS	= 56, /* 213+ */
> +	BDB_GENERIC_DTD			= 58, /* 229+ */
>  	BDB_SKIP			= 254, /* VBIOS only */
>  };

-- 
Jani Nikula, Intel