Re: [PATCH 04/35] drm/i915/bios: Get rid of "LVDS" from all LFP data stuff

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, May 06, 2024 at 12:19:01PM +0300, Jani Nikula wrote:
> On Fri, 03 May 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The LFP data applies to all kinds of display interfaces, so
> > stop calling things by the "LVDS" name.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> 
> However...
> 
> > @@ -902,11 +902,11 @@ struct lfp_brightness_level {
> >  } __packed;
> >  
> >  #define EXP_BDB_LFP_BL_DATA_SIZE_REV_191 \
> > -	offsetof(struct bdb_lfp_backlight_data, brightness_level)
> > +	offsetof(struct bdb_lfp_backlight, brightness_level)
> >  #define EXP_BDB_LFP_BL_DATA_SIZE_REV_234 \
> > -	offsetof(struct bdb_lfp_backlight_data, brightness_precision_bits)
> > +	offsetof(struct bdb_lfp_backlight, brightness_precision_bits)
> 
> I haven't quite figured out what to do with [1] yet. Should probably
> sort it out before making this cleanup?
> 
> BR,
> Jani.
> 
> 
> [1] https://lore.kernel.org/r/20240221180622.v2.1.I0690aa3e96a83a43b3fc33f50395d334b2981826@changeid

Right, forgot about that one. We should just merge it.
The original out of bounds concerns are not a thing
anymore since we started to make copies of the blocks
that are at least as big as our struct definitions.

> 
> 
> >  
> > -struct bdb_lfp_backlight_data {
> > +struct bdb_lfp_backlight {
> >  	u8 entry_size;
> >  	struct lfp_backlight_data_entry data[16];
> >  	u8 level[16];							/* 162-233 */
> 
> -- 
> Jani Nikula, Intel

-- 
Ville Syrjälä
Intel