From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/8] drm/i915/gt: Add media freq factor to per-gt sysfs
Date: Wed, 11 May 2022 21:25:16 -0700 [thread overview]
Message-ID: <87czgj74yb.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <dcf1c336-1ff4-1c71-7dc7-6c919946a2d4@linux.intel.com>
On Tue, 10 May 2022 00:24:02 -0700, Tvrtko Ursulin wrote:
>
> > @@ -598,4 +720,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj)
> > drm_warn(>->i915->drm,
> > "failed to create gt%u throttle sysfs files (%pe)",
> > gt->info.id, ERR_PTR(ret));
> > +
> > + if (HAS_MEDIA_RATIO_MODE(gt->i915) && intel_uc_uses_guc_slpc(>->uc)) {
> > + ret = sysfs_create_files(kobj, media_perf_power_attrs);
> > + if (ret)
> > + drm_warn(>->i915->drm,
> > + "failed to create add gt%u media_perf_power_attrs sysfs (%pe)\n",
>
> Nit - "create add" - pick one?
Fixed in Patch v2 (Series v5).
next prev parent reply other threads:[~2022-05-12 4:25 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 19:56 [Intel-gfx] [PATCH v4 0/8] drm/i915: Media freq factor and per-gt enhancements/fixes Ashutosh Dixit
2022-04-29 19:56 ` [Intel-gfx] [PATCH 1/8] drm/i915: Introduce has_media_ratio_mode Ashutosh Dixit
2022-04-29 19:56 ` [Intel-gfx] [PATCH 2/8] drm/i915/gt: Add media freq factor to per-gt sysfs Ashutosh Dixit
2022-05-10 7:24 ` Tvrtko Ursulin
2022-05-12 4:25 ` Dixit, Ashutosh [this message]
2022-04-29 19:56 ` [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's Ashutosh Dixit
2022-05-02 12:54 ` Rodrigo Vivi
2022-05-10 6:51 ` Andi Shyti
2022-05-10 7:34 ` Tvrtko Ursulin
2022-05-10 7:43 ` Jani Nikula
2022-05-11 5:26 ` Dixit, Ashutosh
2022-05-11 8:18 ` Tvrtko Ursulin
2022-05-12 4:28 ` Dixit, Ashutosh
2022-04-29 19:56 ` [Intel-gfx] [PATCH 4/8] drm/i915/pcode: Add a couple of pcode helpers Ashutosh Dixit
2022-04-29 19:56 ` [Intel-gfx] [PATCH 5/8] drm/i915/gt: Add media RP0/RPn to per-gt sysfs Ashutosh Dixit
2022-05-10 7:37 ` Tvrtko Ursulin
2022-05-12 4:25 ` Dixit, Ashutosh
2022-04-29 19:56 ` [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in " Ashutosh Dixit
2022-05-10 6:02 ` Andi Shyti
2022-05-10 7:28 ` Tvrtko Ursulin
2022-05-10 7:58 ` Andrzej Hajda
2022-05-10 8:18 ` Tvrtko Ursulin
2022-05-10 9:39 ` Andrzej Hajda
2022-05-10 9:48 ` Tvrtko Ursulin
2022-05-10 10:41 ` Andrzej Hajda
2022-05-10 13:25 ` Tvrtko Ursulin
2022-05-11 23:15 ` Dixit, Ashutosh
2022-05-12 7:48 ` Tvrtko Ursulin
2022-05-13 5:05 ` Dixit, Ashutosh
2022-05-13 9:28 ` Tvrtko Ursulin
2022-04-29 19:56 ` [Intel-gfx] [PATCH 7/8] drm/i915/gt: Expose per-gt RPS defaults in sysfs Ashutosh Dixit
2022-05-10 7:53 ` Tvrtko Ursulin
2022-05-10 10:58 ` Andi Shyti
2022-05-26 19:10 ` Dixit, Ashutosh
2022-05-26 19:09 ` Dixit, Ashutosh
2022-04-29 19:56 ` [Intel-gfx] [PATCH 8/8] drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs Ashutosh Dixit
2022-04-29 20:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4) Patchwork
2022-04-29 20:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-04-29 21:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-04-29 23:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-04-30 0:44 ` Dixit, Ashutosh
2022-04-30 5:28 ` Vudum, Lakshminarayana
2022-04-30 5:09 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-04-13 18:11 [Intel-gfx] [PATCH 0/8] drm/i915: Media freq factor and per-gt enhancements/fixes Ashutosh Dixit
2022-04-13 18:11 ` [Intel-gfx] [PATCH 2/8] drm/i915/gt: Add media freq factor to per-gt sysfs Ashutosh Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czgj74yb.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox