* [PATCH] drm/i915: remove the IRQs enabled WARN from intel_disable_gt_powersave @ 2014-11-20 15:59 Imre Deak 2014-11-20 16:01 ` Daniel Vetter 2014-11-22 14:13 ` [PATCH] drm/i915: remove the IRQs enabled WARN from shuang.he 0 siblings, 2 replies; 5+ messages in thread From: Imre Deak @ 2014-11-20 15:59 UTC (permalink / raw) To: intel-gfx; +Cc: paulo.r.zanoni This function can be called now with i915 interrupts enabled, so the corresponding WARN is incorrect, remove it. I think this was spotted by Paulo during his review, but since I already removed the same WARN from intel_suspend_gt_powersave() I missed then his point. Spotted-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Signed-off-by: Imre Deak <imre.deak@intel.com> --- drivers/gpu/drm/i915/intel_pm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index f103fff..e361014 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -6223,9 +6223,6 @@ void intel_disable_gt_powersave(struct drm_device *dev) { struct drm_i915_private *dev_priv = dev->dev_private; - /* Interrupts should be disabled already to avoid re-arming. */ - WARN_ON(intel_irqs_enabled(dev_priv)); - if (IS_IRONLAKE_M(dev)) { ironlake_disable_drps(dev); ironlake_disable_rc6(dev); -- 1.8.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: remove the IRQs enabled WARN from intel_disable_gt_powersave 2014-11-20 15:59 [PATCH] drm/i915: remove the IRQs enabled WARN from intel_disable_gt_powersave Imre Deak @ 2014-11-20 16:01 ` Daniel Vetter 2014-11-22 14:13 ` [PATCH] drm/i915: remove the IRQs enabled WARN from shuang.he 1 sibling, 0 replies; 5+ messages in thread From: Daniel Vetter @ 2014-11-20 16:01 UTC (permalink / raw) To: Imre Deak; +Cc: intel-gfx, paulo.r.zanoni On Thu, Nov 20, 2014 at 05:59:22PM +0200, Imre Deak wrote: > This function can be called now with i915 interrupts enabled, so the > corresponding WARN is incorrect, remove it. I think this was spotted by > Paulo during his review, but since I already removed the same WARN > from intel_suspend_gt_powersave() I missed then his point. > > Spotted-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > Signed-off-by: Imre Deak <imre.deak@intel.com> I think I've just noticed that in the module reload test too. Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: remove the IRQs enabled WARN from 2014-11-20 15:59 [PATCH] drm/i915: remove the IRQs enabled WARN from intel_disable_gt_powersave Imre Deak 2014-11-20 16:01 ` Daniel Vetter @ 2014-11-22 14:13 ` shuang.he 2014-11-24 9:28 ` Daniel Vetter 1 sibling, 1 reply; 5+ messages in thread From: shuang.he @ 2014-11-22 14:13 UTC (permalink / raw) To: shuang.he, intel-gfx, imre.deak Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com) -------------------------------------Summary------------------------------------- Platform Delta drm-intel-nightly Series Applied PNV 367/367 367/367 ILK -5 373/375 368/375 SNB 450/450 450/450 IVB -1 502/503 501/503 BYT 289/289 289/289 HSW -3 567/567 564/567 BDW 417/417 417/417 -------------------------------------Detailed------------------------------------- Platform Test drm-intel-nightly Series Applied ILK igt_kms_flip_absolute-wf_vblank DMESG_WARN(1, M26)PASS(2, M37) DMESG_WARN(1, M26) ILK igt_kms_flip_plain-flip DMESG_WARN(1, M26)PASS(1, M37) DMESG_WARN(1, M26) ILK igt_kms_flip_wf_vblank-ts-check PASS(2, M37M26) DMESG_WARN(1, M26) ILK igt_kms_flip_wf_vblank-ts-check-interruptible PASS(2, M37M26) DMESG_WARN(1, M26) ILK igt_kms_flip_wf_vblank-vs-modeset-interruptible PASS(2, M37M26) DMESG_WARN(1, M26) IVB igt_gem_bad_reloc_negative-reloc-lut NSPT(2, M21M34)PASS(1, M21) NSPT(2, M21) HSW igt_gem_bad_reloc_negative-reloc-lut NSPT(1, M40)PASS(1, M20) NSPT(2, M20) HSW igt_kms_rotation_crc_primary-rotation PASS(2, M20M40) DMESG_WARN(1, M20)PASS(1, M20) HSW igt_pm_rc6_residency_rc6-accuracy PASS(2, M20M40) FAIL(1, M20)PASS(1, M20) _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: remove the IRQs enabled WARN from 2014-11-22 14:13 ` [PATCH] drm/i915: remove the IRQs enabled WARN from shuang.he @ 2014-11-24 9:28 ` Daniel Vetter 2014-11-24 9:58 ` Jani Nikula 0 siblings, 1 reply; 5+ messages in thread From: Daniel Vetter @ 2014-11-24 9:28 UTC (permalink / raw) To: shuang.he; +Cc: intel-gfx Hi He Shuang, I've just noticed that PRTS occasionally drops the end of the subject when replying on intel-gfx, like here. Unfortunately this breaks threading in some mail clients like gmail. Do we already have a JIRA for this or should I make one? Thanks, Daniel On Sat, Nov 22, 2014 at 06:13:26AM -0800, shuang.he@intel.com wrote: > Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com) > -------------------------------------Summary------------------------------------- > Platform Delta drm-intel-nightly Series Applied > PNV 367/367 367/367 > ILK -5 373/375 368/375 > SNB 450/450 450/450 > IVB -1 502/503 501/503 > BYT 289/289 289/289 > HSW -3 567/567 564/567 > BDW 417/417 417/417 > -------------------------------------Detailed------------------------------------- > Platform Test drm-intel-nightly Series Applied > ILK igt_kms_flip_absolute-wf_vblank DMESG_WARN(1, M26)PASS(2, M37) DMESG_WARN(1, M26) > ILK igt_kms_flip_plain-flip DMESG_WARN(1, M26)PASS(1, M37) DMESG_WARN(1, M26) > ILK igt_kms_flip_wf_vblank-ts-check PASS(2, M37M26) DMESG_WARN(1, M26) > ILK igt_kms_flip_wf_vblank-ts-check-interruptible PASS(2, M37M26) DMESG_WARN(1, M26) > ILK igt_kms_flip_wf_vblank-vs-modeset-interruptible PASS(2, M37M26) DMESG_WARN(1, M26) > IVB igt_gem_bad_reloc_negative-reloc-lut NSPT(2, M21M34)PASS(1, M21) NSPT(2, M21) > HSW igt_gem_bad_reloc_negative-reloc-lut NSPT(1, M40)PASS(1, M20) NSPT(2, M20) > HSW igt_kms_rotation_crc_primary-rotation PASS(2, M20M40) DMESG_WARN(1, M20)PASS(1, M20) > HSW igt_pm_rc6_residency_rc6-accuracy PASS(2, M20M40) FAIL(1, M20)PASS(1, M20) > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: remove the IRQs enabled WARN from 2014-11-24 9:28 ` Daniel Vetter @ 2014-11-24 9:58 ` Jani Nikula 0 siblings, 0 replies; 5+ messages in thread From: Jani Nikula @ 2014-11-24 9:58 UTC (permalink / raw) To: Daniel Vetter, shuang.he; +Cc: intel-gfx On Mon, 24 Nov 2014, Daniel Vetter <daniel@ffwll.ch> wrote: > I've just noticed that PRTS occasionally drops the end of the subject when > replying on intel-gfx, like here. Unfortunately this breaks threading in > some mail clients like gmail. Do we already have a JIRA for this or should > I make one? Seems like PRTS does not do proper header unfolding for headers folded to multiple lines. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-24 9:58 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-11-20 15:59 [PATCH] drm/i915: remove the IRQs enabled WARN from intel_disable_gt_powersave Imre Deak 2014-11-20 16:01 ` Daniel Vetter 2014-11-22 14:13 ` [PATCH] drm/i915: remove the IRQs enabled WARN from shuang.he 2014-11-24 9:28 ` Daniel Vetter 2014-11-24 9:58 ` Jani Nikula
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox