From: Jani Nikula <jani.nikula@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/7] Minor revid/stepping and workaround cleanup
Date: Thu, 08 Jul 2021 10:32:58 +0300 [thread overview]
Message-ID: <87h7h56z11.fsf@intel.com> (raw)
In-Reply-To: <20210708053819.2120187-1-matthew.d.roper@intel.com>
On Wed, 07 Jul 2021, Matt Roper <matthew.d.roper@intel.com> wrote:
> PCI revision IDs don't always map to GT and display IP steppings in an
> intuitive/sensible way. On many of our recent platforms we've switched
> to using revid->stepping lookup tables with the infrastructure in
> intel_step.c to handle stepping lookups and comparisons. Since it's
> confusing to have some of our platforms using the new lookup tables and
> some still using old revid comparisons, let's migrate all the old
> platforms over to the table approach since that's what we want to
> standardize on going forward. The only place that revision ID's should
> really get used directly now is when checking to see if we're running on
> pre-production hardware.
Anusha, Matt, please sort this out between the two of you. :)
https://patchwork.freedesktop.org/series/92257/
BR,
Jani.
>
> Let's also take the opportunity to drop a bit of effectively dead code
> in the workarounds file too.
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>
> Matt Roper (7):
> drm/i915: Make pre-production detection use direct revid comparison
> drm/i915/skl: Use revid->stepping tables
> drm/i915/icl: Use revid->stepping tables
> drm/i915/jsl_ehl: Use revid->stepping tables
> drm/i915/rkl: Use revid->stepping tables
> drm/i915/dg1: Use revid->stepping tables
> drm/i915/cnl: Drop all workarounds
>
> .../drm/i915/display/intel_display_power.c | 2 +-
> drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +-
> drivers/gpu/drm/i915/display/intel_psr.c | 4 +-
> drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +-
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 81 +++----------------
> drivers/gpu/drm/i915/i915_drv.c | 8 +-
> drivers/gpu/drm/i915/i915_drv.h | 80 +++---------------
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> drivers/gpu/drm/i915/intel_step.c | 72 +++++++++++++++--
> drivers/gpu/drm/i915/intel_step.h | 7 ++
> 10 files changed, 107 insertions(+), 153 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-07-08 7:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 5:38 [Intel-gfx] [PATCH 0/7] Minor revid/stepping and workaround cleanup Matt Roper
2021-07-08 5:38 ` [Intel-gfx] [PATCH 1/7] drm/i915: Make pre-production detection use direct revid comparison Matt Roper
2021-07-08 18:08 ` Srivatsa, Anusha
2021-07-10 3:43 ` Matt Roper
2021-07-12 21:02 ` Srivatsa, Anusha
2021-07-12 21:08 ` Srivatsa, Anusha
2021-07-08 5:38 ` [Intel-gfx] [PATCH 2/7] drm/i915/skl: Use revid->stepping tables Matt Roper
2021-07-08 18:11 ` Srivatsa, Anusha
2021-07-08 5:38 ` [Intel-gfx] [PATCH 3/7] drm/i915/icl: " Matt Roper
2021-07-08 5:38 ` [Intel-gfx] [PATCH 4/7] drm/i915/jsl_ehl: " Matt Roper
2021-07-08 5:38 ` [Intel-gfx] [PATCH 5/7] drm/i915/rkl: " Matt Roper
2021-07-08 5:38 ` [Intel-gfx] [PATCH 6/7] drm/i915/dg1: " Matt Roper
2021-07-08 5:38 ` [Intel-gfx] [PATCH 7/7] drm/i915/cnl: Drop all workarounds Matt Roper
2021-07-08 5:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Minor revid/stepping and workaround cleanup Patchwork
2021-07-08 5:50 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-07-08 6:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-08 7:32 ` Jani Nikula [this message]
2021-07-08 18:37 ` [Intel-gfx] [PATCH 0/7] " Srivatsa, Anusha
2021-07-08 23:05 ` Matt Roper
2021-07-08 23:08 ` Srivatsa, Anusha
2021-07-08 10:27 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7h56z11.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox