Re: [PATCH v3 1/2] Revert "drm/i915/ehl: Update MOCS table for EHL"

From: Francisco Jerez <currojerez@riseup.net>
To: Matt Roper <matthew.d.roper@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH v3 1/2] Revert "drm/i915/ehl: Update MOCS table for EHL"
Date: Tue, 12 Nov 2019 15:15:28 -0800	[thread overview]
Message-ID: <87h838znxr.fsf@riseup.net> (raw)
In-Reply-To: <20191112224757.25116-1-matthew.d.roper@intel.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 2250 bytes --]

Matt Roper <matthew.d.roper@intel.com> writes:

> This reverts commit f4071997f1de016780ec6b79c63d90cd5886ee83.
>
> These extra EHL entries won't behave as expected without a bit more work
> on the kernel side so let's drop them until that kernel work has had a
> chance to land.  Userspace trying to use these new entries won't get the
> advantage of the new functionality these entries are meant to provide,
> but at least it won't misbehave.
>
> When we do add these back in the future, we'll probably want to
> explicitly use separate tables for ICL and EHL so that userspace
> software that mistakenly uses these entries (which are undefined on ICL)
> sees the same behavior it sees with all the other undefined entries.
>
> Cc: Francisco Jerez <francisco.jerez.plata@intel.com>
> Cc: Jon Bloomfield <jon.bloomfield@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

I think f4071997f1de016780ec6b79c63d90cd5886ee83 has hit a few kernel
releases already.  Wouldn't it make sense to CC stable?

Patch is:

Reviewed-by: Francisco Jerez <currojerez@riseup.net>

> ---
>  drivers/gpu/drm/i915/gt/intel_mocs.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
> index 6e881c735b20..06e2adbf27be 100644
> --- a/drivers/gpu/drm/i915/gt/intel_mocs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
> @@ -200,14 +200,6 @@ static const struct drm_i915_mocs_entry broxton_mocs_table[] = {
>  	MOCS_ENTRY(15, \
>  		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(2) | LE_AOM(1), \
>  		   L3_3_WB), \
> -	/* Bypass LLC - Uncached (EHL+) */ \
> -	MOCS_ENTRY(16, \
> -		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \
> -		   L3_1_UC), \
> -	/* Bypass LLC - L3 (Read-Only) (EHL+) */ \
> -	MOCS_ENTRY(17, \
> -		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \
> -		   L3_3_WB), \
>  	/* Self-Snoop - L3 + LLC */ \
>  	MOCS_ENTRY(18, \
>  		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3) | LE_SSE(3), \
> -- 
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx