* [Intel-gfx] [PATCH 0/3] drm/i915: PCH type cleanup
@ 2022-06-30 15:05 Ville Syrjala
2022-06-30 15:05 ` [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently Ville Syrjala
` (5 more replies)
0 siblings, 6 replies; 16+ messages in thread
From: Ville Syrjala @ 2022-06-30 15:05 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Clear out some unnecessary PCH types.
Ville Syrjälä (3):
drm/i915: Use short PCH names consistently
drm/i915: Nuke PCH_MCC
drm/i915: Nuke PCH_JSP
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
.../gpu/drm/i915/display/intel_display_power.c | 2 +-
drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
drivers/gpu/drm/i915/intel_pch.c | 16 +++++++++-------
drivers/gpu/drm/i915/intel_pch.h | 8 ++------
5 files changed, 14 insertions(+), 16 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently
2022-06-30 15:05 [Intel-gfx] [PATCH 0/3] drm/i915: PCH type cleanup Ville Syrjala
@ 2022-06-30 15:05 ` Ville Syrjala
2022-06-30 15:50 ` Murthy, Arun R
2022-06-30 15:05 ` [Intel-gfx] [PATCH 2/3] drm/i915: Nuke PCH_MCC Ville Syrjala
` (4 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Ville Syrjala @ 2022-06-30 15:05 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The comments regarding PCH compatibility use long vs.
short names inconsistently. Just use short names always.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_pch.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
index e2b2bbdc0714..94446cac6605 100644
--- a/drivers/gpu/drm/i915/intel_pch.c
+++ b/drivers/gpu/drm/i915/intel_pch.c
@@ -25,7 +25,7 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
drm_dbg_kms(&dev_priv->drm, "Found PantherPoint PCH\n");
drm_WARN_ON(&dev_priv->drm,
GRAPHICS_VER(dev_priv) != 6 && !IS_IVYBRIDGE(dev_priv));
- /* PantherPoint is CPT compatible */
+ /* PPT is CPT compatible */
return PCH_CPT;
case INTEL_PCH_LPT_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found LynxPoint PCH\n");
@@ -47,7 +47,7 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
!IS_HASWELL(dev_priv) && !IS_BROADWELL(dev_priv));
drm_WARN_ON(&dev_priv->drm,
IS_HSW_ULT(dev_priv) || IS_BDW_ULT(dev_priv));
- /* WildcatPoint is LPT compatible */
+ /* WPT is LPT compatible */
return PCH_LPT;
case INTEL_PCH_WPT_LP_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found WildcatPoint LP PCH\n");
@@ -55,7 +55,7 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
!IS_HASWELL(dev_priv) && !IS_BROADWELL(dev_priv));
drm_WARN_ON(&dev_priv->drm,
!IS_HSW_ULT(dev_priv) && !IS_BDW_ULT(dev_priv));
- /* WildcatPoint is LPT compatible */
+ /* WPT is LPT compatible */
return PCH_LPT;
case INTEL_PCH_SPT_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found SunrisePoint PCH\n");
@@ -99,14 +99,14 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
!IS_COFFEELAKE(dev_priv) &&
!IS_COMETLAKE(dev_priv) &&
!IS_ROCKETLAKE(dev_priv));
- /* CometPoint is CNP Compatible */
+ /* CMP is CNP compatible */
return PCH_CNP;
case INTEL_PCH_CMP_V_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found Comet Lake V PCH (CMP-V)\n");
drm_WARN_ON(&dev_priv->drm,
!IS_COFFEELAKE(dev_priv) &&
!IS_COMETLAKE(dev_priv));
- /* Comet Lake V PCH is based on KBP, which is SPT compatible */
+ /* CMP-V is based on KBP, which is SPT compatible */
return PCH_SPT;
case INTEL_PCH_ICP_DEVICE_ID_TYPE:
case INTEL_PCH_ICP2_DEVICE_ID_TYPE:
--
2.35.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH 2/3] drm/i915: Nuke PCH_MCC
2022-06-30 15:05 [Intel-gfx] [PATCH 0/3] drm/i915: PCH type cleanup Ville Syrjala
2022-06-30 15:05 ` [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently Ville Syrjala
@ 2022-06-30 15:05 ` Ville Syrjala
2022-07-01 9:55 ` Jani Nikula
2022-06-30 15:06 ` [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP Ville Syrjala
` (3 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Ville Syrjala @ 2022-06-30 15:05 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
MCC is derived from TGP, and we have no real need to
differentiate between the two. Thus remove PCH_MCC and
just declare it to be PCH_TGP compatible.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
drivers/gpu/drm/i915/intel_pch.c | 3 ++-
drivers/gpu/drm/i915/intel_pch.h | 4 +---
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 272e1bf6006b..2330604b0bcc 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -4179,7 +4179,7 @@ static enum hpd_pin ehl_hpd_pin(struct drm_i915_private *dev_priv,
if (port == PORT_D)
return HPD_PORT_A;
- if (HAS_PCH_MCC(dev_priv))
+ if (HAS_PCH_TGP(dev_priv))
return icl_hpd_pin(dev_priv, port);
return HPD_PORT_A + port - PORT_A;
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 1ae09431f53a..ebd91aa69dd2 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -2852,7 +2852,7 @@ static u8 intel_hdmi_ddc_pin(struct intel_encoder *encoder)
ddc_pin = rkl_port_to_ddc_pin(dev_priv, port);
else if (DISPLAY_VER(dev_priv) == 9 && HAS_PCH_TGP(dev_priv))
ddc_pin = gen9bc_tgp_port_to_ddc_pin(dev_priv, port);
- else if (HAS_PCH_MCC(dev_priv))
+ else if (IS_JSL_EHL(dev_priv) && HAS_PCH_TGP(dev_priv))
ddc_pin = mcc_port_to_ddc_pin(dev_priv, port);
else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP)
ddc_pin = icl_port_to_ddc_pin(dev_priv, port);
diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
index 94446cac6605..b45c504c6f03 100644
--- a/drivers/gpu/drm/i915/intel_pch.c
+++ b/drivers/gpu/drm/i915/intel_pch.c
@@ -116,7 +116,8 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
case INTEL_PCH_MCC_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found Mule Creek Canyon PCH\n");
drm_WARN_ON(&dev_priv->drm, !IS_JSL_EHL(dev_priv));
- return PCH_MCC;
+ /* MCC is TGP compatible */
+ return PCH_TGP;
case INTEL_PCH_TGP_DEVICE_ID_TYPE:
case INTEL_PCH_TGP2_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found Tiger Lake LP PCH\n");
diff --git a/drivers/gpu/drm/i915/intel_pch.h b/drivers/gpu/drm/i915/intel_pch.h
index b7a8cf409d48..07f6f5517968 100644
--- a/drivers/gpu/drm/i915/intel_pch.h
+++ b/drivers/gpu/drm/i915/intel_pch.h
@@ -24,8 +24,7 @@ enum intel_pch {
PCH_CNP, /* Cannon/Comet Lake PCH */
PCH_ICP, /* Ice Lake PCH */
PCH_JSP, /* Jasper Lake PCH */
- PCH_MCC, /* Mule Creek Canyon PCH */
- PCH_TGP, /* Tiger Lake PCH */
+ PCH_TGP, /* Tiger Lake/Mule Creek Canyon PCH */
PCH_ADP, /* Alder Lake PCH */
/* Fake PCHs, functionality handled on the same PCI dev */
@@ -69,7 +68,6 @@ enum intel_pch {
#define HAS_PCH_ADP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ADP)
#define HAS_PCH_DG1(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_DG1)
#define HAS_PCH_JSP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_JSP)
-#define HAS_PCH_MCC(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_MCC)
#define HAS_PCH_TGP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_TGP)
#define HAS_PCH_ICP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ICP)
#define HAS_PCH_CNP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_CNP)
--
2.35.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP
2022-06-30 15:05 [Intel-gfx] [PATCH 0/3] drm/i915: PCH type cleanup Ville Syrjala
2022-06-30 15:05 ` [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently Ville Syrjala
2022-06-30 15:05 ` [Intel-gfx] [PATCH 2/3] drm/i915: Nuke PCH_MCC Ville Syrjala
@ 2022-06-30 15:06 ` Ville Syrjala
2022-06-30 15:55 ` Murthy, Arun R
2022-07-01 9:57 ` Jani Nikula
2022-06-30 17:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: PCH type cleanup Patchwork
` (2 subsequent siblings)
5 siblings, 2 replies; 16+ messages in thread
From: Ville Syrjala @ 2022-06-30 15:06 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
JSP is based on ICP and we don't really need to differentiate
between the two. So let's just delcare JSP to be ICP.
The only slight change here is for Wa_14011294188 which we
used to apply for JSP but now we'll only apply to MCC. This
should be fine since the issue being dealt with was introduced
in TGP and inherited into MCC. JSP being derived from ICP
should not need this workaround.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
drivers/gpu/drm/i915/intel_pch.c | 3 ++-
drivers/gpu/drm/i915/intel_pch.h | 4 +---
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index a9cb27f1c964..589af257edeb 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -1608,7 +1608,7 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,
gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
/* Wa_14011294188:ehl,jsl,tgl,rkl,adl-s */
- if (INTEL_PCH_TYPE(dev_priv) >= PCH_JSP &&
+ if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP &&
INTEL_PCH_TYPE(dev_priv) < PCH_DG1)
intel_de_rmw(dev_priv, SOUTH_DSPCLK_GATE_D, 0,
PCH_DPMGUNIT_CLOCK_GATE_DISABLE);
diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
index b45c504c6f03..0fec25be146a 100644
--- a/drivers/gpu/drm/i915/intel_pch.c
+++ b/drivers/gpu/drm/i915/intel_pch.c
@@ -128,7 +128,8 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
case INTEL_PCH_JSP_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found Jasper Lake PCH\n");
drm_WARN_ON(&dev_priv->drm, !IS_JSL_EHL(dev_priv));
- return PCH_JSP;
+ /* JSP is ICP compatible */
+ return PCH_ICP;
case INTEL_PCH_ADP_DEVICE_ID_TYPE:
case INTEL_PCH_ADP2_DEVICE_ID_TYPE:
case INTEL_PCH_ADP3_DEVICE_ID_TYPE:
diff --git a/drivers/gpu/drm/i915/intel_pch.h b/drivers/gpu/drm/i915/intel_pch.h
index 07f6f5517968..7c8ce9781d1a 100644
--- a/drivers/gpu/drm/i915/intel_pch.h
+++ b/drivers/gpu/drm/i915/intel_pch.h
@@ -22,8 +22,7 @@ enum intel_pch {
PCH_LPT, /* Lynxpoint/Wildcatpoint PCH */
PCH_SPT, /* Sunrisepoint/Kaby Lake PCH */
PCH_CNP, /* Cannon/Comet Lake PCH */
- PCH_ICP, /* Ice Lake PCH */
- PCH_JSP, /* Jasper Lake PCH */
+ PCH_ICP, /* Ice Lake/Jasper Lake PCH */
PCH_TGP, /* Tiger Lake/Mule Creek Canyon PCH */
PCH_ADP, /* Alder Lake PCH */
@@ -67,7 +66,6 @@ enum intel_pch {
#define HAS_PCH_DG2(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_DG2)
#define HAS_PCH_ADP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ADP)
#define HAS_PCH_DG1(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_DG1)
-#define HAS_PCH_JSP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_JSP)
#define HAS_PCH_TGP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_TGP)
#define HAS_PCH_ICP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ICP)
#define HAS_PCH_CNP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_CNP)
--
2.35.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently
2022-06-30 15:05 ` [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently Ville Syrjala
@ 2022-06-30 15:50 ` Murthy, Arun R
2022-06-30 17:00 ` Ville Syrjälä
0 siblings, 1 reply; 16+ messages in thread
From: Murthy, Arun R @ 2022-06-30 15:50 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx@lists.freedesktop.org
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The comments regarding PCH compatibility use long vs.
> short names inconsistently. Just use short names always.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_pch.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pch.c
> b/drivers/gpu/drm/i915/intel_pch.c
> index e2b2bbdc0714..94446cac6605 100644
> --- a/drivers/gpu/drm/i915/intel_pch.c
> +++ b/drivers/gpu/drm/i915/intel_pch.c
> @@ -25,7 +25,7 @@ intel_pch_type(const struct drm_i915_private
> *dev_priv, unsigned short id)
> drm_dbg_kms(&dev_priv->drm, "Found PantherPoint
> PCH\n");
> drm_WARN_ON(&dev_priv->drm,
> GRAPHICS_VER(dev_priv) != 6 &&
> !IS_IVYBRIDGE(dev_priv));
> - /* PantherPoint is CPT compatible */
> + /* PPT is CPT compatible */
This is not the code but only comment, I feel elaborated names makes it more readable than abbreviation.
Thanks and Regards,
Arun R Murthy
--------------------
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP
2022-06-30 15:06 ` [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP Ville Syrjala
@ 2022-06-30 15:55 ` Murthy, Arun R
2022-06-30 16:59 ` Ville Syrjälä
2022-07-01 9:57 ` Jani Nikula
1 sibling, 1 reply; 16+ messages in thread
From: Murthy, Arun R @ 2022-06-30 15:55 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx@lists.freedesktop.org
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville
> Syrjala
> Sent: Thursday, June 30, 2022 8:36 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> JSP is based on ICP and we don't really need to differentiate between the
> two. So let's just delcare JSP to be ICP.
>
> The only slight change here is for Wa_14011294188 which we used to apply
> for JSP but now we'll only apply to MCC. This should be fine since the issue
> being dealt with was introduced in TGP and inherited into MCC. JSP being
> derived from ICP should not need this workaround.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
> drivers/gpu/drm/i915/intel_pch.c | 3 ++-
> drivers/gpu/drm/i915/intel_pch.h | 4 +---
> 3 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c
> b/drivers/gpu/drm/i915/display/intel_display_power.c
> index a9cb27f1c964..589af257edeb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -1608,7 +1608,7 @@ static void icl_display_core_init(struct
> drm_i915_private *dev_priv,
> gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
>
> /* Wa_14011294188:ehl,jsl,tgl,rkl,adl-s */
> - if (INTEL_PCH_TYPE(dev_priv) >= PCH_JSP &&
> + if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP &&
> INTEL_PCH_TYPE(dev_priv) < PCH_DG1)
> intel_de_rmw(dev_priv, SOUTH_DSPCLK_GATE_D, 0,
> PCH_DPMGUNIT_CLOCK_GATE_DISABLE); diff --git
> a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
> index b45c504c6f03..0fec25be146a 100644
> --- a/drivers/gpu/drm/i915/intel_pch.c
> +++ b/drivers/gpu/drm/i915/intel_pch.c
> @@ -128,7 +128,8 @@ intel_pch_type(const struct drm_i915_private
> *dev_priv, unsigned short id)
> case INTEL_PCH_JSP_DEVICE_ID_TYPE:
> drm_dbg_kms(&dev_priv->drm, "Found Jasper Lake PCH\n");
> drm_WARN_ON(&dev_priv->drm, !IS_JSL_EHL(dev_priv));
> - return PCH_JSP;
> + /* JSP is ICP compatible */
> + return PCH_ICP;
> case INTEL_PCH_ADP_DEVICE_ID_TYPE:
> case INTEL_PCH_ADP2_DEVICE_ID_TYPE:
> case INTEL_PCH_ADP3_DEVICE_ID_TYPE:
> diff --git a/drivers/gpu/drm/i915/intel_pch.h
> b/drivers/gpu/drm/i915/intel_pch.h
> index 07f6f5517968..7c8ce9781d1a 100644
> --- a/drivers/gpu/drm/i915/intel_pch.h
> +++ b/drivers/gpu/drm/i915/intel_pch.h
> @@ -22,8 +22,7 @@ enum intel_pch {
> PCH_LPT, /* Lynxpoint/Wildcatpoint PCH */
> PCH_SPT, /* Sunrisepoint/Kaby Lake PCH */
> PCH_CNP, /* Cannon/Comet Lake PCH */
> - PCH_ICP, /* Ice Lake PCH */
> - PCH_JSP, /* Jasper Lake PCH */
> + PCH_ICP, /* Ice Lake/Jasper Lake PCH */
Only in i915_irq icp is used and in the rest of the i915 code icl is used leading to confusion.
I would rather suggest to use ICL since most of the driver references it as icl and also change icp in i915_irq to icl.
This is just my opinion, other can comment over here.
Thanks and Regards,
Arun R Murthy
--------------------
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP
2022-06-30 15:55 ` Murthy, Arun R
@ 2022-06-30 16:59 ` Ville Syrjälä
0 siblings, 0 replies; 16+ messages in thread
From: Ville Syrjälä @ 2022-06-30 16:59 UTC (permalink / raw)
To: Murthy, Arun R; +Cc: intel-gfx@lists.freedesktop.org
On Thu, Jun 30, 2022 at 03:55:57PM +0000, Murthy, Arun R wrote:
>
>
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville
> > Syrjala
> > Sent: Thursday, June 30, 2022 8:36 PM
> > To: intel-gfx@lists.freedesktop.org
> > Subject: [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > JSP is based on ICP and we don't really need to differentiate between the
> > two. So let's just delcare JSP to be ICP.
> >
> > The only slight change here is for Wa_14011294188 which we used to apply
> > for JSP but now we'll only apply to MCC. This should be fine since the issue
> > being dealt with was introduced in TGP and inherited into MCC. JSP being
> > derived from ICP should not need this workaround.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
> > drivers/gpu/drm/i915/intel_pch.c | 3 ++-
> > drivers/gpu/drm/i915/intel_pch.h | 4 +---
> > 3 files changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c
> > b/drivers/gpu/drm/i915/display/intel_display_power.c
> > index a9cb27f1c964..589af257edeb 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> > @@ -1608,7 +1608,7 @@ static void icl_display_core_init(struct
> > drm_i915_private *dev_priv,
> > gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
> >
> > /* Wa_14011294188:ehl,jsl,tgl,rkl,adl-s */
> > - if (INTEL_PCH_TYPE(dev_priv) >= PCH_JSP &&
> > + if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP &&
> > INTEL_PCH_TYPE(dev_priv) < PCH_DG1)
> > intel_de_rmw(dev_priv, SOUTH_DSPCLK_GATE_D, 0,
> > PCH_DPMGUNIT_CLOCK_GATE_DISABLE); diff --git
> > a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
> > index b45c504c6f03..0fec25be146a 100644
> > --- a/drivers/gpu/drm/i915/intel_pch.c
> > +++ b/drivers/gpu/drm/i915/intel_pch.c
> > @@ -128,7 +128,8 @@ intel_pch_type(const struct drm_i915_private
> > *dev_priv, unsigned short id)
> > case INTEL_PCH_JSP_DEVICE_ID_TYPE:
> > drm_dbg_kms(&dev_priv->drm, "Found Jasper Lake PCH\n");
> > drm_WARN_ON(&dev_priv->drm, !IS_JSL_EHL(dev_priv));
> > - return PCH_JSP;
> > + /* JSP is ICP compatible */
> > + return PCH_ICP;
> > case INTEL_PCH_ADP_DEVICE_ID_TYPE:
> > case INTEL_PCH_ADP2_DEVICE_ID_TYPE:
> > case INTEL_PCH_ADP3_DEVICE_ID_TYPE:
> > diff --git a/drivers/gpu/drm/i915/intel_pch.h
> > b/drivers/gpu/drm/i915/intel_pch.h
> > index 07f6f5517968..7c8ce9781d1a 100644
> > --- a/drivers/gpu/drm/i915/intel_pch.h
> > +++ b/drivers/gpu/drm/i915/intel_pch.h
> > @@ -22,8 +22,7 @@ enum intel_pch {
> > PCH_LPT, /* Lynxpoint/Wildcatpoint PCH */
> > PCH_SPT, /* Sunrisepoint/Kaby Lake PCH */
> > PCH_CNP, /* Cannon/Comet Lake PCH */
> > - PCH_ICP, /* Ice Lake PCH */
> > - PCH_JSP, /* Jasper Lake PCH */
> > + PCH_ICP, /* Ice Lake/Jasper Lake PCH */
>
> Only in i915_irq icp is used and in the rest of the i915 code icl is used leading to confusion.
> I would rather suggest to use ICL since most of the driver references it as icl and also change icp in i915_irq to icl.
> This is just my opinion, other can comment over here.
ICL is a CPU, ICP is a PCH.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently
2022-06-30 15:50 ` Murthy, Arun R
@ 2022-06-30 17:00 ` Ville Syrjälä
2022-07-01 9:53 ` Jani Nikula
0 siblings, 1 reply; 16+ messages in thread
From: Ville Syrjälä @ 2022-06-30 17:00 UTC (permalink / raw)
To: Murthy, Arun R; +Cc: intel-gfx@lists.freedesktop.org
On Thu, Jun 30, 2022 at 03:50:15PM +0000, Murthy, Arun R wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The comments regarding PCH compatibility use long vs.
> > short names inconsistently. Just use short names always.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_pch.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pch.c
> > b/drivers/gpu/drm/i915/intel_pch.c
> > index e2b2bbdc0714..94446cac6605 100644
> > --- a/drivers/gpu/drm/i915/intel_pch.c
> > +++ b/drivers/gpu/drm/i915/intel_pch.c
> > @@ -25,7 +25,7 @@ intel_pch_type(const struct drm_i915_private
> > *dev_priv, unsigned short id)
> > drm_dbg_kms(&dev_priv->drm, "Found PantherPoint
> > PCH\n");
> > drm_WARN_ON(&dev_priv->drm,
> > GRAPHICS_VER(dev_priv) != 6 &&
> > !IS_IVYBRIDGE(dev_priv));
> > - /* PantherPoint is CPT compatible */
> > + /* PPT is CPT compatible */
>
>
> This is not the code but only comment, I feel elaborated names makes it more readable than abbreviation.
We rarely type out the full names for anything.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: PCH type cleanup
2022-06-30 15:05 [Intel-gfx] [PATCH 0/3] drm/i915: PCH type cleanup Ville Syrjala
` (2 preceding siblings ...)
2022-06-30 15:06 ` [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP Ville Syrjala
@ 2022-06-30 17:58 ` Patchwork
2022-06-30 18:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-01 9:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2022-06-30 17:58 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: PCH type cleanup
URL : https://patchwork.freedesktop.org/series/105822/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: PCH type cleanup
2022-06-30 15:05 [Intel-gfx] [PATCH 0/3] drm/i915: PCH type cleanup Ville Syrjala
` (3 preceding siblings ...)
2022-06-30 17:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: PCH type cleanup Patchwork
@ 2022-06-30 18:19 ` Patchwork
2022-07-01 9:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2022-06-30 18:19 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 12075 bytes --]
== Series Details ==
Series: drm/i915: PCH type cleanup
URL : https://patchwork.freedesktop.org/series/105822/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11834 -> Patchwork_105822v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/index.html
Participating hosts (42 -> 41)
------------------------------
Additional (1): bat-dg1-6
Missing (2): fi-rkl-11600 fi-icl-u2
Known issues
------------
Here are the changes found in Patchwork_105822v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@engines@fds:
- fi-bsw-kefka: [PASS][1] -> [INCOMPLETE][2] ([i915#6310])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/fi-bsw-kefka/igt@gem_exec_parallel@engines@fds.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-bsw-kefka/igt@gem_exec_parallel@engines@fds.html
* igt@gem_mmap@basic:
- bat-dg1-6: NOTRUN -> [SKIP][3] ([i915#4083])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][4] ([i915#4079]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][5] ([i915#4077]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@gem_tiled_fence_blits@basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-6: NOTRUN -> [SKIP][6] ([i915#1155])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@gem:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][7] ([i915#4528])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-pnv-d510/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-cfl-8700k: [PASS][8] -> [DMESG-FAIL][9] ([i915#5334])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/fi-cfl-8700k/igt@i915_selftest@live@gt_heartbeat.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-cfl-8700k/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-g3258: [PASS][10] -> [INCOMPLETE][11] ([i915#4785])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
- fi-snb-2600: [PASS][12] -> [INCOMPLETE][13] ([i915#3921])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-dg1-6: NOTRUN -> [INCOMPLETE][14] ([i915#6011])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-6: NOTRUN -> [SKIP][15] ([i915#4215])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-6: NOTRUN -> [SKIP][16] ([i915#4212]) +7 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-crc-fast:
- bat-dg1-6: NOTRUN -> [SKIP][18] ([fdo#111827]) +7 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- bat-dg1-6: NOTRUN -> [SKIP][19] ([i915#4103] / [i915#4213])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1:
- fi-tgl-u2: [PASS][20] -> [DMESG-WARN][21] ([i915#402]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/fi-tgl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-tgl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-6: NOTRUN -> [SKIP][22] ([fdo#109285])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@sprite_plane_onoff:
- bat-dg1-6: NOTRUN -> [SKIP][23] ([i915#1072] / [i915#4078]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-6: NOTRUN -> [SKIP][24] ([i915#3555])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-6: NOTRUN -> [SKIP][25] ([i915#3708] / [i915#4077]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-userptr:
- bat-dg1-6: NOTRUN -> [SKIP][26] ([i915#3708] / [i915#4873])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- bat-dg1-6: NOTRUN -> [SKIP][27] ([i915#3708]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@prime_vgem@basic-write.html
* igt@runner@aborted:
- bat-dg1-6: NOTRUN -> [FAIL][28] ([i915#4312] / [i915#5257])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-6/igt@runner@aborted.html
- fi-hsw-g3258: NOTRUN -> [FAIL][29] ([fdo#109271] / [i915#4312] / [i915#6246])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-hsw-g3258/igt@runner@aborted.html
- fi-bsw-kefka: NOTRUN -> [FAIL][30] ([i915#4312])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-bsw-kefka/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@coherency:
- {bat-dg2-9}: [DMESG-WARN][31] ([i915#5763]) -> [PASS][32] +7 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/bat-dg2-9/igt@i915_selftest@live@coherency.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg2-9/igt@i915_selftest@live@coherency.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][33] ([i915#4785]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
- bat-dg1-5: [DMESG-FAIL][35] ([i915#4494] / [i915#4957]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][37] ([i915#4528]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/fi-pnv-d510/igt@i915_selftest@live@requests.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s2idle-without-i915:
- {fi-tgl-dsi}: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/fi-tgl-dsi/igt@i915_suspend@basic-s2idle-without-i915.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/fi-tgl-dsi/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- {bat-adlp-6}: [DMESG-WARN][41] ([i915#3576]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
[i915#6246]: https://gitlab.freedesktop.org/drm/intel/issues/6246
[i915#6297]: https://gitlab.freedesktop.org/drm/intel/issues/6297
[i915#6310]: https://gitlab.freedesktop.org/drm/intel/issues/6310
Build changes
-------------
* Linux: CI_DRM_11834 -> Patchwork_105822v1
CI-20190529: 20190529
CI_DRM_11834: 521bf6e9c3ca9405ea53baa3ba0feb597fd24219 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6553: 3cf110f8dcd1f4f02cf84339664b413abdaebf7d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105822v1: 521bf6e9c3ca9405ea53baa3ba0feb597fd24219 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
ace56ad0c6b1 drm/i915: Nuke PCH_JSP
14d872eb5fab drm/i915: Nuke PCH_MCC
d157c463fdd0 drm/i915: Use short PCH names consistently
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/index.html
[-- Attachment #2: Type: text/html, Size: 13977 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: PCH type cleanup
2022-06-30 15:05 [Intel-gfx] [PATCH 0/3] drm/i915: PCH type cleanup Ville Syrjala
` (4 preceding siblings ...)
2022-06-30 18:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-07-01 9:47 ` Patchwork
5 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2022-07-01 9:47 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 52079 bytes --]
== Series Details ==
Series: drm/i915: PCH type cleanup
URL : https://patchwork.freedesktop.org/series/105822/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11834_full -> Patchwork_105822v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_105822v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_105822v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_105822v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_create@create-ext-cpu-access-sanity-check:
- {shard-rkl}: NOTRUN -> [SKIP][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-rkl-1/igt@gem_create@create-ext-cpu-access-sanity-check.html
### Piglit changes ###
#### Possible regressions ####
* spec@!opengl 1.5@normal3b3s-invariance-short:
- pig-glk-j5005: NOTRUN -> [INCOMPLETE][2]
[2]: None
* spec@ext_framebuffer_multisample@interpolation 0 non-centroid-disabled:
- pig-kbl-iris: NOTRUN -> [CRASH][3]
[3]: None
* spec@glsl-1.50@execution@built-in-functions@gs-op-assign-bitxor-ivec4-ivec4:
- pig-skl-6260u: NOTRUN -> [CRASH][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/pig-skl-6260u/spec@glsl-1.50@execution@built-in-functions@gs-op-assign-bitxor-ivec4-ivec4.html
Known issues
------------
Here are the changes found in Patchwork_105822v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-persistence:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-snb7/igt@gem_ctx_persistence@legacy-engines-persistence.html
* igt@gem_ctx_persistence@smoketest:
- shard-glk: [PASS][6] -> [INCOMPLETE][7] ([i915#6310]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-glk1/igt@gem_ctx_persistence@smoketest.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk5/igt@gem_ctx_persistence@smoketest.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][8] -> [TIMEOUT][9] ([i915#3070])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb6/igt@gem_eio@unwedge-stress.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: NOTRUN -> [SKIP][10] ([i915#4525])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb6/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_lmem_swapping@heavy-multi:
- shard-kbl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl4/igt@gem_lmem_swapping@heavy-multi.html
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-skl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4613]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl1/igt@gem_lmem_swapping@heavy-verify-multi.html
- shard-glk: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4613])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk7/igt@gem_lmem_swapping@heavy-verify-multi.html
- shard-iclb: NOTRUN -> [SKIP][17] ([i915#4613])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@gem_lmem_swapping@heavy-verify-multi.html
* igt@gem_pxp@create-protected-buffer:
- shard-iclb: NOTRUN -> [SKIP][18] ([i915#4270]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@gem_pxp@create-protected-buffer.html
* igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
- shard-skl: NOTRUN -> [SKIP][19] ([fdo#109271]) +111 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl1/igt@gem_pxp@verify-pxp-stale-buf-optout-execution.html
* igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs:
- shard-iclb: NOTRUN -> [SKIP][20] ([i915#768])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs.html
* igt@gem_userptr_blits@input-checking:
- shard-kbl: NOTRUN -> [DMESG-WARN][21] ([i915#4991])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl4/igt@gem_userptr_blits@input-checking.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][22] -> [DMESG-WARN][23] ([i915#180]) +4 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-apl1/igt@gem_workarounds@suspend-resume.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl1/igt@gem_workarounds@suspend-resume.html
* igt@gen9_exec_parse@allowed-all:
- shard-iclb: NOTRUN -> [SKIP][24] ([i915#2856])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@gen9_exec_parse@allowed-all.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][25] -> [DMESG-WARN][26] ([i915#5566] / [i915#716])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-skl6/igt@gen9_exec_parse@allowed-single.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl1/igt@gen9_exec_parse@allowed-single.html
- shard-apl: NOTRUN -> [DMESG-WARN][27] ([i915#5566] / [i915#716])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl8/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#658])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl8/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][29] ([i915#454])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl4/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-iclb: NOTRUN -> [SKIP][30] ([fdo#110892])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@i915_pm_rpm@modeset-non-lpsp.html
* igt@i915_suspend@basic-s2idle-without-i915:
- shard-snb: [PASS][31] -> [SKIP][32] ([fdo#109271])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-snb2/igt@i915_suspend@basic-s2idle-without-i915.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-snb6/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#5903])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][34] ([i915#5286])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@kms_big_fb@4-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@linear-32bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#110725] / [fdo#111614])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@kms_big_fb@linear-32bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][36] ([i915#3743])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl10/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#110723])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#3886])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl8/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3886]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk5/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109278] / [i915#3886]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-yf_tiled_ccs:
- shard-glk: [PASS][41] -> [FAIL][42] ([i915#1888])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-glk7/igt@kms_ccs@pipe-b-crc-primary-rotation-180-yf_tiled_ccs.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk9/igt@kms_ccs@pipe-b-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#111615] / [i915#3689])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-tglb3/igt@kms_ccs@pipe-b-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3886]) +4 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl10/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886]) +9 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl6/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109278]) +8 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs.html
* igt@kms_chamelium@dp-crc-fast:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl8/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@dp-hpd-with-enabled-mode:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109284] / [fdo#111827]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@kms_chamelium@dp-hpd-with-enabled-mode.html
* igt@kms_chamelium@hdmi-crc-multiple:
- shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +7 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl1/igt@kms_chamelium@hdmi-crc-multiple.html
* igt@kms_color@pipe-d-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109278] / [i915#1149])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@kms_color@pipe-d-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-a-ctm-negative:
- shard-glk: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk5/igt@kms_color_chamelium@pipe-a-ctm-negative.html
* igt@kms_color_chamelium@pipe-a-degamma:
- shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +13 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl4/igt@kms_color_chamelium@pipe-a-degamma.html
* igt@kms_color_chamelium@pipe-c-ctm-green-to-red:
- shard-snb: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-snb7/igt@kms_color_chamelium@pipe-c-ctm-green-to-red.html
* igt@kms_cursor_crc@cursor-rapid-movement@pipe-b-dp-1-32x10:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271]) +27 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl8/igt@kms_cursor_crc@cursor-rapid-movement@pipe-b-dp-1-32x10.html
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-4tiled:
- shard-iclb: NOTRUN -> [SKIP][55] ([i915#5287])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-4tiled.html
* igt@kms_flip@2x-flip-vs-modeset-vs-hang:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109274])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@kms_flip@2x-flip-vs-modeset-vs-hang.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][57] -> [FAIL][58] ([i915#79])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl3/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-edp1:
- shard-skl: [PASS][59] -> [INCOMPLETE][60] ([i915#4939])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-skl7/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl1/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: [PASS][61] -> [DMESG-WARN][62] ([i915#180]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip@flip-vs-suspend@b-vga1:
- shard-snb: [PASS][63] -> [DMESG-WARN][64] ([i915#5090])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-snb6/igt@kms_flip@flip-vs-suspend@b-vga1.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-snb7/igt@kms_flip@flip-vs-suspend@b-vga1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling:
- shard-glk: [PASS][65] -> [FAIL][66] ([i915#4911])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-glk2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109280]) +11 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-glk: NOTRUN -> [SKIP][68] ([fdo#109271]) +33 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt:
- shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271]) +183 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl4/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt.html
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-kbl: [PASS][70] -> [FAIL][71] ([i915#1188])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl7/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl7/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][72] ([fdo#108145] / [i915#265]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl7/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][73] ([i915#265])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][74] ([fdo#108145] / [i915#265]) +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_lowres@tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][75] ([fdo#112054])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-tglb3/igt@kms_plane_lowres@tiling-yf.html
* igt@kms_plane_lowres@tiling-yf@pipe-a-edp-1:
- shard-iclb: NOTRUN -> [SKIP][76] ([i915#3536]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb5/igt@kms_plane_lowres@tiling-yf@pipe-a-edp-1.html
* igt@kms_plane_scaling@invalid-num-scalers@pipe-a-edp-1-invalid-num-scalers:
- shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#5776]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl10/igt@kms_plane_scaling@invalid-num-scalers@pipe-a-edp-1-invalid-num-scalers.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-glk: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#658])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk7/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
- shard-iclb: NOTRUN -> [SKIP][79] ([fdo#111068] / [i915#658])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#658]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl10/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-kbl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#658]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [PASS][82] -> [SKIP][83] ([fdo#109642] / [fdo#111068] / [i915#658])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb7/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_setmode@basic@pipe-a-vga-1:
- shard-snb: NOTRUN -> [FAIL][84] ([i915#5465]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-snb7/igt@kms_setmode@basic@pipe-a-vga-1.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-glk: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#533])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk7/igt@kms_vblank@pipe-d-wait-idle.html
- shard-skl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#533])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl1/igt@kms_vblank@pipe-d-wait-idle.html
* igt@prime_nv_pcopy@test3_5:
- shard-snb: NOTRUN -> [SKIP][87] ([fdo#109271]) +77 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-snb7/igt@prime_nv_pcopy@test3_5.html
* igt@sw_sync@sync_multi_timeline_wait:
- shard-skl: NOTRUN -> [FAIL][88] ([i915#6140])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl10/igt@sw_sync@sync_multi_timeline_wait.html
* igt@sysfs_clients@fair-0:
- shard-kbl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#2994]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl4/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@split-25:
- shard-iclb: NOTRUN -> [SKIP][90] ([i915#2994])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@sysfs_clients@split-25.html
- shard-skl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2994])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl1/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][92] ([i915#658]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb7/igt@feature_discovery@psr2.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [DMESG-WARN][94] ([i915#180]) -> [PASS][95] +6 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl6/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_ctx_persistence@engines-hostile@bcs0:
- {shard-dg1}: [FAIL][96] ([i915#4883]) -> [PASS][97] +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-dg1-13/igt@gem_ctx_persistence@engines-hostile@bcs0.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-dg1-12/igt@gem_ctx_persistence@engines-hostile@bcs0.html
* igt@gem_eio@kms:
- shard-tglb: [FAIL][98] ([i915#5784]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-tglb5/igt@gem_eio@kms.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-tglb7/igt@gem_eio@kms.html
* igt@gem_eio@reset-stress:
- {shard-dg1}: [FAIL][100] ([i915#5784]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-dg1-15/igt@gem_eio@reset-stress.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-dg1-17/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][102] ([i915#4525]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb7/igt@gem_exec_balancer@parallel-keep-submit-fence.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb2/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-iclb: [FAIL][104] ([i915#2842]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][106] ([i915#2842]) -> [PASS][107] +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl6/igt@gem_exec_fair@basic-pace@rcs0.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][108] ([i915#2849]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][110] ([i915#2190]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-tglb7/igt@gem_huc_copy@huc-copy.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-tglb2/igt@gem_huc_copy@huc-copy.html
* igt@i915_hangman@engine-engine-error@vcs0:
- shard-glk: [INCOMPLETE][112] ([i915#6310]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-glk3/igt@i915_hangman@engine-engine-error@vcs0.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk5/igt@i915_hangman@engine-engine-error@vcs0.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [DMESG-WARN][114] ([i915#6201]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-snb5/igt@i915_module_load@reload-with-fault-injection.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-snb2/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-dg1}: [SKIP][116] ([i915#1397]) -> [PASS][117] +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-dg1-18/igt@i915_pm_rpm@dpms-lpsp.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-dg1-15/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][118] ([i915#3921]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-snb2/igt@i915_selftest@live@hangcheck.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-snb7/igt@i915_selftest@live@hangcheck.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs:
- {shard-rkl}: [SKIP][120] ([i915#1845] / [i915#4098]) -> [PASS][121] +9 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-rkl-1/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-rkl-6/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs.html
* igt@kms_color@pipe-a-ctm-negative:
- {shard-rkl}: [SKIP][122] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-rkl-1/igt@kms_color@pipe-a-ctm-negative.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-rkl-6/igt@kms_color@pipe-a-ctm-negative.html
* igt@kms_color@pipe-a-legacy-gamma-reset:
- {shard-rkl}: [SKIP][124] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][125] +2 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-rkl-1/igt@kms_color@pipe-a-legacy-gamma-reset.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-rkl-6/igt@kms_color@pipe-a-legacy-gamma-reset.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [FAIL][126] ([i915#2346]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled:
- {shard-rkl}: [SKIP][128] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][129] +3 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-rkl-1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [INCOMPLETE][130] ([i915#180] / [i915#1982] / [i915#4939]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-apl8/igt@kms_fbcon_fbt@fbc-suspend.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl8/igt@kms_fbcon_fbt@fbc-suspend.html
- shard-kbl: [INCOMPLETE][132] ([i915#180] / [i915#4939]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-suspend@c-edp1:
- shard-skl: [INCOMPLETE][134] ([i915#4839]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-skl1/igt@kms_flip@flip-vs-suspend@c-edp1.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl10/igt@kms_flip@flip-vs-suspend@c-edp1.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-render:
- {shard-rkl}: [SKIP][136] ([i915#1849] / [i915#4098]) -> [PASS][137] +7 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
* igt@kms_plane@plane-position-covered@pipe-b-planes:
- {shard-rkl}: [SKIP][138] ([i915#3558]) -> [PASS][139] +1 similar issue
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-rkl-1/igt@kms_plane@plane-position-covered@pipe-b-planes.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-rkl-6/igt@kms_plane@plane-position-covered@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][140] ([fdo#108145] / [i915#265]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [SKIP][142] ([i915#5176]) -> [PASS][143] +1 similar issue
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb4/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [SKIP][144] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb5/igt@kms_psr2_su@frontbuffer-xrgb8888.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb2/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][146] ([fdo#109441]) -> [PASS][147] +1 similar issue
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb5/igt@kms_psr@psr2_sprite_render.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@kms_rotation_crc@primary-rotation-90:
- shard-glk: [DMESG-WARN][148] ([i915#6310]) -> [PASS][149]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-glk7/igt@kms_rotation_crc@primary-rotation-90.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-glk7/igt@kms_rotation_crc@primary-rotation-90.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-skl: [INCOMPLETE][150] ([i915#4939]) -> [PASS][151]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-skl4/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl10/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
* igt@perf_pmu@busy-double-start@rcs0:
- {shard-dg1}: [FAIL][152] ([i915#4349]) -> [PASS][153]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-dg1-13/igt@perf_pmu@busy-double-start@rcs0.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-dg1-12/igt@perf_pmu@busy-double-start@rcs0.html
#### Warnings ####
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [FAIL][154] ([i915#2876]) -> [FAIL][155] ([i915#2842])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-tglb7/igt@gem_exec_fair@basic-pace@rcs0.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-tglb2/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][156] ([i915#588]) -> [SKIP][157] ([i915#658])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb7/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_chamelium@dp-crc-fast:
- shard-skl: [SKIP][158] ([fdo#109271] / [fdo#111827] / [i915#1888]) -> [SKIP][159] ([fdo#109271] / [fdo#111827])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-skl6/igt@kms_chamelium@dp-crc-fast.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl1/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-kbl: [DMESG-WARN][160] ([i915#180]) -> [DMESG-FAIL][161] ([i915#180])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl1/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl7/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][162] ([i915#2920]) -> [SKIP][163] ([i915#658])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
* igt@runner@aborted:
- shard-skl: ([FAIL][164], [FAIL][165]) ([i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][166], [FAIL][167], [FAIL][168], [FAIL][169]) ([i915#2029] / [i915#3002] / [i915#4312] / [i915#5257])
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-skl3/igt@runner@aborted.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-skl6/igt@runner@aborted.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl3/igt@runner@aborted.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl1/igt@runner@aborted.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl6/igt@runner@aborted.html
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-skl3/igt@runner@aborted.html
- shard-apl: ([FAIL][170], [FAIL][171], [FAIL][172], [FAIL][173]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][174], [FAIL][175], [FAIL][176], [FAIL][177], [FAIL][178], [FAIL][179], [FAIL][180], [FAIL][181], [FAIL][182]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-apl2/igt@runner@aborted.html
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-apl3/igt@runner@aborted.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-apl7/igt@runner@aborted.html
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-apl8/igt@runner@aborted.html
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl6/igt@runner@aborted.html
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl8/igt@runner@aborted.html
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl4/igt@runner@aborted.html
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl1/igt@runner@aborted.html
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl2/igt@runner@aborted.html
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl8/igt@runner@aborted.html
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl1/igt@runner@aborted.html
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl6/igt@runner@aborted.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-apl2/igt@runner@aborted.html
- shard-kbl: ([FAIL][183], [FAIL][184], [FAIL][185], [FAIL][186], [FAIL][187], [FAIL][188], [FAIL][189], [FAIL][190], [FAIL][191], [FAIL][192], [FAIL][193], [FAIL][194], [FAIL][195], [FAIL][196], [FAIL][197], [FAIL][198], [FAIL][199], [FAIL][200]) ([fdo#109271] / [i915#180] / [i915#4312] / [i915#5257] / [i915#92]) -> ([FAIL][201], [FAIL][202], [FAIL][203], [FAIL][204], [FAIL][205], [FAIL][206], [FAIL][207], [FAIL][208], [FAIL][209], [FAIL][210], [FAIL][211], [FAIL][212], [FAIL][213]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl7/igt@runner@aborted.html
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl7/igt@runner@aborted.html
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl7/igt@runner@aborted.html
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl1/igt@runner@aborted.html
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl1/igt@runner@aborted.html
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl6/igt@runner@aborted.html
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl4/igt@runner@aborted.html
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl4/igt@runner@aborted.html
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl4/igt@runner@aborted.html
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl1/igt@runner@aborted.html
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl1/igt@runner@aborted.html
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl1/igt@runner@aborted.html
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl4/igt@runner@aborted.html
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl4/igt@runner@aborted.html
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl6/igt@runner@aborted.html
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl1/igt@runner@aborted.html
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl4/igt@runner@aborted.html
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11834/shard-kbl4/igt@runner@aborted.html
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl7/igt@runner@aborted.html
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl1/igt@runner@aborted.html
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl6/igt@runner@aborted.html
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl1/igt@runner@aborted.html
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl4/igt@runner@aborted.html
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl1/igt@runner@aborted.html
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl7/igt@runner@aborted.html
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl1/igt@runner@aborted.html
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl7/igt@runner@aborted.html
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl1/igt@runner@aborted.html
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl1/igt@runner@aborted.html
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl6/igt@runner@aborted.html
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/shard-kbl6/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4462]: https://gitlab.freedesktop.org/drm/intel/issues/4462
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4911]: https://gitlab.freedesktop.org/drm/intel/issues/4911
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5090]: https://gitlab.freedesktop.org/drm/intel/issues/5090
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5776]: https://gitlab.freedesktop.org/drm/intel/issues/5776
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6140]: https://gitlab.freedesktop.org/drm/intel/issues/6140
[i915#6201]: https://gitlab.freedesktop.org/drm/intel/issues/6201
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6310]: https://gitlab.freedesktop.org/drm/intel/issues/6310
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* Linux: CI_DRM_11834 -> Patchwork_105822v1
CI-20190529: 20190529
CI_DRM_11834: 521bf6e9c3ca9405ea53baa3ba0feb597fd24219 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6553: 3cf110f8dcd1f4f02cf84339664b413abdaebf7d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105822v1: 521bf6e9c3ca9405ea53baa3ba0feb597fd24219 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105822v1/index.html
[-- Attachment #2: Type: text/html, Size: 59522 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently
2022-06-30 17:00 ` Ville Syrjälä
@ 2022-07-01 9:53 ` Jani Nikula
0 siblings, 0 replies; 16+ messages in thread
From: Jani Nikula @ 2022-07-01 9:53 UTC (permalink / raw)
To: Ville Syrjälä, Murthy, Arun R; +Cc: intel-gfx@lists.freedesktop.org
On Thu, 30 Jun 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Jun 30, 2022 at 03:50:15PM +0000, Murthy, Arun R wrote:
>> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >
>> > The comments regarding PCH compatibility use long vs.
>> > short names inconsistently. Just use short names always.
>> >
>> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > ---
>> > drivers/gpu/drm/i915/intel_pch.c | 10 +++++-----
>> > 1 file changed, 5 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/intel_pch.c
>> > b/drivers/gpu/drm/i915/intel_pch.c
>> > index e2b2bbdc0714..94446cac6605 100644
>> > --- a/drivers/gpu/drm/i915/intel_pch.c
>> > +++ b/drivers/gpu/drm/i915/intel_pch.c
>> > @@ -25,7 +25,7 @@ intel_pch_type(const struct drm_i915_private
>> > *dev_priv, unsigned short id)
>> > drm_dbg_kms(&dev_priv->drm, "Found PantherPoint
>> > PCH\n");
>> > drm_WARN_ON(&dev_priv->drm,
>> > GRAPHICS_VER(dev_priv) != 6 &&
>> > !IS_IVYBRIDGE(dev_priv));
>> > - /* PantherPoint is CPT compatible */
>> > + /* PPT is CPT compatible */
>>
>>
>> This is not the code but only comment, I feel elaborated names makes it more readable than abbreviation.
>
> We rarely type out the full names for anything.
And we still keep debug logging the full names right there.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: Nuke PCH_MCC
2022-06-30 15:05 ` [Intel-gfx] [PATCH 2/3] drm/i915: Nuke PCH_MCC Ville Syrjala
@ 2022-07-01 9:55 ` Jani Nikula
2022-07-01 12:21 ` Ville Syrjälä
0 siblings, 1 reply; 16+ messages in thread
From: Jani Nikula @ 2022-07-01 9:55 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On Thu, 30 Jun 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> MCC is derived from TGP, and we have no real need to
> differentiate between the two. Thus remove PCH_MCC and
> just declare it to be PCH_TGP compatible.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
> drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
> drivers/gpu/drm/i915/intel_pch.c | 3 ++-
> drivers/gpu/drm/i915/intel_pch.h | 4 +---
> 4 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 272e1bf6006b..2330604b0bcc 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -4179,7 +4179,7 @@ static enum hpd_pin ehl_hpd_pin(struct drm_i915_private *dev_priv,
> if (port == PORT_D)
> return HPD_PORT_A;
>
> - if (HAS_PCH_MCC(dev_priv))
> + if (HAS_PCH_TGP(dev_priv))
> return icl_hpd_pin(dev_priv, port);
>
> return HPD_PORT_A + port - PORT_A;
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 1ae09431f53a..ebd91aa69dd2 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -2852,7 +2852,7 @@ static u8 intel_hdmi_ddc_pin(struct intel_encoder *encoder)
> ddc_pin = rkl_port_to_ddc_pin(dev_priv, port);
> else if (DISPLAY_VER(dev_priv) == 9 && HAS_PCH_TGP(dev_priv))
> ddc_pin = gen9bc_tgp_port_to_ddc_pin(dev_priv, port);
> - else if (HAS_PCH_MCC(dev_priv))
> + else if (IS_JSL_EHL(dev_priv) && HAS_PCH_TGP(dev_priv))
> ddc_pin = mcc_port_to_ddc_pin(dev_priv, port);
Nitpick, mcc_ prefix is now an outlier here, and could be named after
the CPU/PCH combo like above for gen 9 and TGP. But no big deal.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP)
> ddc_pin = icl_port_to_ddc_pin(dev_priv, port);
> diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
> index 94446cac6605..b45c504c6f03 100644
> --- a/drivers/gpu/drm/i915/intel_pch.c
> +++ b/drivers/gpu/drm/i915/intel_pch.c
> @@ -116,7 +116,8 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
> case INTEL_PCH_MCC_DEVICE_ID_TYPE:
> drm_dbg_kms(&dev_priv->drm, "Found Mule Creek Canyon PCH\n");
> drm_WARN_ON(&dev_priv->drm, !IS_JSL_EHL(dev_priv));
> - return PCH_MCC;
> + /* MCC is TGP compatible */
> + return PCH_TGP;
> case INTEL_PCH_TGP_DEVICE_ID_TYPE:
> case INTEL_PCH_TGP2_DEVICE_ID_TYPE:
> drm_dbg_kms(&dev_priv->drm, "Found Tiger Lake LP PCH\n");
> diff --git a/drivers/gpu/drm/i915/intel_pch.h b/drivers/gpu/drm/i915/intel_pch.h
> index b7a8cf409d48..07f6f5517968 100644
> --- a/drivers/gpu/drm/i915/intel_pch.h
> +++ b/drivers/gpu/drm/i915/intel_pch.h
> @@ -24,8 +24,7 @@ enum intel_pch {
> PCH_CNP, /* Cannon/Comet Lake PCH */
> PCH_ICP, /* Ice Lake PCH */
> PCH_JSP, /* Jasper Lake PCH */
> - PCH_MCC, /* Mule Creek Canyon PCH */
> - PCH_TGP, /* Tiger Lake PCH */
> + PCH_TGP, /* Tiger Lake/Mule Creek Canyon PCH */
> PCH_ADP, /* Alder Lake PCH */
>
> /* Fake PCHs, functionality handled on the same PCI dev */
> @@ -69,7 +68,6 @@ enum intel_pch {
> #define HAS_PCH_ADP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ADP)
> #define HAS_PCH_DG1(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_DG1)
> #define HAS_PCH_JSP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_JSP)
> -#define HAS_PCH_MCC(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_MCC)
> #define HAS_PCH_TGP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_TGP)
> #define HAS_PCH_ICP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ICP)
> #define HAS_PCH_CNP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_CNP)
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP
2022-06-30 15:06 ` [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP Ville Syrjala
2022-06-30 15:55 ` Murthy, Arun R
@ 2022-07-01 9:57 ` Jani Nikula
1 sibling, 0 replies; 16+ messages in thread
From: Jani Nikula @ 2022-07-01 9:57 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On Thu, 30 Jun 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> JSP is based on ICP and we don't really need to differentiate
> between the two. So let's just delcare JSP to be ICP.
>
> The only slight change here is for Wa_14011294188 which we
> used to apply for JSP but now we'll only apply to MCC. This
> should be fine since the issue being dealt with was introduced
> in TGP and inherited into MCC. JSP being derived from ICP
> should not need this workaround.
I'll take your word for it.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
> drivers/gpu/drm/i915/intel_pch.c | 3 ++-
> drivers/gpu/drm/i915/intel_pch.h | 4 +---
> 3 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index a9cb27f1c964..589af257edeb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -1608,7 +1608,7 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,
> gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
>
> /* Wa_14011294188:ehl,jsl,tgl,rkl,adl-s */
> - if (INTEL_PCH_TYPE(dev_priv) >= PCH_JSP &&
> + if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP &&
> INTEL_PCH_TYPE(dev_priv) < PCH_DG1)
> intel_de_rmw(dev_priv, SOUTH_DSPCLK_GATE_D, 0,
> PCH_DPMGUNIT_CLOCK_GATE_DISABLE);
> diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
> index b45c504c6f03..0fec25be146a 100644
> --- a/drivers/gpu/drm/i915/intel_pch.c
> +++ b/drivers/gpu/drm/i915/intel_pch.c
> @@ -128,7 +128,8 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
> case INTEL_PCH_JSP_DEVICE_ID_TYPE:
> drm_dbg_kms(&dev_priv->drm, "Found Jasper Lake PCH\n");
> drm_WARN_ON(&dev_priv->drm, !IS_JSL_EHL(dev_priv));
> - return PCH_JSP;
> + /* JSP is ICP compatible */
> + return PCH_ICP;
> case INTEL_PCH_ADP_DEVICE_ID_TYPE:
> case INTEL_PCH_ADP2_DEVICE_ID_TYPE:
> case INTEL_PCH_ADP3_DEVICE_ID_TYPE:
> diff --git a/drivers/gpu/drm/i915/intel_pch.h b/drivers/gpu/drm/i915/intel_pch.h
> index 07f6f5517968..7c8ce9781d1a 100644
> --- a/drivers/gpu/drm/i915/intel_pch.h
> +++ b/drivers/gpu/drm/i915/intel_pch.h
> @@ -22,8 +22,7 @@ enum intel_pch {
> PCH_LPT, /* Lynxpoint/Wildcatpoint PCH */
> PCH_SPT, /* Sunrisepoint/Kaby Lake PCH */
> PCH_CNP, /* Cannon/Comet Lake PCH */
> - PCH_ICP, /* Ice Lake PCH */
> - PCH_JSP, /* Jasper Lake PCH */
> + PCH_ICP, /* Ice Lake/Jasper Lake PCH */
> PCH_TGP, /* Tiger Lake/Mule Creek Canyon PCH */
> PCH_ADP, /* Alder Lake PCH */
>
> @@ -67,7 +66,6 @@ enum intel_pch {
> #define HAS_PCH_DG2(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_DG2)
> #define HAS_PCH_ADP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ADP)
> #define HAS_PCH_DG1(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_DG1)
> -#define HAS_PCH_JSP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_JSP)
> #define HAS_PCH_TGP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_TGP)
> #define HAS_PCH_ICP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ICP)
> #define HAS_PCH_CNP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_CNP)
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: Nuke PCH_MCC
2022-07-01 9:55 ` Jani Nikula
@ 2022-07-01 12:21 ` Ville Syrjälä
2022-07-01 13:51 ` Jani Nikula
0 siblings, 1 reply; 16+ messages in thread
From: Ville Syrjälä @ 2022-07-01 12:21 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Fri, Jul 01, 2022 at 12:55:43PM +0300, Jani Nikula wrote:
> On Thu, 30 Jun 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > MCC is derived from TGP, and we have no real need to
> > differentiate between the two. Thus remove PCH_MCC and
> > just declare it to be PCH_TGP compatible.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
> > drivers/gpu/drm/i915/intel_pch.c | 3 ++-
> > drivers/gpu/drm/i915/intel_pch.h | 4 +---
> > 4 files changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> > index 272e1bf6006b..2330604b0bcc 100644
> > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > @@ -4179,7 +4179,7 @@ static enum hpd_pin ehl_hpd_pin(struct drm_i915_private *dev_priv,
> > if (port == PORT_D)
> > return HPD_PORT_A;
> >
> > - if (HAS_PCH_MCC(dev_priv))
> > + if (HAS_PCH_TGP(dev_priv))
> > return icl_hpd_pin(dev_priv, port);
> >
> > return HPD_PORT_A + port - PORT_A;
> > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> > index 1ae09431f53a..ebd91aa69dd2 100644
> > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> > @@ -2852,7 +2852,7 @@ static u8 intel_hdmi_ddc_pin(struct intel_encoder *encoder)
> > ddc_pin = rkl_port_to_ddc_pin(dev_priv, port);
> > else if (DISPLAY_VER(dev_priv) == 9 && HAS_PCH_TGP(dev_priv))
> > ddc_pin = gen9bc_tgp_port_to_ddc_pin(dev_priv, port);
> > - else if (HAS_PCH_MCC(dev_priv))
> > + else if (IS_JSL_EHL(dev_priv) && HAS_PCH_TGP(dev_priv))
> > ddc_pin = mcc_port_to_ddc_pin(dev_priv, port);
>
> Nitpick, mcc_ prefix is now an outlier here, and could be named after
> the CPU/PCH combo like above for gen 9 and TGP. But no big deal.
I want to rewrite these entirely. They should be doing 99% the same
thing as the foo_hpd_pin() functions, yet they are written in all
various kinds of different ways (none of which match the hpd_pin()
stuff).
Also while looking at that I stumbled on the VBT code doing a
slightly different variant of the same stuff using arrays. And on
top of that we have the VBT AUX CH mapping code as well, written
in yet another style. So I think I want to try to unify it all
to a common approach.
I'm thinking the array approach might be the easiest to parse for
mere mortals, so kinda leaning towards that. What do you think?
Although one hurdle between me and arrays for the VBT AUX CH stuff
is the VBT values which are shifted up into the upper nibble of
the byte. So using those directly would result in giant arrays
which are mostly empty. But I could redefine the VBT values as
just the upper four bits and shift down when parsing the VBT.
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Thanks.
>
>
>
> > else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP)
> > ddc_pin = icl_port_to_ddc_pin(dev_priv, port);
> > diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
> > index 94446cac6605..b45c504c6f03 100644
> > --- a/drivers/gpu/drm/i915/intel_pch.c
> > +++ b/drivers/gpu/drm/i915/intel_pch.c
> > @@ -116,7 +116,8 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
> > case INTEL_PCH_MCC_DEVICE_ID_TYPE:
> > drm_dbg_kms(&dev_priv->drm, "Found Mule Creek Canyon PCH\n");
> > drm_WARN_ON(&dev_priv->drm, !IS_JSL_EHL(dev_priv));
> > - return PCH_MCC;
> > + /* MCC is TGP compatible */
> > + return PCH_TGP;
> > case INTEL_PCH_TGP_DEVICE_ID_TYPE:
> > case INTEL_PCH_TGP2_DEVICE_ID_TYPE:
> > drm_dbg_kms(&dev_priv->drm, "Found Tiger Lake LP PCH\n");
> > diff --git a/drivers/gpu/drm/i915/intel_pch.h b/drivers/gpu/drm/i915/intel_pch.h
> > index b7a8cf409d48..07f6f5517968 100644
> > --- a/drivers/gpu/drm/i915/intel_pch.h
> > +++ b/drivers/gpu/drm/i915/intel_pch.h
> > @@ -24,8 +24,7 @@ enum intel_pch {
> > PCH_CNP, /* Cannon/Comet Lake PCH */
> > PCH_ICP, /* Ice Lake PCH */
> > PCH_JSP, /* Jasper Lake PCH */
> > - PCH_MCC, /* Mule Creek Canyon PCH */
> > - PCH_TGP, /* Tiger Lake PCH */
> > + PCH_TGP, /* Tiger Lake/Mule Creek Canyon PCH */
> > PCH_ADP, /* Alder Lake PCH */
> >
> > /* Fake PCHs, functionality handled on the same PCI dev */
> > @@ -69,7 +68,6 @@ enum intel_pch {
> > #define HAS_PCH_ADP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ADP)
> > #define HAS_PCH_DG1(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_DG1)
> > #define HAS_PCH_JSP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_JSP)
> > -#define HAS_PCH_MCC(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_MCC)
> > #define HAS_PCH_TGP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_TGP)
> > #define HAS_PCH_ICP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ICP)
> > #define HAS_PCH_CNP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_CNP)
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: Nuke PCH_MCC
2022-07-01 12:21 ` Ville Syrjälä
@ 2022-07-01 13:51 ` Jani Nikula
0 siblings, 0 replies; 16+ messages in thread
From: Jani Nikula @ 2022-07-01 13:51 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Fri, 01 Jul 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Jul 01, 2022 at 12:55:43PM +0300, Jani Nikula wrote:
>> On Thu, 30 Jun 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >
>> > MCC is derived from TGP, and we have no real need to
>> > differentiate between the two. Thus remove PCH_MCC and
>> > just declare it to be PCH_TGP compatible.
>> >
>> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
>> > drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
>> > drivers/gpu/drm/i915/intel_pch.c | 3 ++-
>> > drivers/gpu/drm/i915/intel_pch.h | 4 +---
>> > 4 files changed, 5 insertions(+), 6 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
>> > index 272e1bf6006b..2330604b0bcc 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
>> > @@ -4179,7 +4179,7 @@ static enum hpd_pin ehl_hpd_pin(struct drm_i915_private *dev_priv,
>> > if (port == PORT_D)
>> > return HPD_PORT_A;
>> >
>> > - if (HAS_PCH_MCC(dev_priv))
>> > + if (HAS_PCH_TGP(dev_priv))
>> > return icl_hpd_pin(dev_priv, port);
>> >
>> > return HPD_PORT_A + port - PORT_A;
>> > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> > index 1ae09431f53a..ebd91aa69dd2 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> > @@ -2852,7 +2852,7 @@ static u8 intel_hdmi_ddc_pin(struct intel_encoder *encoder)
>> > ddc_pin = rkl_port_to_ddc_pin(dev_priv, port);
>> > else if (DISPLAY_VER(dev_priv) == 9 && HAS_PCH_TGP(dev_priv))
>> > ddc_pin = gen9bc_tgp_port_to_ddc_pin(dev_priv, port);
>> > - else if (HAS_PCH_MCC(dev_priv))
>> > + else if (IS_JSL_EHL(dev_priv) && HAS_PCH_TGP(dev_priv))
>> > ddc_pin = mcc_port_to_ddc_pin(dev_priv, port);
>>
>> Nitpick, mcc_ prefix is now an outlier here, and could be named after
>> the CPU/PCH combo like above for gen 9 and TGP. But no big deal.
>
> I want to rewrite these entirely. They should be doing 99% the same
> thing as the foo_hpd_pin() functions, yet they are written in all
> various kinds of different ways (none of which match the hpd_pin()
> stuff).
>
> Also while looking at that I stumbled on the VBT code doing a
> slightly different variant of the same stuff using arrays. And on
> top of that we have the VBT AUX CH mapping code as well, written
> in yet another style. So I think I want to try to unify it all
> to a common approach.
Ack. I've looked at all of this before, but haven't really come up with
anything neat, just grumbling about how it's split between VBT parsing
and this.
> I'm thinking the array approach might be the easiest to parse for
> mere mortals, so kinda leaning towards that. What do you think?
Sounds good, and it has a better separation of platforms, instead of a
bunch of magic conditions. OTOH I'm not overly enthusiastic about how
dvo_port_to_port() ended up looking, and why it needs to be platform
specific at all, oh well. I think you'll only know for real when you've
played with the code and have half the implementation written...
> Although one hurdle between me and arrays for the VBT AUX CH stuff
> is the VBT values which are shifted up into the upper nibble of
> the byte. So using those directly would result in giant arrays
> which are mostly empty. But I could redefine the VBT values as
> just the upper four bits and shift down when parsing the VBT.
If we can hide that in intel_bios.c or something, should be fine I
think.
BR,
Jani.
>
>>
>> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Thanks.
>
>>
>>
>>
>> > else if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP)
>> > ddc_pin = icl_port_to_ddc_pin(dev_priv, port);
>> > diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
>> > index 94446cac6605..b45c504c6f03 100644
>> > --- a/drivers/gpu/drm/i915/intel_pch.c
>> > +++ b/drivers/gpu/drm/i915/intel_pch.c
>> > @@ -116,7 +116,8 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
>> > case INTEL_PCH_MCC_DEVICE_ID_TYPE:
>> > drm_dbg_kms(&dev_priv->drm, "Found Mule Creek Canyon PCH\n");
>> > drm_WARN_ON(&dev_priv->drm, !IS_JSL_EHL(dev_priv));
>> > - return PCH_MCC;
>> > + /* MCC is TGP compatible */
>> > + return PCH_TGP;
>> > case INTEL_PCH_TGP_DEVICE_ID_TYPE:
>> > case INTEL_PCH_TGP2_DEVICE_ID_TYPE:
>> > drm_dbg_kms(&dev_priv->drm, "Found Tiger Lake LP PCH\n");
>> > diff --git a/drivers/gpu/drm/i915/intel_pch.h b/drivers/gpu/drm/i915/intel_pch.h
>> > index b7a8cf409d48..07f6f5517968 100644
>> > --- a/drivers/gpu/drm/i915/intel_pch.h
>> > +++ b/drivers/gpu/drm/i915/intel_pch.h
>> > @@ -24,8 +24,7 @@ enum intel_pch {
>> > PCH_CNP, /* Cannon/Comet Lake PCH */
>> > PCH_ICP, /* Ice Lake PCH */
>> > PCH_JSP, /* Jasper Lake PCH */
>> > - PCH_MCC, /* Mule Creek Canyon PCH */
>> > - PCH_TGP, /* Tiger Lake PCH */
>> > + PCH_TGP, /* Tiger Lake/Mule Creek Canyon PCH */
>> > PCH_ADP, /* Alder Lake PCH */
>> >
>> > /* Fake PCHs, functionality handled on the same PCI dev */
>> > @@ -69,7 +68,6 @@ enum intel_pch {
>> > #define HAS_PCH_ADP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ADP)
>> > #define HAS_PCH_DG1(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_DG1)
>> > #define HAS_PCH_JSP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_JSP)
>> > -#define HAS_PCH_MCC(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_MCC)
>> > #define HAS_PCH_TGP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_TGP)
>> > #define HAS_PCH_ICP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ICP)
>> > #define HAS_PCH_CNP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_CNP)
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2022-07-01 13:51 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-30 15:05 [Intel-gfx] [PATCH 0/3] drm/i915: PCH type cleanup Ville Syrjala
2022-06-30 15:05 ` [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently Ville Syrjala
2022-06-30 15:50 ` Murthy, Arun R
2022-06-30 17:00 ` Ville Syrjälä
2022-07-01 9:53 ` Jani Nikula
2022-06-30 15:05 ` [Intel-gfx] [PATCH 2/3] drm/i915: Nuke PCH_MCC Ville Syrjala
2022-07-01 9:55 ` Jani Nikula
2022-07-01 12:21 ` Ville Syrjälä
2022-07-01 13:51 ` Jani Nikula
2022-06-30 15:06 ` [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP Ville Syrjala
2022-06-30 15:55 ` Murthy, Arun R
2022-06-30 16:59 ` Ville Syrjälä
2022-07-01 9:57 ` Jani Nikula
2022-06-30 17:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: PCH type cleanup Patchwork
2022-06-30 18:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-01 9:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox