* [Intel-gfx] [PATCH] i915: Increase *_latency array size
@ 2021-05-05 3:37 Andi Kleen
2021-05-05 4:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Andi Kleen @ 2021-05-05 3:37 UTC (permalink / raw)
To: jani.nikula; +Cc: airlied, intel-gfx, dri-devel, Andi Kleen
From: Andi Kleen <andi@firstfloor.org>
Newer gcc prints the following warning:
drivers/gpu/drm/i915/intel_pm.c:3057:9: warning: ‘intel_print_wm_latency’ reading 16 bytes from a region of size 10 [-Wstringop-overread]
and some other related warnings in similar functions.
gcc has a point here. Some of the latency arrays only have 5 members,
but print_wm_latency may read up to max_level returned by ilk_wm_max_level,
which can be upto 7 for the >= GEN9 case.
So it will read some fields beyond the array.
Increase all the latency fields to 8 members, which is enough for SKL.
I don't know if they are correctly initialized upto 8, but dev_priv
should start out as zero, so presumably they will be zero.
Signed-off-by: Andi Kleen <andi@firstfloor.org>
---
drivers/gpu/drm/i915/i915_drv.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index cb62ddba2035..c80add5f6d33 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1095,11 +1095,11 @@ struct drm_i915_private {
* in 0.5us units for WM1+.
*/
/* primary */
- u16 pri_latency[5];
+ u16 pri_latency[8];
/* sprite */
- u16 spr_latency[5];
+ u16 spr_latency[8];
/* cursor */
- u16 cur_latency[5];
+ u16 cur_latency[8];
/*
* Raw watermark memory latency values
* for SKL for all 8 levels
--
2.25.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for i915: Increase *_latency array size 2021-05-05 3:37 [Intel-gfx] [PATCH] i915: Increase *_latency array size Andi Kleen @ 2021-05-05 4:23 ` Patchwork 2021-05-05 5:43 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-05-05 6:32 ` [Intel-gfx] [PATCH] " Jani Nikula 2 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2021-05-05 4:23 UTC (permalink / raw) To: Andi Kleen; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 2239 bytes --] == Series Details == Series: i915: Increase *_latency array size URL : https://patchwork.freedesktop.org/series/89793/ State : success == Summary == CI Bug Log - changes from CI_DRM_10046 -> Patchwork_20064 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/index.html Known issues ------------ Here are the changes found in Patchwork_20064 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_prime@amd-to-i915: - fi-tgl-y: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/fi-tgl-y/igt@amdgpu/amd_prime@amd-to-i915.html - fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/fi-kbl-soraka/igt@amdgpu/amd_prime@amd-to-i915.html * igt@runner@aborted: - fi-bdw-5557u: NOTRUN -> [FAIL][3] ([i915#1602] / [i915#2029]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/fi-bdw-5557u/igt@runner@aborted.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 Participating hosts (45 -> 40) ------------------------------ Missing (5): fi-ilk-m540 fi-cml-s fi-hsw-4200u fi-ctg-p8600 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_10046 -> Patchwork_20064 CI-20190529: 20190529 CI_DRM_10046: dd7bc2f509bb416be13e6c376d676f11ac7fd1ca @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6077: 126a3f6fc0e97786e2819085efc84e741093aed5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_20064: 2440cd7e3b8c7f550e552c753edab579b3b8a1f5 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 2440cd7e3b8c i915: Increase *_latency array size == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/index.html [-- Attachment #1.2: Type: text/html, Size: 2881 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for i915: Increase *_latency array size 2021-05-05 3:37 [Intel-gfx] [PATCH] i915: Increase *_latency array size Andi Kleen 2021-05-05 4:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2021-05-05 5:43 ` Patchwork 2021-05-05 6:32 ` [Intel-gfx] [PATCH] " Jani Nikula 2 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2021-05-05 5:43 UTC (permalink / raw) To: Andi Kleen; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 29042 bytes --] == Series Details == Series: i915: Increase *_latency array size URL : https://patchwork.freedesktop.org/series/89793/ State : success == Summary == CI Bug Log - changes from CI_DRM_10046_full -> Patchwork_20064_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_20064_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_create@create-massive: - shard-skl: NOTRUN -> [DMESG-WARN][1] ([i915#3002]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl7/igt@gem_create@create-massive.html * igt@gem_ctx_persistence@clone: - shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +3 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-snb5/igt@gem_ctx_persistence@clone.html * igt@gem_ctx_persistence@legacy-engines-hostile@render: - shard-iclb: [PASS][3] -> [FAIL][4] ([i915#2410]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-iclb2/igt@gem_ctx_persistence@legacy-engines-hostile@render.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-iclb5/igt@gem_ctx_persistence@legacy-engines-hostile@render.html * igt@gem_ctx_ringsize@active@bcs0: - shard-skl: [PASS][5] -> [INCOMPLETE][6] ([i915#3316]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-skl7/igt@gem_ctx_ringsize@active@bcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl8/igt@gem_ctx_ringsize@active@bcs0.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][7] -> [TIMEOUT][8] ([i915#2369] / [i915#3063]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-tglb1/igt@gem_eio@unwedge-stress.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-tglb8/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-glk: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-glk7/igt@gem_exec_fair@basic-none-rrul@rcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-glk3/igt@gem_exec_fair@basic-none-rrul@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [PASS][11] -> [FAIL][12] ([i915#2842]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-iclb1/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-iclb: NOTRUN -> [FAIL][13] ([i915#2842]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-skl: NOTRUN -> [FAIL][14] ([i915#2389]) +3 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl2/igt@gem_exec_reloc@basic-wide-active@bcs0.html * igt@gem_exec_reloc@basic-wide-active@vcs1: - shard-iclb: NOTRUN -> [FAIL][15] ([i915#2389]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-iclb1/igt@gem_exec_reloc@basic-wide-active@vcs1.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [PASS][16] -> [SKIP][17] ([i915#2190]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-tglb8/igt@gem_huc_copy@huc-copy.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-tglb6/igt@gem_huc_copy@huc-copy.html * igt@gem_mmap_gtt@cpuset-big-copy: - shard-glk: [PASS][18] -> [FAIL][19] ([i915#307]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-glk4/igt@gem_mmap_gtt@cpuset-big-copy.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-glk7/igt@gem_mmap_gtt@cpuset-big-copy.html * igt@gem_mmap_gtt@cpuset-big-copy-xy: - shard-iclb: [PASS][20] -> [FAIL][21] ([i915#2428]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-iclb2/igt@gem_mmap_gtt@cpuset-big-copy-xy.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-iclb2/igt@gem_mmap_gtt@cpuset-big-copy-xy.html * igt@gem_pwrite@basic-exhaustion: - shard-snb: NOTRUN -> [WARN][22] ([i915#2658]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-snb5/igt@gem_pwrite@basic-exhaustion.html * igt@gem_render_copy@x-tiled-to-vebox-yf-tiled: - shard-kbl: NOTRUN -> [SKIP][23] ([fdo#109271]) +66 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl6/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html * igt@gem_userptr_blits@dmabuf-sync: - shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3323]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl8/igt@gem_userptr_blits@dmabuf-sync.html - shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3323]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl6/igt@gem_userptr_blits@dmabuf-sync.html * igt@gem_userptr_blits@vma-merge: - shard-apl: NOTRUN -> [FAIL][26] ([i915#3318]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl6/igt@gem_userptr_blits@vma-merge.html * igt@i915_selftest@live@hangcheck: - shard-snb: [PASS][27] -> [INCOMPLETE][28] ([i915#2782]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-snb2/igt@i915_selftest@live@hangcheck.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-snb2/igt@i915_selftest@live@hangcheck.html * igt@i915_suspend@forcewake: - shard-kbl: NOTRUN -> [DMESG-WARN][29] ([i915#180]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl6/igt@i915_suspend@forcewake.html * igt@kms_big_fb@yf-tiled-addfb: - shard-tglb: NOTRUN -> [SKIP][30] ([fdo#111615]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-tglb2/igt@kms_big_fb@yf-tiled-addfb.html * igt@kms_big_joiner@basic: - shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#2705]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl9/igt@kms_big_joiner@basic.html * igt@kms_ccs@pipe-c-bad-aux-stride: - shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111304]) +2 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl2/igt@kms_ccs@pipe-c-bad-aux-stride.html * igt@kms_chamelium@vga-hpd-after-suspend: - shard-skl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +23 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl6/igt@kms_chamelium@vga-hpd-after-suspend.html * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red: - shard-snb: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +7 similar issues [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html * igt@kms_color_chamelium@pipe-a-ctm-limited-range: - shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +21 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl1/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html * igt@kms_color_chamelium@pipe-a-gamma: - shard-tglb: NOTRUN -> [SKIP][36] ([fdo#109284] / [fdo#111827]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-tglb2/igt@kms_color_chamelium@pipe-a-gamma.html * igt@kms_color_chamelium@pipe-c-ctm-0-25: - shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +6 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl3/igt@kms_color_chamelium@pipe-c-ctm-0-25.html * igt@kms_content_protection@atomic: - shard-apl: NOTRUN -> [TIMEOUT][38] ([i915#1319]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl6/igt@kms_content_protection@atomic.html * igt@kms_cursor_crc@pipe-a-cursor-32x32-rapid-movement: - shard-tglb: NOTRUN -> [SKIP][39] ([i915#3319]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-tglb2/igt@kms_cursor_crc@pipe-a-cursor-32x32-rapid-movement.html * igt@kms_flip@blocking-absolute-wf_vblank@a-edp1: - shard-skl: [PASS][40] -> [DMESG-WARN][41] ([i915#1982]) +1 similar issue [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-skl4/igt@kms_flip@blocking-absolute-wf_vblank@a-edp1.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl8/igt@kms_flip@blocking-absolute-wf_vblank@a-edp1.html * igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1: - shard-skl: NOTRUN -> [FAIL][42] ([i915#2122]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl1/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [PASS][43] -> [DMESG-WARN][44] ([i915#180]) +6 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@plain-flip-fb-recreate@b-edp1: - shard-skl: [PASS][45] -> [FAIL][46] ([i915#2122]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-skl4/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl2/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile: - shard-snb: NOTRUN -> [SKIP][47] ([fdo#109271]) +131 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-snb6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html - shard-skl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#2642]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs: - shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#2672]) +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt: - shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271]) +219 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl9/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html * igt@kms_pipe_crc_basic@read-crc-pipe-d: - shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#533]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl1/igt@kms_pipe_crc_basic@read-crc-pipe-d.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes: - shard-kbl: [PASS][52] -> [DMESG-WARN][53] ([i915#180] / [i915#533]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - shard-skl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265]) +4 similar issues [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb: - shard-skl: NOTRUN -> [FAIL][55] ([i915#265]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max: - shard-apl: NOTRUN -> [FAIL][56] ([fdo#108145] / [i915#265]) +5 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl3/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html - shard-kbl: NOTRUN -> [FAIL][57] ([fdo#108145] / [i915#265]) +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2: - shard-skl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#658]) +5 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-2: - shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#658]) +4 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl2/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3: - shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#658]) +2 similar issues [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html * igt@kms_psr@psr2_primary_mmap_gtt: - shard-iclb: [PASS][61] -> [SKIP][62] ([fdo#109441]) +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-iclb5/igt@kms_psr@psr2_primary_mmap_gtt.html * igt@kms_psr@psr2_sprite_render: - shard-tglb: NOTRUN -> [FAIL][63] ([i915#132]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-tglb2/igt@kms_psr@psr2_sprite_render.html * igt@kms_vblank@pipe-d-wait-idle: - shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#533]) +2 similar issues [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl9/igt@kms_vblank@pipe-d-wait-idle.html * igt@kms_writeback@writeback-check-output: - shard-skl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#2437]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl10/igt@kms_writeback@writeback-check-output.html * igt@kms_writeback@writeback-invalid-parameters: - shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#2437]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl6/igt@kms_writeback@writeback-invalid-parameters.html - shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#2437]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl2/igt@kms_writeback@writeback-invalid-parameters.html * igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame: - shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271]) +214 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl3/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html * igt@perf@polling-parameterized: - shard-skl: NOTRUN -> [FAIL][69] ([i915#1542]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl2/igt@perf@polling-parameterized.html * igt@sysfs_clients@fair-0: - shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#2994]) +3 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl5/igt@sysfs_clients@fair-0.html * igt@sysfs_clients@pidname: - shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#2994]) +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl8/igt@sysfs_clients@pidname.html #### Possible fixes #### * igt@gem_exec_fair@basic-deadline: - shard-glk: [FAIL][72] ([i915#2846]) -> [PASS][73] [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-glk7/igt@gem_exec_fair@basic-deadline.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-glk3/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-tglb: [FAIL][74] ([i915#2842]) -> [PASS][75] +1 similar issue [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-tglb2/igt@gem_exec_fair@basic-none-share@rcs0.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-tglb6/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-kbl: [FAIL][76] ([i915#2842]) -> [PASS][77] [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_mmap_gtt@cpuset-medium-copy-odd: - shard-glk: [FAIL][78] ([i915#307]) -> [PASS][79] [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-glk2/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-glk5/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-kbl: [DMESG-WARN][80] ([i915#180]) -> [PASS][81] +4 similar issues [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html - shard-apl: [DMESG-WARN][82] ([i915#180]) -> [PASS][83] +1 similar issue [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_flip@flip-vs-suspend@a-dp1: - shard-kbl: [INCOMPLETE][84] ([i915#155] / [i915#180]) -> [PASS][85] [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl7/igt@kms_flip@flip-vs-suspend@a-dp1.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl3/igt@kms_flip@flip-vs-suspend@a-dp1.html * igt@kms_hdr@bpc-switch-suspend: - shard-skl: [FAIL][86] ([i915#1188]) -> [PASS][87] [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-skl1/igt@kms_hdr@bpc-switch-suspend.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl6/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [FAIL][88] ([fdo#108145] / [i915#265]) -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: [SKIP][90] ([fdo#109441]) -> [PASS][91] +1 similar issue [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@perf@blocking: - shard-skl: [FAIL][92] ([i915#1542]) -> [PASS][93] [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-skl2/igt@perf@blocking.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl10/igt@perf@blocking.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][94] ([i915#2684]) -> [WARN][95] ([i915#1804] / [i915#2684]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-iclb7/igt@i915_pm_rc6_residency@rc6-fence.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4: - shard-iclb: [SKIP][96] ([i915#2920]) -> [SKIP][97] ([i915#658]) +1 similar issue [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-iclb5/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5: - shard-iclb: [SKIP][98] ([i915#658]) -> [SKIP][99] ([i915#2920]) +1 similar issue [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html * igt@runner@aborted: - shard-kbl: ([FAIL][100], [FAIL][101], [FAIL][102], [FAIL][103], [FAIL][104], [FAIL][105], [FAIL][106], [FAIL][107]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363]) -> ([FAIL][108], [FAIL][109], [FAIL][110], [FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2292] / [i915#2505] / [i915#3002] / [i915#3363]) [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl7/igt@runner@aborted.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl6/igt@runner@aborted.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl4/igt@runner@aborted.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl7/igt@runner@aborted.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl7/igt@runner@aborted.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl6/igt@runner@aborted.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl3/igt@runner@aborted.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-kbl7/igt@runner@aborted.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl2/igt@runner@aborted.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl1/igt@runner@aborted.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl6/igt@runner@aborted.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl2/igt@runner@aborted.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl6/igt@runner@aborted.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl7/igt@runner@aborted.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl4/igt@runner@aborted.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-kbl2/igt@runner@aborted.html - shard-apl: ([FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#62]) -> ([FAIL][122], [FAIL][123]) ([i915#180] / [i915#3002] / [i915#3363]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-apl3/igt@runner@aborted.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-apl8/igt@runner@aborted.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-apl6/igt@runner@aborted.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-apl6/igt@runner@aborted.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-apl6/igt@runner@aborted.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-apl1/igt@runner@aborted.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl3/igt@runner@aborted.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-apl6/igt@runner@aborted.html - shard-skl: ([FAIL][124], [FAIL][125], [FAIL][126]) ([i915#1814] / [i915#2029] / [i915#3002] / [i915#3363]) -> ([FAIL][127], [FAIL][128]) ([i915#3002] / [i915#3363]) [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-skl2/igt@runner@aborted.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-skl1/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10046/shard-skl2/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl7/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/shard-skl1/igt@runner@aborted.html [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292 [i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410 [i915#2428]: https://gitlab.freedesktop.org/drm/intel/issues/2428 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505 [i915#2642]: https://gitlab.freedesktop.org/drm/intel/issues/2642 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063 [i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307 [i915#3316]: https://gitlab.freedesktop.org/drm/intel/issues/3316 [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 [i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319 [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323 [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 Participating hosts (11 -> 11) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_10046 -> Patchwork_20064 CI-20190529: 20190529 CI_DRM_10046: dd7bc2f509bb416be13e6c376d676f11ac7fd1ca @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6077: 126a3f6fc0e97786e2819085efc84e741093aed5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_20064: 2440cd7e3b8c7f550e552c753edab579b3b8a1f5 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20064/index.html [-- Attachment #1.2: Type: text/html, Size: 37168 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Increase *_latency array size 2021-05-05 3:37 [Intel-gfx] [PATCH] i915: Increase *_latency array size Andi Kleen 2021-05-05 4:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-05-05 5:43 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2021-05-05 6:32 ` Jani Nikula 2021-05-05 14:18 ` Andi Kleen 2 siblings, 1 reply; 7+ messages in thread From: Jani Nikula @ 2021-05-05 6:32 UTC (permalink / raw) To: Andi Kleen; +Cc: airlied, intel-gfx, dri-devel, Andi Kleen On Tue, 04 May 2021, Andi Kleen <ak@linux.intel.com> wrote: > From: Andi Kleen <andi@firstfloor.org> > > Newer gcc prints the following warning: > > drivers/gpu/drm/i915/intel_pm.c:3057:9: warning: ‘intel_print_wm_latency’ reading 16 bytes from a region of size 10 [-Wstringop-overread] > and some other related warnings in similar functions. > > gcc has a point here. Some of the latency arrays only have 5 members, > but print_wm_latency may read up to max_level returned by ilk_wm_max_level, > which can be upto 7 for the >= GEN9 case. > > So it will read some fields beyond the array. > > Increase all the latency fields to 8 members, which is enough for SKL. > > I don't know if they are correctly initialized upto 8, but dev_priv > should start out as zero, so presumably they will be zero. Thanks, the warning should be fixed by commit c6deb5e97ded ("drm/i915/pm: Make the wm parameter of print_wm_latency a pointer") in drm-intel-next. There doesn't actually seem to be a bug here, but I wonder if we should send that to stable or v5.13-rc1+ anyway to stop people spending time on the same issue. BR, Jani. > > Signed-off-by: Andi Kleen <andi@firstfloor.org> > --- > drivers/gpu/drm/i915/i915_drv.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index cb62ddba2035..c80add5f6d33 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1095,11 +1095,11 @@ struct drm_i915_private { > * in 0.5us units for WM1+. > */ > /* primary */ > - u16 pri_latency[5]; > + u16 pri_latency[8]; > /* sprite */ > - u16 spr_latency[5]; > + u16 spr_latency[8]; > /* cursor */ > - u16 cur_latency[5]; > + u16 cur_latency[8]; > /* > * Raw watermark memory latency values > * for SKL for all 8 levels -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Increase *_latency array size 2021-05-05 6:32 ` [Intel-gfx] [PATCH] " Jani Nikula @ 2021-05-05 14:18 ` Andi Kleen 2021-05-05 14:25 ` Ville Syrjälä 0 siblings, 1 reply; 7+ messages in thread From: Andi Kleen @ 2021-05-05 14:18 UTC (permalink / raw) To: Jani Nikula; +Cc: airlied, intel-gfx, dri-devel, Andi Kleen > > Increase all the latency fields to 8 members, which is enough for SKL. > > > > I don't know if they are correctly initialized upto 8, but dev_priv > > should start out as zero, so presumably they will be zero. > > Thanks, the warning should be fixed by commit > > c6deb5e97ded ("drm/i915/pm: Make the wm parameter of print_wm_latency a pointer") > > in drm-intel-next. That's just hiding the problem. > > There doesn't actually seem to be a bug here, Can you explain that please? This is the loop in question max_level = ilk_wm_max_level(dev_priv); for (level = 0; level <= max_level; level++) { unsigned int latency = wm[level]; if (latency == 0) { drm_dbg_kms(&dev_priv->drm, "%s WM%d latency not provided\n", name, level); continue; } ... } (no other loop termination condition) and ilk_wm_max_level is int ilk_wm_max_level(const struct drm_i915_private *dev_priv) { /* how many WM levels are we expecting */ if (INTEL_GEN(dev_priv) >= 9) return 7; else if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) return 4; else if (INTEL_GEN(dev_priv) >= 6) return 3; else return 2; } There is no loop termination in the loop above, it will always read every member through the max level reported. And on GEN>=9 it will be 7, while the input array for several of the cases has only 5 members. So it will read beyond the array and gcc is correct in complaining. What do I miss when you say there is no bug? -Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Increase *_latency array size 2021-05-05 14:18 ` Andi Kleen @ 2021-05-05 14:25 ` Ville Syrjälä 2021-05-06 10:23 ` Jani Nikula 0 siblings, 1 reply; 7+ messages in thread From: Ville Syrjälä @ 2021-05-05 14:25 UTC (permalink / raw) To: Andi Kleen; +Cc: airlied, intel-gfx, Andi Kleen, dri-devel On Wed, May 05, 2021 at 07:18:30AM -0700, Andi Kleen wrote: > > > Increase all the latency fields to 8 members, which is enough for SKL. > > > > > > I don't know if they are correctly initialized upto 8, but dev_priv > > > should start out as zero, so presumably they will be zero. > > > > Thanks, the warning should be fixed by commit > > > > c6deb5e97ded ("drm/i915/pm: Make the wm parameter of print_wm_latency a pointer") > > > > in drm-intel-next. > > That's just hiding the problem. > > > > > There doesn't actually seem to be a bug here, > > Can you explain that please? > > This is the loop in question > > max_level = ilk_wm_max_level(dev_priv); > > for (level = 0; level <= max_level; level++) { > unsigned int latency = wm[level]; > > if (latency == 0) { > drm_dbg_kms(&dev_priv->drm, > "%s WM%d latency not provided\n", > name, level); > continue; > } > > ... > } > > (no other loop termination condition) > > and ilk_wm_max_level is > > int ilk_wm_max_level(const struct drm_i915_private *dev_priv) > { > /* how many WM levels are we expecting */ > if (INTEL_GEN(dev_priv) >= 9) > return 7; > else if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) > return 4; > else if (INTEL_GEN(dev_priv) >= 6) > return 3; > else > return 2; > } > > There is no loop termination in the loop above, it will always read > every member through the max level reported. And on GEN>=9 it will be 7, while > the input array for several of the cases has only 5 members. > > So it will read beyond the array and gcc is correct in complaining. > > What do I miss when you say there is no bug? We always use dev_priv->wm.skl_latency[] for gen9+. See {pri,spr,cur}_wm_latency_show(), skl_setup_wm_latency(), etc. -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] i915: Increase *_latency array size 2021-05-05 14:25 ` Ville Syrjälä @ 2021-05-06 10:23 ` Jani Nikula 0 siblings, 0 replies; 7+ messages in thread From: Jani Nikula @ 2021-05-06 10:23 UTC (permalink / raw) To: Ville Syrjälä, Andi Kleen Cc: airlied, intel-gfx, Andi Kleen, dri-devel On Wed, 05 May 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Wed, May 05, 2021 at 07:18:30AM -0700, Andi Kleen wrote: >> What do I miss when you say there is no bug? > > We always use dev_priv->wm.skl_latency[] for gen9+. See > {pri,spr,cur}_wm_latency_show(), skl_setup_wm_latency(), etc. Granted, we should probably make this more obvious and/or pass in the buf size to make it easier to see what's going on. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-05-06 10:23 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-05-05 3:37 [Intel-gfx] [PATCH] i915: Increase *_latency array size Andi Kleen 2021-05-05 4:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-05-05 5:43 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-05-05 6:32 ` [Intel-gfx] [PATCH] " Jani Nikula 2021-05-05 14:18 ` Andi Kleen 2021-05-05 14:25 ` Ville Syrjälä 2021-05-06 10:23 ` Jani Nikula
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox