From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915: Nuke the magic FBC_CONTROL save/restore
Date: Fri, 11 Sep 2020 19:47:00 +0300 [thread overview]
Message-ID: <87o8mcz2ez.fsf@intel.com> (raw)
In-Reply-To: <20200908140210.31048-2-ville.syrjala@linux.intel.com>
On Tue, 08 Sep 2020, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The FBC_CONTROL save restore is there just to preserve the
> compression interval setting. Since commit a68ce21ba0c4
> ("drm/i915/fbc: Store the fbc1 compression interval in the params")
> we've been explicitly setting the interval to a specific
> value, so the sace/restore is now entirely pointless.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Seems legit,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 1 -
> drivers/gpu/drm/i915/i915_suspend.c | 8 --------
> 2 files changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 2e4438e8e3eb..3917bb1a6157 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -537,7 +537,6 @@ struct intel_gmbus {
>
> struct i915_suspend_saved_registers {
> u32 saveDSPARB;
> - u32 saveFBC_CONTROL;
> u32 saveCACHE_MODE_0;
> u32 saveMI_ARB_STATE;
> u32 saveSWF0[16];
> diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915/i915_suspend.c
> index ed2be3489f8e..592c230e6914 100644
> --- a/drivers/gpu/drm/i915/i915_suspend.c
> +++ b/drivers/gpu/drm/i915/i915_suspend.c
> @@ -37,10 +37,6 @@ static void i915_save_display(struct drm_i915_private *dev_priv)
> /* Display arbitration control */
> if (INTEL_GEN(dev_priv) <= 4)
> dev_priv->regfile.saveDSPARB = I915_READ(DSPARB);
> -
> - /* save FBC interval */
> - if (HAS_FBC(dev_priv) && INTEL_GEN(dev_priv) <= 4 && !IS_G4X(dev_priv))
> - dev_priv->regfile.saveFBC_CONTROL = I915_READ(FBC_CONTROL);
> }
>
> static void i915_restore_display(struct drm_i915_private *dev_priv)
> @@ -52,10 +48,6 @@ static void i915_restore_display(struct drm_i915_private *dev_priv)
> /* only restore FBC info on the platform that supports FBC*/
> intel_fbc_global_disable(dev_priv);
>
> - /* restore FBC interval */
> - if (HAS_FBC(dev_priv) && INTEL_GEN(dev_priv) <= 4 && !IS_G4X(dev_priv))
> - I915_WRITE(FBC_CONTROL, dev_priv->regfile.saveFBC_CONTROL);
> -
> intel_vga_redisable(dev_priv);
> }
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-09-11 16:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 14:02 [Intel-gfx] [PATCH 1/4] drm/i915: Kill unused savePCH_PORT_HOTPLUG Ville Syrjala
2020-09-08 14:02 ` [Intel-gfx] [PATCH 2/4] drm/i915: Nuke the magic FBC_CONTROL save/restore Ville Syrjala
2020-09-11 16:47 ` Jani Nikula [this message]
2020-09-08 14:02 ` [Intel-gfx] [PATCH 3/4] drm/i915: Nuke MI_ARB_STATE save/restore Ville Syrjala
2020-09-11 16:48 ` Jani Nikula
2020-09-08 14:02 ` [Intel-gfx] [PATCH 4/4] drm/i915: Nuke CACHE_MODE_0 save/restore Ville Syrjala
2020-09-11 16:50 ` Jani Nikula
2020-09-08 14:28 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Kill unused savePCH_PORT_HOTPLUG Patchwork
2020-09-10 12:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Kill unused savePCH_PORT_HOTPLUG (rev2) Patchwork
2020-09-10 14:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-09-11 16:41 ` [Intel-gfx] [PATCH 1/4] drm/i915: Kill unused savePCH_PORT_HOTPLUG Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8mcz2ez.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox