Re: [Intel-gfx] [PATCH 12/15] drm/i915/bios: Split VBT data into per-panel vs. global parts

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 10 May 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Move the panel specific VBT parsing to happen during the
> output probing stage. Needs to be done because the VBT
> parsing will need to look at the EDID to determine
> the correct panel_type on some machines.
>
> We split the parsed VBT data (i915->vbt) along the same
> boundary. For the moment we just hoist all the panel
> specific stuff into connector->panel.vbt since that seems
> like the most convenient place for eg. the backlight code.

For a lot of stuff I was thinking we'd hang this stuff off of the
encoder, but I guess for panel stuff this makes sense. Child device
stuff in the encoder then.

>  drivers/gpu/drm/i915/i915_drv.h               |  63 ---

Gotta love this.

> diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c b/drivers/gpu/drm/i915/display/intel_drrs.c
> index 166caf293f7b..7da4a9cbe4ba 100644
> --- a/drivers/gpu/drm/i915/display/intel_drrs.c
> +++ b/drivers/gpu/drm/i915/display/intel_drrs.c
> @@ -217,9 +217,6 @@ static void intel_drrs_frontbuffer_update(struct drm_i915_private *dev_priv,
>  {
>  	struct intel_crtc *crtc;
>  
> -	if (dev_priv->vbt.drrs_type != DRRS_TYPE_SEAMLESS)
> -		return;

I think this was the only unexplained thing in the entire monster patch
that I could spot. With that explained, even just in reply,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> -
>  	for_each_intel_crtc(&dev_priv->drm, crtc) {
>  		unsigned int frontbuffer_bits;
>  

-- 
Jani Nikula, Intel Open Source Graphics Center