From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 16/17] drm/i915: Nuke buf_trans hdmi functions
Date: Wed, 23 Jun 2021 17:14:35 +0300 [thread overview]
Message-ID: <87r1gsu0qc.fsf@intel.com> (raw)
In-Reply-To: <20210608073603.2408-17-ville.syrjala@linux.intel.com>
On Tue, 08 Jun 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> All the foo_get_buf_trans_hdmi() functions just reuturn a single table.
> Remove the pointless wrappers.
>
> v2: Handle adl-p
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Less is more.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> .../drm/i915/display/intel_ddi_buf_trans.c | 51 +++----------------
> 1 file changed, 7 insertions(+), 44 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> index 2bd51ce4aa2c..a456823df102 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> @@ -1294,15 +1294,6 @@ cnl_get_buf_trans(struct intel_encoder *encoder,
> return cnl_get_buf_trans_dp(encoder, n_entries);
> }
>
> -static const struct intel_ddi_buf_trans *
> -icl_get_combo_buf_trans_hdmi(struct intel_encoder *encoder,
> - const struct intel_crtc_state *crtc_state,
> - int *n_entries)
> -{
> - return intel_get_buf_trans(&icl_combo_phy_ddi_translations_hdmi,
> - n_entries);
> -}
> -
> static const struct intel_ddi_buf_trans *
> icl_get_combo_buf_trans_dp(struct intel_encoder *encoder,
> const struct intel_crtc_state *crtc_state,
> @@ -1336,22 +1327,13 @@ icl_get_combo_buf_trans(struct intel_encoder *encoder,
> int *n_entries)
> {
> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
> - return icl_get_combo_buf_trans_hdmi(encoder, crtc_state, n_entries);
> + return intel_get_buf_trans(&icl_combo_phy_ddi_translations_hdmi, n_entries);
> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP))
> return icl_get_combo_buf_trans_edp(encoder, crtc_state, n_entries);
> else
> return icl_get_combo_buf_trans_dp(encoder, crtc_state, n_entries);
> }
>
> -static const struct intel_ddi_buf_trans *
> -icl_get_mg_buf_trans_hdmi(struct intel_encoder *encoder,
> - const struct intel_crtc_state *crtc_state,
> - int *n_entries)
> -{
> - return intel_get_buf_trans(&icl_mg_phy_ddi_translations_hdmi,
> - n_entries);
> -}
> -
> static const struct intel_ddi_buf_trans *
> icl_get_mg_buf_trans_dp(struct intel_encoder *encoder,
> const struct intel_crtc_state *crtc_state,
> @@ -1372,12 +1354,11 @@ icl_get_mg_buf_trans(struct intel_encoder *encoder,
> int *n_entries)
> {
> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
> - return icl_get_mg_buf_trans_hdmi(encoder, crtc_state, n_entries);
> + return intel_get_buf_trans(&icl_mg_phy_ddi_translations_hdmi, n_entries);
> else
> return icl_get_mg_buf_trans_dp(encoder, crtc_state, n_entries);
> }
>
> -
> static const struct intel_ddi_buf_trans *
> ehl_get_combo_buf_trans_edp(struct intel_encoder *encoder,
> const struct intel_crtc_state *crtc_state,
> @@ -1432,15 +1413,6 @@ jsl_get_combo_buf_trans(struct intel_encoder *encoder,
> return intel_get_buf_trans(&icl_combo_phy_ddi_translations_dp_hbr2_edp_hbr3, n_entries);
> }
>
> -static const struct intel_ddi_buf_trans *
> -tgl_get_combo_buf_trans_hdmi(struct intel_encoder *encoder,
> - const struct intel_crtc_state *crtc_state,
> - int *n_entries)
> -{
> - return intel_get_buf_trans(&icl_combo_phy_ddi_translations_hdmi,
> - n_entries);
> -}
> -
> static const struct intel_ddi_buf_trans *
> tgl_get_combo_buf_trans_dp(struct intel_encoder *encoder,
> const struct intel_crtc_state *crtc_state,
> @@ -1490,7 +1462,7 @@ tgl_get_combo_buf_trans(struct intel_encoder *encoder,
> int *n_entries)
> {
> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
> - return tgl_get_combo_buf_trans_hdmi(encoder, crtc_state, n_entries);
> + return intel_get_buf_trans(&icl_combo_phy_ddi_translations_hdmi, n_entries);
> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP))
> return tgl_get_combo_buf_trans_edp(encoder, crtc_state, n_entries);
> else
> @@ -1537,7 +1509,7 @@ dg1_get_combo_buf_trans(struct intel_encoder *encoder,
> int *n_entries)
> {
> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
> - return icl_get_combo_buf_trans_hdmi(encoder, crtc_state, n_entries);
> + return intel_get_buf_trans(&icl_combo_phy_ddi_translations_hdmi, n_entries);
> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP))
> return dg1_get_combo_buf_trans_edp(encoder, crtc_state, n_entries);
> else
> @@ -1583,22 +1555,13 @@ rkl_get_combo_buf_trans(struct intel_encoder *encoder,
> int *n_entries)
> {
> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
> - return tgl_get_combo_buf_trans_hdmi(encoder, crtc_state, n_entries);
> + return intel_get_buf_trans(&icl_combo_phy_ddi_translations_hdmi, n_entries);
> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP))
> return rkl_get_combo_buf_trans_edp(encoder, crtc_state, n_entries);
> else
> return rkl_get_combo_buf_trans_dp(encoder, crtc_state, n_entries);
> }
>
> -static const struct intel_ddi_buf_trans *
> -tgl_get_dkl_buf_trans_hdmi(struct intel_encoder *encoder,
> - const struct intel_crtc_state *crtc_state,
> - int *n_entries)
> -{
> - return intel_get_buf_trans(&tgl_dkl_phy_ddi_translations_hdmi,
> - n_entries);
> -}
> -
> static const struct intel_ddi_buf_trans *
> tgl_get_dkl_buf_trans_dp(struct intel_encoder *encoder,
> const struct intel_crtc_state *crtc_state,
> @@ -1619,7 +1582,7 @@ tgl_get_dkl_buf_trans(struct intel_encoder *encoder,
> int *n_entries)
> {
> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
> - return tgl_get_dkl_buf_trans_hdmi(encoder, crtc_state, n_entries);
> + return intel_get_buf_trans(&tgl_dkl_phy_ddi_translations_hdmi, n_entries);
> else
> return tgl_get_dkl_buf_trans_dp(encoder, crtc_state, n_entries);
> }
> @@ -1644,7 +1607,7 @@ adlp_get_dkl_buf_trans(struct intel_encoder *encoder,
> int *n_entries)
> {
> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
> - return tgl_get_dkl_buf_trans_hdmi(encoder, crtc_state, n_entries);
> + return intel_get_buf_trans(&tgl_dkl_phy_ddi_translations_hdmi, n_entries);
> else
> return adlp_get_dkl_buf_trans_dp(encoder, crtc_state, n_entries);
> }
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-23 14:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 7:35 [Intel-gfx] [PATCH v2 00/17] drm/i915: DDI buf trans cleaup and fixes Ville Syrjala
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 01/17] drm/i915: s/intel/hsw/ for hsw/bdw/skl buf trans Ville Syrjala
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 02/17] drm/i915: Introduce hsw_get_buf_trans() Ville Syrjala
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 03/17] drm/i915: Wrap the platform specific buf trans structs into a union Ville Syrjala
2021-06-18 12:04 ` Jani Nikula
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 04/17] drm/i915: Rename dkl phy buf trans tables Ville Syrjala
2021-06-18 12:04 ` Jani Nikula
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 05/17] drm/i915: Wrap the buf trans tables into a struct Ville Syrjala
2021-06-18 12:05 ` Jani Nikula
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 06/17] drm/i915: Introduce intel_get_buf_trans() Ville Syrjala
2021-06-18 12:08 ` Jani Nikula
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 07/17] drm/i915; Return the whole buf_trans struct from get_buf_trans() Ville Syrjala
2021-06-18 12:11 ` Jani Nikula
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 08/17] drm/i915: Store the HDMI default entry in the bug trans struct Ville Syrjala
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 09/17] drm/i915: Introduce encoder->get_buf_trans() Ville Syrjala
2021-06-18 12:19 ` Jani Nikula
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 10/17] drm/i915: Clean up hsw/bdw/skl/kbl buf trans funcs Ville Syrjala
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 11/17] drm/i915: Introduce rkl_get_combo_buf_trans() Ville Syrjala
2021-06-18 12:22 ` Jani Nikula
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 12/17] drm/i915: Fix dg1 buf trans tables Ville Syrjala
2021-06-18 12:28 ` Jani Nikula
2021-06-08 7:35 ` [Intel-gfx] [PATCH v2 13/17] drm/i915: Deduplicate icl DP HBR2 vs. eDP HBR3 table Ville Syrjala
2021-06-18 12:30 ` Jani Nikula
2021-06-23 12:55 ` Ville Syrjälä
2021-06-08 7:36 ` [Intel-gfx] [PATCH v2 14/17] drm/i915: Fix ehl edp hbr2 vswing table Ville Syrjala
2021-06-23 14:02 ` Jani Nikula
2021-06-08 7:36 ` [Intel-gfx] [PATCH v2 15/17] drm/i915: Clean up jsl/ehl buf trans functions Ville Syrjala
2021-06-23 14:13 ` Jani Nikula
2021-06-24 17:05 ` Ville Syrjälä
2021-06-08 7:36 ` [Intel-gfx] [PATCH v2 16/17] drm/i915: Nuke buf_trans hdmi functions Ville Syrjala
2021-06-23 14:14 ` Jani Nikula [this message]
2021-06-08 7:36 ` [Intel-gfx] [PATCH v2 17/17] drm/i915: Add the missing adls vswing tables Ville Syrjala
2021-06-23 14:36 ` Jani Nikula
2021-06-08 8:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: DDI buf trans cleaup and fixes (rev4) Patchwork
2021-06-08 8:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-06-08 9:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-06-08 9:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2021-06-08 13:33 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1gsu0qc.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox