public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/pxp: fix non-optimised !CONFIG_DRM_I915_PXP build
@ 2024-11-03 11:02 Jonathan Gray
  2024-11-04 10:16 ` Jani Nikula
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Jonathan Gray @ 2024-11-03 11:02 UTC (permalink / raw)
  To: alan.previn.teres.alexis
  Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, intel-gfx,
	dri-devel

intel_pxp_gsccs_is_ready_for_sessions() is gated by CONFIG_DRM_I915_PXP
but called from intel_pxp.c which isn't.  Provide a fallback inline
function to fix the non-optimised build.

Fixes: 99afb7cc8c44 ("drm/i915/pxp: Add ARB session creation and cleanup")
Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
---
 drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.h b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.h
index 9aae779c4da3..b93488e99685 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.h
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.h
@@ -16,26 +16,30 @@ struct intel_pxp;
 #define GSC_PENDING_RETRY_PAUSE_MS 50
 #define GSCFW_MAX_ROUND_TRIP_LATENCY_MS (GSC_HECI_REPLY_LATENCY_MS + \
 					 (GSC_PENDING_RETRY_MAXCOUNT * GSC_PENDING_RETRY_PAUSE_MS))
 
 #ifdef CONFIG_DRM_I915_PXP
 void intel_pxp_gsccs_fini(struct intel_pxp *pxp);
 int intel_pxp_gsccs_init(struct intel_pxp *pxp);
+bool intel_pxp_gsccs_is_ready_for_sessions(struct intel_pxp *pxp);
 
 int intel_pxp_gsccs_create_session(struct intel_pxp *pxp, int arb_session_id);
 void intel_pxp_gsccs_end_arb_fw_session(struct intel_pxp *pxp, u32 arb_session_id);
 
 #else
 static inline void intel_pxp_gsccs_fini(struct intel_pxp *pxp)
 {
 }
 
 static inline int intel_pxp_gsccs_init(struct intel_pxp *pxp)
 {
 	return 0;
 }
 
-#endif
+static inline bool intel_pxp_gsccs_is_ready_for_sessions(struct intel_pxp *pxp)
+{
+	return false;
+}
 
-bool intel_pxp_gsccs_is_ready_for_sessions(struct intel_pxp *pxp);
+#endif
 
 #endif /*__INTEL_PXP_GSCCS_H__ */
-- 
2.47.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-05-06 14:45 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-03 11:02 [PATCH] drm/i915/pxp: fix non-optimised !CONFIG_DRM_I915_PXP build Jonathan Gray
2024-11-04 10:16 ` Jani Nikula
2024-11-04 11:44   ` Jonathan Gray
2024-11-04 13:40     ` Jani Nikula
2024-11-04 14:20 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-11-05  1:35 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-05  9:23 ` [PATCH] " Jani Nikula
2025-05-06 12:42   ` Jonathan Gray
2025-05-06 13:04     ` Jani Nikula
2025-05-06 14:45       ` Jonathan Gray

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox