public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/selftest: Disable IRQ for timestamp calculation
@ 2021-11-30 13:20 Anshuman Gupta
  2021-11-30 14:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest: Disable IRQ for timestamp calculation (rev3) Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Anshuman Gupta @ 2021-11-30 13:20 UTC (permalink / raw)
  To: intel-gfx; +Cc: Chris P Wilson

gt_pm selftest calculates engine ticks cycles and wall time
cycles by delta of respective engine elapsed TIMESTAMP and ktime
for period of 1000us.
It compares the engine ticks cycles with wall time cycles.

Disable local cpu interrupt so that interrupt handler does not
switch out the thread during measure_clocks() and prevent
miscalculation of engine tick cycles.

v2:
- nuke preempt_{disable,enable}, as disable_local_irq()
  disable the preemption. (Chris)

Cc: Chris P Wilson <chris.p.wilson@intel.com>
Cc: Badal Nilawar <badal.nilawar@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_gt_pm.c b/drivers/gpu/drm/i915/gt/selftest_gt_pm.c
index b9441217ca3d..55c5cdb99f45 100644
--- a/drivers/gpu/drm/i915/gt/selftest_gt_pm.c
+++ b/drivers/gpu/drm/i915/gt/selftest_gt_pm.c
@@ -43,7 +43,7 @@ static void measure_clocks(struct intel_engine_cs *engine,
 	int i;
 
 	for (i = 0; i < 5; i++) {
-		preempt_disable();
+		local_irq_disable();
 		cycles[i] = -ENGINE_READ_FW(engine, RING_TIMESTAMP);
 		dt[i] = ktime_get();
 
@@ -51,7 +51,7 @@ static void measure_clocks(struct intel_engine_cs *engine,
 
 		dt[i] = ktime_sub(ktime_get(), dt[i]);
 		cycles[i] += ENGINE_READ_FW(engine, RING_TIMESTAMP);
-		preempt_enable();
+		local_irq_enable();
 	}
 
 	/* Use the median of both cycle/dt; close enough */
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-12-03 16:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-30 13:20 [Intel-gfx] [PATCH] drm/i915/selftest: Disable IRQ for timestamp calculation Anshuman Gupta
2021-11-30 14:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest: Disable IRQ for timestamp calculation (rev3) Patchwork
2021-11-30 18:29 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-12-03  8:40   ` Anshuman Gupta
2021-12-03 16:38     ` Vudum, Lakshminarayana
2021-12-02  1:34 ` [Intel-gfx] [PATCH] drm/i915/selftest: Disable IRQ for timestamp calculation Dixit, Ashutosh
2021-12-03 16:30 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftest: Disable IRQ for timestamp calculation (rev3) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox