public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH v4] drm/i915/skl: Implement the skl version of MMIO flips
@ 2014-11-20 13:48 Damien Lespiau
  2014-11-20 14:45 ` Ville Syrjälä
  2014-11-22  8:43 ` [PATCH v4] " shuang.he
  0 siblings, 2 replies; 7+ messages in thread
From: Damien Lespiau @ 2014-11-20 13:48 UTC (permalink / raw)
  To: intel-gfx

Because the plane registers are different in Skylake we need to adapt
the MMIO code as well.

v2: Don't introduce yet another vfunc when the direction is do
consolidate the plane updates to use the same code path (Daniel)

v3:
  - Use enum pipe instead of int (Ville)
  - Also update PLANE_STRIDE when the tiling has changed (Ville)
  - Put intel_mark_page_flip_active() in the shared code (Damien)

v4:
  - Remove unused variable

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 64 ++++++++++++++++++++++++++++++++----
 1 file changed, 57 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index c0af4c6..9a52d7e 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9436,22 +9436,50 @@ static bool use_mmio_flip(struct intel_engine_cs *ring,
 		return ring != obj->ring;
 }
 
-static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
+static void skl_do_mmio_flip(struct intel_crtc *intel_crtc)
+{
+       struct drm_device *dev = intel_crtc->base.dev;
+       struct drm_i915_private *dev_priv = dev->dev_private;
+       struct drm_framebuffer *fb = intel_crtc->base.primary->fb;
+       struct intel_framebuffer *intel_fb = to_intel_framebuffer(fb);
+       struct drm_i915_gem_object *obj = intel_fb->obj;
+       const enum pipe pipe = intel_crtc->pipe;
+       u32 ctl, stride;
+
+       ctl = I915_READ(PLANE_CTL(pipe, 0));
+       ctl &= ~PLANE_CTL_TILED_MASK;
+       if (obj->tiling_mode == I915_TILING_X)
+               ctl |= PLANE_CTL_TILED_X;
+
+	/*
+	 * The stride is either expressed as a multiple of 64 bytes chunks for
+	 * linear buffers or in number of tiles for tiled buffers.
+	 */
+       stride = fb->pitches[0] >> 6;
+       if (obj->tiling_mode == I915_TILING_X)
+		stride = fb->pitches[0] >> 9; /* X tiles are 512 bytes wide */
+
+	/*
+	 * Both PLANE_CTL and PLANE_STRIDE are not updated on vblank but on
+	 * PLANE_SURF updates, the update is then guaranteed to be atomic.
+	 */
+       I915_WRITE(PLANE_CTL(pipe, 0), ctl);
+       I915_WRITE(PLANE_STRIDE(pipe, 0), stride);
+
+       I915_WRITE(PLANE_SURF(pipe, 0), intel_crtc->unpin_work->gtt_offset);
+       POSTING_READ(PLANE_SURF(pipe, 0));
+}
+
+static void ilk_do_mmio_flip(struct intel_crtc *intel_crtc)
 {
 	struct drm_device *dev = intel_crtc->base.dev;
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	struct intel_framebuffer *intel_fb =
 		to_intel_framebuffer(intel_crtc->base.primary->fb);
 	struct drm_i915_gem_object *obj = intel_fb->obj;
-	bool atomic_update;
-	u32 start_vbl_count;
 	u32 dspcntr;
 	u32 reg;
 
-	intel_mark_page_flip_active(intel_crtc);
-
-	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);
-
 	reg = DSPCNTR(intel_crtc->plane);
 	dspcntr = I915_READ(reg);
 
@@ -9466,6 +9494,28 @@ static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
 		   intel_crtc->unpin_work->gtt_offset);
 	POSTING_READ(DSPSURF(intel_crtc->plane));
 
+}
+
+/*
+ * XXX: This is the temporary way to update the plane registers until we get
+ * around to using the usual plane update functions for MMIO flips
+ */
+static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
+{
+	struct drm_device *dev = intel_crtc->base.dev;
+	bool atomic_update;
+	u32 start_vbl_count;
+
+	intel_mark_page_flip_active(intel_crtc);
+
+	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);
+
+	if (INTEL_INFO(dev)->gen >= 9)
+		skl_do_mmio_flip(intel_crtc);
+	else
+		/* use_mmio_flip() retricts MMIO flips to ilk+ */
+		ilk_do_mmio_flip(intel_crtc);
+
 	if (atomic_update)
 		intel_pipe_update_end(intel_crtc, start_vbl_count);
 }
-- 
1.8.3.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v4] drm/i915/skl: Implement the skl version of MMIO flips
  2014-11-20 13:48 [PATCH v4] drm/i915/skl: Implement the skl version of MMIO flips Damien Lespiau
@ 2014-11-20 14:45 ` Ville Syrjälä
  2014-11-20 14:54   ` Damien Lespiau
  2014-11-20 14:58   ` [PATCH v5] " Damien Lespiau
  2014-11-22  8:43 ` [PATCH v4] " shuang.he
  1 sibling, 2 replies; 7+ messages in thread
From: Ville Syrjälä @ 2014-11-20 14:45 UTC (permalink / raw)
  To: Damien Lespiau; +Cc: intel-gfx

On Thu, Nov 20, 2014 at 01:48:35PM +0000, Damien Lespiau wrote:
> Because the plane registers are different in Skylake we need to adapt
> the MMIO code as well.
> 
> v2: Don't introduce yet another vfunc when the direction is do
> consolidate the plane updates to use the same code path (Daniel)
> 
> v3:
>   - Use enum pipe instead of int (Ville)
>   - Also update PLANE_STRIDE when the tiling has changed (Ville)
>   - Put intel_mark_page_flip_active() in the shared code (Damien)
> 
> v4:
>   - Remove unused variable
> 
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Looks OK. I'm not super happy about looking at plane->fb here, but the
code already did that. And it should work as long as we don't allow
queuing multiple flips and the plane->fb gets update after the pending
flip wait. But as the comment now says this is a temporary solution and
should hopefully get sorted out in the end.

The patch seems whitespace damaged though (lots of spaces where tabs
should be). With that fixed:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_display.c | 64 ++++++++++++++++++++++++++++++++----
>  1 file changed, 57 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index c0af4c6..9a52d7e 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9436,22 +9436,50 @@ static bool use_mmio_flip(struct intel_engine_cs *ring,
>  		return ring != obj->ring;
>  }
>  
> -static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
> +static void skl_do_mmio_flip(struct intel_crtc *intel_crtc)
> +{
> +       struct drm_device *dev = intel_crtc->base.dev;
> +       struct drm_i915_private *dev_priv = dev->dev_private;
> +       struct drm_framebuffer *fb = intel_crtc->base.primary->fb;
> +       struct intel_framebuffer *intel_fb = to_intel_framebuffer(fb);
> +       struct drm_i915_gem_object *obj = intel_fb->obj;
> +       const enum pipe pipe = intel_crtc->pipe;
> +       u32 ctl, stride;
> +
> +       ctl = I915_READ(PLANE_CTL(pipe, 0));
> +       ctl &= ~PLANE_CTL_TILED_MASK;
> +       if (obj->tiling_mode == I915_TILING_X)
> +               ctl |= PLANE_CTL_TILED_X;
> +
> +	/*
> +	 * The stride is either expressed as a multiple of 64 bytes chunks for
> +	 * linear buffers or in number of tiles for tiled buffers.
> +	 */
> +       stride = fb->pitches[0] >> 6;
> +       if (obj->tiling_mode == I915_TILING_X)
> +		stride = fb->pitches[0] >> 9; /* X tiles are 512 bytes wide */
> +
> +	/*
> +	 * Both PLANE_CTL and PLANE_STRIDE are not updated on vblank but on
> +	 * PLANE_SURF updates, the update is then guaranteed to be atomic.
> +	 */
> +       I915_WRITE(PLANE_CTL(pipe, 0), ctl);
> +       I915_WRITE(PLANE_STRIDE(pipe, 0), stride);
> +
> +       I915_WRITE(PLANE_SURF(pipe, 0), intel_crtc->unpin_work->gtt_offset);
> +       POSTING_READ(PLANE_SURF(pipe, 0));
> +}
> +
> +static void ilk_do_mmio_flip(struct intel_crtc *intel_crtc)
>  {
>  	struct drm_device *dev = intel_crtc->base.dev;
>  	struct drm_i915_private *dev_priv = dev->dev_private;
>  	struct intel_framebuffer *intel_fb =
>  		to_intel_framebuffer(intel_crtc->base.primary->fb);
>  	struct drm_i915_gem_object *obj = intel_fb->obj;
> -	bool atomic_update;
> -	u32 start_vbl_count;
>  	u32 dspcntr;
>  	u32 reg;
>  
> -	intel_mark_page_flip_active(intel_crtc);
> -
> -	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);
> -
>  	reg = DSPCNTR(intel_crtc->plane);
>  	dspcntr = I915_READ(reg);
>  
> @@ -9466,6 +9494,28 @@ static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
>  		   intel_crtc->unpin_work->gtt_offset);
>  	POSTING_READ(DSPSURF(intel_crtc->plane));
>  
> +}
> +
> +/*
> + * XXX: This is the temporary way to update the plane registers until we get
> + * around to using the usual plane update functions for MMIO flips
> + */
> +static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
> +{
> +	struct drm_device *dev = intel_crtc->base.dev;
> +	bool atomic_update;
> +	u32 start_vbl_count;
> +
> +	intel_mark_page_flip_active(intel_crtc);
> +
> +	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);
> +
> +	if (INTEL_INFO(dev)->gen >= 9)
> +		skl_do_mmio_flip(intel_crtc);
> +	else
> +		/* use_mmio_flip() retricts MMIO flips to ilk+ */
> +		ilk_do_mmio_flip(intel_crtc);
> +
>  	if (atomic_update)
>  		intel_pipe_update_end(intel_crtc, start_vbl_count);
>  }
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v4] drm/i915/skl: Implement the skl version of MMIO flips
  2014-11-20 14:45 ` Ville Syrjälä
@ 2014-11-20 14:54   ` Damien Lespiau
  2014-11-20 14:58   ` [PATCH v5] " Damien Lespiau
  1 sibling, 0 replies; 7+ messages in thread
From: Damien Lespiau @ 2014-11-20 14:54 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

On Thu, Nov 20, 2014 at 04:45:52PM +0200, Ville Syrjälä wrote:
> The patch seems whitespace damaged though (lots of spaces where tabs
> should be). With that fixed:

Oh my, I have no idea how this happnened. Oh well.

> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks!

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v5] drm/i915/skl: Implement the skl version of MMIO flips
  2014-11-20 14:45 ` Ville Syrjälä
  2014-11-20 14:54   ` Damien Lespiau
@ 2014-11-20 14:58   ` Damien Lespiau
  2014-11-21 17:52     ` Daniel Vetter
  2014-11-22 11:06     ` [PATCH v5] drm/i915/skl: Implement the skl version of shuang.he
  1 sibling, 2 replies; 7+ messages in thread
From: Damien Lespiau @ 2014-11-20 14:58 UTC (permalink / raw)
  To: intel-gfx

Because the plane registers are different in Skylake we need to adapt
the MMIO code as well.

v2: Don't introduce yet another vfunc when the direction is do
consolidate the plane updates to use the same code path (Daniel)

v3:
  - Use enum pipe instead of int (Ville)
  - Also update PLANE_STRIDE when the tiling has changed (Ville)
  - Put intel_mark_page_flip_active() in the shared code (Damien)

v4:
  - Remove unused variable

v5:
  - Fix whitespace Vs tabs (Ville)

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 64 ++++++++++++++++++++++++++++++++----
 1 file changed, 57 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index c0af4c6..211243b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9436,22 +9436,50 @@ static bool use_mmio_flip(struct intel_engine_cs *ring,
 		return ring != obj->ring;
 }
 
-static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
+static void skl_do_mmio_flip(struct intel_crtc *intel_crtc)
+{
+	struct drm_device *dev = intel_crtc->base.dev;
+	struct drm_i915_private *dev_priv = dev->dev_private;
+	struct drm_framebuffer *fb = intel_crtc->base.primary->fb;
+	struct intel_framebuffer *intel_fb = to_intel_framebuffer(fb);
+	struct drm_i915_gem_object *obj = intel_fb->obj;
+	const enum pipe pipe = intel_crtc->pipe;
+	u32 ctl, stride;
+
+	ctl = I915_READ(PLANE_CTL(pipe, 0));
+	ctl &= ~PLANE_CTL_TILED_MASK;
+	if (obj->tiling_mode == I915_TILING_X)
+		ctl |= PLANE_CTL_TILED_X;
+
+	/*
+	 * The stride is either expressed as a multiple of 64 bytes chunks for
+	 * linear buffers or in number of tiles for tiled buffers.
+	 */
+	stride = fb->pitches[0] >> 6;
+	if (obj->tiling_mode == I915_TILING_X)
+		stride = fb->pitches[0] >> 9; /* X tiles are 512 bytes wide */
+
+	/*
+	 * Both PLANE_CTL and PLANE_STRIDE are not updated on vblank but on
+	 * PLANE_SURF updates, the update is then guaranteed to be atomic.
+	 */
+	I915_WRITE(PLANE_CTL(pipe, 0), ctl);
+	I915_WRITE(PLANE_STRIDE(pipe, 0), stride);
+
+	I915_WRITE(PLANE_SURF(pipe, 0), intel_crtc->unpin_work->gtt_offset);
+	POSTING_READ(PLANE_SURF(pipe, 0));
+}
+
+static void ilk_do_mmio_flip(struct intel_crtc *intel_crtc)
 {
 	struct drm_device *dev = intel_crtc->base.dev;
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	struct intel_framebuffer *intel_fb =
 		to_intel_framebuffer(intel_crtc->base.primary->fb);
 	struct drm_i915_gem_object *obj = intel_fb->obj;
-	bool atomic_update;
-	u32 start_vbl_count;
 	u32 dspcntr;
 	u32 reg;
 
-	intel_mark_page_flip_active(intel_crtc);
-
-	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);
-
 	reg = DSPCNTR(intel_crtc->plane);
 	dspcntr = I915_READ(reg);
 
@@ -9466,6 +9494,28 @@ static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
 		   intel_crtc->unpin_work->gtt_offset);
 	POSTING_READ(DSPSURF(intel_crtc->plane));
 
+}
+
+/*
+ * XXX: This is the temporary way to update the plane registers until we get
+ * around to using the usual plane update functions for MMIO flips
+ */
+static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
+{
+	struct drm_device *dev = intel_crtc->base.dev;
+	bool atomic_update;
+	u32 start_vbl_count;
+
+	intel_mark_page_flip_active(intel_crtc);
+
+	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);
+
+	if (INTEL_INFO(dev)->gen >= 9)
+		skl_do_mmio_flip(intel_crtc);
+	else
+		/* use_mmio_flip() retricts MMIO flips to ilk+ */
+		ilk_do_mmio_flip(intel_crtc);
+
 	if (atomic_update)
 		intel_pipe_update_end(intel_crtc, start_vbl_count);
 }
-- 
1.8.3.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v5] drm/i915/skl: Implement the skl version of MMIO flips
  2014-11-20 14:58   ` [PATCH v5] " Damien Lespiau
@ 2014-11-21 17:52     ` Daniel Vetter
  2014-11-22 11:06     ` [PATCH v5] drm/i915/skl: Implement the skl version of shuang.he
  1 sibling, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2014-11-21 17:52 UTC (permalink / raw)
  To: Damien Lespiau; +Cc: intel-gfx

On Thu, Nov 20, 2014 at 02:58:16PM +0000, Damien Lespiau wrote:
> Because the plane registers are different in Skylake we need to adapt
> the MMIO code as well.
> 
> v2: Don't introduce yet another vfunc when the direction is do
> consolidate the plane updates to use the same code path (Daniel)
> 
> v3:
>   - Use enum pipe instead of int (Ville)
>   - Also update PLANE_STRIDE when the tiling has changed (Ville)
>   - Put intel_mark_page_flip_active() in the shared code (Damien)
> 
> v4:
>   - Remove unused variable
> 
> v5:
>   - Fix whitespace Vs tabs (Ville)
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Queued for -next, thanks for the patch.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_display.c | 64 ++++++++++++++++++++++++++++++++----
>  1 file changed, 57 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index c0af4c6..211243b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9436,22 +9436,50 @@ static bool use_mmio_flip(struct intel_engine_cs *ring,
>  		return ring != obj->ring;
>  }
>  
> -static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
> +static void skl_do_mmio_flip(struct intel_crtc *intel_crtc)
> +{
> +	struct drm_device *dev = intel_crtc->base.dev;
> +	struct drm_i915_private *dev_priv = dev->dev_private;
> +	struct drm_framebuffer *fb = intel_crtc->base.primary->fb;
> +	struct intel_framebuffer *intel_fb = to_intel_framebuffer(fb);
> +	struct drm_i915_gem_object *obj = intel_fb->obj;
> +	const enum pipe pipe = intel_crtc->pipe;
> +	u32 ctl, stride;
> +
> +	ctl = I915_READ(PLANE_CTL(pipe, 0));
> +	ctl &= ~PLANE_CTL_TILED_MASK;
> +	if (obj->tiling_mode == I915_TILING_X)
> +		ctl |= PLANE_CTL_TILED_X;
> +
> +	/*
> +	 * The stride is either expressed as a multiple of 64 bytes chunks for
> +	 * linear buffers or in number of tiles for tiled buffers.
> +	 */
> +	stride = fb->pitches[0] >> 6;
> +	if (obj->tiling_mode == I915_TILING_X)
> +		stride = fb->pitches[0] >> 9; /* X tiles are 512 bytes wide */
> +
> +	/*
> +	 * Both PLANE_CTL and PLANE_STRIDE are not updated on vblank but on
> +	 * PLANE_SURF updates, the update is then guaranteed to be atomic.
> +	 */
> +	I915_WRITE(PLANE_CTL(pipe, 0), ctl);
> +	I915_WRITE(PLANE_STRIDE(pipe, 0), stride);
> +
> +	I915_WRITE(PLANE_SURF(pipe, 0), intel_crtc->unpin_work->gtt_offset);
> +	POSTING_READ(PLANE_SURF(pipe, 0));
> +}
> +
> +static void ilk_do_mmio_flip(struct intel_crtc *intel_crtc)
>  {
>  	struct drm_device *dev = intel_crtc->base.dev;
>  	struct drm_i915_private *dev_priv = dev->dev_private;
>  	struct intel_framebuffer *intel_fb =
>  		to_intel_framebuffer(intel_crtc->base.primary->fb);
>  	struct drm_i915_gem_object *obj = intel_fb->obj;
> -	bool atomic_update;
> -	u32 start_vbl_count;
>  	u32 dspcntr;
>  	u32 reg;
>  
> -	intel_mark_page_flip_active(intel_crtc);
> -
> -	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);
> -
>  	reg = DSPCNTR(intel_crtc->plane);
>  	dspcntr = I915_READ(reg);
>  
> @@ -9466,6 +9494,28 @@ static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
>  		   intel_crtc->unpin_work->gtt_offset);
>  	POSTING_READ(DSPSURF(intel_crtc->plane));
>  
> +}
> +
> +/*
> + * XXX: This is the temporary way to update the plane registers until we get
> + * around to using the usual plane update functions for MMIO flips
> + */
> +static void intel_do_mmio_flip(struct intel_crtc *intel_crtc)
> +{
> +	struct drm_device *dev = intel_crtc->base.dev;
> +	bool atomic_update;
> +	u32 start_vbl_count;
> +
> +	intel_mark_page_flip_active(intel_crtc);
> +
> +	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);
> +
> +	if (INTEL_INFO(dev)->gen >= 9)
> +		skl_do_mmio_flip(intel_crtc);
> +	else
> +		/* use_mmio_flip() retricts MMIO flips to ilk+ */
> +		ilk_do_mmio_flip(intel_crtc);
> +
>  	if (atomic_update)
>  		intel_pipe_update_end(intel_crtc, start_vbl_count);
>  }
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v4] drm/i915/skl: Implement the skl version of
  2014-11-20 13:48 [PATCH v4] drm/i915/skl: Implement the skl version of MMIO flips Damien Lespiau
  2014-11-20 14:45 ` Ville Syrjälä
@ 2014-11-22  8:43 ` shuang.he
  1 sibling, 0 replies; 7+ messages in thread
From: shuang.he @ 2014-11-22  8:43 UTC (permalink / raw)
  To: shuang.he, intel-gfx, damien.lespiau

Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                                  367/367              367/367
ILK              +2                 373/375              375/375
SNB                                  450/450              450/450
IVB                 -2              503/503              501/503
BYT                                  289/289              289/289
HSW                 -3              567/567              564/567
BDW                                  417/417              417/417
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
ILK  igt_kms_flip_flip-vs-panning      NSPT(1, M26)      PASS(2, M26)
ILK  igt_kms_flip_nonexisting-fb      DMESG_WARN(1, M26)      PASS(2, M26)
IVB  igt_gem_bad_reloc_negative-reloc      PASS(1, M21)      NSPT(2, M4)
IVB  igt_gem_bad_reloc_negative-reloc-lut      PASS(1, M21)      NSPT(1, M4)PASS(1, M4)
HSW  igt_gem_bad_reloc_negative-reloc-lut      PASS(1, M19)      NSPT(2, M20)
HSW  igt_kms_rotation_crc_primary-rotation      PASS(1, M19)      DMESG_WARN(1, M20)PASS(1, M20)
HSW  igt_pm_rc6_residency_rc6-accuracy      PASS(1, M19)      FAIL(1, M20)PASS(1, M20)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v5] drm/i915/skl: Implement the skl version of
  2014-11-20 14:58   ` [PATCH v5] " Damien Lespiau
  2014-11-21 17:52     ` Daniel Vetter
@ 2014-11-22 11:06     ` shuang.he
  1 sibling, 0 replies; 7+ messages in thread
From: shuang.he @ 2014-11-22 11:06 UTC (permalink / raw)
  To: shuang.he, intel-gfx, damien.lespiau

Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                                  367/367              367/367
ILK                 -7              373/375              366/375
SNB                                  450/450              450/450
IVB                 -1              502/503              501/503
BYT                 -1              289/289              288/289
HSW                 -3              567/567              564/567
BDW                                  417/417              417/417
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
ILK  igt_kms_flip_absolute-wf_vblank      PASS(1, M37)      DMESG_WARN(2, M26)
ILK  igt_kms_flip_bcs-flip-vs-modeset-interruptible      PASS(1, M37)      DMESG_WARN(1, M26)PASS(1, M26)
ILK  igt_kms_flip_flip-vs-dpms-off-vs-modeset      PASS(1, M37)      DMESG_WARN(1, M26)PASS(1, M26)
ILK  igt_kms_flip_plain-flip      PASS(1, M37)      DMESG_WARN(1, M26)PASS(1, M26)
ILK  igt_kms_flip_plain-flip-fb-recreate-interruptible      PASS(1, M37)      DMESG_WARN(1, M26)PASS(1, M26)
ILK  igt_kms_flip_wf_vblank-ts-check      PASS(1, M37)      DMESG_WARN(1, M26)PASS(1, M26)
ILK  igt_kms_pipe_crc_basic_bad-nb-words-1      PASS(1, M37)      DMESG_WARN(1, M26)PASS(1, M26)
IVB  igt_gem_bad_reloc_negative-reloc-lut      PASS(1, M21)      NSPT(2, M34)
BYT  igt_gem_exec_bad_domains_conflicting-write-domain      PASS(1, M36)      TIMEOUT(1, M36)PASS(1, M36)
HSW  igt_gem_bad_reloc_negative-reloc-lut      PASS(1, M20)      NSPT(2, M20)
HSW  igt_kms_rotation_crc_primary-rotation      PASS(1, M20)      DMESG_WARN(1, M20)PASS(1, M20)
HSW  igt_pm_rc6_residency_rc6-accuracy      PASS(1, M20)      FAIL(1, M20)PASS(1, M20)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-11-22 11:16 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-20 13:48 [PATCH v4] drm/i915/skl: Implement the skl version of MMIO flips Damien Lespiau
2014-11-20 14:45 ` Ville Syrjälä
2014-11-20 14:54   ` Damien Lespiau
2014-11-20 14:58   ` [PATCH v5] " Damien Lespiau
2014-11-21 17:52     ` Daniel Vetter
2014-11-22 11:06     ` [PATCH v5] drm/i915/skl: Implement the skl version of shuang.he
2014-11-22  8:43 ` [PATCH v4] " shuang.he

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox