From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Prefer local execution_mask for determing viable engines
Date: Thu, 28 Jan 2021 09:00:46 +0000 [thread overview]
Message-ID: <98cfaefe-16b4-4b34-62d8-abf2ff559396@linux.intel.com> (raw)
In-Reply-To: <20210127090608.16925-1-chris@chris-wilson.co.uk>
On 27/01/2021 09:06, Chris Wilson wrote:
> In gen8_emit_flush_xcs, we have to look at all the engines the request
> may execute on, and emit an aux-invalidate for each. Currently, we
> handle the virtual engine by looking at its engine mask, but that is
> copied and refined as the request->execution_mask. If we prefer the
> local mask, this is one fewer rq->engine pointer chasing we have to
> eliminate later when we remove rq->engine.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
> index 07ba524da90b..cac80af7ad1c 100644
> --- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
> @@ -277,7 +277,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
> if (mode & EMIT_INVALIDATE)
> cmd += 2;
> if (mode & EMIT_INVALIDATE)
> - aux_inv = rq->engine->mask & ~BIT(BCS0);
> + aux_inv = rq->execution_mask & ~BIT(BCS0);
> if (aux_inv)
> cmd += 2 * hweight8(aux_inv) + 2;
>
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-01-28 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 9:06 [Intel-gfx] [PATCH] drm/i915/gt: Prefer local execution_mask for determing viable engines Chris Wilson
2021-01-27 14:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-27 17:08 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-28 9:00 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98cfaefe-16b4-4b34-62d8-abf2ff559396@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox