* [Intel-gfx] [PATCH] drm/i915/gt: Prefer local execution_mask for determing viable engines
@ 2021-01-27 9:06 Chris Wilson
2021-01-27 14:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2021-01-27 9:06 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
In gen8_emit_flush_xcs, we have to look at all the engines the request
may execute on, and emit an aux-invalidate for each. Currently, we
handle the virtual engine by looking at its engine mask, but that is
copied and refined as the request->execution_mask. If we prefer the
local mask, this is one fewer rq->engine pointer chasing we have to
eliminate later when we remove rq->engine.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
index 07ba524da90b..cac80af7ad1c 100644
--- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
+++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
@@ -277,7 +277,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
if (mode & EMIT_INVALIDATE)
cmd += 2;
if (mode & EMIT_INVALIDATE)
- aux_inv = rq->engine->mask & ~BIT(BCS0);
+ aux_inv = rq->execution_mask & ~BIT(BCS0);
if (aux_inv)
cmd += 2 * hweight8(aux_inv) + 2;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Prefer local execution_mask for determing viable engines 2021-01-27 9:06 [Intel-gfx] [PATCH] drm/i915/gt: Prefer local execution_mask for determing viable engines Chris Wilson @ 2021-01-27 14:25 ` Patchwork 2021-01-27 17:08 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-01-28 9:00 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2021-01-27 14:25 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 3846 bytes --] == Series Details == Series: drm/i915/gt: Prefer local execution_mask for determing viable engines URL : https://patchwork.freedesktop.org/series/86342/ State : success == Summary == CI Bug Log - changes from CI_DRM_9687 -> Patchwork_19516 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/index.html Known issues ------------ Here are the changes found in Patchwork_19516 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#2411] / [i915#402]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live@hangcheck: - fi-glk-dsi: [PASS][3] -> [INCOMPLETE][4] ([i915#2895]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/fi-glk-dsi/igt@i915_selftest@live@hangcheck.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/fi-glk-dsi/igt@i915_selftest@live@hangcheck.html * igt@kms_chamelium@hdmi-edid-read: - fi-kbl-7500u: [PASS][5] -> [DMESG-FAIL][6] ([i915#165]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html * igt@prime_self_import@basic-with_one_bo_two_files: - fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([i915#402]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html #### Possible fixes #### * igt@kms_chamelium@dp-crc-fast: - fi-icl-u2: [FAIL][9] ([i915#1161] / [i915#262]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html * igt@prime_vgem@basic-gtt: - fi-tgl-y: [DMESG-WARN][11] ([i915#402]) -> [PASS][12] +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/fi-tgl-y/igt@prime_vgem@basic-gtt.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/fi-tgl-y/igt@prime_vgem@basic-gtt.html [i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161 [i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165 [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262 [i915#2895]: https://gitlab.freedesktop.org/drm/intel/issues/2895 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (45 -> 38) ------------------------------ Missing (7): fi-jsl-1 fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_9687 -> Patchwork_19516 CI-20190529: 20190529 CI_DRM_9687: 7b5229b02338bfb24c3db4e76abb328d1e9cf8f1 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5974: a85398dcae50930c0e27548cf8c9575ad0bf69d1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19516: f44073b31909dda007cf8c510eebdff04b9da8fe @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == f44073b31909 drm/i915/gt: Prefer local execution_mask for determing viable engines == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/index.html [-- Attachment #1.2: Type: text/html, Size: 4723 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Prefer local execution_mask for determing viable engines 2021-01-27 9:06 [Intel-gfx] [PATCH] drm/i915/gt: Prefer local execution_mask for determing viable engines Chris Wilson 2021-01-27 14:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2021-01-27 17:08 ` Patchwork 2021-01-28 9:00 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2021-01-27 17:08 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 25850 bytes --] == Series Details == Series: drm/i915/gt: Prefer local execution_mask for determing viable engines URL : https://patchwork.freedesktop.org/series/86342/ State : success == Summary == CI Bug Log - changes from CI_DRM_9687_full -> Patchwork_19516_full ==================================================== Summary ------- **SUCCESS** No regressions found. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_19516_full: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * {igt@gem_ctx_persistence@many-contexts}: - shard-tglb: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb5/igt@gem_ctx_persistence@many-contexts.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-tglb1/igt@gem_ctx_persistence@many-contexts.html * {igt@sysfs_clients@busy@rcs0}: - shard-skl: [PASS][3] -> [FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl1/igt@sysfs_clients@busy@rcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl9/igt@sysfs_clients@busy@rcs0.html Known issues ------------ Here are the changes found in Patchwork_19516_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@feature_discovery@chamelium: - shard-iclb: NOTRUN -> [SKIP][5] ([fdo#111827]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@feature_discovery@chamelium.html * igt@gem_ctx_persistence@clone: - shard-hsw: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-hsw4/igt@gem_ctx_persistence@clone.html * igt@gem_exec_fair@basic-none@vcs0: - shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace@bcs0: - shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb5/igt@gem_exec_fair@basic-pace@bcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-tglb1/igt@gem_exec_fair@basic-pace@bcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [PASS][11] -> [FAIL][12] ([i915#2849]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_reloc@basic-many-active@vcs1: - shard-iclb: NOTRUN -> [FAIL][13] ([i915#2389]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb1/igt@gem_exec_reloc@basic-many-active@vcs1.html * igt@gem_exec_schedule@u-fairslice@vecs0: - shard-skl: [PASS][14] -> [DMESG-WARN][15] ([i915#1610] / [i915#2803]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl10/igt@gem_exec_schedule@u-fairslice@vecs0.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl10/igt@gem_exec_schedule@u-fairslice@vecs0.html * igt@gem_render_copy@yf-tiled-to-vebox-linear: - shard-iclb: NOTRUN -> [SKIP][16] ([i915#768]) +1 similar issue [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@gem_render_copy@yf-tiled-to-vebox-linear.html * igt@gem_softpin@evict-snoop-interruptible: - shard-iclb: NOTRUN -> [SKIP][17] ([fdo#109312]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@gem_softpin@evict-snoop-interruptible.html * igt@gen7_exec_parse@basic-allowed: - shard-iclb: NOTRUN -> [SKIP][18] ([fdo#109289]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@gen7_exec_parse@basic-allowed.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [PASS][19] -> [DMESG-WARN][20] ([i915#1436] / [i915#716]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl2/igt@gen9_exec_parse@allowed-single.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl8/igt@gen9_exec_parse@allowed-single.html * igt@i915_selftest@live@hangcheck: - shard-hsw: NOTRUN -> [INCOMPLETE][21] ([i915#2782]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-hsw4/igt@i915_selftest@live@hangcheck.html * igt@kms_async_flips@test-time-stamp: - shard-tglb: [PASS][22] -> [FAIL][23] ([i915#2597]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb8/igt@kms_async_flips@test-time-stamp.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-tglb8/igt@kms_async_flips@test-time-stamp.html * igt@kms_ccs@pipe-c-crc-primary-basic: - shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111304]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl5/igt@kms_ccs@pipe-c-crc-primary-basic.html * igt@kms_chamelium@dp-mode-timings: - shard-iclb: NOTRUN -> [SKIP][25] ([fdo#109284] / [fdo#111827]) +2 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@kms_chamelium@dp-mode-timings.html * igt@kms_chamelium@hdmi-cmp-planar-formats: - shard-glk: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +1 similar issue [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-glk7/igt@kms_chamelium@hdmi-cmp-planar-formats.html * igt@kms_chamelium@vga-hpd-enable-disable-mode: - shard-hsw: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-hsw4/igt@kms_chamelium@vga-hpd-enable-disable-mode.html * igt@kms_color_chamelium@pipe-d-ctm-blue-to-red: - shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl7/igt@kms_color_chamelium@pipe-d-ctm-blue-to-red.html * igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes: - shard-skl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +2 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl5/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html * igt@kms_content_protection@atomic-dpms: - shard-iclb: NOTRUN -> [SKIP][30] ([fdo#109300] / [fdo#111066]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@kms_content_protection@atomic-dpms.html * igt@kms_cursor_crc@pipe-a-cursor-128x128-random: - shard-skl: [PASS][31] -> [FAIL][32] ([i915#54]) +3 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl9/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl9/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html * igt@kms_cursor_crc@pipe-d-cursor-128x42-random: - shard-glk: NOTRUN -> [SKIP][33] ([fdo#109271]) +3 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-glk7/igt@kms_cursor_crc@pipe-d-cursor-128x42-random.html * igt@kms_cursor_edge_walk@pipe-d-64x64-top-edge: - shard-hsw: NOTRUN -> [SKIP][34] ([fdo#109271]) +14 similar issues [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-hsw4/igt@kms_cursor_edge_walk@pipe-d-64x64-top-edge.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: - shard-hsw: [PASS][35] -> [FAIL][36] ([i915#96]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic: - shard-glk: [PASS][37] -> [FAIL][38] ([i915#72]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: - shard-iclb: NOTRUN -> [SKIP][39] ([fdo#109274] / [fdo#109278]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html * igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled: - shard-skl: [PASS][40] -> [FAIL][41] ([i915#177] / [i915#52] / [i915#54]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl5/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl2/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html * igt@kms_flip@plain-flip-fb-recreate@c-edp1: - shard-skl: [PASS][42] -> [FAIL][43] ([i915#2122]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl2/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl8/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt: - shard-kbl: NOTRUN -> [SKIP][44] ([fdo#109271]) +7 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt: - shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109280]) +3 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt.html * igt@kms_hdr@bpc-switch: - shard-skl: NOTRUN -> [FAIL][46] ([i915#1188]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl5/igt@kms_hdr@bpc-switch.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-d: - shard-skl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#533]) +1 similar issue [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl5/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - shard-skl: NOTRUN -> [FAIL][48] ([fdo#108145] / [i915#265]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [PASS][49] -> [FAIL][50] ([fdo#108145] / [i915#265]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_plane_cursor@pipe-d-viewport-size-64: - shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109278]) +4 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@kms_plane_cursor@pipe-d-viewport-size-64.html * igt@kms_plane_scaling@2x-scaler-multi-pipe: - shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109274]) +1 similar issue [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@kms_plane_scaling@2x-scaler-multi-pipe.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-iclb: NOTRUN -> [SKIP][53] ([i915#2920]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html - shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#658]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl5/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5: - shard-kbl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#658]) +1 similar issue [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][56] -> [SKIP][57] ([fdo#109642] / [fdo#111068] / [i915#658]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb2/igt@kms_psr2_su@frontbuffer.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb6/igt@kms_psr2_su@frontbuffer.html * igt@nouveau_crc@pipe-d-ctx-flip-detection: - shard-skl: NOTRUN -> [SKIP][58] ([fdo#109271]) +36 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl5/igt@nouveau_crc@pipe-d-ctx-flip-detection.html - shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109278] / [i915#2530]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@nouveau_crc@pipe-d-ctx-flip-detection.html * igt@perf@polling-parameterized: - shard-skl: [PASS][60] -> [FAIL][61] ([i915#1542]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl3/igt@perf@polling-parameterized.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl1/igt@perf@polling-parameterized.html #### Possible fixes #### * igt@gem_ctx_persistence@smoketest: - shard-iclb: [FAIL][62] ([i915#2896]) -> [PASS][63] [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb1/igt@gem_ctx_persistence@smoketest.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb7/igt@gem_ctx_persistence@smoketest.html * igt@gem_exec_fair@basic-none@vcs1: - shard-kbl: [FAIL][64] ([i915#2842]) -> [PASS][65] [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl2/igt@gem_exec_fair@basic-none@vcs1.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl7/igt@gem_exec_fair@basic-none@vcs1.html * igt@gem_exec_fair@basic-pace@bcs0: - shard-iclb: [FAIL][66] ([i915#2842]) -> [PASS][67] [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb8/igt@gem_exec_fair@basic-pace@bcs0.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb5/igt@gem_exec_fair@basic-pace@bcs0.html * igt@gem_exec_whisper@basic-fds-priority: - shard-iclb: [INCOMPLETE][68] ([i915#1394]) -> [PASS][69] [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb7/igt@gem_exec_whisper@basic-fds-priority.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb2/igt@gem_exec_whisper@basic-fds-priority.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [DMESG-WARN][70] ([i915#1436] / [i915#716]) -> [PASS][71] [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-glk6/igt@gen9_exec_parse@allowed-all.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-glk7/igt@gen9_exec_parse@allowed-all.html * igt@i915_pm_rpm@system-suspend-modeset: - shard-kbl: [INCOMPLETE][72] ([i915#151]) -> [PASS][73] [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl2/igt@i915_pm_rpm@system-suspend-modeset.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl7/igt@i915_pm_rpm@system-suspend-modeset.html * igt@kms_color@pipe-b-ctm-max: - shard-skl: [DMESG-WARN][74] ([i915#1982]) -> [PASS][75] [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl2/igt@kms_color@pipe-b-ctm-max.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl8/igt@kms_color@pipe-b-ctm-max.html * igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen: - shard-skl: [FAIL][76] ([i915#54]) -> [PASS][77] +10 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html * igt@kms_cursor_legacy@flip-vs-cursor-varying-size: - shard-tglb: [FAIL][78] ([i915#2346]) -> [PASS][79] [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb8/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-tglb8/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: - shard-skl: [FAIL][80] ([i915#79]) -> [PASS][81] +1 similar issue [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html * igt@kms_flip@flip-vs-suspend@b-dp1: - shard-kbl: [DMESG-WARN][82] ([i915#180]) -> [PASS][83] +2 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl4/igt@kms_flip@flip-vs-suspend@b-dp1.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl1/igt@kms_flip@flip-vs-suspend@b-dp1.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [FAIL][84] ([i915#1188]) -> [PASS][85] [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl9/igt@kms_hdr@bpc-switch-dpms.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl9/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [FAIL][86] ([fdo#108145] / [i915#265]) -> [PASS][87] [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * {igt@sysfs_clients@busy@vcs0}: - shard-kbl: [FAIL][88] -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl3/igt@sysfs_clients@busy@vcs0.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl3/igt@sysfs_clients@busy@vcs0.html * {igt@sysfs_clients@busy@vecs0}: - shard-apl: [FAIL][90] -> [PASS][91] [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-apl4/igt@sysfs_clients@busy@vecs0.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-apl4/igt@sysfs_clients@busy@vecs0.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][92] ([i915#2681] / [i915#2684]) -> [WARN][93] ([i915#1804] / [i915#2684]) [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html * igt@runner@aborted: - shard-kbl: ([FAIL][94], [FAIL][95], [FAIL][96], [FAIL][97], [FAIL][98]) ([i915#2295]) -> ([FAIL][99], [FAIL][100], [FAIL][101], [FAIL][102]) ([i915#2295] / [i915#2505]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl3/igt@runner@aborted.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl4/igt@runner@aborted.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl4/igt@runner@aborted.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl4/igt@runner@aborted.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl7/igt@runner@aborted.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl6/igt@runner@aborted.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl2/igt@runner@aborted.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl1/igt@runner@aborted.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-kbl4/igt@runner@aborted.html - shard-skl: ([FAIL][103], [FAIL][104], [FAIL][105]) ([i915#2295]) -> ([FAIL][106], [FAIL][107], [FAIL][108], [FAIL][109]) ([i915#1436] / [i915#2295] / [i915#2426]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl6/igt@runner@aborted.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl1/igt@runner@aborted.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl10/igt@runner@aborted.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl10/igt@runner@aborted.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl8/igt@runner@aborted.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl2/igt@runner@aborted.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/shard-skl10/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1394]: https://gitlab.freedesktop.org/drm/intel/issues/1394 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505 [i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530 [i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782 [i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849 [i915#2896]: https://gitlab.freedesktop.org/drm/intel/issues/2896 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_9687 -> Patchwork_19516 CI-20190529: 20190529 CI_DRM_9687: 7b5229b02338bfb24c3db4e76abb328d1e9cf8f1 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5974: a85398dcae50930c0e27548cf8c9575ad0bf69d1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19516: f44073b31909dda007cf8c510eebdff04b9da8fe @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19516/index.html [-- Attachment #1.2: Type: text/html, Size: 30926 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Prefer local execution_mask for determing viable engines 2021-01-27 9:06 [Intel-gfx] [PATCH] drm/i915/gt: Prefer local execution_mask for determing viable engines Chris Wilson 2021-01-27 14:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-01-27 17:08 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2021-01-28 9:00 ` Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Tvrtko Ursulin @ 2021-01-28 9:00 UTC (permalink / raw) To: Chris Wilson, intel-gfx On 27/01/2021 09:06, Chris Wilson wrote: > In gen8_emit_flush_xcs, we have to look at all the engines the request > may execute on, and emit an aux-invalidate for each. Currently, we > handle the virtual engine by looking at its engine mask, but that is > copied and refined as the request->execution_mask. If we prefer the > local mask, this is one fewer rq->engine pointer chasing we have to > eliminate later when we remove rq->engine. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > index 07ba524da90b..cac80af7ad1c 100644 > --- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > +++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > @@ -277,7 +277,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode) > if (mode & EMIT_INVALIDATE) > cmd += 2; > if (mode & EMIT_INVALIDATE) > - aux_inv = rq->engine->mask & ~BIT(BCS0); > + aux_inv = rq->execution_mask & ~BIT(BCS0); > if (aux_inv) > cmd += 2 * hweight8(aux_inv) + 2; > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-28 9:00 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-01-27 9:06 [Intel-gfx] [PATCH] drm/i915/gt: Prefer local execution_mask for determing viable engines Chris Wilson 2021-01-27 14:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-01-27 17:08 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-01-28 9:00 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox