Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Add workarounds Wa_14017066071, Wa_14017654203
@ 2023-01-20  1:06 Radhakrishna Sripada
  2023-01-20  1:06 ` [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add Wa_22015279794 Radhakrishna Sripada
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Radhakrishna Sripada @ 2023-01-20  1:06 UTC (permalink / raw)
  To: intel-gfx

This patch add the workaround to disable Sampler-OOO to avoid hang
during a benchmark.

Original Author: Madhumitha Tolakanhalli Pradeep
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_gt_regs.h     | 1 +
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
index 4a4bab261e66..27b06ff380a9 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
@@ -1145,6 +1145,7 @@
 #define   ENABLE_SMALLPL			REG_BIT(15)
 #define   SC_DISABLE_POWER_OPTIMIZATION_EBB	REG_BIT(9)
 #define   GEN11_SAMPLER_ENABLE_HEADLESS_MSG	REG_BIT(5)
+#define   MTL_DISABLE_SAMPLER_SC_OOO		REG_BIT(3)
 
 #define GEN9_HALF_SLICE_CHICKEN7		MCR_REG(0xe194)
 #define   DG2_DISABLE_ROUND_ENABLE_ALLOW_FOR_SSLA	REG_BIT(15)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 918a271447e2..c52c5f9ad9ce 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -2332,6 +2332,13 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
 		/* Wa_22014600077 */
 		wa_mcr_masked_en(wal, GEN10_CACHE_MODE_SS,
 				 ENABLE_EU_COUNT_FOR_TDL_FLUSH);
+
+		/*
+		 * Wa_14017066071: mtl-p/m[a0]
+		 * Wa_14017654203: mtl-p/m[a0]
+		 */
+		wa_mcr_masked_en(wal, GEN10_SAMPLER_MODE,
+				 MTL_DISABLE_SAMPLER_SC_OOO);
 	}
 
 	if (IS_MTL_GRAPHICS_STEP(i915, M, STEP_A0, STEP_B0) ||
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH 0/2] Add MTL Wa_14017066071, Wa_14017654203 and Wa_22015279794
@ 2023-03-29 20:24 Gustavo Sousa
  2023-03-29 20:24 ` [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add Wa_22015279794 Gustavo Sousa
  0 siblings, 1 reply; 10+ messages in thread
From: Gustavo Sousa @ 2023-03-29 20:24 UTC (permalink / raw)
  To: intel-gfx

Add some GT workarounds for MTL. Note that Wa_14017066071 and Wa_14017654203
require the same implementation and have the same platform and stepping bounds,
so there is a single patch for them.

Radhakrishna Sripada (2):
  drm/i915/mtl: Add workarounds Wa_14017066071 and Wa_14017654203
  drm/i915/mtl: Add Wa_22015279794

 drivers/gpu/drm/i915/gt/intel_gt_regs.h     |  7 +++++++
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 17 +++++++++++++++--
 2 files changed, 22 insertions(+), 2 deletions(-)

-- 
2.40.0


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-03-29 21:12 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-20  1:06 [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Add workarounds Wa_14017066071, Wa_14017654203 Radhakrishna Sripada
2023-01-20  1:06 ` [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add Wa_22015279794 Radhakrishna Sripada
2023-01-20 10:47   ` Rodrigo Vivi
2023-01-20  1:21 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/mtl: Add workarounds Wa_14017066071, Wa_14017654203 Patchwork
2023-01-20  1:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-01-20 10:47 ` [Intel-gfx] [PATCH 1/2] " Rodrigo Vivi
2023-01-24  8:58   ` Jani Nikula
2023-01-20 22:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-03-29 20:24 [Intel-gfx] [PATCH 0/2] Add MTL Wa_14017066071, Wa_14017654203 and Wa_22015279794 Gustavo Sousa
2023-03-29 20:24 ` [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add Wa_22015279794 Gustavo Sousa
2023-03-29 21:12   ` Matt Roper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox