* [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check
@ 2023-05-04 10:28 Juha-Pekka Heikkila
2023-05-04 10:28 ` [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs Juha-Pekka Heikkila
` (12 more replies)
0 siblings, 13 replies; 18+ messages in thread
From: Juha-Pekka Heikkila @ 2023-05-04 10:28 UTC (permalink / raw)
To: intel-gfx; +Cc: Pallavi Mishra
From: Pallavi Mishra <pallavi.mishra@intel.com>
Remove FLAT CCS check from XY_FAST_COLOR_BLT usage, thus
enabling MTL to use it.
Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index 3f638f198796..e0998879a0e1 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -920,7 +920,7 @@ static int emit_clear(struct i915_request *rq, u32 offset, int size,
GEM_BUG_ON(size >> PAGE_SHIFT > S16_MAX);
- if (HAS_FLAT_CCS(i915) && ver >= 12)
+ if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50))
ring_sz = XY_FAST_COLOR_BLT_DW;
else if (ver >= 8)
ring_sz = 8;
@@ -931,7 +931,7 @@ static int emit_clear(struct i915_request *rq, u32 offset, int size,
if (IS_ERR(cs))
return PTR_ERR(cs);
- if (HAS_FLAT_CCS(i915) && ver >= 12) {
+ if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
*cs++ = XY_FAST_COLOR_BLT_CMD | XY_FAST_COLOR_BLT_DEPTH_32 |
(XY_FAST_COLOR_BLT_DW - 2);
*cs++ = FIELD_PREP(XY_FAST_COLOR_BLT_MOCS_MASK, mocs) |
--
2.25.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
@ 2023-05-04 10:28 ` Juha-Pekka Heikkila
2023-05-04 20:15 ` Sripada, Radhakrishna
2023-05-05 8:38 ` Andi Shyti
2023-05-04 10:28 ` [Intel-gfx] [PATCH 3/4] drm/fourcc: define Intel Meteorlake related ccs modifiers Juha-Pekka Heikkila
` (11 subsequent siblings)
12 siblings, 2 replies; 18+ messages in thread
From: Juha-Pekka Heikkila @ 2023-05-04 10:28 UTC (permalink / raw)
To: intel-gfx
From: Clint Taylor <clinton.a.taylor@intel.com>
Add support for remapping CCS FBs on MTL to remove the restriction
of the power-of-two sized stride and the 2MB surface offset alignment
for these FBs.
Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
drivers/gpu/drm/i915/display/intel_fb.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index e5f637897b5e..c004f08fcfe1 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -1190,7 +1190,8 @@ bool intel_fb_needs_pot_stride_remap(const struct intel_framebuffer *fb)
{
struct drm_i915_private *i915 = to_i915(fb->base.dev);
- return IS_ALDERLAKE_P(i915) && intel_fb_uses_dpt(&fb->base);
+ return (IS_ALDERLAKE_P(i915) || DISPLAY_VER(i915) >= 14) &&
+ intel_fb_uses_dpt(&fb->base);
}
static int intel_fb_pitch(const struct intel_framebuffer *fb, int color_plane, unsigned int rotation)
@@ -1326,9 +1327,10 @@ plane_view_scanout_stride(const struct intel_framebuffer *fb, int color_plane,
unsigned int tile_width,
unsigned int src_stride_tiles, unsigned int dst_stride_tiles)
{
+ struct drm_i915_private *i915 = to_i915(fb->base.dev);
unsigned int stride_tiles;
- if (IS_ALDERLAKE_P(to_i915(fb->base.dev)))
+ if (IS_ALDERLAKE_P(i915) || DISPLAY_VER(i915) >= 14)
stride_tiles = src_stride_tiles;
else
stride_tiles = dst_stride_tiles;
@@ -1522,7 +1524,8 @@ static void intel_fb_view_init(struct drm_i915_private *i915, struct intel_fb_vi
memset(view, 0, sizeof(*view));
view->gtt.type = view_type;
- if (view_type == I915_GTT_VIEW_REMAPPED && IS_ALDERLAKE_P(i915))
+ if (view_type == I915_GTT_VIEW_REMAPPED &&
+ (IS_ALDERLAKE_P(i915) || DISPLAY_VER(i915) >= 14))
view->gtt.remapped.plane_alignment = SZ_2M / PAGE_SIZE;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH 3/4] drm/fourcc: define Intel Meteorlake related ccs modifiers
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
2023-05-04 10:28 ` [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs Juha-Pekka Heikkila
@ 2023-05-04 10:28 ` Juha-Pekka Heikkila
2023-05-04 10:28 ` [Intel-gfx] [PATCH 4/4] drm/i915/mtl: Add handling for MTL " Juha-Pekka Heikkila
` (10 subsequent siblings)
12 siblings, 0 replies; 18+ messages in thread
From: Juha-Pekka Heikkila @ 2023-05-04 10:28 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel
Add Tile4 type ccs modifiers with aux buffer needed for MTL
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
include/uapi/drm/drm_fourcc.h | 43 +++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index de703c6be969..cbe214adf1e4 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -657,6 +657,49 @@ extern "C" {
*/
#define I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC fourcc_mod_code(INTEL, 12)
+/*
+ * Intel color control surfaces (CCS) for display ver 14 render compression.
+ *
+ * The main surface is tile4 and at plane index 0, the CCS is linear and
+ * at index 1. A 64B CCS cache line corresponds to an area of 4x1 tiles in
+ * main surface. In other words, 4 bits in CCS map to a main surface cache
+ * line pair. The main surface pitch is required to be a multiple of four
+ * tile4 widths.
+ */
+#define I915_FORMAT_MOD_4_TILED_MTL_RC_CCS fourcc_mod_code(INTEL, 13)
+
+/*
+ * Intel color control surfaces (CCS) for display ver 14 media compression
+ *
+ * The main surface is tile4 and at plane index 0, the CCS is linear and
+ * at index 1. A 64B CCS cache line corresponds to an area of 4x1 tiles in
+ * main surface. In other words, 4 bits in CCS map to a main surface cache
+ * line pair. The main surface pitch is required to be a multiple of four
+ * tile4 widths. For semi-planar formats like NV12, CCS planes follow the
+ * Y and UV planes i.e., planes 0 and 1 are used for Y and UV surfaces,
+ * planes 2 and 3 for the respective CCS.
+ */
+#define I915_FORMAT_MOD_4_TILED_MTL_MC_CCS fourcc_mod_code(INTEL, 14)
+
+/*
+ * Intel Color Control Surface with Clear Color (CCS) for display ver 14 render
+ * compression.
+ *
+ * The main surface is tile4 and is at plane index 0 whereas CCS is linear
+ * and at index 1. The clear color is stored at index 2, and the pitch should
+ * be ignored. The clear color structure is 256 bits. The first 128 bits
+ * represents Raw Clear Color Red, Green, Blue and Alpha color each represented
+ * by 32 bits. The raw clear color is consumed by the 3d engine and generates
+ * the converted clear color of size 64 bits. The first 32 bits store the Lower
+ * Converted Clear Color value and the next 32 bits store the Higher Converted
+ * Clear Color value when applicable. The Converted Clear Color values are
+ * consumed by the DE. The last 64 bits are used to store Color Discard Enable
+ * and Depth Clear Value Valid which are ignored by the DE. A CCS cache line
+ * corresponds to an area of 4x1 tiles in the main surface. The main surface
+ * pitch is required to be a multiple of 4 tile widths.
+ */
+#define I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC fourcc_mod_code(INTEL, 15)
+
/*
* Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks
*
--
2.25.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH 4/4] drm/i915/mtl: Add handling for MTL ccs modifiers
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
2023-05-04 10:28 ` [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs Juha-Pekka Heikkila
2023-05-04 10:28 ` [Intel-gfx] [PATCH 3/4] drm/fourcc: define Intel Meteorlake related ccs modifiers Juha-Pekka Heikkila
@ 2023-05-04 10:28 ` Juha-Pekka Heikkila
2023-05-08 11:41 ` Kahola, Mika
2023-05-04 18:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check Patchwork
` (9 subsequent siblings)
12 siblings, 1 reply; 18+ messages in thread
From: Juha-Pekka Heikkila @ 2023-05-04 10:28 UTC (permalink / raw)
To: intel-gfx
Add Tile4 ccs modifiers w/ auxbuffer handling
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
drivers/gpu/drm/i915/display/intel_fb.c | 42 ++++++++++++++++++-
.../drm/i915/display/skl_universal_plane.c | 22 +++++++++-
2 files changed, 61 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index c004f08fcfe1..f9420a68ed3c 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -157,6 +157,32 @@ struct intel_modifier_desc {
static const struct intel_modifier_desc intel_modifiers[] = {
{
+ .modifier = I915_FORMAT_MOD_4_TILED_MTL_MC_CCS,
+ .display_ver = { 14, 14 },
+ .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_MC,
+
+ .ccs.packed_aux_planes = BIT(1),
+ .ccs.planar_aux_planes = BIT(2) | BIT(3),
+
+ FORMAT_OVERRIDE(gen12_ccs_formats),
+ }, {
+ .modifier = I915_FORMAT_MOD_4_TILED_MTL_RC_CCS,
+ .display_ver = { 14, 14 },
+ .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_RC,
+
+ .ccs.packed_aux_planes = BIT(1),
+
+ FORMAT_OVERRIDE(gen12_ccs_formats),
+ }, {
+ .modifier = I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC,
+ .display_ver = { 14, 14 },
+ .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_RC_CC,
+
+ .ccs.cc_planes = BIT(2),
+ .ccs.packed_aux_planes = BIT(1),
+
+ FORMAT_OVERRIDE(gen12_ccs_cc_formats),
+ }, {
.modifier = I915_FORMAT_MOD_4_TILED_DG2_MC_CCS,
.display_ver = { 13, 13 },
.plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_MC,
@@ -370,6 +396,14 @@ static bool plane_has_modifier(struct drm_i915_private *i915,
if (!plane_caps_contain_all(plane_caps, md->plane_caps))
return false;
+ /*
+ * Separate AuxCCS and Flat CCS modifiers to be run only on platforms
+ * where supported.
+ */
+ if (intel_fb_is_ccs_modifier(md->modifier) &&
+ HAS_FLAT_CCS(i915) != !md->ccs.packed_aux_planes)
+ return false;
+
return true;
}
@@ -489,7 +523,7 @@ static bool intel_fb_is_gen12_ccs_aux_plane(const struct drm_framebuffer *fb, in
{
const struct intel_modifier_desc *md = lookup_modifier(fb->modifier);
- return check_modifier_display_ver_range(md, 12, 13) &&
+ return check_modifier_display_ver_range(md, 12, 14) &&
ccs_aux_plane_mask(md, fb->format) & BIT(color_plane);
}
@@ -605,6 +639,9 @@ intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane)
if (intel_fb_is_ccs_aux_plane(fb, color_plane))
return 128;
fallthrough;
+ case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS:
+ case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC:
+ case I915_FORMAT_MOD_4_TILED_MTL_MC_CCS:
case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
@@ -791,6 +828,9 @@ unsigned int intel_surf_alignment(const struct drm_framebuffer *fb,
case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
+ case I915_FORMAT_MOD_4_TILED_MTL_MC_CCS:
+ case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS:
+ case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC:
return 16 * 1024;
case I915_FORMAT_MOD_Y_TILED_CCS:
case I915_FORMAT_MOD_Yf_TILED_CCS:
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 8ea0598a5a07..f6f760e59c9e 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -789,6 +789,14 @@ static u32 skl_plane_ctl_tiling(u64 fb_modifier)
PLANE_CTL_CLEAR_COLOR_DISABLE;
case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
return PLANE_CTL_TILED_4 | PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
+ case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS:
+ return PLANE_CTL_TILED_4 |
+ PLANE_CTL_RENDER_DECOMPRESSION_ENABLE |
+ PLANE_CTL_CLEAR_COLOR_DISABLE;
+ case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC:
+ return PLANE_CTL_TILED_4 | PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
+ case I915_FORMAT_MOD_4_TILED_MTL_MC_CCS:
+ return PLANE_CTL_TILED_4 | PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE;
case I915_FORMAT_MOD_Y_TILED_CCS:
case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
return PLANE_CTL_TILED_Y | PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
@@ -2160,6 +2168,11 @@ skl_plane_disable_flip_done(struct intel_plane *plane)
static bool skl_plane_has_rc_ccs(struct drm_i915_private *i915,
enum pipe pipe, enum plane_id plane_id)
{
+ /* Wa_14017240301 */
+ if (IS_MTL_GRAPHICS_STEP(i915, M, STEP_A0, STEP_B0) ||
+ IS_MTL_GRAPHICS_STEP(i915, P, STEP_A0, STEP_B0))
+ return false;
+
/* Wa_22011186057 */
if (IS_ADLP_DISPLAY_STEP(i915, STEP_A0, STEP_B0))
return false;
@@ -2441,12 +2454,17 @@ skl_get_initial_plane_config(struct intel_crtc *crtc,
case PLANE_CTL_TILED_Y:
plane_config->tiling = I915_TILING_Y;
if (val & PLANE_CTL_RENDER_DECOMPRESSION_ENABLE)
- if (DISPLAY_VER(dev_priv) >= 12)
+ if (DISPLAY_VER(dev_priv) >= 14)
+ fb->modifier = I915_FORMAT_MOD_4_TILED_MTL_RC_CCS;
+ else if (DISPLAY_VER(dev_priv) >= 12)
fb->modifier = I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS;
else
fb->modifier = I915_FORMAT_MOD_Y_TILED_CCS;
else if (val & PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE)
- fb->modifier = I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS;
+ if (DISPLAY_VER(dev_priv) >= 14)
+ fb->modifier = I915_FORMAT_MOD_4_TILED_MTL_MC_CCS;
+ else
+ fb->modifier = I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS;
else
fb->modifier = I915_FORMAT_MOD_Y_TILED;
break;
--
2.25.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
` (2 preceding siblings ...)
2023-05-04 10:28 ` [Intel-gfx] [PATCH 4/4] drm/i915/mtl: Add handling for MTL " Juha-Pekka Heikkila
@ 2023-05-04 18:43 ` Patchwork
2023-05-04 18:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (8 subsequent siblings)
12 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-05-04 18:43 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check
URL : https://patchwork.freedesktop.org/series/117272/
State : warning
== Summary ==
Error: dim checkpatch failed
ba3e9fcba540 drm/i915/mtl: Drop FLAT CCS check
04d76f28c9fd drm/i915/mtl: Add MTL for remapping CCS FBs
332613fe637d drm/fourcc: define Intel Meteorlake related ccs modifiers
0304dff378ec drm/i915/mtl: Add handling for MTL ccs modifiers
-:56: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#56: FILE: drivers/gpu/drm/i915/display/intel_fb.c:404:
+ if (intel_fb_is_ccs_modifier(md->modifier) &&
+ HAS_FLAT_CCS(i915) != !md->ccs.packed_aux_planes)
total: 0 errors, 0 warnings, 1 checks, 116 lines checked
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
` (3 preceding siblings ...)
2023-05-04 18:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check Patchwork
@ 2023-05-04 18:43 ` Patchwork
2023-05-04 18:54 ` [Intel-gfx] [PATCH 1/4] " Das, Nirmoy
` (7 subsequent siblings)
12 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-05-04 18:43 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check
URL : https://patchwork.freedesktop.org/series/117272/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
` (4 preceding siblings ...)
2023-05-04 18:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2023-05-04 18:54 ` Das, Nirmoy
2023-05-04 19:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] " Patchwork
` (6 subsequent siblings)
12 siblings, 0 replies; 18+ messages in thread
From: Das, Nirmoy @ 2023-05-04 18:54 UTC (permalink / raw)
To: Juha-Pekka Heikkila, intel-gfx; +Cc: Pallavi Mishra
On 5/4/2023 12:28 PM, Juha-Pekka Heikkila wrote:
> From: Pallavi Mishra <pallavi.mishra@intel.com>
>
> Remove FLAT CCS check from XY_FAST_COLOR_BLT usage, thus
> enabling MTL to use it.
>
> Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
I think should fix the mtl migrate selftest failure.
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13108/bat-mtlp-6/igt@i915_selftest@live@migrate.html#dmesg-warnings745
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 3f638f198796..e0998879a0e1 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -920,7 +920,7 @@ static int emit_clear(struct i915_request *rq, u32 offset, int size,
>
> GEM_BUG_ON(size >> PAGE_SHIFT > S16_MAX);
>
> - if (HAS_FLAT_CCS(i915) && ver >= 12)
> + if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50))
> ring_sz = XY_FAST_COLOR_BLT_DW;
> else if (ver >= 8)
> ring_sz = 8;
> @@ -931,7 +931,7 @@ static int emit_clear(struct i915_request *rq, u32 offset, int size,
> if (IS_ERR(cs))
> return PTR_ERR(cs);
>
> - if (HAS_FLAT_CCS(i915) && ver >= 12) {
> + if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> *cs++ = XY_FAST_COLOR_BLT_CMD | XY_FAST_COLOR_BLT_DEPTH_32 |
> (XY_FAST_COLOR_BLT_DW - 2);
> *cs++ = FIELD_PREP(XY_FAST_COLOR_BLT_MOCS_MASK, mocs) |
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
` (5 preceding siblings ...)
2023-05-04 18:54 ` [Intel-gfx] [PATCH 1/4] " Das, Nirmoy
@ 2023-05-04 19:01 ` Patchwork
2023-05-04 21:24 ` [Intel-gfx] [PATCH 1/4] " Andrzej Hajda
` (5 subsequent siblings)
12 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-05-04 19:01 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 7575 bytes --]
== Series Details ==
Series: series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check
URL : https://patchwork.freedesktop.org/series/117272/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13109 -> Patchwork_117272v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_117272v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_117272v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/index.html
Participating hosts (41 -> 38)
------------------------------
Missing (3): fi-kbl-soraka fi-snb-2520m bat-mtlp-6
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_117272v1:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-kbl-7567u: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13109/fi-kbl-7567u/igt@gem_exec_suspend@basic-s3@smem.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/fi-kbl-7567u/igt@gem_exec_suspend@basic-s3@smem.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-3:
- bat-dg2-9: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13109/bat-dg2-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-dg2-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-3.html
Known issues
------------
Here are the changes found in Patchwork_117272v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: NOTRUN -> [ABORT][5] ([i915#6687] / [i915#7978] / [i915#8407])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@mman:
- bat-rpls-2: [PASS][6] -> [TIMEOUT][7] ([i915#6794] / [i915#7392])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13109/bat-rpls-2/igt@i915_selftest@live@mman.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-rpls-2/igt@i915_selftest@live@mman.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][8] ([i915#6367])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-dg1-7: NOTRUN -> [SKIP][9] ([i915#7828])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-dg1-7/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-dg1-7: NOTRUN -> [SKIP][10] ([i915#1845] / [i915#4078])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-dg1-7/igt@kms_pipe_crc_basic@suspend-read-crc.html
#### Possible fixes ####
* igt@i915_selftest@live@migrate:
- {bat-mtlp-8}: [DMESG-FAIL][11] ([i915#7699]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13109/bat-mtlp-8/igt@i915_selftest@live@migrate.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-mtlp-8/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][13] ([i915#4983] / [i915#7911] / [i915#7920]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13109/bat-rpls-1/igt@i915_selftest@live@requests.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- {bat-mtlp-8}: [DMESG-WARN][15] ([i915#6367]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13109/bat-mtlp-8/igt@i915_selftest@live@slpc.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-mtlp-8/igt@i915_selftest@live@slpc.html
* igt@i915_selftest@live@workarounds:
- bat-dg1-7: [ABORT][17] ([i915#4983]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13109/bat-dg1-7/igt@i915_selftest@live@workarounds.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-dg1-7/igt@i915_selftest@live@workarounds.html
* igt@kms_busy@basic@flip:
- {bat-mtlp-8}: [DMESG-WARN][19] ([i915#8379]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13109/bat-mtlp-8/igt@kms_busy@basic@flip.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-mtlp-8/igt@kms_busy@basic@flip.html
* igt@kms_frontbuffer_tracking@basic:
- {bat-mtlp-8}: [DMESG-FAIL][21] ([i915#8379]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13109/bat-mtlp-8/igt@kms_frontbuffer_tracking@basic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-mtlp-8/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
- bat-dg2-8: [FAIL][23] ([i915#7932]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13109/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8379]: https://gitlab.freedesktop.org/drm/intel/issues/8379
[i915#8407]: https://gitlab.freedesktop.org/drm/intel/issues/8407
Build changes
-------------
* Linux: CI_DRM_13109 -> Patchwork_117272v1
CI-20190529: 20190529
CI_DRM_13109: 1c3b807eabfd457e98ccbec6c22cc39b45befed5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7277: 1cb3507f3ff28d11bd5cfabcde576fe78ddab571 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117272v1: 1c3b807eabfd457e98ccbec6c22cc39b45befed5 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
921820675548 drm/i915/mtl: Add handling for MTL ccs modifiers
c89ff4fdf697 drm/fourcc: define Intel Meteorlake related ccs modifiers
8d2e87bf19ed drm/i915/mtl: Add MTL for remapping CCS FBs
021124d35fdb drm/i915/mtl: Drop FLAT CCS check
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v1/index.html
[-- Attachment #2: Type: text/html, Size: 8766 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs
2023-05-04 10:28 ` [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs Juha-Pekka Heikkila
@ 2023-05-04 20:15 ` Sripada, Radhakrishna
2023-05-05 8:38 ` Andi Shyti
1 sibling, 0 replies; 18+ messages in thread
From: Sripada, Radhakrishna @ 2023-05-04 20:15 UTC (permalink / raw)
To: Juha-Pekka Heikkila, intel-gfx@lists.freedesktop.org
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Juha-
> Pekka Heikkila
> Sent: Thursday, May 4, 2023 3:28 AM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs
>
> From: Clint Taylor <clinton.a.taylor@intel.com>
>
> Add support for remapping CCS FBs on MTL to remove the restriction
> of the power-of-two sized stride and the 2MB surface offset alignment
> for these FBs.
>
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
With Alignment of commit message fixed.
Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c
> b/drivers/gpu/drm/i915/display/intel_fb.c
> index e5f637897b5e..c004f08fcfe1 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> @@ -1190,7 +1190,8 @@ bool intel_fb_needs_pot_stride_remap(const struct
> intel_framebuffer *fb)
> {
> struct drm_i915_private *i915 = to_i915(fb->base.dev);
>
> - return IS_ALDERLAKE_P(i915) && intel_fb_uses_dpt(&fb->base);
> + return (IS_ALDERLAKE_P(i915) || DISPLAY_VER(i915) >= 14) &&
> + intel_fb_uses_dpt(&fb->base);
> }
>
> static int intel_fb_pitch(const struct intel_framebuffer *fb, int color_plane,
> unsigned int rotation)
> @@ -1326,9 +1327,10 @@ plane_view_scanout_stride(const struct
> intel_framebuffer *fb, int color_plane,
> unsigned int tile_width,
> unsigned int src_stride_tiles, unsigned int
> dst_stride_tiles)
> {
> + struct drm_i915_private *i915 = to_i915(fb->base.dev);
> unsigned int stride_tiles;
>
> - if (IS_ALDERLAKE_P(to_i915(fb->base.dev)))
> + if (IS_ALDERLAKE_P(i915) || DISPLAY_VER(i915) >= 14)
> stride_tiles = src_stride_tiles;
> else
> stride_tiles = dst_stride_tiles;
> @@ -1522,7 +1524,8 @@ static void intel_fb_view_init(struct drm_i915_private
> *i915, struct intel_fb_vi
> memset(view, 0, sizeof(*view));
> view->gtt.type = view_type;
>
> - if (view_type == I915_GTT_VIEW_REMAPPED &&
> IS_ALDERLAKE_P(i915))
> + if (view_type == I915_GTT_VIEW_REMAPPED &&
> + (IS_ALDERLAKE_P(i915) || DISPLAY_VER(i915) >= 14))
> view->gtt.remapped.plane_alignment = SZ_2M / PAGE_SIZE;
> }
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
` (6 preceding siblings ...)
2023-05-04 19:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] " Patchwork
@ 2023-05-04 21:24 ` Andrzej Hajda
2023-05-05 8:36 ` Andi Shyti
` (4 subsequent siblings)
12 siblings, 0 replies; 18+ messages in thread
From: Andrzej Hajda @ 2023-05-04 21:24 UTC (permalink / raw)
To: Juha-Pekka Heikkila, intel-gfx; +Cc: Pallavi Mishra
On 04.05.2023 12:28, Juha-Pekka Heikkila wrote:
> From: Pallavi Mishra <pallavi.mishra@intel.com>
>
> Remove FLAT CCS check from XY_FAST_COLOR_BLT usage, thus
> enabling MTL to use it.
>
> Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 3f638f198796..e0998879a0e1 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -920,7 +920,7 @@ static int emit_clear(struct i915_request *rq, u32 offset, int size,
>
> GEM_BUG_ON(size >> PAGE_SHIFT > S16_MAX);
>
> - if (HAS_FLAT_CCS(i915) && ver >= 12)
> + if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50))
> ring_sz = XY_FAST_COLOR_BLT_DW;
> else if (ver >= 8)
> ring_sz = 8;
> @@ -931,7 +931,7 @@ static int emit_clear(struct i915_request *rq, u32 offset, int size,
> if (IS_ERR(cs))
> return PTR_ERR(cs);
>
> - if (HAS_FLAT_CCS(i915) && ver >= 12) {
> + if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> *cs++ = XY_FAST_COLOR_BLT_CMD | XY_FAST_COLOR_BLT_DEPTH_32 |
> (XY_FAST_COLOR_BLT_DW - 2);
> *cs++ = FIELD_PREP(XY_FAST_COLOR_BLT_MOCS_MASK, mocs) |
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
` (7 preceding siblings ...)
2023-05-04 21:24 ` [Intel-gfx] [PATCH 1/4] " Andrzej Hajda
@ 2023-05-05 8:36 ` Andi Shyti
2023-05-05 19:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2) Patchwork
` (3 subsequent siblings)
12 siblings, 0 replies; 18+ messages in thread
From: Andi Shyti @ 2023-05-05 8:36 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: Pallavi Mishra, intel-gfx
Hi JP,
On Thu, May 04, 2023 at 01:28:02PM +0300, Juha-Pekka Heikkila wrote:
> From: Pallavi Mishra <pallavi.mishra@intel.com>
>
> Remove FLAT CCS check from XY_FAST_COLOR_BLT usage, thus
> enabling MTL to use it.
>
> Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs
2023-05-04 10:28 ` [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs Juha-Pekka Heikkila
2023-05-04 20:15 ` Sripada, Radhakrishna
@ 2023-05-05 8:38 ` Andi Shyti
1 sibling, 0 replies; 18+ messages in thread
From: Andi Shyti @ 2023-05-05 8:38 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: intel-gfx
On Thu, May 04, 2023 at 01:28:03PM +0300, Juha-Pekka Heikkila wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
>
> Add support for remapping CCS FBs on MTL to remove the restriction
> of the power-of-two sized stride and the 2MB surface offset alignment
> for these FBs.
The alignment here is off.
Andi
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2)
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
` (8 preceding siblings ...)
2023-05-05 8:36 ` Andi Shyti
@ 2023-05-05 19:48 ` Patchwork
2023-05-05 19:48 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (2 subsequent siblings)
12 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-05-05 19:48 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2)
URL : https://patchwork.freedesktop.org/series/117272/
State : warning
== Summary ==
Error: dim checkpatch failed
dc3883be8311 drm/i915/mtl: Drop FLAT CCS check
e09733f11ed1 drm/i915/mtl: Add MTL for remapping CCS FBs
6fd87f83a0af drm/fourcc: define Intel Meteorlake related ccs modifiers
66b3940de554 drm/i915/mtl: Add handling for MTL ccs modifiers
-:56: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#56: FILE: drivers/gpu/drm/i915/display/intel_fb.c:404:
+ if (intel_fb_is_ccs_modifier(md->modifier) &&
+ HAS_FLAT_CCS(i915) != !md->ccs.packed_aux_planes)
total: 0 errors, 0 warnings, 1 checks, 116 lines checked
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2)
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
` (9 preceding siblings ...)
2023-05-05 19:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2) Patchwork
@ 2023-05-05 19:48 ` Patchwork
2023-05-05 19:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-06 13:18 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
12 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-05-05 19:48 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2)
URL : https://patchwork.freedesktop.org/series/117272/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2)
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
` (10 preceding siblings ...)
2023-05-05 19:48 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2023-05-05 19:58 ` Patchwork
2023-05-06 13:18 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
12 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-05-05 19:58 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6242 bytes --]
== Series Details ==
Series: series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2)
URL : https://patchwork.freedesktop.org/series/117272/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13114 -> Patchwork_117272v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/index.html
Participating hosts (40 -> 39)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_117272v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@reset:
- bat-rpls-1: NOTRUN -> [ABORT][1] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- bat-rplp-1: [PASS][2] -> [DMESG-WARN][3] ([i915#6367])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/bat-rplp-1/igt@i915_selftest@live@slpc.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-rplp-1/igt@i915_selftest@live@slpc.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-2: NOTRUN -> [SKIP][4] ([i915#7828])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
- bat-adlp-6: NOTRUN -> [SKIP][5] ([i915#7828])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-adlp-6/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
- bat-jsl-3: NOTRUN -> [SKIP][6] ([i915#7828])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-jsl-3/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-2: NOTRUN -> [SKIP][7] ([i915#1845])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-rpls-2/igt@kms_pipe_crc_basic@suspend-read-crc.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-2: [ABORT][8] ([i915#6687] / [i915#7978]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/bat-rpls-2/igt@gem_exec_suspend@basic-s3@smem.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-rpls-2/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@hangcheck:
- bat-adlp-6: [ABORT][10] ([i915#7677] / [i915#7913]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/bat-adlp-6/igt@i915_selftest@live@hangcheck.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-adlp-6/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@migrate:
- {bat-mtlp-8}: [DMESG-FAIL][12] ([i915#7699]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/bat-mtlp-8/igt@i915_selftest@live@migrate.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-mtlp-8/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][14] ([i915#4983] / [i915#7911] / [i915#7920]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/bat-rpls-1/igt@i915_selftest@live@requests.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@kms_busy@basic@flip:
- {bat-mtlp-8}: [DMESG-WARN][16] ([i915#8379]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/bat-mtlp-8/igt@kms_busy@basic@flip.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-mtlp-8/igt@kms_busy@basic@flip.html
* igt@kms_frontbuffer_tracking@basic:
- {bat-mtlp-8}: [DMESG-FAIL][18] ([i915#1982] / [i915#8379]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/bat-mtlp-8/igt@kms_frontbuffer_tracking@basic.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/bat-mtlp-8/igt@kms_frontbuffer_tracking@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8379]: https://gitlab.freedesktop.org/drm/intel/issues/8379
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
Build changes
-------------
* Linux: CI_DRM_13114 -> Patchwork_117272v2
CI-20190529: 20190529
CI_DRM_13114: b4d6f70062cd04a8fdb9872828bcbe4767a4f833 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7281: 9e9cd7e69a393b7cce8fc12fce409eb59817dd7e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117272v2: b4d6f70062cd04a8fdb9872828bcbe4767a4f833 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
4a7160d6edb7 drm/i915/mtl: Add handling for MTL ccs modifiers
a4ed70ab9bb9 drm/fourcc: define Intel Meteorlake related ccs modifiers
10b2f27a32fd drm/i915/mtl: Add MTL for remapping CCS FBs
963a030ad590 drm/i915/mtl: Drop FLAT CCS check
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/index.html
[-- Attachment #2: Type: text/html, Size: 7401 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2)
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
` (11 preceding siblings ...)
2023-05-05 19:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-05-06 13:18 ` Patchwork
12 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2023-05-06 13:18 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10961 bytes --]
== Series Details ==
Series: series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2)
URL : https://patchwork.freedesktop.org/series/117272/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13114_full -> Patchwork_117272v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_117272v2_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
- {shard-dg1}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-dg1-17/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-dg1-17/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
Known issues
------------
Here are the changes found in Patchwork_117272v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@process:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-snb6/igt@gem_ctx_persistence@process.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271]) +110 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-snb6/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_flip@plain-flip-fb-recreate@b-hdmi-a2:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2122])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-glk7/igt@kms_flip@plain-flip-fb-recreate@b-hdmi-a2.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-glk2/igt@kms_flip@plain-flip-fb-recreate@b-hdmi-a2.html
* igt@perf@stress-open-close@0-rcs0:
- shard-glk: [PASS][7] -> [ABORT][8] ([i915#5213] / [i915#7941])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-glk9/igt@perf@stress-open-close@0-rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-glk7/igt@perf@stress-open-close@0-rcs0.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][9] ([i915#6268]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-tglu-10/igt@gem_ctx_exec@basic-nohangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-rkl}: [FAIL][11] ([i915#2842]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-rkl-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-rkl-1/igt@gem_exec_fair@basic-pace-share@rcs0.html
- {shard-tglu}: [FAIL][13] ([i915#2842]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-tglu-8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-tglu-6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][15] ([i915#2842]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [FAIL][17] ([i915#2842]) -> [PASS][18] +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-glk3/igt@gem_exec_fair@basic-pace@vcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-glk8/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_suspend@basic-s4-devices@lmem0:
- {shard-dg1}: [ABORT][19] ([i915#7975] / [i915#8213]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-dg1-14/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-dg1-16/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
* igt@gem_mmap_gtt@fault-concurrent-y:
- shard-snb: [ABORT][21] ([i915#5161]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-snb2/igt@gem_mmap_gtt@fault-concurrent-y.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-snb6/igt@gem_mmap_gtt@fault-concurrent-y.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-tglu}: [SKIP][23] ([i915#4281]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-tglu-6/igt@i915_pm_dc@dc9-dpms.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-tglu-9/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][25] ([i915#1397]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-rkl-6/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][27] ([i915#2346]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][29] ([i915#2346]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-suspend@b-vga1:
- shard-snb: [DMESG-WARN][31] ([i915#5090]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13114/shard-snb2/igt@kms_flip@flip-vs-suspend@b-vga1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/shard-snb6/igt@kms_flip@flip-vs-suspend@b-vga1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#5090]: https://gitlab.freedesktop.org/drm/intel/issues/5090
[i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8304]: https://gitlab.freedesktop.org/drm/intel/issues/8304
Build changes
-------------
* Linux: CI_DRM_13114 -> Patchwork_117272v2
CI-20190529: 20190529
CI_DRM_13114: b4d6f70062cd04a8fdb9872828bcbe4767a4f833 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7281: 9e9cd7e69a393b7cce8fc12fce409eb59817dd7e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117272v2: b4d6f70062cd04a8fdb9872828bcbe4767a4f833 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117272v2/index.html
[-- Attachment #2: Type: text/html, Size: 10001 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH 4/4] drm/i915/mtl: Add handling for MTL ccs modifiers
2023-05-04 10:28 ` [Intel-gfx] [PATCH 4/4] drm/i915/mtl: Add handling for MTL " Juha-Pekka Heikkila
@ 2023-05-08 11:41 ` Kahola, Mika
2023-05-09 11:58 ` Juha-Pekka Heikkila
0 siblings, 1 reply; 18+ messages in thread
From: Kahola, Mika @ 2023-05-08 11:41 UTC (permalink / raw)
To: Juha-Pekka Heikkila, intel-gfx@lists.freedesktop.org
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Juha-Pekka Heikkila
> Sent: Thursday, May 4, 2023 1:28 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 4/4] drm/i915/mtl: Add handling for MTL ccs modifiers
>
> Add Tile4 ccs modifiers w/ auxbuffer handling
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 42 ++++++++++++++++++-
> .../drm/i915/display/skl_universal_plane.c | 22 +++++++++-
> 2 files changed, 61 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
> index c004f08fcfe1..f9420a68ed3c 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> @@ -157,6 +157,32 @@ struct intel_modifier_desc {
>
> static const struct intel_modifier_desc intel_modifiers[] = {
> {
> + .modifier = I915_FORMAT_MOD_4_TILED_MTL_MC_CCS,
> + .display_ver = { 14, 14 },
> + .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_MC,
> +
> + .ccs.packed_aux_planes = BIT(1),
> + .ccs.planar_aux_planes = BIT(2) | BIT(3),
> +
> + FORMAT_OVERRIDE(gen12_ccs_formats),
> + }, {
> + .modifier = I915_FORMAT_MOD_4_TILED_MTL_RC_CCS,
> + .display_ver = { 14, 14 },
> + .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_RC,
> +
> + .ccs.packed_aux_planes = BIT(1),
> +
> + FORMAT_OVERRIDE(gen12_ccs_formats),
> + }, {
> + .modifier = I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC,
> + .display_ver = { 14, 14 },
> + .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_RC_CC,
> +
> + .ccs.cc_planes = BIT(2),
> + .ccs.packed_aux_planes = BIT(1),
Nitpick, earlier we have defined order in BIT(1), BIT(2), etc. but here we have BIT(2) defined before BIT(1). Maybe define BIT(1) here before BIT2)?
Otherwise, patch looks ok to me.
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
> +
> + FORMAT_OVERRIDE(gen12_ccs_cc_formats),
> + }, {
> .modifier = I915_FORMAT_MOD_4_TILED_DG2_MC_CCS,
> .display_ver = { 13, 13 },
> .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_MC, @@ -370,6 +396,14 @@ static bool
> plane_has_modifier(struct drm_i915_private *i915,
> if (!plane_caps_contain_all(plane_caps, md->plane_caps))
> return false;
>
> + /*
> + * Separate AuxCCS and Flat CCS modifiers to be run only on platforms
> + * where supported.
> + */
> + if (intel_fb_is_ccs_modifier(md->modifier) &&
> + HAS_FLAT_CCS(i915) != !md->ccs.packed_aux_planes)
> + return false;
> +
> return true;
> }
>
> @@ -489,7 +523,7 @@ static bool intel_fb_is_gen12_ccs_aux_plane(const struct drm_framebuffer *fb, in {
> const struct intel_modifier_desc *md = lookup_modifier(fb->modifier);
>
> - return check_modifier_display_ver_range(md, 12, 13) &&
> + return check_modifier_display_ver_range(md, 12, 14) &&
> ccs_aux_plane_mask(md, fb->format) & BIT(color_plane); }
>
> @@ -605,6 +639,9 @@ intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane)
> if (intel_fb_is_ccs_aux_plane(fb, color_plane))
> return 128;
> fallthrough;
> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS:
> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC:
> + case I915_FORMAT_MOD_4_TILED_MTL_MC_CCS:
> case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
> case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
> case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
> @@ -791,6 +828,9 @@ unsigned int intel_surf_alignment(const struct drm_framebuffer *fb,
> case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
> case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
> case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
> + case I915_FORMAT_MOD_4_TILED_MTL_MC_CCS:
> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS:
> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC:
> return 16 * 1024;
> case I915_FORMAT_MOD_Y_TILED_CCS:
> case I915_FORMAT_MOD_Yf_TILED_CCS:
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index 8ea0598a5a07..f6f760e59c9e 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -789,6 +789,14 @@ static u32 skl_plane_ctl_tiling(u64 fb_modifier)
> PLANE_CTL_CLEAR_COLOR_DISABLE;
> case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
> return PLANE_CTL_TILED_4 | PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS:
> + return PLANE_CTL_TILED_4 |
> + PLANE_CTL_RENDER_DECOMPRESSION_ENABLE |
> + PLANE_CTL_CLEAR_COLOR_DISABLE;
> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC:
> + return PLANE_CTL_TILED_4 | PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
> + case I915_FORMAT_MOD_4_TILED_MTL_MC_CCS:
> + return PLANE_CTL_TILED_4 | PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE;
> case I915_FORMAT_MOD_Y_TILED_CCS:
> case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
> return PLANE_CTL_TILED_Y | PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
> @@ -2160,6 +2168,11 @@ skl_plane_disable_flip_done(struct intel_plane *plane) static bool skl_plane_has_rc_ccs(struct
> drm_i915_private *i915,
> enum pipe pipe, enum plane_id plane_id) {
> + /* Wa_14017240301 */
> + if (IS_MTL_GRAPHICS_STEP(i915, M, STEP_A0, STEP_B0) ||
> + IS_MTL_GRAPHICS_STEP(i915, P, STEP_A0, STEP_B0))
> + return false;
> +
> /* Wa_22011186057 */
> if (IS_ADLP_DISPLAY_STEP(i915, STEP_A0, STEP_B0))
> return false;
> @@ -2441,12 +2454,17 @@ skl_get_initial_plane_config(struct intel_crtc *crtc,
> case PLANE_CTL_TILED_Y:
> plane_config->tiling = I915_TILING_Y;
> if (val & PLANE_CTL_RENDER_DECOMPRESSION_ENABLE)
> - if (DISPLAY_VER(dev_priv) >= 12)
> + if (DISPLAY_VER(dev_priv) >= 14)
> + fb->modifier = I915_FORMAT_MOD_4_TILED_MTL_RC_CCS;
> + else if (DISPLAY_VER(dev_priv) >= 12)
> fb->modifier = I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS;
> else
> fb->modifier = I915_FORMAT_MOD_Y_TILED_CCS;
> else if (val & PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE)
> - fb->modifier = I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS;
> + if (DISPLAY_VER(dev_priv) >= 14)
> + fb->modifier = I915_FORMAT_MOD_4_TILED_MTL_MC_CCS;
> + else
> + fb->modifier = I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS;
> else
> fb->modifier = I915_FORMAT_MOD_Y_TILED;
> break;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH 4/4] drm/i915/mtl: Add handling for MTL ccs modifiers
2023-05-08 11:41 ` Kahola, Mika
@ 2023-05-09 11:58 ` Juha-Pekka Heikkila
0 siblings, 0 replies; 18+ messages in thread
From: Juha-Pekka Heikkila @ 2023-05-09 11:58 UTC (permalink / raw)
To: Kahola, Mika, intel-gfx@lists.freedesktop.org
On 8.5.2023 14.41, Kahola, Mika wrote:
>> -----Original Message-----
>> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Juha-Pekka Heikkila
>> Sent: Thursday, May 4, 2023 1:28 PM
>> To: intel-gfx@lists.freedesktop.org
>> Subject: [Intel-gfx] [PATCH 4/4] drm/i915/mtl: Add handling for MTL ccs modifiers
>>
>> Add Tile4 ccs modifiers w/ auxbuffer handling
>>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_fb.c | 42 ++++++++++++++++++-
>> .../drm/i915/display/skl_universal_plane.c | 22 +++++++++-
>> 2 files changed, 61 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
>> index c004f08fcfe1..f9420a68ed3c 100644
>> --- a/drivers/gpu/drm/i915/display/intel_fb.c
>> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
>> @@ -157,6 +157,32 @@ struct intel_modifier_desc {
>>
>> static const struct intel_modifier_desc intel_modifiers[] = {
>> {
>> + .modifier = I915_FORMAT_MOD_4_TILED_MTL_MC_CCS,
>> + .display_ver = { 14, 14 },
>> + .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_MC,
>> +
>> + .ccs.packed_aux_planes = BIT(1),
>> + .ccs.planar_aux_planes = BIT(2) | BIT(3),
>> +
>> + FORMAT_OVERRIDE(gen12_ccs_formats),
>> + }, {
>> + .modifier = I915_FORMAT_MOD_4_TILED_MTL_RC_CCS,
>> + .display_ver = { 14, 14 },
>> + .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_RC,
>> +
>> + .ccs.packed_aux_planes = BIT(1),
>> +
>> + FORMAT_OVERRIDE(gen12_ccs_formats),
>> + }, {
>> + .modifier = I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC,
>> + .display_ver = { 14, 14 },
>> + .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_RC_CC,
>> +
>> + .ccs.cc_planes = BIT(2),
>> + .ccs.packed_aux_planes = BIT(1),
>
> Nitpick, earlier we have defined order in BIT(1), BIT(2), etc. but here we have BIT(2) defined before BIT(1). Maybe define BIT(1) here before BIT2)?
While I agree with your comment this follow how rc ccs cc is earlier
defined in same table for I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC. I'd
stick with current order and later time do cleanups if needed.
>
> Otherwise, patch looks ok to me.
>
> Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Thanks!
/Juha-Pekka
>
>> +
>> + FORMAT_OVERRIDE(gen12_ccs_cc_formats),
>> + }, {
>> .modifier = I915_FORMAT_MOD_4_TILED_DG2_MC_CCS,
>> .display_ver = { 13, 13 },
>> .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_MC, @@ -370,6 +396,14 @@ static bool
>> plane_has_modifier(struct drm_i915_private *i915,
>> if (!plane_caps_contain_all(plane_caps, md->plane_caps))
>> return false;
>>
>> + /*
>> + * Separate AuxCCS and Flat CCS modifiers to be run only on platforms
>> + * where supported.
>> + */
>> + if (intel_fb_is_ccs_modifier(md->modifier) &&
>> + HAS_FLAT_CCS(i915) != !md->ccs.packed_aux_planes)
>> + return false;
>> +
>> return true;
>> }
>>
>> @@ -489,7 +523,7 @@ static bool intel_fb_is_gen12_ccs_aux_plane(const struct drm_framebuffer *fb, in {
>> const struct intel_modifier_desc *md = lookup_modifier(fb->modifier);
>>
>> - return check_modifier_display_ver_range(md, 12, 13) &&
>> + return check_modifier_display_ver_range(md, 12, 14) &&
>> ccs_aux_plane_mask(md, fb->format) & BIT(color_plane); }
>>
>> @@ -605,6 +639,9 @@ intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane)
>> if (intel_fb_is_ccs_aux_plane(fb, color_plane))
>> return 128;
>> fallthrough;
>> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS:
>> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC:
>> + case I915_FORMAT_MOD_4_TILED_MTL_MC_CCS:
>> case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
>> case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
>> case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
>> @@ -791,6 +828,9 @@ unsigned int intel_surf_alignment(const struct drm_framebuffer *fb,
>> case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
>> case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
>> case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
>> + case I915_FORMAT_MOD_4_TILED_MTL_MC_CCS:
>> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS:
>> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC:
>> return 16 * 1024;
>> case I915_FORMAT_MOD_Y_TILED_CCS:
>> case I915_FORMAT_MOD_Yf_TILED_CCS:
>> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
>> index 8ea0598a5a07..f6f760e59c9e 100644
>> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
>> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
>> @@ -789,6 +789,14 @@ static u32 skl_plane_ctl_tiling(u64 fb_modifier)
>> PLANE_CTL_CLEAR_COLOR_DISABLE;
>> case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
>> return PLANE_CTL_TILED_4 | PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
>> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS:
>> + return PLANE_CTL_TILED_4 |
>> + PLANE_CTL_RENDER_DECOMPRESSION_ENABLE |
>> + PLANE_CTL_CLEAR_COLOR_DISABLE;
>> + case I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC:
>> + return PLANE_CTL_TILED_4 | PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
>> + case I915_FORMAT_MOD_4_TILED_MTL_MC_CCS:
>> + return PLANE_CTL_TILED_4 | PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE;
>> case I915_FORMAT_MOD_Y_TILED_CCS:
>> case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
>> return PLANE_CTL_TILED_Y | PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
>> @@ -2160,6 +2168,11 @@ skl_plane_disable_flip_done(struct intel_plane *plane) static bool skl_plane_has_rc_ccs(struct
>> drm_i915_private *i915,
>> enum pipe pipe, enum plane_id plane_id) {
>> + /* Wa_14017240301 */
>> + if (IS_MTL_GRAPHICS_STEP(i915, M, STEP_A0, STEP_B0) ||
>> + IS_MTL_GRAPHICS_STEP(i915, P, STEP_A0, STEP_B0))
>> + return false;
>> +
>> /* Wa_22011186057 */
>> if (IS_ADLP_DISPLAY_STEP(i915, STEP_A0, STEP_B0))
>> return false;
>> @@ -2441,12 +2454,17 @@ skl_get_initial_plane_config(struct intel_crtc *crtc,
>> case PLANE_CTL_TILED_Y:
>> plane_config->tiling = I915_TILING_Y;
>> if (val & PLANE_CTL_RENDER_DECOMPRESSION_ENABLE)
>> - if (DISPLAY_VER(dev_priv) >= 12)
>> + if (DISPLAY_VER(dev_priv) >= 14)
>> + fb->modifier = I915_FORMAT_MOD_4_TILED_MTL_RC_CCS;
>> + else if (DISPLAY_VER(dev_priv) >= 12)
>> fb->modifier = I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS;
>> else
>> fb->modifier = I915_FORMAT_MOD_Y_TILED_CCS;
>> else if (val & PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE)
>> - fb->modifier = I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS;
>> + if (DISPLAY_VER(dev_priv) >= 14)
>> + fb->modifier = I915_FORMAT_MOD_4_TILED_MTL_MC_CCS;
>> + else
>> + fb->modifier = I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS;
>> else
>> fb->modifier = I915_FORMAT_MOD_Y_TILED;
>> break;
>> --
>> 2.25.1
>
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2023-05-09 11:58 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-04 10:28 [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check Juha-Pekka Heikkila
2023-05-04 10:28 ` [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs Juha-Pekka Heikkila
2023-05-04 20:15 ` Sripada, Radhakrishna
2023-05-05 8:38 ` Andi Shyti
2023-05-04 10:28 ` [Intel-gfx] [PATCH 3/4] drm/fourcc: define Intel Meteorlake related ccs modifiers Juha-Pekka Heikkila
2023-05-04 10:28 ` [Intel-gfx] [PATCH 4/4] drm/i915/mtl: Add handling for MTL " Juha-Pekka Heikkila
2023-05-08 11:41 ` Kahola, Mika
2023-05-09 11:58 ` Juha-Pekka Heikkila
2023-05-04 18:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check Patchwork
2023-05-04 18:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-05-04 18:54 ` [Intel-gfx] [PATCH 1/4] " Das, Nirmoy
2023-05-04 19:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] " Patchwork
2023-05-04 21:24 ` [Intel-gfx] [PATCH 1/4] " Andrzej Hajda
2023-05-05 8:36 ` Andi Shyti
2023-05-05 19:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check (rev2) Patchwork
2023-05-05 19:48 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-05-05 19:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-06 13:18 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox