* [Intel-gfx] [PATCH] drm/i915/gt: drop dependency on VLV_DISPLAY_BASE
@ 2023-05-11 9:04 Jani Nikula
2023-05-11 11:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jani Nikula @ 2023-05-11 9:04 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
CHV_FUSE_GT (0x182168) is purely about GT fuses, therefore belongs in
intel_gt_regs.h, is in the gcfgmmio unit, but is technically in the VLV
display base area.
Use the 0x182168 MMIO address directly to drop dependency on
VLV_DISPLAY_BASE and thus display/intel_display_reg_defs.h in
intel_gt_regs.h.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
index b8a39c219b60..f38550dae6b8 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
@@ -7,7 +7,6 @@
#define __INTEL_GT_REGS__
#include "i915_reg_defs.h"
-#include "display/intel_display_reg_defs.h" /* VLV_DISPLAY_BASE */
/*
* The perf control registers are technically multicast registers, but the
@@ -1469,7 +1468,7 @@
#define GEN12_RCU_MODE _MMIO(0x14800)
#define GEN12_RCU_MODE_CCS_ENABLE REG_BIT(0)
-#define CHV_FUSE_GT _MMIO(VLV_DISPLAY_BASE + 0x2168)
+#define CHV_FUSE_GT _MMIO(0x182168)
#define CHV_FGT_DISABLE_SS0 (1 << 10)
#define CHV_FGT_DISABLE_SS1 (1 << 11)
#define CHV_FGT_EU_DIS_SS0_R0_SHIFT 16
--
2.39.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: drop dependency on VLV_DISPLAY_BASE
2023-05-11 9:04 [Intel-gfx] [PATCH] drm/i915/gt: drop dependency on VLV_DISPLAY_BASE Jani Nikula
@ 2023-05-11 11:00 ` Patchwork
2023-05-11 12:20 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2023-05-11 13:30 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2023-05-11 11:00 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8263 bytes --]
== Series Details ==
Series: drm/i915/gt: drop dependency on VLV_DISPLAY_BASE
URL : https://patchwork.freedesktop.org/series/117620/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13133 -> Patchwork_117620v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/index.html
Participating hosts (41 -> 38)
------------------------------
Missing (3): fi-kbl-soraka bat-rpls-2 fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_117620v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@dmabuf@all-tests@dma_fence:
- fi-glk-j4005: [PASS][1] -> [ABORT][2] ([i915#8144])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/fi-glk-j4005/igt@dmabuf@all-tests@dma_fence.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/fi-glk-j4005/igt@dmabuf@all-tests@dma_fence.html
* igt@dmabuf@all-tests@dma_fence_chain:
- fi-glk-j4005: [PASS][3] -> [DMESG-FAIL][4] ([i915#8144])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/fi-glk-j4005/igt@dmabuf@all-tests@dma_fence_chain.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/fi-glk-j4005/igt@dmabuf@all-tests@dma_fence_chain.html
* igt@gem_exec_suspend@basic-s0@lmem0:
- bat-dg1-7: [PASS][5] -> [FAIL][6] ([fdo#103375] / [i915#8011]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/bat-dg1-7/igt@gem_exec_suspend@basic-s0@lmem0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-dg1-7/igt@gem_exec_suspend@basic-s0@lmem0.html
* igt@gem_exec_suspend@basic-s3@smem:
- bat-dg1-7: [PASS][7] -> [FAIL][8] ([fdo#103375]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/bat-dg1-7/igt@gem_exec_suspend@basic-s3@smem.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-dg1-7/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_pm_backlight@basic-brightness@edp-1:
- bat-rplp-1: NOTRUN -> [ABORT][9] ([i915#7077])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-rplp-1/igt@i915_pm_backlight@basic-brightness@edp-1.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][10] -> [DMESG-FAIL][11] ([i915#5334])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@migrate:
- bat-atsm-1: [PASS][12] -> [DMESG-FAIL][13] ([i915#7699] / [i915#7913])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/bat-atsm-1/igt@i915_selftest@live@migrate.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-atsm-1/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][14] ([i915#6367] / [i915#7953])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][15] ([i915#6687] / [i915#7953] / [i915#7978])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
- bat-dg2-8: [PASS][16] -> [FAIL][17] ([i915#7932]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-9: NOTRUN -> [SKIP][18] ([i915#3546]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-adlp-9/igt@kms_pipe_crc_basic@read-crc.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: NOTRUN -> [SKIP][19] ([i915#3555] / [i915#4579])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_lrc:
- bat-rpls-1: [INCOMPLETE][20] ([i915#4983] / [i915#7953]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/bat-rpls-1/igt@i915_selftest@live@gt_lrc.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-rpls-1/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@requests:
- {bat-mtlp-6}: [ABORT][22] ([i915#4983] / [i915#7920] / [i915#7953]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/bat-mtlp-6/igt@i915_selftest@live@requests.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-mtlp-6/igt@i915_selftest@live@requests.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [FAIL][24] ([i915#7932]) -> [PASS][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
#### Warnings ####
* igt@kms_psr@primary_mmap_gtt:
- bat-rplp-1: [ABORT][26] -> [SKIP][27] ([i915#1072])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8144]: https://gitlab.freedesktop.org/drm/intel/issues/8144
Build changes
-------------
* Linux: CI_DRM_13133 -> Patchwork_117620v1
CI-20190529: 20190529
CI_DRM_13133: 9de28734b7c6180707b305c9d736b439fb02e032 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7285: d1cbf2bad9c2664ab8bd3bd0946510a52800912f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117620v1: 9de28734b7c6180707b305c9d736b439fb02e032 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
d6069d14de2c drm/i915/gt: drop dependency on VLV_DISPLAY_BASE
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/index.html
[-- Attachment #2: Type: text/html, Size: 9381 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: drop dependency on VLV_DISPLAY_BASE
2023-05-11 9:04 [Intel-gfx] [PATCH] drm/i915/gt: drop dependency on VLV_DISPLAY_BASE Jani Nikula
2023-05-11 11:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-05-11 12:20 ` Ville Syrjälä
2023-05-11 12:31 ` Jani Nikula
2023-05-11 13:30 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjälä @ 2023-05-11 12:20 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, May 11, 2023 at 12:04:27PM +0300, Jani Nikula wrote:
> CHV_FUSE_GT (0x182168) is purely about GT fuses, therefore belongs in
> intel_gt_regs.h, is in the gcfgmmio unit, but is technically in the VLV
> display base area.
>
> Use the 0x182168 MMIO address directly to drop dependency on
> VLV_DISPLAY_BASE and thus display/intel_display_reg_defs.h in
> intel_gt_regs.h.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> index b8a39c219b60..f38550dae6b8 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> @@ -7,7 +7,6 @@
> #define __INTEL_GT_REGS__
>
> #include "i915_reg_defs.h"
> -#include "display/intel_display_reg_defs.h" /* VLV_DISPLAY_BASE */
>
> /*
> * The perf control registers are technically multicast registers, but the
> @@ -1469,7 +1468,7 @@
> #define GEN12_RCU_MODE _MMIO(0x14800)
> #define GEN12_RCU_MODE_CCS_ENABLE REG_BIT(0)
>
> -#define CHV_FUSE_GT _MMIO(VLV_DISPLAY_BASE + 0x2168)
> +#define CHV_FUSE_GT _MMIO(0x182168)
Or mmaybe s/VLV_DISPLAY_BASE/VLV_GUNIT_BASE/ here? Although all the
other Gunit register defintions are still in i915_reg.h, and using
VLV_DISPLAY_BASE. Not sure what to do about all that...
> #define CHV_FGT_DISABLE_SS0 (1 << 10)
> #define CHV_FGT_DISABLE_SS1 (1 << 11)
> #define CHV_FGT_EU_DIS_SS0_R0_SHIFT 16
> --
> 2.39.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: drop dependency on VLV_DISPLAY_BASE
2023-05-11 12:20 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2023-05-11 12:31 ` Jani Nikula
2023-05-11 12:33 ` Ville Syrjälä
0 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2023-05-11 12:31 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Thu, 11 May 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, May 11, 2023 at 12:04:27PM +0300, Jani Nikula wrote:
>> CHV_FUSE_GT (0x182168) is purely about GT fuses, therefore belongs in
>> intel_gt_regs.h, is in the gcfgmmio unit, but is technically in the VLV
>> display base area.
>>
>> Use the 0x182168 MMIO address directly to drop dependency on
>> VLV_DISPLAY_BASE and thus display/intel_display_reg_defs.h in
>> intel_gt_regs.h.
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
>> index b8a39c219b60..f38550dae6b8 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
>> +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
>> @@ -7,7 +7,6 @@
>> #define __INTEL_GT_REGS__
>>
>> #include "i915_reg_defs.h"
>> -#include "display/intel_display_reg_defs.h" /* VLV_DISPLAY_BASE */
>>
>> /*
>> * The perf control registers are technically multicast registers, but the
>> @@ -1469,7 +1468,7 @@
>> #define GEN12_RCU_MODE _MMIO(0x14800)
>> #define GEN12_RCU_MODE_CCS_ENABLE REG_BIT(0)
>>
>> -#define CHV_FUSE_GT _MMIO(VLV_DISPLAY_BASE + 0x2168)
>> +#define CHV_FUSE_GT _MMIO(0x182168)
>
> Or mmaybe s/VLV_DISPLAY_BASE/VLV_GUNIT_BASE/ here? Although all the
> other Gunit register defintions are still in i915_reg.h, and using
> VLV_DISPLAY_BASE. Not sure what to do about all that...
Works for me, as long as I can drop the dependency on
display/intel_display_reg_defs.h.
Just let me know.
BR,
Jani.
>
>> #define CHV_FGT_DISABLE_SS0 (1 << 10)
>> #define CHV_FGT_DISABLE_SS1 (1 << 11)
>> #define CHV_FGT_EU_DIS_SS0_R0_SHIFT 16
>> --
>> 2.39.2
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: drop dependency on VLV_DISPLAY_BASE
2023-05-11 12:31 ` Jani Nikula
@ 2023-05-11 12:33 ` Ville Syrjälä
2023-05-11 12:46 ` Jani Nikula
0 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjälä @ 2023-05-11 12:33 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, May 11, 2023 at 03:31:16PM +0300, Jani Nikula wrote:
> On Thu, 11 May 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Thu, May 11, 2023 at 12:04:27PM +0300, Jani Nikula wrote:
> >> CHV_FUSE_GT (0x182168) is purely about GT fuses, therefore belongs in
> >> intel_gt_regs.h, is in the gcfgmmio unit, but is technically in the VLV
> >> display base area.
> >>
> >> Use the 0x182168 MMIO address directly to drop dependency on
> >> VLV_DISPLAY_BASE and thus display/intel_display_reg_defs.h in
> >> intel_gt_regs.h.
> >>
> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> >> index b8a39c219b60..f38550dae6b8 100644
> >> --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> >> +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> >> @@ -7,7 +7,6 @@
> >> #define __INTEL_GT_REGS__
> >>
> >> #include "i915_reg_defs.h"
> >> -#include "display/intel_display_reg_defs.h" /* VLV_DISPLAY_BASE */
> >>
> >> /*
> >> * The perf control registers are technically multicast registers, but the
> >> @@ -1469,7 +1468,7 @@
> >> #define GEN12_RCU_MODE _MMIO(0x14800)
> >> #define GEN12_RCU_MODE_CCS_ENABLE REG_BIT(0)
> >>
> >> -#define CHV_FUSE_GT _MMIO(VLV_DISPLAY_BASE + 0x2168)
> >> +#define CHV_FUSE_GT _MMIO(0x182168)
> >
> > Or mmaybe s/VLV_DISPLAY_BASE/VLV_GUNIT_BASE/ here? Although all the
> > other Gunit register defintions are still in i915_reg.h, and using
> > VLV_DISPLAY_BASE. Not sure what to do about all that...
>
> Works for me, as long as I can drop the dependency on
> display/intel_display_reg_defs.h.
>
> Just let me know.
I'd probably go with the VLV_GUNIT_BASE approach. We can think
about what to do with all the other Gunit registers later.
>
> BR,
> Jani.
>
>
> >
> >> #define CHV_FGT_DISABLE_SS0 (1 << 10)
> >> #define CHV_FGT_DISABLE_SS1 (1 << 11)
> >> #define CHV_FGT_EU_DIS_SS0_R0_SHIFT 16
> >> --
> >> 2.39.2
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: drop dependency on VLV_DISPLAY_BASE
2023-05-11 12:33 ` Ville Syrjälä
@ 2023-05-11 12:46 ` Jani Nikula
2023-05-11 14:15 ` Ville Syrjälä
0 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2023-05-11 12:46 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Thu, 11 May 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, May 11, 2023 at 03:31:16PM +0300, Jani Nikula wrote:
>> On Thu, 11 May 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>> > On Thu, May 11, 2023 at 12:04:27PM +0300, Jani Nikula wrote:
>> >> CHV_FUSE_GT (0x182168) is purely about GT fuses, therefore belongs in
>> >> intel_gt_regs.h, is in the gcfgmmio unit, but is technically in the VLV
>> >> display base area.
>> >>
>> >> Use the 0x182168 MMIO address directly to drop dependency on
>> >> VLV_DISPLAY_BASE and thus display/intel_display_reg_defs.h in
>> >> intel_gt_regs.h.
>> >>
>> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> >> ---
>> >> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +--
>> >> 1 file changed, 1 insertion(+), 2 deletions(-)
>> >>
>> >> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
>> >> index b8a39c219b60..f38550dae6b8 100644
>> >> --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
>> >> +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
>> >> @@ -7,7 +7,6 @@
>> >> #define __INTEL_GT_REGS__
>> >>
>> >> #include "i915_reg_defs.h"
>> >> -#include "display/intel_display_reg_defs.h" /* VLV_DISPLAY_BASE */
>> >>
>> >> /*
>> >> * The perf control registers are technically multicast registers, but the
>> >> @@ -1469,7 +1468,7 @@
>> >> #define GEN12_RCU_MODE _MMIO(0x14800)
>> >> #define GEN12_RCU_MODE_CCS_ENABLE REG_BIT(0)
>> >>
>> >> -#define CHV_FUSE_GT _MMIO(VLV_DISPLAY_BASE + 0x2168)
>> >> +#define CHV_FUSE_GT _MMIO(0x182168)
>> >
>> > Or mmaybe s/VLV_DISPLAY_BASE/VLV_GUNIT_BASE/ here? Although all the
>> > other Gunit register defintions are still in i915_reg.h, and using
>> > VLV_DISPLAY_BASE. Not sure what to do about all that...
>>
>> Works for me, as long as I can drop the dependency on
>> display/intel_display_reg_defs.h.
>>
>> Just let me know.
>
> I'd probably go with the VLV_GUNIT_BASE approach. We can think
> about what to do with all the other Gunit registers later.
Hmm, where to put VLV_GUNIT_BASE, then?
To avoid deps on display/, it would be here, i915_reg_defs.h, or a new
file that would mostly just contain this kind of offsets.
BR,
Jani.
>
>>
>> BR,
>> Jani.
>>
>>
>> >
>> >> #define CHV_FGT_DISABLE_SS0 (1 << 10)
>> >> #define CHV_FGT_DISABLE_SS1 (1 << 11)
>> >> #define CHV_FGT_EU_DIS_SS0_R0_SHIFT 16
>> >> --
>> >> 2.39.2
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: drop dependency on VLV_DISPLAY_BASE
2023-05-11 9:04 [Intel-gfx] [PATCH] drm/i915/gt: drop dependency on VLV_DISPLAY_BASE Jani Nikula
2023-05-11 11:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-11 12:20 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2023-05-11 13:30 ` Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2023-05-11 13:30 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 16541 bytes --]
== Series Details ==
Series: drm/i915/gt: drop dependency on VLV_DISPLAY_BASE
URL : https://patchwork.freedesktop.org/series/117620/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13133_full -> Patchwork_117620v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (8 -> 7)
------------------------------
Missing (1): shard-rkl0
Known issues
------------
Here are the changes found in Patchwork_117620v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][1] -> [FAIL][2] ([i915#2842])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@i915_pm_rps@reset:
- shard-snb: [PASS][3] -> [INCOMPLETE][4] ([i915#7790])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-snb4/igt@i915_pm_rps@reset.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-snb4/igt@i915_pm_rps@reset.html
* igt@kms_content_protection@atomic@pipe-a-dp-1:
- shard-apl: NOTRUN -> [TIMEOUT][5] ([i915#7173])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-apl7/igt@kms_content_protection@atomic@pipe-a-dp-1.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [PASS][6] -> [FAIL][7] ([i915#2346])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][8] -> [FAIL][9] ([i915#4767])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-apl4/igt@kms_fbcon_fbt@fbc-suspend.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2122])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-glk1/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-glk3/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1.html
* igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4579]) +16 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-snb1/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271]) +24 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-snb6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-vga-1.html
#### Possible fixes ####
* igt@gem_barrier_race@remote-request@rcs0:
- {shard-tglu}: [ABORT][14] ([i915#7953] / [i915#8211] / [i915#8234]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-tglu-3/igt@gem_barrier_race@remote-request@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-tglu-2/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][16] ([i915#6268]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-tglu-7/igt@gem_ctx_exec@basic-nohangcheck.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_eio@hibernate:
- {shard-tglu}: [ABORT][18] ([i915#7953] / [i915#7975] / [i915#8213] / [i915#8398]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-tglu-10/igt@gem_eio@hibernate.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-tglu-9/igt@gem_eio@hibernate.html
* igt@gem_eio@wait-immediate:
- shard-apl: [DMESG-WARN][20] ([i915#62]) -> [PASS][21] +44 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-apl7/igt@gem_eio@wait-immediate.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-apl7/igt@gem_eio@wait-immediate.html
* igt@gem_exec_endless@dispatch@rcs0:
- {shard-rkl}: [TIMEOUT][22] ([i915#3778]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-rkl-1/igt@gem_exec_endless@dispatch@rcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-rkl-1/igt@gem_exec_endless@dispatch@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-rkl}: [FAIL][24] ([i915#2842]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-rkl-3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-rkl-4/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_suspend@basic-s4-devices@lmem0:
- {shard-dg1}: [ABORT][26] ([i915#7975] / [i915#8213]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-dg1-14/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-dg1-18/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [TIMEOUT][28] ([i915#5493]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-dg1-16/igt@gem_lmem_swapping@smem-oom@lmem0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-dg1-15/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@i915_module_load@reload-with-fault-injection:
- {shard-dg1}: [DMESG-WARN][30] ([i915#8420]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-dg1-17/igt@i915_module_load@reload-with-fault-injection.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-dg1-13/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- {shard-rkl}: [SKIP][32] ([i915#1397]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-rkl-2/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-0:
- shard-apl: [DMESG-WARN][34] ([i915#1982] / [i915#62]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-apl7/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-apl7/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][36] ([i915#2122]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-glk9/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-glk2/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@sysfs_heartbeat_interval@precise@rcs0:
- shard-glk: [FAIL][38] -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-glk6/igt@sysfs_heartbeat_interval@precise@rcs0.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-glk1/igt@sysfs_heartbeat_interval@precise@rcs0.html
#### Warnings ####
* igt@i915_module_load@load:
- shard-snb: [SKIP][40] ([fdo#109271]) -> [SKIP][41] ([fdo#109271] / [i915#6227])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-snb7/igt@i915_module_load@load.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-snb7/igt@i915_module_load@load.html
- shard-apl: [SKIP][42] ([fdo#109271]) -> [SKIP][43] ([fdo#109271] / [i915#6227])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-apl3/igt@i915_module_load@load.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-apl6/igt@i915_module_load@load.html
- shard-glk: [SKIP][44] ([fdo#109271]) -> [SKIP][45] ([fdo#109271] / [i915#6227])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-glk5/igt@i915_module_load@load.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-glk5/igt@i915_module_load@load.html
* igt@kms_content_protection@mei_interface:
- shard-snb: [SKIP][46] ([fdo#109271] / [i915#4579]) -> [SKIP][47] ([fdo#109271])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13133/shard-snb5/igt@kms_content_protection@mei_interface.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/shard-snb2/igt@kms_content_protection@mei_interface.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8420]: https://gitlab.freedesktop.org/drm/intel/issues/8420
Build changes
-------------
* Linux: CI_DRM_13133 -> Patchwork_117620v1
CI-20190529: 20190529
CI_DRM_13133: 9de28734b7c6180707b305c9d736b439fb02e032 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7285: d1cbf2bad9c2664ab8bd3bd0946510a52800912f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117620v1: 9de28734b7c6180707b305c9d736b439fb02e032 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117620v1/index.html
[-- Attachment #2: Type: text/html, Size: 14167 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: drop dependency on VLV_DISPLAY_BASE
2023-05-11 12:46 ` Jani Nikula
@ 2023-05-11 14:15 ` Ville Syrjälä
0 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjälä @ 2023-05-11 14:15 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, May 11, 2023 at 03:46:14PM +0300, Jani Nikula wrote:
> On Thu, 11 May 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Thu, May 11, 2023 at 03:31:16PM +0300, Jani Nikula wrote:
> >> On Thu, 11 May 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> >> > On Thu, May 11, 2023 at 12:04:27PM +0300, Jani Nikula wrote:
> >> >> CHV_FUSE_GT (0x182168) is purely about GT fuses, therefore belongs in
> >> >> intel_gt_regs.h, is in the gcfgmmio unit, but is technically in the VLV
> >> >> display base area.
> >> >>
> >> >> Use the 0x182168 MMIO address directly to drop dependency on
> >> >> VLV_DISPLAY_BASE and thus display/intel_display_reg_defs.h in
> >> >> intel_gt_regs.h.
> >> >>
> >> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> >> ---
> >> >> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +--
> >> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >> >>
> >> >> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> >> >> index b8a39c219b60..f38550dae6b8 100644
> >> >> --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> >> >> +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> >> >> @@ -7,7 +7,6 @@
> >> >> #define __INTEL_GT_REGS__
> >> >>
> >> >> #include "i915_reg_defs.h"
> >> >> -#include "display/intel_display_reg_defs.h" /* VLV_DISPLAY_BASE */
> >> >>
> >> >> /*
> >> >> * The perf control registers are technically multicast registers, but the
> >> >> @@ -1469,7 +1468,7 @@
> >> >> #define GEN12_RCU_MODE _MMIO(0x14800)
> >> >> #define GEN12_RCU_MODE_CCS_ENABLE REG_BIT(0)
> >> >>
> >> >> -#define CHV_FUSE_GT _MMIO(VLV_DISPLAY_BASE + 0x2168)
> >> >> +#define CHV_FUSE_GT _MMIO(0x182168)
> >> >
> >> > Or mmaybe s/VLV_DISPLAY_BASE/VLV_GUNIT_BASE/ here? Although all the
> >> > other Gunit register defintions are still in i915_reg.h, and using
> >> > VLV_DISPLAY_BASE. Not sure what to do about all that...
> >>
> >> Works for me, as long as I can drop the dependency on
> >> display/intel_display_reg_defs.h.
> >>
> >> Just let me know.
> >
> > I'd probably go with the VLV_GUNIT_BASE approach. We can think
> > about what to do with all the other Gunit registers later.
>
> Hmm, where to put VLV_GUNIT_BASE, then?
>
> To avoid deps on display/, it would be here, i915_reg_defs.h, or a new
> file that would mostly just contain this kind of offsets.
I suppose it could just live in intel_gt_regs.h for the moment?
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-05-11 14:16 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-11 9:04 [Intel-gfx] [PATCH] drm/i915/gt: drop dependency on VLV_DISPLAY_BASE Jani Nikula
2023-05-11 11:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-11 12:20 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2023-05-11 12:31 ` Jani Nikula
2023-05-11 12:33 ` Ville Syrjälä
2023-05-11 12:46 ` Jani Nikula
2023-05-11 14:15 ` Ville Syrjälä
2023-05-11 13:30 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox