Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 0/2] Calculate CDCLK more properly when DSC is enabled
@ 2023-07-04 13:17 Stanislav Lisovskiy
  2023-07-04 13:17 ` [Intel-gfx] [PATCH 1/2] drm/i915: Add helper function for getting number of VDSC engines Stanislav Lisovskiy
                   ` (5 more replies)
  0 siblings, 6 replies; 11+ messages in thread
From: Stanislav Lisovskiy @ 2023-07-04 13:17 UTC (permalink / raw)
  To: intel-gfx

We need to properly estimate our available BW when DSC is enabled because
this can lead both to need in increasing or decresing CDCLK.
Each DSC engine can process only single pixel at a time thus if only
single DSC engine is enabled, CDCLK is obliged to be equal to pixel clock
(while in non-compressed case it can be usualy lower)
However if we have 2 DSC engines CDCLK can be ~pixel clock / 2 and so on.
Lets do the estimation more properly based on amount of VDSC engines used.
That most likely is going to fix some FIFO underruns, we are currently
having.

Stanislav Lisovskiy (2):
  drm/i915: Add helper function for getting number of VDSC engines
  drm/i915: Don't rely that 2 VDSC engines are always enough for pixel
    rate

 drivers/gpu/drm/i915/display/intel_cdclk.c | 13 +++++++++++--
 drivers/gpu/drm/i915/display/intel_vdsc.c  | 15 +++++++++++----
 drivers/gpu/drm/i915/display/intel_vdsc.h  |  1 +
 3 files changed, 23 insertions(+), 6 deletions(-)

-- 
2.37.3


^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH 0/2] Calculate CDCLK more properly when DSC is enabled
@ 2023-07-04 10:31 Stanislav Lisovskiy
  2023-07-04 10:31 ` [Intel-gfx] [PATCH 2/2] drm/i915: Don't rely that 2 VDSC engines are always enough for pixel rate Stanislav Lisovskiy
  0 siblings, 1 reply; 11+ messages in thread
From: Stanislav Lisovskiy @ 2023-07-04 10:31 UTC (permalink / raw)
  To: intel-gfx

We need to properly estimate our available BW when DSC is enabled because
this can lead both to need in increasing or decresing CDCLK.
Each DSC engine can process only single pixel at a time thus if only
single DSC engine is enabled, CDCLK is obliged to be equal to pixel clock
(while in non-compressed case it can be usualy lower)
However if we have 2 DSC engines CDCLK can be ~pixel clock / 2 and so on.
Lets do the estimation more properly based on amount of VDSC engines used.
That most likely is going to fix some FIFO underruns, we are currently
having.

Stanislav Lisovskiy (2):
  drm/i915: Add helper function for getting number of VDSC engines
  drm/i915: Don't rely that 2 VDSC engines are always enough for pixel
    rate

 drivers/gpu/drm/i915/display/intel_cdclk.c | 13 +++++++++++--
 drivers/gpu/drm/i915/display/intel_vdsc.c  | 15 +++++++++++----
 drivers/gpu/drm/i915/display/intel_vdsc.h  |  1 +
 3 files changed, 23 insertions(+), 6 deletions(-)

-- 
2.37.3


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-07-10  8:57 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-04 13:17 [Intel-gfx] [PATCH 0/2] Calculate CDCLK more properly when DSC is enabled Stanislav Lisovskiy
2023-07-04 13:17 ` [Intel-gfx] [PATCH 1/2] drm/i915: Add helper function for getting number of VDSC engines Stanislav Lisovskiy
2023-07-10  6:10   ` Nautiyal, Ankit K
2023-07-04 13:17 ` [Intel-gfx] [PATCH 2/2] drm/i915: Don't rely that 2 VDSC engines are always enough for pixel rate Stanislav Lisovskiy
2023-07-10  6:07   ` Nautiyal, Ankit K
2023-07-10  8:56     ` Lisovskiy, Stanislav
2023-07-04 14:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Calculate CDCLK more properly when DSC is enabled Patchwork
2023-07-04 14:15 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-07-04 14:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-04 17:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-07-04 10:31 [Intel-gfx] [PATCH 0/2] " Stanislav Lisovskiy
2023-07-04 10:31 ` [Intel-gfx] [PATCH 2/2] drm/i915: Don't rely that 2 VDSC engines are always enough for pixel rate Stanislav Lisovskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox